Patrisious Haddad
607e1df7bd
net/mlx5: Fix IPsec RoCE MPV trace call
Prevent the call trace below from happening, by not allowing IPsec
creation over a slave, if master device doesn't support IPsec.
WARNING: CPU: 44 PID: 16136 at kernel/locking/rwsem.c:240 down_read+0x75/0x94
Modules linked in: esp4_offload esp4 act_mirred act_vlan cls_flower sch_ingress mlx5_vdpa vringh vhost_iotlb vdpa mst_pciconf(OE) nfsv3 nfs_acl nfs lockd grace fscache netfs xt_CHECKSUM xt_MASQUERADE xt_conntrack ipt_REJECT nf_reject_ipv4 nft_compat nft_counter nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 rfkill cuse fuse rpcrdma sunrpc rdma_ucm ib_srpt ib_isert iscsi_target_mod target_core_mod ib_umad ib_iser libiscsi scsi_transport_iscsi rdma_cm ib_ipoib iw_cm ib_cm ipmi_ssif intel_rapl_msr intel_rapl_common amd64_edac edac_mce_amd kvm_amd kvm irqbypass crct10dif_pclmul crc32_pclmul mlx5_ib ghash_clmulni_intel sha1_ssse3 dell_smbios ib_uverbs aesni_intel crypto_simd dcdbas wmi_bmof dell_wmi_descriptor cryptd pcspkr ib_core acpi_ipmi sp5100_tco ccp i2c_piix4 ipmi_si ptdma k10temp ipmi_devintf ipmi_msghandler acpi_power_meter acpi_cpufreq ext4 mbcache jbd2 sd_mod t10_pi sg mgag200 drm_kms_helper syscopyarea sysfillrect mlx5_core sysimgblt fb_sys_fops cec
ahci libahci mlxfw drm pci_hyperv_intf libata tg3 sha256_ssse3 tls megaraid_sas i2c_algo_bit psample wmi dm_mirror dm_region_hash dm_log dm_mod [last unloaded: mst_pci]
CPU: 44 PID: 16136 Comm: kworker/44:3 Kdump: loaded Tainted: GOE 5.15.0-20240509.el8uek.uek7_u3_update_v6.6_ipsec_bf.x86_64 #2
Hardware name: Dell Inc. PowerEdge R7525/074H08, BIOS 2.0.3 01/15/2021
Workqueue: events xfrm_state_gc_task
RIP: 0010:down_read+0x75/0x94
Code: 00 48 8b 45 08 65 48 8b 14 25 80 fc 01 00 83 e0 02 48 09 d0 48 83 c8 01 48 89 45 08 5d 31 c0 89 c2 89 c6 89 c7 e9 cb 88 3b 00 <0f> 0b 48 8b 45 08 a8 01 74 b2 a8 02 75 ae 48 89 c2 48 83 ca 02 f0
RSP: 0018:ffffb26387773da8 EFLAGS: 00010282
RAX: 0000000000000000 RBX: ffffa08b658af900 RCX: 0000000000000001
RDX: 0000000000000000 RSI: ff886bc5e1366f2f RDI: 0000000000000000
RBP: ffffa08b658af940 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000000 R12: ffffa0a9bfb31540
R13: ffffa0a9bfb37900 R14: 0000000000000000 R15: ffffa0a9bfb37905
FS: 0000000000000000(0000) GS:ffffa0a9bfb00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 000055a45ed814e8 CR3: 000000109038a000 CR4: 0000000000350ee0
Call Trace:
<TASK>
? show_trace_log_lvl+0x1d6/0x2f9
? show_trace_log_lvl+0x1d6/0x2f9
? mlx5_devcom_for_each_peer_begin+0x29/0x60 [mlx5_core]
? down_read+0x75/0x94
? __warn+0x80/0x113
? down_read+0x75/0x94
? report_bug+0xa4/0x11d
? handle_bug+0x35/0x8b
? exc_invalid_op+0x14/0x75
? asm_exc_invalid_op+0x16/0x1b
? down_read+0x75/0x94
? down_read+0xe/0x94
mlx5_devcom_for_each_peer_begin+0x29/0x60 [mlx5_core]
mlx5_ipsec_fs_roce_tx_destroy+0xb1/0x130 [mlx5_core]
tx_destroy+0x1b/0xc0 [mlx5_core]
tx_ft_put+0x53/0xc0 [mlx5_core]
mlx5e_xfrm_free_state+0x45/0x90 [mlx5_core]
___xfrm_state_destroy+0x10f/0x1a2
xfrm_state_gc_task+0x81/0xa9
process_one_work+0x1f1/0x3c6
worker_thread+0x53/0x3e4
? process_one_work.cold+0x46/0x3c
kthread+0x127/0x144
? set_kthread_struct+0x60/0x52
ret_from_fork+0x22/0x2d
</TASK>
---[ end trace 5ef7896144d398e1 ]---
Fixes: dfbd229abe ("net/mlx5: Configure IPsec steering for egress RoCEv2 MPV traffic")
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Patrisious Haddad <phaddad@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20240815071611.2211873-5-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2024-08-16 16:15:57 -07:00
..
2024-07-27 10:14:34 -07:00
2024-07-31 13:48:25 +02:00
2024-08-14 15:49:37 +02:00
2024-08-12 10:41:44 +01:00
2024-07-26 11:04:28 -07:00
2024-07-31 14:41:44 +02:00
2024-07-27 15:28:53 -07:00
2024-08-07 16:35:53 -04:00
2024-07-27 12:46:16 -07:00
2024-08-01 07:15:02 -07:00
2024-07-24 20:59:29 +02:00
2024-07-31 13:47:45 +02:00
2024-07-27 12:46:16 -07:00
2024-07-25 06:53:47 -05:00
2024-07-19 15:55:08 -07:00
2024-08-02 14:40:13 +02:00
2024-07-20 12:41:03 -07:00
2024-07-28 09:33:28 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-10 15:38:14 +02:00
2024-07-25 10:42:22 -07:00
2024-07-21 17:15:46 -07:00
2024-07-28 15:49:18 -07:00
2024-07-25 10:42:22 -07:00
2024-07-29 10:33:51 -07:00
2024-07-25 10:42:22 -07:00
2024-07-31 13:40:00 +02:00
2024-07-27 12:54:06 -07:00
2024-08-09 17:16:29 +10:00
2024-07-25 10:42:22 -07:00
2024-07-29 13:07:05 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-28 15:49:18 -07:00
2024-07-25 10:42:22 -07:00
2024-08-09 15:28:08 +02:00
2024-07-27 10:53:06 -07:00
2024-07-25 06:53:47 -05:00
2024-07-19 09:59:58 -07:00
2024-07-29 10:44:48 -07:00
2024-07-19 15:55:08 -07:00
2024-07-27 12:39:55 -07:00
2024-08-10 10:42:04 +02:00
2024-07-25 08:05:05 -07:00
2024-07-17 17:51:30 -07:00
2024-07-25 12:58:36 -07:00
2024-07-19 21:25:23 -05:00
2024-07-25 10:42:22 -07:00
2024-07-28 13:41:14 -07:00
2024-08-15 10:23:19 -07:00
2024-07-25 10:42:22 -07:00
2024-07-27 12:46:16 -07:00
2024-07-31 13:47:27 +02:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-28 11:51:51 -07:00
2024-08-16 16:15:57 -07:00
2024-07-28 15:49:18 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-31 07:40:10 -07:00
2024-07-25 10:42:22 -07:00
2024-07-19 09:59:58 -07:00
2024-07-15 18:55:14 +02:00
2024-07-25 12:58:36 -07:00
2024-08-01 12:58:03 -05:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-08-01 07:15:13 -07:00
2024-07-24 13:11:28 -07:00
2024-07-25 06:53:47 -05:00
2024-08-12 08:21:52 -07:00
2024-08-07 09:45:21 -07:00
2024-07-25 10:42:22 -07:00
2024-07-16 19:28:34 -07:00
2024-07-25 06:53:47 -05:00
2024-07-15 18:20:24 -07:00
2024-07-27 12:27:52 -07:00
2024-07-23 13:41:59 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-10 17:15:33 +02:00
2024-07-31 16:30:20 +02:00
2024-07-11 15:42:03 +02:00
2024-08-11 09:28:04 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00
2024-08-07 23:45:12 +01:00
2024-07-31 13:49:28 +02:00
2024-08-15 10:23:19 -07:00
2024-07-25 10:42:22 -07:00
2024-07-31 12:31:27 +02:00
2024-07-25 10:42:22 -07:00
2024-07-31 12:31:32 +02:00
2024-08-01 21:59:00 -04:00
2024-08-07 12:48:30 +02:00
2024-07-29 12:53:37 -07:00
2024-07-25 10:42:22 -07:00
2024-08-06 10:58:28 -07:00
2024-07-21 17:15:46 -07:00
2024-07-20 12:41:03 -07:00
2024-07-29 12:53:37 -07:00
2024-07-25 10:18:35 -07:00
2024-07-25 10:42:22 -07:00
2024-07-25 10:42:22 -07:00