Shang XiaoJing
60da738082
rtc: class: Fix potential memleak in devm_rtc_allocate_device()
devm_rtc_allocate_device() will alloc a rtc_device first, and then run
dev_set_name(). If dev_set_name() failed, the rtc_device will memleak.
Move devm_add_action_or_reset() in front of dev_set_name() to prevent
memleak.
unreferenced object 0xffff888110a53000 (size 2048):
comm "python3", pid 470, jiffies 4296078308 (age 58.882s)
hex dump (first 32 bytes):
00 00 00 00 00 00 00 00 08 30 a5 10 81 88 ff ff .........0......
08 30 a5 10 81 88 ff ff 00 00 00 00 00 00 00 00 .0..............
backtrace:
[<000000004aac0364>] kmalloc_trace+0x21/0x110
[<000000000ff02202>] devm_rtc_allocate_device+0xd4/0x400
[<000000001bdf5639>] devm_rtc_device_register+0x1a/0x80
[<00000000351bf81c>] rx4581_probe+0xdd/0x110 [rtc_rx4581]
[<00000000f0eba0ae>] spi_probe+0xde/0x130
[<00000000bff89ee8>] really_probe+0x175/0x3f0
[<00000000128e8d84>] __driver_probe_device+0xe6/0x170
[<00000000ee5bf913>] device_driver_attach+0x32/0x80
[<00000000f3f28f92>] bind_store+0x10b/0x1a0
[<000000009ff812d8>] drv_attr_store+0x49/0x70
[<000000008139c323>] sysfs_kf_write+0x8d/0xb0
[<00000000b6146e01>] kernfs_fop_write_iter+0x214/0x2d0
[<00000000ecbe3895>] vfs_write+0x61a/0x7d0
[<00000000aa2196ea>] ksys_write+0xc8/0x190
[<0000000046a600f5>] do_syscall_64+0x37/0x90
[<00000000541a336f>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
Fixes: 24d23181e4 ("rtc: class: check return value when calling dev_set_name()")
Signed-off-by: Shang XiaoJing <shangxiaojing@huawei.com>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20221110090810.11225-1-shangxiaojing@huawei.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
2022-11-15 21:01:51 +01:00
..
2022-10-10 13:28:06 -07:00
2022-10-10 09:10:28 -07:00
2022-10-07 10:48:49 -07:00
2022-10-12 10:23:24 -07:00
2022-10-12 10:23:24 -07:00
2022-10-16 15:27:07 -07:00
2022-10-08 08:56:37 -07:00
2022-10-11 17:42:58 -06:00
2022-10-16 11:08:19 -07:00
2022-10-10 10:16:00 -07:00
2022-10-08 09:46:29 -07:00
2022-10-08 08:56:37 -07:00
2022-10-09 13:24:01 -07:00
2022-10-10 13:04:25 -07:00
2022-10-14 18:41:41 -07:00
2022-10-11 17:42:58 -06:00
2022-10-06 17:22:11 -07:00
2022-10-13 11:07:13 -07:00
2022-10-08 08:56:37 -07:00
2022-10-11 10:44:20 -07:00
2022-10-08 08:56:37 -07:00
2022-10-12 10:23:24 -07:00
2022-10-16 15:27:07 -07:00
2022-10-11 10:53:25 -07:00
2022-10-10 13:59:01 -07:00
2022-10-08 08:56:37 -07:00
2022-10-08 08:56:37 -07:00
2022-10-11 11:03:42 -07:00
2022-10-12 23:45:29 +02:00
2022-10-08 08:56:37 -07:00
2022-10-11 17:42:58 -06:00
2022-10-11 10:53:25 -07:00
2022-10-10 13:20:53 -07:00
2022-10-08 08:56:37 -07:00
2022-10-12 10:23:24 -07:00
2022-10-09 19:11:54 +01:00
2022-10-14 13:14:03 -07:00
2022-10-09 14:05:15 -07:00
2022-10-05 21:51:58 -05:00
2022-10-11 17:42:58 -06:00
2022-10-11 17:42:58 -06:00
2022-10-07 11:24:20 -07:00
2022-10-11 17:42:58 -06:00
2022-10-16 15:27:07 -07:00
2022-10-16 15:27:07 -07:00
2022-10-16 15:27:07 -07:00
2022-10-14 18:41:41 -07:00
2022-10-16 15:27:07 -07:00
2022-10-10 13:13:51 -07:00
2022-10-14 12:10:01 -07:00
2022-10-15 16:36:38 -07:00
2022-10-14 12:38:03 -07:00
2022-10-11 11:08:18 -07:00
2022-10-12 10:23:24 -07:00
2022-10-12 10:35:20 -07:00
2022-10-10 18:11:11 +02:00
2022-10-07 11:48:30 -07:00
2022-10-10 09:10:28 -07:00
2022-10-10 08:37:24 +01:00
2022-10-07 11:32:10 -07:00
2022-10-07 11:24:20 -07:00
2022-10-05 09:20:44 -06:00
2022-10-08 10:06:48 -07:00
2022-11-15 21:01:51 +01:00
2022-10-14 11:36:05 -07:00
2022-10-11 17:42:58 -06:00
2022-10-13 11:07:13 -07:00
2022-10-07 16:13:55 -07:00
2022-10-04 19:36:53 -07:00
2022-09-30 14:33:23 +02:00
2022-10-08 10:06:48 -07:00
2022-10-11 17:42:58 -06:00
2022-10-10 17:53:04 -07:00
2022-10-10 13:52:14 -07:00
2022-10-11 17:42:58 -06:00
2022-10-14 12:10:01 -07:00
2022-10-07 12:33:18 -07:00
2022-10-10 17:53:04 -07:00
2022-10-10 14:02:53 -07:00
2022-10-12 14:46:48 -07:00
2022-10-10 14:02:53 -07:00
2022-10-16 15:27:07 -07:00
2022-10-08 08:56:37 -07:00
2022-10-13 09:33:03 -04:00
2022-10-08 08:56:37 -07:00
2022-10-13 10:31:13 -07:00
2022-10-12 14:39:38 -07:00