a3d543b9e6
The soundwire-amd driver has a bit of a layering violation requiring
the SOF driver to directly call into its exported symbols rather than
through an abstraction.
The SND_SOC_SOF_AMD_SOUNDWIRE Kconfig symbol tries to deal with the
dependency by selecting SOUNDWIRE_AMD in a complicated set of conditions,
but gets it wrong for a configuration involving SND_SOC_SOF_AMD_COMMON=y,
SND_SOC_SOF_AMD_ACP63=m, and SND_SOC_SOF_AMD_SOUNDWIRE_LINK_BASELINE=m
SOUNDWIRE_AMD=m, which results in a link failure:
ld.lld: error: undefined symbol: sdw_amd_get_slave_info
>>> referenced by acp-common.c
ld.lld: error: undefined symbol: amd_sdw_scan_controller
ld.lld: error: undefined symbol: sdw_amd_probe
ld.lld: error: undefined symbol: sdw_amd_exit
>>> referenced by acp.c
>>> sound/soc/sof/amd/acp.o:(amd_sof_acp_remove) in archive vmlinux.a
In essence, the SND_SOC_SOF_AMD_COMMON option cannot be built-in when
trying to link against a modular SOUNDWIRE_AMD driver.
Since CONFIG_SOUNDWIRE_AMD is a user-visible option, it really should
never be selected by another driver in the first place, so replace the
extra complexity with a normal Kconfig dependency in SND_SOC_SOF_AMD_SOUNDWIRE,
plus a top-level check that forbids any of the AMD SOF drivers from being
built-in with CONFIG_SOUNDWIRE_AMD=m.
In normal configs, they should all either be built-in or all loadable
modules anyway, so this simplification does not limit any real usecases.
Fixes: d948218424 ("ASoC: SOF: amd: add code for invoking soundwire manager helper functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://msgid.link/r/20240219093900.644574-1-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
91 lines
2.6 KiB
Plaintext
91 lines
2.6 KiB
Plaintext
# SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
|
|
# This file is provided under a dual BSD/GPLv2 license. When using or
|
|
# redistributing this file, you may do so under either license.
|
|
#
|
|
# Copyright(c) 2021, 2023 Advanced Micro Devices, Inc. All rights reserved.
|
|
|
|
config SND_SOC_SOF_AMD_TOPLEVEL
|
|
tristate "SOF support for AMD audio DSPs"
|
|
depends on SOUNDWIRE_AMD || !SOUNDWIRE_AMD
|
|
depends on X86 || COMPILE_TEST
|
|
help
|
|
This adds support for Sound Open Firmware for AMD platforms.
|
|
Say Y if you have such a device.
|
|
If unsure select "N".
|
|
|
|
if SND_SOC_SOF_AMD_TOPLEVEL
|
|
|
|
config SND_SOC_SOF_AMD_COMMON
|
|
tristate
|
|
select SND_SOC_SOF
|
|
select SND_SOC_SOF_IPC3
|
|
select SND_SOC_SOF_PCI_DEV
|
|
select SND_AMD_ACP_CONFIG
|
|
select SND_SOC_SOF_XTENSA
|
|
select SND_SOC_SOF_ACP_PROBES
|
|
select SND_SOC_ACPI if ACPI
|
|
help
|
|
This option is not user-selectable but automatically handled by
|
|
'select' statements at a higher level
|
|
|
|
config SND_SOC_SOF_AMD_RENOIR
|
|
tristate "SOF support for RENOIR"
|
|
depends on SND_SOC_SOF_PCI
|
|
select SND_SOC_SOF_AMD_COMMON
|
|
help
|
|
Select this option for SOF support on AMD Renoir platform
|
|
|
|
config SND_SOC_SOF_AMD_VANGOGH
|
|
tristate "SOF support for VANGOGH"
|
|
depends on SND_SOC_SOF_PCI
|
|
select SND_SOC_SOF_AMD_COMMON
|
|
help
|
|
Select this option for SOF support
|
|
on AMD Vangogh platform.
|
|
Say Y if you want to enable SOF on Vangogh.
|
|
If unsure select "N".
|
|
|
|
config SND_SOC_SOF_AMD_REMBRANDT
|
|
tristate "SOF support for REMBRANDT"
|
|
depends on SND_SOC_SOF_PCI
|
|
select SND_SOC_SOF_AMD_COMMON
|
|
help
|
|
Select this option for SOF support on AMD Rembrandt platform
|
|
Say Y if you want to enable SOF on Rembrandt.
|
|
If unsure select "N".
|
|
|
|
config SND_SOC_SOF_ACP_PROBES
|
|
tristate
|
|
select SND_SOC_SOF_DEBUG_PROBES
|
|
help
|
|
This option is not user-selectable but automatically handled by
|
|
'select' statements at a higher level
|
|
|
|
config SND_SOC_SOF_AMD_SOUNDWIRE_LINK_BASELINE
|
|
tristate
|
|
select SND_AMD_SOUNDWIRE_ACPI if ACPI
|
|
|
|
config SND_SOC_SOF_AMD_SOUNDWIRE
|
|
tristate "SOF support for SoundWire based AMD platforms"
|
|
default SND_SOC_SOF_AMD_SOUNDWIRE_LINK_BASELINE
|
|
depends on SND_SOC_SOF_AMD_SOUNDWIRE_LINK_BASELINE
|
|
depends on ACPI
|
|
depends on SOUNDWIRE_AMD
|
|
help
|
|
This adds support for SoundWire with Sound Open Firmware
|
|
for AMD platforms.
|
|
Say Y if you want to enable SoundWire links with SOF.
|
|
If unsure select "N".
|
|
|
|
config SND_SOC_SOF_AMD_ACP63
|
|
tristate "SOF support for ACP6.3 platform"
|
|
depends on SND_SOC_SOF_PCI
|
|
select SND_SOC_SOF_AMD_COMMON
|
|
select SND_SOC_SOF_AMD_SOUNDWIRE_LINK_BASELINE
|
|
help
|
|
Select this option for SOF support on
|
|
AMD ACP6.3 version based platforms.
|
|
Say Y if you want to enable SOF on ACP6.3 based platform.
|
|
If unsure select "N".
|
|
endif
|