Marek Szyprowski
6b4feaea25
clk: exynos: use irqsave version of spin_lock to avoid deadlock with irqs
It is allowed to enable/disable clocks from interrupts, so common Exynos
ARM clock management code for CPUfreq should use 'irqsave' version of
spin_lock calls to avoid potential deadlock caused by spin_lock recursion.
The same spin_lock is used by gate/mux clocks during enable/disable calls.
This deadlock, can be reproduced by enabling CPUfreq (ondemand or
userspace) and decoding video with s5p-mfc driver.
Relevant stack trace:
[ 5928.061534] BUG: spinlock recursion on CPU#0, bash/1252
[ 5928.061609] lock: 0xee80454c, .magic: dead4ead, .owner: bash/1252, .owner_cpu: 0
[ 5928.068586] CPU: 0 PID: 1252 Comm: bash Tainted: G W 4.4.0-rc4-00001-g447a7fd #678
[ 5928.077260] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree)
[ 5928.083359] [<c00153dc>] (unwind_backtrace) from [<c00121b4>] (show_stack+0x10/0x14)
[ 5928.091072] [<c00121b4>] (show_stack) from [<c0213e28>] (dump_stack+0x68/0xb8)
[ 5928.098275] [<c0213e28>] (dump_stack) from [<c005c1ec>] (do_raw_spin_lock+0x184/0x1ac)
[ 5928.106177] [<c005c1ec>] (do_raw_spin_lock) from [<c05cfa98>] (_raw_spin_lock_irqsave+0x20/0x28)
[ 5928.114943] [<c05cfa98>] (_raw_spin_lock_irqsave) from [<c0468698>] (clk_gate_endisable+0x24/0x98)
[ 5928.123882] [<c0468698>] (clk_gate_endisable) from [<c0464d40>] (clk_core_disable+0x60/0x84)
[ 5928.132299] [<c0464d40>] (clk_core_disable) from [<c0465e00>] (clk_disable+0x24/0x30)
[ 5928.140117] [<c0465e00>] (clk_disable) from [<c03f3b80>] (s5p_mfc_handle_frame+0x254/0x860)
[ 5928.148445] [<c03f3b80>] (s5p_mfc_handle_frame) from [<c03f4b34>] (s5p_mfc_irq+0x890/0xa24)
[ 5928.156778] [<c03f4b34>] (s5p_mfc_irq) from [<c00627bc>] (handle_irq_event_percpu+0x50/0x14c)
[ 5928.165283] [<c00627bc>] (handle_irq_event_percpu) from [<c00628f0>] (handle_irq_event+0x38/0x5c)
[ 5928.174143] [<c00628f0>] (handle_irq_event) from [<c0065864>] (handle_fasteoi_irq+0xdc/0x1a4)
[ 5928.182645] [<c0065864>] (handle_fasteoi_irq) from [<c0062090>] (generic_handle_irq+0x18/0x28)
[ 5928.191236] [<c0062090>] (generic_handle_irq) from [<c00621a4>] (__handle_domain_irq+0x6c/0xdc)
[ 5928.199917] [<c00621a4>] (__handle_domain_irq) from [<c0009470>] (gic_handle_irq+0x4c/0x98)
[ 5928.208249] [<c0009470>] (gic_handle_irq) from [<c0012c54>] (__irq_svc+0x54/0x90)
[ 5928.215709] Exception stack(0xeddb5cb8 to 0xeddb5d00)
[ 5928.220745] 5ca0: ee80454c faddfadc
[ 5928.228906] 5cc0: 00000000 01000001 ee831ce0 f8114200 ee807c00 01130520 00000403 eddb5d84
[ 5928.237063] 5ce0: ee807c48 2faf0800 ee807c0c eddb5d08 c046b618 c046b634 20000053 ffffffff
[ 5928.245225] [<c0012c54>] (__irq_svc) from [<c046b634>] (exynos_cpuclk_notifier_cb+0x170/0x270)
[ 5928.253823] [<c046b634>] (exynos_cpuclk_notifier_cb) from [<c003cb58>] (notifier_call_chain+0x44/0x84)
[ 5928.263106] [<c003cb58>] (notifier_call_chain) from [<c003ccd4>] (__srcu_notifier_call_chain+0x6c/0x9c)
[ 5928.272480] [<c003ccd4>] (__srcu_notifier_call_chain) from [<c003cd1c>] (srcu_notifier_call_chain+0x18/0x20)
[ 5928.282288] [<c003cd1c>] (srcu_notifier_call_chain) from [<c0464ed0>] (__clk_notify+0x6c/0x74)
[ 5928.290881] [<c0464ed0>] (__clk_notify) from [<c0465388>] (clk_propagate_rate_change+0xa0/0xac)
[ 5928.299561] [<c0465388>] (clk_propagate_rate_change) from [<c0465378>] (clk_propagate_rate_change+0x90/0xac)
[ 5928.309370] [<c0465378>] (clk_propagate_rate_change) from [<c04666fc>] (clk_core_set_rate_nolock+0x64/0xa8)
[ 5928.319091] [<c04666fc>] (clk_core_set_rate_nolock) from [<c0466760>] (clk_set_rate+0x20/0x30)
[ 5928.327686] [<c0466760>] (clk_set_rate) from [<c0428c70>] (set_target+0xe8/0x23c)
[ 5928.335152] [<c0428c70>] (set_target) from [<c04244d0>] (__cpufreq_driver_target+0x184/0x29c)
[ 5928.343655] [<c04244d0>] (__cpufreq_driver_target) from [<c0427128>] (cpufreq_set+0x44/0x64)
[ 5928.352074] [<c0427128>] (cpufreq_set) from [<c0423948>] (store_scaling_setspeed+0x5c/0x74)
[ 5928.360407] [<c0423948>] (store_scaling_setspeed) from [<c04238d0>] (store+0x7c/0x98)
[ 5928.368221] [<c04238d0>] (store) from [<c0132540>] (sysfs_kf_write+0x44/0x48)
[ 5928.375338] [<c0132540>] (sysfs_kf_write) from [<c0131b9c>] (kernfs_fop_write+0xb8/0x1bc)
[ 5928.383496] [<c0131b9c>] (kernfs_fop_write) from [<c00d71f8>] (__vfs_write+0x2c/0xd4)
[ 5928.391308] [<c00d71f8>] (__vfs_write) from [<c00d7de8>] (vfs_write+0xa0/0x144)
[ 5928.398598] [<c00d7de8>] (vfs_write) from [<c00d8048>] (SyS_write+0x44/0x84)
[ 5928.405631] [<c00d8048>] (SyS_write) from [<c000f540>] (ret_fast_syscall+0x0/0x3c)
CC: stable@vger.kernel.org # v4.2+
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
2015-12-16 16:36:03 +01:00
..
2015-12-04 11:30:45 -08:00
2015-12-07 10:25:57 -05:00
2015-12-12 10:15:34 -08:00
2015-12-12 10:24:00 -08:00
2015-11-10 18:11:41 -08:00
2015-11-12 09:58:21 -08:00
2015-12-09 13:13:06 -06:00
2015-12-16 16:36:03 +01:00
2015-12-10 19:37:18 +01:00
2015-11-06 17:50:42 -08:00
2015-12-12 16:43:44 -08:00
2015-10-23 12:40:48 +02:00
2015-12-05 10:46:44 -08:00
2015-11-16 09:21:05 +05:30
2015-10-30 01:16:16 -04:00
2015-11-06 14:22:15 -08:00
2015-10-26 14:48:22 +00:00
2015-11-11 10:21:34 -08:00
2015-11-10 15:00:03 -08:00
2015-11-24 15:25:46 -08:00
2015-11-30 13:50:21 +01:00
2015-12-11 14:04:44 +10:00
2015-12-13 11:58:18 -08:00
2015-10-30 16:10:40 +01:00
2015-11-04 16:24:33 +01:00
2015-11-16 09:59:50 -08:00
2015-11-13 20:04:17 -08:00
2015-11-20 16:22:21 +01:00
2015-11-06 17:50:42 -08:00
2015-11-21 18:24:44 +00:00
2015-12-08 16:55:31 -05:00
2015-11-13 21:41:14 -08:00
2015-11-09 09:10:49 +01:00
2015-12-01 22:50:16 +01:00
2015-11-25 11:49:58 -05:00
2015-11-05 13:15:12 -08:00
2015-12-07 09:14:20 -07:00
2015-11-04 14:03:04 +05:30
2015-10-29 09:02:16 +09:00
2015-12-10 10:30:18 -05:00
2015-11-20 16:17:32 -08:00
2015-11-10 15:00:03 -08:00
2015-11-12 07:06:18 -05:00
2015-11-06 14:22:15 -08:00
2015-12-08 16:57:01 +11:00
2015-11-09 14:04:52 +01:00
2015-11-16 10:51:39 -08:00
2015-12-10 14:42:22 -08:00
2015-11-10 18:11:41 -08:00
2015-11-08 16:24:43 -05:00
2015-11-12 09:55:23 -08:00
2015-12-07 09:14:19 -07:00
2015-12-09 09:08:36 -06:00
2015-12-12 16:07:25 +01:00
2015-12-09 09:26:06 -08:00
2015-11-04 14:47:13 -08:00
2015-11-09 17:44:24 -05:00
2015-12-01 11:13:04 +01:00
2015-11-13 21:53:18 -08:00
2015-11-06 10:23:50 -08:00
2015-11-11 09:16:10 -08:00
2015-11-05 13:15:12 -08:00
2015-11-26 17:44:28 +02:00
2015-11-26 18:11:26 +01:00
2015-11-18 08:59:29 -08:00
2015-12-06 08:02:25 -08:00
2015-11-17 02:12:46 +09:00
2015-11-25 23:48:12 +01:00
2015-11-30 12:26:47 +00:00
2015-11-04 22:15:15 -08:00
2015-10-28 21:05:21 +02:00
2015-12-13 12:24:39 -08:00
2015-11-28 21:23:13 -08:00
2015-11-23 16:38:40 -08:00
2015-11-20 16:19:54 -08:00
2015-12-11 15:40:51 -08:00
2015-11-04 21:50:37 -08:00
2015-12-04 08:38:42 -07:00
2015-12-07 17:28:10 +02:00
2015-11-10 10:00:09 -08:00
2015-12-07 17:28:11 +02:00
2015-11-04 22:15:15 -08:00
2015-11-05 12:28:15 -08:00
2015-11-23 09:00:09 +01:00
2015-11-26 11:42:25 -08:00
2015-11-04 22:15:15 -08:00
2015-11-16 15:22:28 -07:00