Xiao Guangrong 6bd364d829 KEYS: fix uninitialized persistent_keyring_register_sem ...

We run into this bug:
[ 2736.063245] Unable to handle kernel paging request for data at address 0x00000000
[ 2736.063293] Faulting instruction address: 0xc00000000037efb0
[ 2736.063300] Oops: Kernel access of bad area, sig: 11 [#1]
[ 2736.063303] SMP NR_CPUS=2048 NUMA pSeries
[ 2736.063310] Modules linked in: sg nfsv3 rpcsec_gss_krb5 nfsv4 dns_resolver nfs fscache nf_conntrack_netbios_ns nf_conntrack_broadcast ipt_MASQUERADE ip6table_mangle ip6table_security ip6table_raw ip6t_REJECT iptable_nat nf_nat_ipv4 iptable_mangle iptable_security iptable_raw ipt_REJECT nf_conntrack_ipv4 nf_defrag_ipv4 xt_conntrack ebtable_filter ebtables ip6table_filter iptable_filter ip_tables ip6table_nat nf_conntrack_ipv6 nf_defrag_ipv6 nf_nat_ipv6 nf_nat nf_conntrack ip6_tables ibmveth pseries_rng nx_crypto nfsd auth_rpcgss nfs_acl lockd sunrpc binfmt_misc xfs libcrc32c dm_service_time sd_mod crc_t10dif crct10dif_common ibmvfc scsi_transport_fc scsi_tgt dm_mirror dm_region_hash dm_log dm_multipath dm_mod
[ 2736.063383] CPU: 1 PID: 7128 Comm: ssh Not tainted 3.10.0-48.el7.ppc64 #1
[ 2736.063389] task: c000000131930120 ti: c0000001319a0000 task.ti: c0000001319a0000
[ 2736.063394] NIP: c00000000037efb0 LR: c0000000006c40f8 CTR: 0000000000000000
[ 2736.063399] REGS: c0000001319a3870 TRAP: 0300   Not tainted  (3.10.0-48.el7.ppc64)
[ 2736.063403] MSR: 8000000000009032 <SF,EE,ME,IR,DR,RI>  CR: 28824242  XER: 20000000
[ 2736.063415] SOFTE: 0
[ 2736.063418] CFAR: c00000000000908c
[ 2736.063421] DAR: 0000000000000000, DSISR: 40000000
[ 2736.063425]
GPR00: c0000000006c40f8 c0000001319a3af0 c000000001074788 c0000001319a3bf0
GPR04: 0000000000000000 0000000000000000 0000000000000020 000000000000000a
GPR08: fffffffe00000002 00000000ffff0000 0000000080000001 c000000000924888
GPR12: 0000000028824248 c000000007e00400 00001fffffa0f998 0000000000000000
GPR16: 0000000000000022 00001fffffa0f998 0000010022e92470 0000000000000000
GPR20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
GPR24: 0000000000000000 c000000000f4a828 00003ffffe527108 0000000000000000
GPR28: c000000000f4a730 c000000000f4a828 0000000000000000 c0000001319a3bf0
[ 2736.063498] NIP [c00000000037efb0] .__list_add+0x30/0x110
[ 2736.063504] LR [c0000000006c40f8] .rwsem_down_write_failed+0x78/0x264
[ 2736.063508] PACATMSCRATCH [800000000280f032]
[ 2736.063511] Call Trace:
[ 2736.063516] [c0000001319a3af0] [c0000001319a3b80] 0xc0000001319a3b80 (unreliable)
[ 2736.063523] [c0000001319a3b80] [c0000000006c40f8] .rwsem_down_write_failed+0x78/0x264
[ 2736.063530] [c0000001319a3c50] [c0000000006c1bb0] .down_write+0x70/0x78
[ 2736.063536] [c0000001319a3cd0] [c0000000002e5ffc] .keyctl_get_persistent+0x20c/0x320
[ 2736.063542] [c0000001319a3dc0] [c0000000002e2388] .SyS_keyctl+0x238/0x260
[ 2736.063548] [c0000001319a3e30] [c000000000009e7c] syscall_exit+0x0/0x7c
[ 2736.063553] Instruction dump:
[ 2736.063556] 7c0802a6 fba1ffe8 fbc1fff0 fbe1fff8 7cbd2b78 7c9e2378 7c7f1b78 f8010010
[ 2736.063566] f821ff71 e8a50008 7fa52040 40de00c0 <e8be0000> 7fbd2840 40de0094 7fbff040
[ 2736.063579] ---[ end trace 2708241785538296 ]---

It's caused by uninitialized persistent_keyring_register_sem.

The bug was introduced by commit f36f8c75, two typos are in that commit:
CONFIG_KEYS_KERBEROS_CACHE should be CONFIG_PERSISTENT_KEYRINGS and
krb_cache_register_sem should be persistent_keyring_register_sem.

Signed-off-by: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Signed-off-by: David Howells <dhowells@redhat.com>

2013-12-13 15:59:11 +00:00

..

cpu

sched: Add NEED_RESCHED to the preempt_count

2013-09-25 14:07:49 +02:00

debug

kdb: Add support for external NMI handler to call KGDB/KDB

2013-10-03 18:47:54 +02:00

events

perf: Remove fragile swevent hlist optimization

2013-11-19 16:57:42 +01:00

gcov

gcov: reuse kbasename helper

2013-11-13 12:09:34 +09:00

irq

Merge branch 'irq-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2013-12-02 10:15:39 -08:00

locking

locking/lockdep: Mark __lockdep_count_forward_deps() as static

2013-11-13 13:50:17 +01:00

power

Merge branch 'pm-sleep'

2013-11-19 01:07:08 +01:00

printk

printk.c: comments should refer to /proc/vmcore instead of /proc/vmcoreinfo

2013-11-13 12:09:14 +09:00

rcu

NOHZ: Check for nohz active instead of nohz enabled

2013-11-19 14:59:50 +01:00

sched

sched: Expose preempt_schedule_irq()

2013-11-27 11:04:53 +01:00

time

nohz: Fix another inconsistency between CONFIG_NO_HZ=n and nohz=off

2013-11-29 12:23:03 +01:00

trace

Merge tag 'trace-fixes-3.13-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace

2013-12-06 08:34:16 -08:00

.gitignore

Ignore generated file kernel/x509_certificate_list

2013-12-10 18:21:34 +00:00

acct.c

fs: Fix hang with BSD accounting on frozen filesystem

2013-05-04 14:57:58 -04:00

async.c

…

audit_tree.c

kernel/audit_tree.c:audit_add_tree_rule(): protect `rule' from kill_rules()

2013-06-12 16:29:46 -07:00

audit_watch.c

…

audit.c

Merge git://git.infradead.org/users/eparis/audit

2013-11-21 19:18:14 -08:00

audit.h

audit: call audit_bprm() only once to add AUDIT_EXECVE information

2013-11-05 11:15:03 -05:00

auditfilter.c

audit: do not reject all AUDIT_INODE filter types

2013-11-05 11:09:16 -05:00

auditsc.c

audit: fix type of sessionid in audit_set_loginuid()

2013-11-06 11:47:24 -05:00

backtracetest.c

…

bounds.c

kernel/bounds: avoid circular dependencies in generated headers

2013-11-19 14:20:12 -08:00

capability.c

Merge tag 'xfs-for-linus-v3.12-rc1' of git://oss.sgi.com/xfs/xfs

2013-09-09 11:19:09 -07:00

cgroup_freezer.c

cgroup: make css_for_each_descendant() and friends include the origin css in the iteration

2013-08-08 20:11:27 -04:00

cgroup.c

cgroup: fix cgroup_subsys_state leak for seq_files

2013-11-27 18:16:21 -05:00

compat.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/signal

2013-05-01 07:21:43 -07:00

configs.c

proc: Supply PDE attribute setting accessor functions

2013-05-01 17:29:18 -04:00

context_tracking.c

Merge tag 'v3.12-rc4' into sched/core

2013-10-09 12:36:13 +02:00

cpu_pm.c

…

cpu.c

Merge branch 'sched-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2013-11-14 16:55:11 +09:00

cpuset.c

cpuset: Fix memory allocator deadlock

2013-11-27 13:52:47 -05:00

crash_dump.c

…

cred.c

…

delayacct.c

kernel/delayacct.c: remove redundant checking in __delayacct_add_tsk()

2013-11-13 12:09:12 +09:00

dma.c

…

elfcore.c

switch elf_core_write_extra_phdrs() to dump_emit()

2013-11-09 00:16:23 -05:00

exec_domain.c

…

exit.c

ptrace: revert "Prepare to fix racy accesses on task breakpoints"

2013-07-09 10:33:26 -07:00

extable.c

kernel/extable: fix address-checks for core_kernel and init areas

2013-11-28 09:49:41 -08:00

fork.c

mm: implement split page table lock for PMD level

2013-11-15 09:32:15 +09:00

freezer.c

freezer: set PF_SUSPEND_TASK flag on tasks that call freeze_processes

2013-07-30 14:05:06 +02:00

futex_compat.c

…

futex.c

futex: move user address verification up to common code

2013-12-12 09:53:51 -08:00

groups.c

userns: Kill nsown_capable it makes the wrong thing easy

2013-08-30 23:44:11 -07:00

hrtimer.c

kernel: delete __cpuinit usage from all core kernel files

2013-07-14 19:36:59 -04:00

hung_task.c

Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm

2013-11-15 13:51:36 +09:00

irq_work.c

…

itimer.c

…

jump_label.c

static_key: WARN on usage before jump_label_init was called

2013-10-19 19:45:35 -04:00

kallsyms.c

kernel: kallsyms: memory override issue, need check destination buffer length

2013-04-15 15:17:26 +09:30

kcmp.c

…

Kconfig.freezer

…

Kconfig.hz

kernel: remove CONFIG_USE_GENERIC_SMP_HELPERS

2013-11-15 09:32:22 +09:00

Kconfig.locks

locking: Fix copy/paste errors of "ARCH_INLINE_*_UNLOCK_BH"

2013-05-28 08:50:00 +02:00

Kconfig.preempt

…

kexec.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial

2013-11-15 16:47:22 -08:00

kmod.c

kernel/kmod.c: check for NULL in call_usermodehelper_exec()

2013-09-30 14:31:02 -07:00

kprobes.c

kprobes: use KSYM_NAME_LEN to size identifier buffers

2013-11-13 12:09:26 +09:00

ksysfs.c

kernel: replace strict_strto*() with kstrto*()

2013-09-12 15:38:03 -07:00

kthread.c

kthread: make kthread_create() killable

2013-11-13 12:08:59 +09:00

latencytop.c

…

Makefile

KEYS: Remove files generated when SYSTEM_TRUSTED_KEYRING=y

2013-12-13 15:59:11 +00:00

module_signing.c

keys: change asymmetric keys to use common hash definitions

2013-10-25 17:15:18 -04:00

module-internal.h

KEYS: Separate the kernel signature checking keyring from module signing

2013-09-25 17:17:01 +01:00

module.c

Merge tag 'modules-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux

2013-11-15 13:27:50 +09:00

notifier.c

…

nsproxy.c

Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace

2013-09-07 14:35:32 -07:00

padata.c

padata: make the sequence counter an atomic_t

2013-10-30 12:02:58 +08:00

panic.c

kernel/panic.c: reduce 1 byte usage for print tainted buffer

2013-11-13 12:09:35 +09:00

params.c

kernel/params: fix handling of signed integer types

2013-09-28 12:35:52 -07:00

pid_namespace.c

pid_namespace: make freeing struct pid_namespace rcu-delayed

2013-10-24 23:43:29 -04:00

pid.c

pidns: fix free_pid() to handle the first fork failure

2013-09-30 14:31:03 -07:00

posix-cpu-timers.c

posix_timers: fix racy timer delta caching on task exit

2013-07-03 16:54:42 +02:00

posix-timers.c

posix-timers: Remove unused variable

2013-04-18 12:51:19 +02:00

profile.c

kernel: delete __cpuinit usage from all core kernel files

2013-07-14 19:36:59 -04:00

ptrace.c

exec/ptrace: fix get_dumpable() incorrect tests

2013-11-13 12:09:33 +09:00

range.c

range: Do not add new blank slot with add_range_with_merge

2013-06-18 11:32:10 -05:00

reboot.c

kernel/reboot.c: re-enable the function of variable reboot_default

2013-09-24 17:00:26 -07:00

relay.c

kernel: delete __cpuinit usage from all core kernel files

2013-07-14 19:36:59 -04:00

res_counter.c

memcg: reduce function dereference

2013-09-12 15:38:02 -07:00

resource.c

kernel/resource.c: remove the unneeded assignment in function __find_resource

2013-07-03 16:08:06 -07:00

seccomp.c

seccomp: allow BPF_XOR based ALU instructions.

2013-03-26 11:07:19 +11:00

signal.c

constify copy_siginfo_to_user{,32}()

2013-11-09 00:16:29 -05:00

smp.c

kernel: fix generic_exec_single indentation

2013-11-15 09:32:22 +09:00

smpboot.c

kernel: delete __cpuinit usage from all core kernel files

2013-07-14 19:36:59 -04:00

smpboot.h

…

softirq.c

revert "softirq: Add support for triggering softirq work on softirqs"

2013-11-15 09:32:22 +09:00

stacktrace.c

…

stop_machine.c

stop_machine: Fix race between stop_two_cpus() and stop_cpus()

2013-11-11 12:43:38 +01:00

sys_ni.c

unify compat fanotify_mark(2), switch to COMPAT_SYSCALL_DEFINE

2013-05-09 13:46:38 -04:00

sys.c

kernel/sys.c: remove obsolete #include <linux/kexec.h>

2013-11-13 12:09:13 +09:00

sysctl_binary.c

kernel/sysctl_binary.c: use scnprintf() instead of snprintf()

2013-11-13 12:09:33 +09:00

sysctl.c

Merge branch 'core-locking-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2013-11-14 16:30:30 +09:00

system_certificates.S

KEYS: correct alignment of system_certificate_list content in assembly file

2013-12-10 18:25:28 +00:00

system_keyring.c

KEYS: correct alignment of system_certificate_list content in assembly file

2013-12-10 18:25:28 +00:00

task_work.c

task_work: documentation

2013-09-11 15:58:27 -07:00

taskstats.c

genetlink: only pass array to genl_register_family_with_ops()

2013-11-19 16:39:05 -05:00

test_kprobes.c

kernel/: rename random32() to prandom_u32()

2013-04-29 18:28:42 -07:00

time.c

sched: Rename sched.c as sched/core.c in comments and Documentation

2013-06-19 12:58:42 +02:00

timeconst.bc

…

timer.c

timer: Convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...)

2013-11-19 14:59:50 +01:00

tracepoint.c

Merge tag 'trace-3.10' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace

2013-04-29 13:55:38 -07:00

tsacct.c

…

uid16.c

userns: Kill nsown_capable it makes the wrong thing easy

2013-08-30 23:44:11 -07:00

up.c

kernel: provide a __smp_call_function_single stub for !CONFIG_SMP

2013-11-15 09:32:22 +09:00

user_namespace.c

KEYS: Add per-user_namespace registers for persistent per-UID kerberos caches

2013-09-24 10:35:19 +01:00

user-return-notifier.c

…

user.c

KEYS: fix uninitialized persistent_keyring_register_sem

2013-12-13 15:59:11 +00:00

utsname_sysctl.c

…

utsname.c

userns: Kill nsown_capable it makes the wrong thing easy

2013-08-30 23:44:11 -07:00

watchdog.c

watchdog: update watchdog_thresh properly

2013-09-24 17:00:25 -07:00

workqueue_internal.h

sched: Rename sched.c as sched/core.c in comments and Documentation

2013-06-19 12:58:42 +02:00

workqueue.c

workqueue: fix pool ID allocation leakage and remove BUILD_BUG_ON() in init_workqueues

2013-11-22 18:14:47 -05:00