Nathaniel W. Turner
6c06f072c2
xfs: copy li_lsn before dropping AIL lock
...
Access to log items on the AIL is generally protected by m_ail_lock;
this is particularly needed when we're getting or setting the 64-bit
li_lsn on a 32-bit platform. This patch fixes a couple places where we
were accessing the log item after dropping the AIL lock on 32-bit
machines.
This can result in a partially-zeroed log->l_tail_lsn if
xfs_trans_ail_delete is racing with xfs_trans_ail_update, and in at
least some cases, this can leave the l_tail_lsn with a zero cycle
number, which means xlog_space_left will think the log is full (unless
CONFIG_XFS_DEBUG is set, in which case we'll trip an ASSERT), leading to
processes stuck forever in xlog_grant_log_space.
Thanks to Adrian VanderSpek for first spotting the race potential and to
Dave Chinner for debug assistance.
Signed-off-by: Nathaniel W. Turner <nate@houseofnate.net >
Reviewed-by: Christoph Hellwig <hch@lst.de >
Signed-off-by: Alex Elder <aelder@sgi.com >
2009-11-17 10:26:49 -06:00
..
2009-11-02 08:43:45 -06:00
2009-09-24 07:21:05 -07:00
2009-06-11 21:36:14 -04:00
2009-10-01 16:11:16 -07:00
2009-09-21 15:14:58 +02:00
2009-08-31 17:44:05 -10:00
2009-09-24 07:47:42 -04:00
2009-07-12 12:22:34 -07:00
2009-11-11 13:38:59 -08:00
2009-06-11 21:36:06 -04:00
2009-11-06 22:06:14 +00:00
2009-10-04 15:05:10 -07:00
2009-09-11 09:20:26 +02:00
2009-06-15 21:30:28 -07:00
2009-09-23 07:39:28 -07:00
2009-09-30 12:19:44 -05:00
2009-10-08 11:31:38 -05:00
2009-06-17 00:36:36 -04:00
2009-09-24 07:47:38 -04:00
2009-09-24 07:53:22 -07:00
2009-11-11 15:22:49 +01:00
2009-11-08 15:45:44 -05:00
2009-09-30 09:31:14 -07:00
2009-07-12 12:22:34 -07:00
2009-05-27 10:20:13 -07:00
2009-11-04 10:24:52 +01:00
2009-09-27 11:39:25 -07:00
2009-10-29 07:39:29 -07:00
2009-10-29 07:39:27 -07:00
2009-06-30 18:56:03 -07:00
2009-07-12 12:22:34 -07:00
2009-09-24 08:32:11 -07:00
2009-09-24 07:47:42 -04:00
2009-11-12 10:24:12 +01:00
2009-11-11 15:24:14 +01:00
2009-09-23 10:07:49 -07:00
2009-09-24 07:47:42 -04:00
2009-09-23 18:13:10 -07:00
2009-09-23 07:39:57 -07:00
2009-09-27 11:39:25 -07:00
2009-10-26 08:09:46 -04:00
2009-11-14 12:55:55 -08:00
2009-11-08 19:04:25 +09:00
2009-09-30 09:31:14 -07:00
2009-10-20 18:02:33 -04:00
2009-09-24 08:32:11 -07:00
2009-10-01 16:11:11 -07:00
2009-10-01 16:11:11 -07:00
2009-10-06 20:16:55 +02:00
2009-11-12 07:25:57 -08:00
2009-09-23 07:39:30 -07:00
2009-09-22 07:17:24 -07:00
2009-09-24 08:41:47 -04:00
2009-09-22 07:17:24 -07:00
2009-10-11 11:33:56 -07:00
2009-09-24 07:47:42 -04:00
2009-09-22 07:17:24 -07:00
2009-11-05 08:19:18 +11:00
2009-06-17 00:36:37 -04:00
2009-09-27 11:39:25 -07:00
2009-09-14 19:13:01 +02:00
2009-06-18 13:03:46 -07:00
2009-11-17 10:26:49 -06:00
2009-09-23 07:39:29 -07:00
2009-10-04 15:05:10 -07:00
2009-09-24 08:41:47 -04:00
2009-09-24 07:21:02 -07:00
2009-09-24 07:21:01 -07:00
2009-09-24 07:21:03 -07:00
2009-07-01 10:56:25 +02:00
2009-11-02 11:41:13 +01:00
2009-10-26 15:27:11 +01:00
2009-09-25 09:27:30 -07:00
2009-09-24 07:21:03 -07:00
2009-11-12 07:25:57 -08:00
2009-11-04 13:25:03 +01:00
2009-07-18 15:51:44 +02:00
2009-05-22 23:22:54 +02:00
2009-09-24 07:21:04 -07:00
2009-09-23 07:39:29 -07:00
2009-06-18 13:03:41 -07:00
2009-11-12 07:25:58 -08:00
2009-09-24 07:21:01 -07:00
2009-09-24 07:21:04 -07:00
2009-10-11 11:20:58 -07:00
2009-09-26 00:10:40 +02:00
2009-09-24 07:47:27 -04:00
2009-09-24 08:40:15 -04:00
2009-11-12 07:26:01 -08:00
2009-10-30 15:03:54 +11:00
2009-09-24 07:47:30 -04:00
2009-09-22 07:17:25 -07:00
2009-09-11 08:55:49 -07:00
2009-09-24 08:40:15 -04:00
2009-09-23 09:21:05 -07:00
2009-10-22 08:11:44 +09:00
2009-09-24 07:47:34 -04:00
2009-10-04 15:05:10 -07:00
2009-09-24 07:47:35 -04:00
2009-09-14 17:55:15 -07:00
2009-09-24 07:47:41 -04:00
2009-09-23 07:39:29 -07:00
2009-09-10 10:11:22 +10:00