Joel Stanley 6cee9d649c
ftgmac100: return error in ftgmac100_alloc_rx_buf ...
The error paths set err, but it's not returned.
I wondered if we should fix all of the callers to check the returned
value, but Ben explains why the code is this way:
> Most call sites ignore it on purpose. There's nothing we can do if
> we fail to get a buffer at interrupt time, so we point the buffer to
> the scratch page so the HW doesn't DMA into lalaland and lose the
> packet.
>
> The one call site that tests and can fail is the one used when brining
> the interface up. If we fail to allocate at that point, we fail the
> ifup. But as you noticed, I do have a bug not returning the error.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org >
Signed-off-by: Joel Stanley <joel@jms.id.au >
Signed-off-by: David S. Miller <davem@davemloft.net >
2017-07-25 21:21:44 -07:00
2017-07-17 11:43:58 -07:00
2017-07-06 09:41:58 -07:00
2017-07-18 11:37:46 -07:00
2017-07-20 14:56:46 -07:00
2017-07-11 15:36:52 -07:00
2017-07-05 12:31:59 -07:00
2017-07-09 18:48:37 -07:00
2017-06-27 12:13:45 -06:00
2017-07-15 12:44:02 -07:00
2017-07-15 10:59:54 -07:00
2017-07-04 14:47:47 -07:00
2017-07-20 18:57:15 +02:00
2017-07-07 13:55:45 -07:00
2017-07-14 22:49:50 -07:00
2017-07-18 17:49:14 -07:00
2017-07-06 10:17:24 +09:00
2017-07-08 12:36:50 -07:00
2017-06-29 10:37:50 +02:00
2017-07-12 16:26:02 -07:00
2017-07-07 13:30:05 -07:00
2017-07-15 11:47:27 -07:00
2017-07-20 15:45:39 +02:00
2017-07-04 14:28:22 -07:00
2017-07-06 12:10:33 -07:00
2017-06-24 08:58:06 -07:00
2017-07-03 20:55:59 -07:00
2017-07-12 10:04:56 -07:00
2017-06-29 22:58:35 +02:00
2017-07-04 11:48:27 -07:00
2017-07-17 21:21:30 -04:00
2017-07-14 22:53:37 -07:00
2017-07-12 10:00:04 -07:00
2017-07-05 17:09:27 -07:00
2017-07-15 21:25:56 -07:00
2017-07-06 11:32:40 -07:00
2017-07-07 13:17:36 -06:00
2017-07-05 13:13:32 -07:00
2017-07-07 10:24:07 -07:00
2017-07-18 11:51:08 -07:00
2017-07-09 18:48:37 -07:00
2017-07-04 14:47:47 -07:00
2017-07-11 09:55:47 -07:00
2017-07-07 13:55:45 -07:00
2017-07-14 13:10:06 -07:00
2017-07-13 12:07:44 -07:00
2017-07-25 21:21:44 -07:00
2017-07-01 14:30:39 -07:00
2017-07-06 11:30:08 -04:00
2017-07-17 11:43:58 -07:00
2017-07-11 15:36:52 -07:00
2017-07-10 15:23:45 -07:00
2017-07-05 21:46:42 +02:00
2017-07-14 22:24:25 -07:00
2017-06-26 10:54:27 +01:00
2017-07-06 11:38:59 -07:00
2017-07-15 10:59:54 -07:00
2017-07-07 12:40:27 -07:00
2017-07-13 11:47:59 -07:00
2017-06-28 00:38:34 +02:00
2017-07-06 11:40:58 +01:00
2017-07-13 11:49:52 -07:00
2017-07-05 17:09:27 -07:00
2017-07-03 16:52:21 +01:00
2017-06-27 16:21:34 -07:00
2017-07-04 14:47:47 -07:00
2017-07-06 15:38:31 -07:00
2017-07-13 12:15:06 -07:00
2017-07-12 16:26:04 -07:00
2017-06-27 12:13:45 -06:00
2017-07-17 12:26:12 -07:00
2017-07-06 16:24:30 -07:00
2017-07-04 14:47:47 -07:00
2017-07-08 10:41:53 -07:00
2017-07-13 12:07:44 -07:00
2017-07-15 12:44:02 -07:00
2017-07-14 13:12:32 -07:00
2017-07-12 16:26:04 -07:00
2017-07-12 16:26:04 -07:00
2017-07-03 20:27:48 -07:00
2017-07-13 12:23:54 -07:00
2017-07-13 14:27:32 -07:00
2017-07-13 12:38:49 -07:00
2017-07-11 09:59:37 -07:00
2017-07-13 14:27:32 -07:00
6cee9d649c