mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
7433632c9ff68a991bd0bc38cabf354e9d2de410
linux/kernel/trace
History
Steven Rostedt (Google) 7433632c9f ring-buffer: Check for NULL cpu_buffer in ring_buffer_wake_waiters() 
On some machines the number of listed CPUs may be bigger than the actual
CPUs that exist. The tracing subsystem allocates a per_cpu directory with
access to the per CPU ring buffer via a cpuX file. But to save space, the
ring buffer will only allocate buffers for online CPUs, even though the
CPU array will be as big as the nr_cpu_ids.

With the addition of waking waiters on the ring buffer when closing the
file, the ring_buffer_wake_waiters() now needs to make sure that the
buffer is allocated (with the irq_work allocated with it) before trying to
wake waiters, as it will cause a NULL pointer dereference.

While debugging this, I added a NULL check for the buffer itself (which is
OK to do), and also NULL pointer checks against buffer->buffers (which is
not fine, and will WARN) as well as making sure the CPU number passed in
is within the nr_cpu_ids (which is also not fine if it isn't).

Link: https://lore.kernel.org/all/87h6zklb6n.wl-tiwai@suse.de/
Link: https://lore.kernel.org/all/CAM6Wdxc0KRJMXVAA0Y=u6Jh2V=uWB-_Fn6M4xRuNppfXzL1mUg@mail.gmail.com/
Link: https://lkml.kernel.org/linux-trace-kernel/20221101191009.1e7378c8@rorschach.local.home

Cc: stable@vger.kernel.org
Cc: Steven Noonan <steven.noonan@gmail.com>
Bugzilla: https://bugzilla.opensuse.org/show_bug.cgi?id=1204705
Reported-by: Takashi Iwai <tiwai@suse.de>
Reported-by: Roland Ruckerbauer <roland.rucky@gmail.com>
Fixes: f3ddb74ad0 ("tracing: Wake up ring buffer waiters on closing of the file")
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@kernel.org>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
2022-11-02 23:52:03 -04:00
..
rv
rv/monitor: Add __init/__exit annotations to module init/exit funcs
2022-09-26 18:10:51 -04:00
blktrace.c
blktrace: remove unnessary stop block trace in 'blk_trace_shutdown'
2022-10-20 06:02:52 -07:00
bpf_trace.c
bpf: Fix sample_flags for bpf_perf_event_output
2022-10-17 16:32:06 +02:00
bpf_trace.h
…
error_report-traces.c
…
fgraph.c
Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
2022-06-03 14:05:34 -07:00
fprobe.c
fprobe: Resolve symbols with ftrace_lookup_symbols
2022-05-10 14:42:06 -07:00
ftrace_internal.h
…
ftrace.c
Merge tag 'trace-v6.1-1' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
2022-10-13 10:36:57 -07:00
Kconfig
ftrace: Add HAVE_DYNAMIC_FTRACE_NO_PATCHABLE
2022-09-16 22:16:48 +02:00
kprobe_event_gen_test.c
tracing: kprobe: Make gen test module work in arm and riscv
2022-09-26 16:04:47 -04:00
Makefile
rv: Add Runtime Verification (RV) interface
2022-07-30 14:01:28 -04:00
pid_list.c
tracing: Cleanup double word in comment
2022-04-26 17:58:50 -04:00
pid_list.h
…
power-traces.c
…
preemptirq_delay_test.c
…
rethook.c
rethook: Reject getting a rethook if RCU is not watching
2022-06-17 21:53:35 +02:00
ring_buffer_benchmark.c
…
ring_buffer.c
ring-buffer: Check for NULL cpu_buffer in ring_buffer_wake_waiters()
2022-11-02 23:52:03 -04:00
rpm-traces.c
…
synth_event_gen_test.c
…
trace_benchmark.c
tracing: Add numeric delta time to the trace event benchmark
2022-09-26 13:01:09 -04:00
trace_benchmark.h
tracing: Add numeric delta time to the trace event benchmark
2022-09-26 13:01:09 -04:00
trace_boot.c
tracing: Initialize integer variable to prevent garbage return value
2022-05-26 21:13:00 -04:00
trace_branch.c
…
trace_clock.c
…
trace_dynevent.c
tracing: Auto generate event name when creating a group of events
2022-07-24 19:11:17 -04:00
trace_dynevent.h
…
trace_entries.h
…
trace_eprobe.c
tracing: Move duplicate code of trace_kprobe/eprobe.c into header
2022-10-12 13:50:00 -04:00
trace_event_perf.c
tracing/perf: Fix double put of trace event when init fails
2022-08-21 15:56:07 -04:00
trace_events_filter_test.h
…
trace_events_filter.c
tracing/filter: Call filter predicate functions directly via a switch statement
2022-09-26 13:01:10 -04:00
trace_events_hist.c
tracing/hist: Call hist functions directly via a switch statement
2022-09-26 13:01:10 -04:00
trace_events_inject.c
tracing: Support __rel_loc relative dynamic data location attribute
2021-12-06 15:37:21 -05:00
trace_events_synth.c
tracing: Fix reading strings from synthetic events
2022-10-12 13:51:16 -04:00
trace_events_trigger.c
tracing: Fix to check event_mutex is held while accessing trigger list
2022-09-06 22:26:00 -04:00
trace_events_user.c
tracing/user_events: Move pages/locks into groups to prepare for namespaces
2022-10-03 13:28:46 -04:00
trace_events.c
tracing: Have filter accept "common_cpu" to be consistent
2022-08-21 15:56:08 -04:00
trace_export.c
…
trace_functions_graph.c
…
trace_functions.c
…
trace_hwlat.c
trace/hwlat: make use of the helper function kthread_run_on_cpu()
2022-01-15 16:30:24 +02:00
trace_irqsoff.c
…
trace_kdb.c
…
trace_kprobe_selftest.c
…
trace_kprobe_selftest.h
…
trace_kprobe.c
tracing: Move duplicate code of trace_kprobe/eprobe.c into header
2022-10-12 13:50:00 -04:00
trace_mmiotrace.c
…
trace_nop.c
…
trace_osnoise.c
tracing/osnoise: Fix possible recursive locking in stop_per_cpu_kthreads
2022-09-26 16:05:18 -04:00
trace_output.c
tracing: Remove usage of list iterator after the loop body
2022-04-27 17:19:30 -04:00
trace_output.h
…
trace_preemptirq.c
tracing: hold caller_addr to hardirq_{enable,disable}_ip
2022-09-06 22:26:00 -04:00
trace_printk.c
…
trace_probe_kernel.h
tracing: Add "(fault)" name injection to kernel probes
2022-10-12 13:50:20 -04:00
trace_probe_tmpl.h
…
trace_probe.c
tracing/probes: Have kprobes and uprobes use $COMM too
2022-08-21 15:56:08 -04:00
trace_probe.h
tracing/eprobe: Add eprobe filter support
2022-09-26 13:01:08 -04:00
trace_recursion_record.c
tracing: Use trace_create_file() to simplify creation of tracefs entries
2022-05-26 21:12:52 -04:00
trace_sched_switch.c
sched/tracing: Append prev_state to tp args instead
2022-05-12 00:37:11 +02:00
trace_sched_wakeup.c
sched/tracing: Append prev_state to tp args instead
2022-05-12 00:37:11 +02:00
trace_selftest_dynamic.c
…
trace_selftest.c
tracing: Reset the function filter after completing trampoline/graph selftest
2022-05-25 16:57:37 -04:00
trace_seq.c
…
trace_stack.c
…
trace_stat.c
…
trace_stat.h
…
trace_synth.h
…
trace_syscalls.c
tracing: Make tp_printk work on syscall tracepoints
2022-04-26 17:58:52 -04:00
trace_uprobe.c
Merge tag 'trace-v6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
2022-08-05 09:41:12 -07:00
trace.c
tracing: Do not free snapshot if tracer is on cmdline
2022-10-05 22:18:23 -04:00
trace.h
tracing: Move struct filter_pred into trace_events_filter.c
2022-09-26 13:01:10 -04:00
tracing_map.c
tracing: Remove unused variable 'dups'
2022-10-03 12:20:31 -04:00
tracing_map.h
…