Jiri Pirko a0c76345e3
devlink: disallow reload operation during device cleanup ...
There is a race between driver code that does setup/cleanup of device
and devlink reload operation that in some drivers works with the same
code. Use after free could we easily obtained by running:
while true; do
echo 10 > /sys/bus/netdevsim/new_device
devlink dev reload netdevsim/netdevsim10 &
echo 10 > /sys/bus/netdevsim/del_device
done
Fix this by enabling reload only after setup of device is complete and
disabling it at the beginning of the cleanup process.
Reported-by: Ido Schimmel <idosch@mellanox.com >
Fixes: 2d8dc5bbf4jiri@mellanox.com >
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com >
Signed-off-by: David S. Miller <davem@davemloft.net >
2019-11-08 14:11:47 -08:00
2019-11-01 09:30:48 -07:00
2019-10-23 06:26:33 -04:00
2019-10-17 05:58:44 -07:00
2019-10-25 14:22:20 -06:00
2019-10-28 16:47:22 -07:00
2019-09-17 16:22:26 -07:00
2019-10-21 02:05:21 +02:00
2019-10-24 08:45:31 +03:00
2019-10-25 14:37:21 -06:00
2019-10-21 17:05:14 +02:00
2019-11-02 13:54:56 -07:00
2019-10-02 13:49:43 -07:00
2019-10-04 09:06:41 -07:00
2019-10-02 16:16:07 -07:00
2019-10-22 18:07:30 +02:00
2019-10-22 11:43:17 +02:00
2019-11-06 21:35:34 -08:00
2019-08-26 21:37:37 +09:00
2019-10-23 21:15:21 +05:30
2019-10-10 17:05:20 +02:00
2019-10-17 11:27:05 +02:00
2019-09-19 14:14:28 -07:00
2019-11-07 20:07:30 -08:00
2019-11-02 13:54:56 -07:00
2019-09-18 11:14:31 -07:00
2019-08-28 22:59:18 +02:00
2019-10-15 01:19:05 +02:00
2019-11-01 11:27:39 +10:00
2019-08-27 19:03:08 +02:00
2019-10-28 14:26:33 +01:00
2019-09-22 12:02:21 -07:00
2019-10-01 14:49:45 -04:00
2019-10-02 06:42:48 -07:00
2019-09-18 11:14:31 -07:00
2019-10-24 20:52:21 +02:00
2019-08-27 09:43:59 +02:00
2019-08-28 11:29:32 +02:00
2019-10-10 11:18:37 +02:00
2019-10-28 15:06:38 -03:00
2019-10-25 17:31:53 -04:00
2019-10-30 10:30:22 +01:00
2019-10-25 14:25:15 +02:00
2019-11-03 19:10:30 -08:00
2019-09-12 20:45:52 +02:00
2019-09-05 13:17:01 -06:00
2019-10-21 02:05:21 +02:00
2019-09-17 00:54:29 -05:00
2019-10-18 22:29:36 -04:00
2019-10-04 14:38:46 +02:00
2019-08-30 15:57:27 +02:00
2019-10-09 11:08:03 +02:00
2019-10-24 08:49:25 +01:00
2019-10-04 18:22:14 +02:00
2019-10-21 16:16:38 +02:00
2019-10-07 09:56:36 +02:00
2019-11-08 14:11:47 -08:00
2019-10-29 21:05:26 -07:00
2019-09-23 17:20:40 -04:00
2019-09-29 10:33:41 -07:00
2019-11-01 17:48:11 -07:00
2019-09-18 11:14:31 -07:00
2019-11-04 11:21:25 -08:00
2019-10-23 10:58:44 +05:30
2019-10-14 21:44:26 +02:00
2019-09-18 11:14:31 -07:00
2019-10-15 23:51:36 +02:00
2019-09-28 08:14:15 -07:00
2019-08-30 12:46:12 +01:00
2019-09-23 19:16:01 -07:00
2019-10-16 15:58:27 +02:00
2019-10-14 15:31:50 +03:00
2019-09-22 12:04:59 -07:00
2019-09-17 19:15:14 -07:00
2019-11-06 21:19:59 -08:00
2019-09-27 12:19:47 -07:00
2019-10-23 15:31:17 -04:00
2019-09-22 10:55:08 -07:00
2019-09-30 10:04:28 -07:00
2019-09-17 15:33:31 -07:00
2019-09-22 11:05:43 -07:00
2019-11-02 13:54:56 -07:00
2019-10-25 20:11:33 -04:00
2019-11-02 13:54:56 -07:00
2019-09-22 10:52:23 -07:00
2019-10-08 17:38:15 +01:00
2019-09-13 17:23:18 +03:00
2019-11-02 13:54:56 -07:00
2019-10-25 20:11:33 -04:00
2019-09-25 17:51:41 -07:00
2019-10-21 02:05:21 +02:00
2019-08-26 12:15:06 +03:00
2019-10-15 21:38:41 +02:00
2019-09-18 11:14:31 -07:00
2019-10-18 12:00:15 -07:00
2019-10-15 14:07:01 -06:00
2019-10-28 04:25:04 -04:00
2019-10-05 15:29:49 +09:00
2019-10-10 14:50:32 +02:00
2019-10-28 04:24:46 -04:00
2019-10-10 15:35:41 +02:00
2019-09-27 11:17:38 -07:00
2019-10-19 17:09:11 -04:00
2019-09-18 11:05:34 -07:00
2019-09-18 11:05:34 -07:00
a0c76345e3