mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
7d63b67125382ff0ffdfca434acbc94a38bd092b
linux/net/ipv4
History
Eric Dumazet 7d63b67125 icmp: guard against too small mtu 
syzbot was able to trigger a panic [1] in icmp_glue_bits(), or
more exactly in skb_copy_and_csum_bits()

There is no repro yet, but I think the issue is that syzbot
manages to lower device mtu to a small value, fooling __icmp_send()

__icmp_send() must make sure there is enough room for the
packet to include at least the headers.

We might in the future refactor skb_copy_and_csum_bits() and its
callers to no longer crash when something bad happens.

[1]
kernel BUG at net/core/skbuff.c:3343 !
invalid opcode: 0000 [#1] PREEMPT SMP KASAN
CPU: 0 PID: 15766 Comm: syz-executor.0 Not tainted 6.3.0-rc4-syzkaller-00039-gffe78bbd5121 #0
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.14.0-2 04/01/2014
RIP: 0010:skb_copy_and_csum_bits+0x798/0x860 net/core/skbuff.c:3343
Code: f0 c1 c8 08 41 89 c6 e9 73 ff ff ff e8 61 48 d4 f9 e9 41 fd ff ff 48 8b 7c 24 48 e8 52 48 d4 f9 e9 c3 fc ff ff e8 c8 27 84 f9 <0f> 0b 48 89 44 24 28 e8 3c 48 d4 f9 48 8b 44 24 28 e9 9d fb ff ff
RSP: 0018:ffffc90000007620 EFLAGS: 00010246
RAX: 0000000000000000 RBX: 00000000000001e8 RCX: 0000000000000100
RDX: ffff8880276f6280 RSI: ffffffff87fdd138 RDI: 0000000000000005
RBP: 0000000000000000 R08: 0000000000000005 R09: 0000000000000000
R10: 00000000000001e8 R11: 0000000000000001 R12: 000000000000003c
R13: 0000000000000000 R14: ffff888028244868 R15: 0000000000000b0e
FS: 00007fbc81f1c700(0000) GS:ffff88802ca00000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000001b2df43000 CR3: 00000000744db000 CR4: 0000000000150ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<IRQ>
icmp_glue_bits+0x7b/0x210 net/ipv4/icmp.c:353
__ip_append_data+0x1d1b/0x39f0 net/ipv4/ip_output.c:1161
ip_append_data net/ipv4/ip_output.c:1343 [inline]
ip_append_data+0x115/0x1a0 net/ipv4/ip_output.c:1322
icmp_push_reply+0xa8/0x440 net/ipv4/icmp.c:370
__icmp_send+0xb80/0x1430 net/ipv4/icmp.c:765
ipv4_send_dest_unreach net/ipv4/route.c:1239 [inline]
ipv4_link_failure+0x5a9/0x9e0 net/ipv4/route.c:1246
dst_link_failure include/net/dst.h:423 [inline]
arp_error_report+0xcb/0x1c0 net/ipv4/arp.c:296
neigh_invalidate+0x20d/0x560 net/core/neighbour.c:1079
neigh_timer_handler+0xc77/0xff0 net/core/neighbour.c:1166
call_timer_fn+0x1a0/0x580 kernel/time/timer.c:1700
expire_timers+0x29b/0x4b0 kernel/time/timer.c:1751
__run_timers kernel/time/timer.c:2022 [inline]

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Reported-by: syzbot+d373d60fddbdc915e666@syzkaller.appspotmail.com
Signed-off-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20230330174502.1915328-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-03-31 21:37:06 -07:00
..
bpfilter
net: Revert "net: optimize the sockptr_t for unified kernel/user address spaces"
2020-08-10 12:06:44 -07:00
netfilter
netfilter: tproxy: fix deadlock due to missing BH disable
2023-03-06 12:09:48 +01:00
af_inet.c
net: no longer support SOCK_REFCNT_DEBUG feature
2023-02-15 10:25:21 +00:00
ah4.c
net: ipv4: Remove completion function scaffolding
2023-02-13 18:35:15 +08:00
arp.c
ipv4: move from strlcpy with unused retval to strscpy
2022-08-22 17:59:37 -07:00
bpf_tcp_ca.c
bpf: Pass const struct bpf_prog * to .check_member
2023-01-25 10:25:57 -08:00
cipso_ipv4.c
cipso_ipv4: use iph_set_totlen in skbuff_setattr
2023-02-01 20:54:27 -08:00
datagram.c
Merge tag 'net-6.1-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-10-20 17:24:59 -07:00
devinet.c
net: devinet: Reduce refcount before grace period
2022-11-30 13:17:52 -08:00
esp4_offload.c
xfrm: replay: Fix ESN wrap around for GSO
2022-10-19 09:00:53 +02:00
esp4.c
net: ipv4: Remove completion function scaffolding
2023-02-13 18:35:15 +08:00
fib_frontend.c
ipv4: Fix incorrect table ID in IOCTL path
2023-03-16 17:26:31 -07:00
fib_lookup.h
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-02-17 11:44:20 -08:00
fib_notifier.c
net: ipv4: remove superfluous header files from fib_notifier.c
2021-09-28 17:32:56 -07:00
fib_rules.c
ipv4: remove unnecessary type castings
2022-04-30 15:12:58 +01:00
fib_semantics.c
ipv4: prevent potential spectre v1 gadget in fib_metrics_match()
2023-01-23 21:37:39 -08:00
fib_trie.c
ipv4: Fix error return code in fib_table_insert()
2022-11-22 20:18:20 -08:00
fou_core.c
net: fou: use policy and operation tables generated from the spec
2023-01-24 10:58:11 +01:00
fou_nl.c
ynl: broaden the license even more
2023-03-16 21:20:32 -07:00
fou_nl.h
ynl: broaden the license even more
2023-03-16 21:20:32 -07:00
gre_demux.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
gre_offload.c
net: gro: skb_gro_header helper function
2022-08-25 10:33:21 +02:00
icmp.c
icmp: guard against too small mtu
2023-03-31 21:37:06 -07:00
igmp.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
inet_connection_sock.c
net/ulp: Remove redundant ->clone() test in inet_clone_ulp().
2023-02-20 16:31:49 -08:00
inet_diag.c
net: inet: Retire port only listening_hash
2022-05-12 16:52:18 -07:00
inet_fragment.c
net: dropreason: add SKB_DROP_REASON_FRAG_REASM_TIMEOUT
2022-10-31 20:14:27 -07:00
inet_hashtables.c
tcp: Fix bind() conflict check for dual-stack wildcard address.
2023-03-15 00:23:14 -07:00
inet_timewait_sock.c
net: no longer support SOCK_REFCNT_DEBUG feature
2023-02-15 10:25:21 +00:00
inetpeer.c
inetpeer: Fix data-races around sysctl.
2022-07-08 12:10:33 +01:00
ip_forward.c
ip: Fix data-races around sysctl_ip_fwd_update_priority.
2022-07-15 11:49:55 +01:00
ip_fragment.c
net: dropreason: add SKB_DROP_REASON_FRAG_TOO_FAR
2022-10-31 20:14:27 -07:00
ip_gre.c
erspan: do not use skb_mac_header() in ndo_start_xmit()
2023-03-21 21:16:26 -07:00
ip_input.c
net: add support for ipv4 big tcp
2023-02-01 20:54:27 -08:00
ip_options.c
ipv4: drop fragmentation code from ip_options_build()
2022-01-29 17:53:07 +00:00
ip_output.c
net: add support for ipv4 big tcp
2023-02-01 20:54:27 -08:00
ip_sockglue.c
inet: Add IP_LOCAL_PORT_RANGE socket option
2023-01-25 22:45:00 -08:00
ip_tunnel_core.c
net: Add helper function to parse netlink msg of ip_tunnel_parm
2022-10-03 07:59:06 +01:00
ip_tunnel.c
net: tunnels: annotate lockless accesses to dev->needed_headroom
2023-03-15 00:04:04 -07:00
ip_vti.c
ipv4: tunnels: use DEV_STATS_INC()
2022-11-16 12:48:44 +00:00
ipcomp.c
xfrm: ipcomp: add extack to ipcomp{4,6}_init_state
2022-09-29 07:18:00 +02:00
ipconfig.c
Merge tag 'driver-core-6.0-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core
2022-08-04 11:31:20 -07:00
ipip.c
ipv4: tunnels: use DEV_STATS_INC()
2022-11-16 12:48:44 +00:00
ipmr_base.c
ipmr: adopt rcu_read_lock() in mr_dump()
2022-06-24 11:34:38 +01:00
ipmr.c
treewide: Convert del_timer*() to timer_shutdown*()
2022-12-25 13:38:09 -08:00
Kconfig
tcp: configurable source port perturb table size
2022-11-16 13:02:04 +00:00
Makefile
net: fou: use policy and operation tables generated from the spec
2023-01-24 10:58:11 +01:00
metrics.c
ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()
2023-01-23 21:37:25 -08:00
netfilter.c
netfilter: Use l3mdev flow key when re-routing mangled packets
2022-05-16 13:03:29 +02:00
netlink.c
…
nexthop.c
nh: fix scope used to find saddr when adding non gw nh
2022-10-27 10:17:40 -07:00
ping.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-12-08 18:19:59 -08:00
proc.c
icmp: Add counters for rate limits
2023-01-26 10:52:18 +01:00
protocol.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
raw_diag.c
raw: complete rcu conversion
2022-06-21 11:38:29 +02:00
raw.c
raw: use net_hash_mix() in hash function
2023-02-03 19:56:23 -08:00
route.c
treewide: use get_random_u32_below() instead of deprecated function
2022-11-18 02:15:15 +01:00
syncookies.c
mptcp: remove MPTCP 'ifdef' in TCP SYN cookies
2022-12-12 13:11:24 -08:00
sysctl_net_ipv4.c
udp: Introduce optional per-netns hash table.
2022-11-16 09:43:35 +00:00
tcp_bbr.c
bpf: Add __bpf_kfunc tag to all kfuncs
2023-02-02 00:25:14 +01:00
tcp_bic.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_bpf.c
bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser()
2023-03-03 17:25:15 +01:00
tcp_cdg.c
Merge tag 'random-6.1-rc1-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/crng/random
2022-10-16 15:27:07 -07:00
tcp_cong.c
bpf: Add __bpf_kfunc tag to all kfuncs
2023-02-02 00:25:14 +01:00
tcp_cubic.c
bpf: Add __bpf_kfunc tag to all kfuncs
2023-02-02 00:25:14 +01:00
tcp_dctcp.c
bpf: Add __bpf_kfunc tag to all kfuncs
2023-02-02 00:25:14 +01:00
tcp_dctcp.h
…
tcp_diag.c
tcp: Access &tcp_hashinfo via net.
2022-09-20 10:21:49 -07:00
tcp_fastopen.c
tcp: Make SYN ACK RTO tunable by BPF programs with TFO
2022-08-17 10:19:22 +01:00
tcp_highspeed.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_htcp.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_hybla.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_illinois.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_input.c
Merge tag 'net-next-6.2' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2022-12-13 15:47:48 -08:00
tcp_ipv4.c
tcp: add TCP_MINTTL drop reason
2023-02-02 21:14:50 -08:00
tcp_lp.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_metrics.c
genetlink: start to validate reserved header bytes
2022-08-29 12:47:15 +01:00
tcp_minisocks.c
tcp: tcp_check_req() can be called from process context
2023-02-27 11:59:29 -08:00
tcp_nv.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_offload.c
gro: add support of (hw)gro packets to gro stack
2022-10-03 12:38:34 +01:00
tcp_output.c
tcp: tcp_make_synack() can be called from process context
2023-03-09 23:12:00 -08:00
tcp_plb.c
prandom: remove prandom_u32_max()
2022-12-20 03:13:45 +01:00
tcp_rate.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net
2022-04-28 13:02:01 -07:00
tcp_recovery.c
tcp: Fix data-races around sysctl_tcp_recovery.
2022-07-20 10:14:50 +01:00
tcp_scalable.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_timer.c
tcp: Make SYN ACK RTO tunable by BPF programs with TFO
2022-08-17 10:19:22 +01:00
tcp_ulp.c
net/ulp: use consistent error code when blocking ULP
2023-01-19 09:26:16 -08:00
tcp_vegas.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_vegas.h
…
tcp_veno.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_westwood.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp_yeah.c
tcp: add accessors to read/set tp->snd_cwnd
2022-04-06 12:05:41 -07:00
tcp.c
Merge tag 'mm-stable-2023-02-20-13-37' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2023-02-23 17:09:35 -08:00
tunnel4.c
net: Remove the member netns_ok
2021-05-17 15:29:35 -07:00
udp_bpf.c
bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser()
2023-03-03 17:25:15 +01:00
udp_diag.c
udp: Access &udp_table via net.
2022-11-16 09:43:35 +00:00
udp_impl.h
net: remove noblock parameter from recvmsg() entities
2022-04-12 15:00:25 +02:00
udp_offload.c
udp: allow header check for dodgy GSO_UDP_L4 packets.
2022-12-12 09:29:56 +00:00
udp_tunnel_core.c
net/tunnel: wait until all sk_user_data reader finish before releasing the sock
2022-12-12 09:51:52 +00:00
udp_tunnel_nic.c
udp_tunnel: Add checks for nla_nest_start() in __udp_tunnel_nic_dump_write()
2022-11-29 08:44:24 -08:00
udp_tunnel_stub.c
udp_tunnel: add central NIC RX port offload infrastructure
2020-07-10 13:54:00 -07:00
udp.c
inet: Add IP_LOCAL_PORT_RANGE socket option
2023-01-25 22:45:00 -08:00
udplite.c
tcp/udp: Call inet6_destroy_sock() in IPv6 sk->sk_destruct().
2022-10-12 17:50:37 -07:00
xfrm4_input.c
…
xfrm4_output.c
…
xfrm4_policy.c
net: rename reference+tracking helpers
2022-06-09 21:52:55 -07:00
xfrm4_protocol.c
net: xfrm: unexport __init-annotated xfrm4_protocol_init()
2022-06-08 10:10:13 -07:00
xfrm4_state.c
…
xfrm4_tunnel.c
xfrm: tunnel: add extack to ipip_init_state, xfrm6_tunnel_init_state
2022-09-29 07:18:00 +02:00