Eric Dumazet
75475bb51e
ipv6: fix potential NULL deref in fib6_add()
If fib6_find_prefix() returns NULL, we should silently fallback
using fib6_null_entry regardless of RT6_DEBUG value.
syzbot reported:
WARNING: CPU: 0 PID: 5477 at net/ipv6/ip6_fib.c:1516 fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516
Modules linked in:
CPU: 0 PID: 5477 Comm: syz-executor.0 Not tainted 6.7.0-rc2-syzkaller-00029-g9b6de136b5f0 #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 11/10/2023
RIP: 0010:fib6_add+0x310d/0x3fa0 net/ipv6/ip6_fib.c:1516
Code: 00 48 8b 54 24 68 e8 42 22 00 00 48 85 c0 74 14 49 89 c6 e8 d5 d3 c2 f7 eb 5d e8 ce d3 c2 f7 e9 ca 00 00 00 e8 c4 d3 c2 f7 90 <0f> 0b 90 48 b8 00 00 00 00 00 fc ff df 48 8b 4c 24 38 80 3c 01 00
RSP: 0018:ffffc90005067740 EFLAGS: 00010293
RAX: ffffffff89cba5bc RBX: ffffc90005067ab0 RCX: ffff88801a2e9dc0
RDX: 0000000000000000 RSI: 0000000000000001 RDI: 0000000000000000
RBP: ffffc90005067980 R08: ffffffff89cbca85 R09: 1ffff110040d4b85
R10: dffffc0000000000 R11: ffffed10040d4b86 R12: 00000000ffffffff
R13: 1ffff110051c3904 R14: ffff8880206a5c00 R15: ffff888028e1c820
FS: 00007f763783c6c0(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 00007f763783bff8 CR3: 000000007f74d000 CR4: 00000000003506f0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
Call Trace:
<TASK>
__ip6_ins_rt net/ipv6/route.c:1303 [inline]
ip6_route_add+0x88/0x120 net/ipv6/route.c:3847
ipv6_route_ioctl+0x525/0x7b0 net/ipv6/route.c:4467
inet6_ioctl+0x21a/0x270 net/ipv6/af_inet6.c:575
sock_do_ioctl+0x152/0x460 net/socket.c:1220
sock_ioctl+0x615/0x8c0 net/socket.c:1339
vfs_ioctl fs/ioctl.c:51 [inline]
__do_sys_ioctl fs/ioctl.c:871 [inline]
__se_sys_ioctl+0xf8/0x170 fs/ioctl.c:857
do_syscall_x64 arch/x86/entry/common.c:51 [inline]
do_syscall_64+0x45/0x110 arch/x86/entry/common.c:82
Fixes: 7bbfe00e02 ("ipv6: fix general protection fault in fib6_add()")
Reported-by: syzbot <syzkaller@googlegroups.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Wei Wang <weiwan@google.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20231129160630.3509216-1-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2023-11-30 23:20:14 -08:00
..
2023-10-27 12:44:13 +09:00
2023-10-28 11:29:28 +01:00
2023-10-28 11:29:28 +01:00
2023-10-13 17:59:32 -07:00
2023-10-23 08:45:25 +01:00
2023-10-01 19:09:54 +01:00
2023-08-24 10:51:39 -07:00
2023-11-02 16:15:30 -10:00
2023-11-01 22:33:53 -07:00
2023-11-14 16:16:21 +01:00
2023-10-12 17:07:34 -07:00
2023-11-02 16:15:30 -10:00
2023-11-30 00:25:16 +01:00
2023-08-01 21:07:46 -07:00
2023-11-02 12:56:03 +01:00
2023-11-01 22:13:43 -07:00
2023-10-24 13:08:14 -07:00
2023-11-29 08:43:27 -08:00
2023-10-26 13:46:28 -07:00
2023-11-01 22:26:04 -07:00
2023-08-29 17:39:15 -07:00
2023-11-24 15:25:56 +00:00
2023-11-30 23:20:14 -08:00
2023-09-19 13:26:57 +02:00
2023-11-08 18:17:44 -08:00
2023-08-18 12:44:56 -07:00
2023-10-05 13:16:47 -07:00
2023-11-01 22:21:32 -07:00
2023-11-27 11:25:09 +01:00
2023-10-10 19:43:22 -07:00
2023-08-15 15:26:18 -07:00
2023-11-24 14:58:33 +00:00
2023-11-15 09:59:44 +00:00
2023-11-14 16:16:21 +01:00
2023-08-02 12:28:22 -07:00
2023-11-03 11:42:48 +00:00
2023-10-01 19:09:54 +01:00
2023-10-16 17:34:53 -07:00
2023-11-08 17:47:08 -08:00
2023-11-19 20:09:13 +00:00
2023-07-17 09:02:30 +01:00
2023-10-01 19:31:29 +01:00
2023-10-11 16:55:10 +02:00
2023-10-01 19:09:54 +01:00
2023-11-17 02:50:33 +00:00
2023-11-16 10:10:51 +01:00
2023-11-19 20:09:13 +00:00
2023-11-22 12:10:19 +00:00
2023-11-08 13:39:16 -08:00
2023-07-21 08:54:03 +01:00
2023-11-19 20:09:13 +00:00
2023-11-23 08:51:45 -08:00
2023-11-30 00:25:16 +01:00
2023-11-19 20:09:13 +00:00
2023-11-27 11:24:58 +01:00
2023-10-01 19:09:54 +01:00
2023-11-19 20:09:13 +00:00
2023-11-09 17:09:35 -08:00
2023-10-11 10:39:01 +01:00
2023-11-01 22:33:53 -07:00
2023-08-15 15:26:17 -07:00