linux/net at 9ac0be9d4fa0c0ec7a447eeaa080bc13cf865319 - linux - Gitea: Git with a cup of tea

mirror/linux

Files

History

Alexey Dobriyan 9ac0be9d4f [AX25]: don't free pointers to statically allocated data

commit 8d5cf596d1 started to add statically
allocated ax25_protocol's to list. However kfree() was still in place waiting
for unsuspecting ones on module removal.

Steps to reproduce:

	modprobe netrom
	rmmod netrom

P.S.: code would benefit greatly from list_add/list_del usage

kernel BUG at mm/slab.c:592!
invalid opcode: 0000 [1] PREEMPT SMP 
CPU 0 
Modules linked in: netrom ax25 af_packet usbcore rtc_cmos rtc_core rtc_lib
Pid: 4477, comm: rmmod Not tainted 2.6.23-rc3-bloat #2
RIP: 0010:[<ffffffff802ac646>]  [<ffffffff802ac646>] kfree+0x1c6/0x260
RSP: 0000:ffff810079a05e48  EFLAGS: 00010046
RAX: 0000000000000000 RBX: 0000000000000000 RCX: ffff81000000c000
RDX: ffff81007e552458 RSI: 0000000000000000 RDI: 000000000000805d
RBP: ffff810079a05e88 R08: 0000000000000001 R09: 0000000000000000
R10: 0000000000000001 R11: 0000000000000000 R12: ffffffff8805d080
R13: ffffffff8805d080 R14: 0000000000000000 R15: 0000000000000282
FS:  00002b73fc98aae0(0000) GS:ffffffff805dc000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 000000008005003b
CR2: 000000000053f3b8 CR3: 0000000079ff2000 CR4: 00000000000006e0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400
Process rmmod (pid: 4477, threadinfo ffff810079a04000, task ffff8100775aa480)
Stack:  ffff810079a05e68 0000000000000246 ffffffff8804eca0 0000000000000000
 ffffffff8805d080 00000000000000cf 0000000000000000 0000000000000880
 ffff810079a05eb8 ffffffff8803ec90 ffff810079a05eb8 0000000000000000
Call Trace:
 [<ffffffff8803ec90>] :ax25:ax25_protocol_release+0xa0/0xb0
 [<ffffffff88056ecb>] :netrom:nr_exit+0x6b/0xf0
 [<ffffffff80268bf0>] sys_delete_module+0x170/0x1f0
 [<ffffffff8025da35>] trace_hardirqs_on+0xd5/0x170
 [<ffffffff804835aa>] trace_hardirqs_on_thunk+0x35/0x37
 [<ffffffff8020c13e>] system_call+0x7e/0x83


Code: 0f 0b eb fe 66 66 90 66 66 90 48 8b 52 10 48 8b 02 25 00 40 
RIP  [<ffffffff802ac646>] kfree+0x1c6/0x260
 RSP <ffff810079a05e48>
Kernel panic - not syncing: Fatal exception

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

2007-08-14 17:24:05 -07:00

..

fs: 9p/conv.c error path fix

2007-07-31 15:39:42 -07:00

[NET]: Make all initialized struct seq_operations const.

2007-07-10 23:07:31 -07:00

[NET]: ethtool ops are the only way

2007-07-31 14:00:02 -07:00

[NET]: Make all initialized struct seq_operations const.

2007-07-10 23:07:31 -07:00

[ATM]: Clean up duplicate includes in net/atm/

2007-08-13 22:52:01 -07:00

[AX25]: don't free pointers to statically allocated data

2007-08-14 17:24:05 -07:00

[BLUETOOTH] l2cap: don't mangle cmd.len

2007-07-31 02:28:09 -07:00

[BRIDGE]: Fix typo in net/bridge/br_stp_if.c

2007-08-14 13:22:58 -07:00

[NET]: Share correct feature code between bridging and bonding

2007-08-13 22:52:14 -07:00

[DCCP]: fix memory leak and clean up style - dccp_feat_empty_confirm()

2007-08-13 22:52:10 -07:00

[DECNET]: kmalloc + memset conversion to kzalloc

2007-07-31 14:05:56 -07:00

[SK_BUFF]: Convert skb->tail to sk_buff_data_t

2007-04-25 22:26:28 -07:00

[ETH]: Validate address in eth_mac_addr

2007-07-11 19:41:18 -07:00

[PATCH] softmac: Fix deadlock of wx_set_essid with assoc work

2007-08-06 15:06:03 -04:00

[NETFILTER]: nf_nat_sip: don't drop short packets

2007-08-14 13:14:58 -07:00

[IPV6]: Clean up duplicate includes in net/ipv6/

2007-08-13 22:52:03 -07:00

[NET]: Make all initialized struct seq_operations const.

2007-07-10 23:07:31 -07:00

[IrDA] Typo fix in irnetlink.c copyright

2007-07-21 19:06:53 -07:00

[S390] Convert to smp_call_function_single.

2007-07-27 12:29:17 +02:00

[PF_KEY]: Fix ipsec not working in 2.6.23-rc1-git10

2007-08-02 19:42:29 -07:00

[PATCH] remove many unneeded #includes of sched.h

2007-02-14 08:09:54 -08:00

[NET]: Make all initialized struct seq_operations const.

2007-07-10 23:07:31 -07:00

[PATCH] mac80211: don't allow scanning in monitor mode

2007-08-06 15:39:15 -04:00

[NETFILTER]: nf_conntrack_sip: fix SIP-URI parsing

2007-08-14 13:14:35 -07:00

[NetLabel]: add missing rcu_dereference() calls in the LSM domain mapping hash table

2007-08-07 17:53:10 -07:00

[GENETLINK]: Correctly report errors while registering a multicast group

2007-07-24 15:34:53 -07:00

[NET] NETROM: Fix whitespace errors.

2007-07-19 10:44:32 +09:00

[NET] PACKET: Fix whitespace errors.

2007-07-19 10:44:35 +09:00

[NET] RFKILL: Fix whitespace errors.

2007-07-19 10:44:38 +09:00

[NET] ROSE: Fix whitespace errors.

2007-07-19 10:44:40 +09:00

net/* misc endianness annotations

2007-07-26 11:11:56 -07:00

[PKT_SCHED]: Clean up duplicate includes in net/sched/

2007-08-13 22:52:04 -07:00

SCTP: remove useless code in function sctp_init_cause

2007-08-02 10:56:07 -04:00

[SUNRPC]: Clean up duplicate includes in net/sunrpc/

2007-08-13 22:52:05 -07:00

[TIPC]: Clean up duplicate includes in net/tipc/

2007-08-13 22:52:07 -07:00

[AF_UNIX]: Make code static.

2007-07-31 02:28:27 -07:00

[NET]: Removal of duplicated include net/wanrouter/wanmain.c

2007-08-02 19:42:22 -07:00

[PATCH] cfg80211: Radiotap parser

2007-07-12 16:07:24 -04:00

[NET]: Make all initialized struct seq_operations const.

2007-07-10 23:07:31 -07:00

[XFRM]: Clean up duplicate includes in net/xfrm/

2007-08-13 22:52:08 -07:00

compat.c

O_CLOEXEC for SCM_RIGHTS

2007-07-16 09:05:45 -07:00

Kconfig

9p: Reorganization of 9p file system code

2007-07-14 15:13:40 -05:00

Makefile

9p: Reorganization of 9p file system code

2007-07-14 15:13:40 -05:00

nonet.c

[PATCH] Make most file operations structs in fs/ const

2006-03-28 09:16:06 -08:00

socket.c

mm: Remove slab destructors from kmem_cache_create().

2007-07-20 10:11:58 +09:00

sysctl_net.c

Remove obsolete #include <linux/config.h>

2006-06-30 19:25:36 +02:00

TUNABLE

…