Michael S. Tsirkin 7ad4723976
vhost: move smp_rmb() into vhost_get_avail_idx() ...
All callers of vhost_get_avail_idx() use smp_rmb() to
order the available ring entry read and avail_idx read.
Make vhost_get_avail_idx() call smp_rmb() itself whenever the avail_idx
is accessed. This way, the callers don't need to worry about the memory
barrier. As a side benefit, we also validate the index on all paths now,
which will hopefully help prevent/catch earlier future bugs.
Note that current code is inconsistent in how the errors are handled.
They are treated as an empty ring in some places, but as non-empty
ring in other places. This patch doesn't attempt to change the existing
behaviour.
No functional change intended.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com >
Reviewed-by: Gavin Shan <gshan@redhat.com >
Acked-by: Will Deacon <will@kernel.org >
Message-Id: <20240429232748.642356-1-gshan@redhat.com >
2024-07-09 08:42:40 -04:00
2024-05-19 09:21:03 -07:00
2024-05-24 08:43:25 -07:00
2024-06-21 12:55:12 +02:00
2024-05-04 18:59:47 +02:00
2024-06-30 22:23:39 +02:00
2024-05-06 18:26:47 -07:00
2024-05-22 10:45:12 -07:00
2024-06-04 18:14:51 +02:00
2024-06-14 06:21:25 -06:00
2024-05-23 12:04:36 -07:00
2024-05-22 20:14:47 -04:00
2024-05-15 12:59:55 -06:00
2024-06-05 04:55:04 +03:00
2024-06-12 16:58:05 -07:00
2024-05-22 09:56:00 -07:00
2024-06-22 13:48:11 +09:00
2024-06-24 20:55:11 +02:00
2024-05-16 08:50:32 -07:00
2024-06-27 17:43:15 -07:00
2024-06-25 14:45:27 -07:00
2024-05-19 09:21:03 -07:00
2024-05-09 00:30:37 +09:00
2024-06-11 23:39:26 +05:30
2024-05-28 22:21:34 +02:00
2024-05-13 16:53:53 -07:00
2024-06-04 11:29:52 +02:00
2024-05-03 22:09:50 +02:00
2024-05-09 01:03:39 +09:00
2024-06-15 14:59:26 +09:00
2024-06-22 07:58:21 -07:00
2024-05-22 12:26:46 -07:00
2024-06-27 17:21:28 +02:00
2024-06-28 08:56:26 +10:00
2024-05-04 18:59:41 +02:00
2024-06-08 10:48:11 -07:00
2024-06-06 06:03:29 +00:00
2024-05-30 09:05:19 -07:00
2024-05-22 12:26:46 -07:00
2024-06-28 20:44:38 +02:00
2024-05-23 00:29:19 +02:00
2024-06-09 12:02:34 +01:00
2024-06-21 10:19:36 -03:00
2024-06-24 14:36:11 -04:00
2024-05-22 20:14:47 -04:00
2024-06-27 12:14:19 +02:00
2024-06-23 17:09:26 +02:00
2024-06-16 09:33:28 -07:00
2024-05-17 09:05:46 -07:00
2024-05-31 12:39:15 -05:00
2024-04-29 10:53:31 +02:00
2024-05-28 06:55:59 -06:00
2024-06-12 09:28:04 -07:00
2024-05-17 08:53:47 -07:00
2024-05-14 18:25:53 -07:00
2024-06-14 08:43:39 +01:00
2024-06-04 18:08:39 +02:00
2024-06-20 16:42:30 +02:00
2024-05-27 13:42:25 +02:00
2024-04-29 08:20:07 -07:00
2024-06-27 12:35:58 +02:00
2024-05-29 13:08:31 +01:00
2024-05-23 12:04:36 -07:00
2024-06-26 10:13:04 -07:00
2024-05-03 07:26:39 +02:00
2024-05-30 19:43:47 -05:00
2024-05-17 13:01:24 +02:00
2024-06-04 18:08:31 +02:00
2024-06-24 23:33:38 +02:00
2024-05-23 12:09:22 -07:00
2024-06-03 19:30:47 +05:30
2024-06-17 10:36:56 +02:00
2024-06-24 13:33:20 +02:00
2024-05-27 08:18:31 -07:00
2024-05-28 21:53:51 +02:00
2024-05-20 08:55:18 -07:00
2024-04-30 21:10:37 +02:00
2024-04-29 08:20:06 -07:00
2024-06-18 13:26:44 -07:00
2024-06-22 16:13:19 +02:00
2024-05-14 23:36:19 +09:00
2024-06-16 11:22:57 +02:00
2024-06-12 21:30:43 +01:00
2024-05-06 13:34:12 -06:00
2024-06-21 13:49:25 +02:00
2024-05-23 12:04:36 -07:00
2024-05-07 23:40:46 +02:00
2024-06-24 11:07:06 +02:00
2024-07-01 22:57:03 -07:00
2024-05-08 19:21:51 +01:00
2024-06-27 16:33:39 +02:00
2024-06-03 17:35:24 +05:30
2024-06-19 14:07:13 +01:00
2024-05-08 19:46:11 +01:00
2024-06-27 15:47:30 +02:00
2024-05-21 13:11:44 -07:00
2024-06-27 17:10:38 +02:00
2024-06-25 14:37:05 +02:00
2024-05-31 13:13:39 +03:00
2024-06-30 08:57:43 -07:00
2024-06-13 21:00:25 -04:00
2024-06-30 08:54:24 -07:00
2024-07-09 08:42:39 -04:00
2024-06-12 15:40:39 -06:00
2024-07-09 08:42:40 -04:00
2024-05-22 10:45:12 -07:00
2024-05-19 09:21:03 -07:00
2024-07-09 08:42:39 -04:00
2024-06-15 12:49:57 +02:00
2024-05-24 10:24:49 -07:00
2024-04-29 16:45:53 +02:00
2024-05-10 04:34:52 +09:00
7ad4723976