Dan Carpenter 641db40f3a proc/vmcore: fix signedness bug in read_from_oldmem() ...

The bug is the error handling:

	if (tmp < nr_bytes) {

"tmp" can hold negative error codes but because "nr_bytes" is type size_t
the negative error codes are treated as very high positive values
(success).  Fix this by changing "nr_bytes" to type ssize_t.  The
"nr_bytes" variable is used to store values between 1 and PAGE_SIZE and
they can fit in ssize_t without any issue.

Link: https://lkml.kernel.org/r/b55f7eed-1c65-4adc-95d1-6c7c65a54a6e@moroto.mountain
Fixes: 5d8de293c2 ("vmcore: convert copy_oldmem_page() to take an iov_iter")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Baoquan He <bhe@redhat.com>
Cc: Dave Young <dyoung@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

2023-07-27 13:07:05 -07:00

..

array.c

Merge tag 'x86_mm_for_6.4' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2023-04-28 09:43:49 -07:00

base.c

Merge tag 'mm-nonmm-stable-2023-04-27-16-01' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm

2023-04-27 19:57:00 -07:00

bootconfig.c

proc: bootconfig: Add null pointer check

2022-04-02 08:40:09 -04:00

cmdline.c

proc: mark /proc/cmdline as permanent

2023-02-02 22:50:02 -08:00

consoles.c

proc: consoles: use console_list_lock for list iteration

2022-12-02 11:25:02 +01:00

cpuinfo.c

x86/aperfmperf: Replace aperfmperf_get_khz()

2022-04-27 20:22:19 +02:00

devices.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

fd.c

Merge tag 'fs.idmapped.v6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping

2023-02-20 11:53:11 -08:00

fd.h

fs: port ->permission() to pass mnt_idmap

2023-01-19 09:24:28 +01:00

generic.c

proc: remove mark_inode_dirty() in .setattr()

2023-04-08 13:45:36 -07:00

inode.c

tty, proc, kernfs, random: Use copy_splice_read()

2023-05-24 08:42:16 -06:00

internal.h

fs: port ->getattr() to pass mnt_idmap

2023-01-19 09:24:25 +01:00

interrupts.c

proc: introduce proc_create_seq{,_data}

2018-05-16 07:23:35 +02:00

Kconfig

proc: make config PROC_CHILDREN depend on PROC_FS

2022-10-03 14:21:43 -07:00

kcore.c

Merge tag 'asm-generic-6.5' of git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic

2023-07-06 10:06:04 -07:00

kmsg.c

Merge tag 'printk-for-6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux

2022-10-10 11:24:19 -07:00

loadavg.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

Makefile

proc: bootconfig: Add /proc/bootconfig to show boot config list

2020-01-13 13:19:39 -05:00

meminfo.c

mm: Add support for unaccepted memory

2023-06-06 16:38:22 +02:00

namespaces.c

Merge branch 'work.openat2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2020-01-29 11:20:24 -08:00

nommu.c

proc: delete unused <linux/uaccess.h> includes

2022-07-17 17:31:39 -07:00

page.c

mm, pagemap: remove SLOB and SLQB from comments and documentation

2023-03-29 10:32:11 +02:00

proc_net.c

fs: port ->getattr() to pass mnt_idmap

2023-01-19 09:24:25 +01:00

proc_sysctl.c

sysctl: set variable sysctl_mount_point storage-class-specifier to static

2023-06-30 16:19:47 -07:00

proc_tty.c

proc: delete unused <linux/uaccess.h> includes

2022-07-17 17:31:39 -07:00

root.c

fs: port ->getattr() to pass mnt_idmap

2023-01-19 09:24:25 +01:00

self.c

Revert "proc: don't allow async path resolution of /proc/self components"

2021-02-23 20:32:11 -07:00

softirqs.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

stat.c

proc/stat: remove arch_idle_time()

2023-04-18 16:39:33 -07:00

task_mmu.c

mm: ptep_get() conversion

2023-06-19 16:19:25 -07:00

task_nommu.c

mm: nommu: correct the range of mmap_sem_read_lock in task_mem()

2023-06-23 16:59:32 -07:00

thread_self.c

Revert "proc: don't allow async path resolution of /proc/thread-self components"

2021-02-23 20:32:11 -07:00

uptime.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

util.c

fs/proc/util.c: include fs/proc/internal.h for name_to_int()

2019-01-04 13:13:45 -08:00

version.c

proc: mark more files as permanent

2022-10-03 14:21:45 -07:00

vmcore.c

proc/vmcore: fix signedness bug in read_from_oldmem()

2023-07-27 13:07:05 -07:00