mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
9da73974eb9c965dd9989befb593b8c8da9e4bdc
linux/kernel/trace
History
Vamshi K Sthambamkadi 9da73974eb tracing: Fix memory leaks in trace_events_hist.c 
kmemleak report 1:
    [<9092c50b>] kmem_cache_alloc_trace+0x138/0x270
    [<05a2c9ed>] create_field_var+0xcf/0x180
    [<528a2d68>] action_create+0xe2/0xc80
    [<63f50b61>] event_hist_trigger_func+0x15b5/0x1920
    [<28ea5d3d>] trigger_process_regex+0x7b/0xc0
    [<3138e86f>] event_trigger_write+0x4d/0xb0
    [<ffd66c19>] __vfs_write+0x30/0x200
    [<4f424a0d>] vfs_write+0x96/0x1b0
    [<da59a290>] ksys_write+0x53/0xc0
    [<3717101a>] __ia32_sys_write+0x15/0x20
    [<c5f23497>] do_fast_syscall_32+0x70/0x250
    [<46e2629c>] entry_SYSENTER_32+0xaf/0x102

This is because save_vars[] of struct hist_trigger_data are
not destroyed

kmemleak report 2:
    [<9092c50b>] kmem_cache_alloc_trace+0x138/0x270
    [<6e5e97c5>] create_var+0x3c/0x110
    [<de82f1b9>] create_field_var+0xaf/0x180
    [<528a2d68>] action_create+0xe2/0xc80
    [<63f50b61>] event_hist_trigger_func+0x15b5/0x1920
    [<28ea5d3d>] trigger_process_regex+0x7b/0xc0
    [<3138e86f>] event_trigger_write+0x4d/0xb0
    [<ffd66c19>] __vfs_write+0x30/0x200
    [<4f424a0d>] vfs_write+0x96/0x1b0
    [<da59a290>] ksys_write+0x53/0xc0
    [<3717101a>] __ia32_sys_write+0x15/0x20
    [<c5f23497>] do_fast_syscall_32+0x70/0x250
    [<46e2629c>] entry_SYSENTER_32+0xaf/0x102

struct hist_field allocated through create_var() do not initialize
"ref" field to 1. The code in __destroy_hist_field() does not destroy
object if "ref" is initialized to zero, the condition
if (--hist_field->ref > 1) always passes since unsigned int wraps.

kmemleak report 3:
    [<f8666fcc>] __kmalloc_track_caller+0x139/0x2b0
    [<bb7f80a5>] kstrdup+0x27/0x50
    [<39d70006>] init_var_ref+0x58/0xd0
    [<8ca76370>] create_var_ref+0x89/0xe0
    [<f045fc39>] action_create+0x38f/0xc80
    [<7c146821>] event_hist_trigger_func+0x15b5/0x1920
    [<07de3f61>] trigger_process_regex+0x7b/0xc0
    [<e87daf8f>] event_trigger_write+0x4d/0xb0
    [<19bf1512>] __vfs_write+0x30/0x200
    [<64ce4d27>] vfs_write+0x96/0x1b0
    [<a6f34170>] ksys_write+0x53/0xc0
    [<7d4230cd>] __ia32_sys_write+0x15/0x20
    [<8eadca00>] do_fast_syscall_32+0x70/0x250
    [<235cf985>] entry_SYSENTER_32+0xaf/0x102

hist_fields (system & event_name) are not freed

Link: http://lkml.kernel.org/r/20200422061503.GA5151@cosmos

Signed-off-by: Vamshi K Sthambamkadi <vamshi.k.sthambamkadi@gmail.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
2020-04-22 21:24:00 -04:00
..
blktrace.c
blktrace: fix dereference after null check
2020-03-05 13:42:40 -07:00
bpf_trace.c
Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next
2020-03-30 19:52:37 -07:00
fgraph.c
tracing: Define MCOUNT_INSN_SIZE when not defined without direct calls
2020-01-02 21:56:44 -05:00
ftrace_internal.h
treewide: Rename rcu_dereference_raw_notrace() to _check()
2019-08-01 14:16:21 -07:00
ftrace.c
Merge tag 'trace-v5.7' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
2020-04-05 10:36:18 -07:00
Kconfig
bootconfig: Fix CONFIG_BOOTTIME_TRACING dependency issue
2020-02-25 19:07:58 -05:00
kprobe_event_gen_test.c
tracing: Add kprobe event command generation test module
2020-01-30 09:46:28 -05:00
Makefile
tracing: Add kprobe event command generation test module
2020-01-30 09:46:28 -05:00
power-traces.c
…
preemptirq_delay_test.c
preemptirq_delay_test: Add the burst feature and a sysfs trigger
2019-11-13 09:37:28 -05:00
ring_buffer_benchmark.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
ring_buffer.c
ring-buffer/tracing: Have iterator acknowledge dropped events
2020-03-27 16:39:01 -04:00
rpm-traces.c
…
synth_event_gen_test.c
tracing: Have synthetic event test use raw_smp_processor_id()
2020-02-20 17:43:41 -05:00
trace_benchmark.c
trace: Use pr_warn instead of pr_warning
2019-10-18 15:01:57 +02:00
trace_benchmark.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_boot.c
tracing: Change trace_boot to use synth_event interface
2020-01-31 12:59:26 -05:00
trace_branch.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
trace_clock.c
tracing: Add SPDX License format tags to tracing files
2018-08-16 19:08:06 -04:00
trace_dynevent.c
tracing: Use seq_buf for building dynevent_cmd string
2020-02-01 13:10:15 -05:00
trace_dynevent.h
tracing: Remove check_arg() callbacks from dynevent args
2020-02-01 13:09:23 -05:00
trace_entries.h
tracing: Have hwlat ts be first instance and record count of instances
2020-03-03 17:33:43 -05:00
trace_event_perf.c
Merge branch 'perf/urgent' into perf/core, to pick up fixes
2019-10-28 12:38:26 +01:00
trace_events_filter_test.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_events_filter.c
tracing: Avoid memory leak in process_system_preds()
2019-12-19 18:24:17 -05:00
trace_events_hist.c
tracing: Fix memory leaks in trace_events_hist.c
2020-04-22 21:24:00 -04:00
trace_events_inject.c
tracing: Initialize val to zero in parse_entry of inject code
2020-01-02 19:04:57 -05:00
trace_events_trigger.c
tracing: Fix the race between registering 'snapshot' event trigger and triggering 'snapshot' operation
2020-04-14 22:02:10 -04:00
trace_events.c
tracing: Create set_event_notrace_pid to not trace tasks
2020-03-27 16:39:02 -04:00
trace_export.c
Merge tag 'v5.5-rc1' into core/kprobes, to resolve conflicts
2019-12-10 10:11:00 +01:00
trace_functions_graph.c
ring-buffer: Rename ring_buffer_read() to read_buffer_iter_advance()
2020-03-19 19:11:19 -04:00
trace_functions.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_hwlat.c
tracing: Have hwlat ts be first instance and record count of instances
2020-03-03 17:33:43 -05:00
trace_irqsoff.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_kdb.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_kprobe_selftest.c
selftest/ftrace: Move kprobe selftest function to separate compile unit
2018-07-30 18:41:04 -04:00
trace_kprobe_selftest.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_kprobe.c
ftrace/kprobe: Show the maxactive number on kprobe_events
2020-03-27 16:39:02 -04:00
trace_mmiotrace.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
trace_nop.c
…
trace_output.c
tracing: Save off entry when peeking at next entry
2020-03-19 17:48:36 -04:00
trace_output.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00
trace_preemptirq.c
kprobes: Prohibit probing on hardirq tracers
2019-02-13 08:16:40 +01:00
trace_printk.c
tracing: Add locked_down checks to the open calls of files created for tracefs
2019-10-12 20:48:06 -04:00
trace_probe_tmpl.h
tracing/probe: Support user-space dereference
2019-05-25 23:04:42 -04:00
trace_probe.c
tracing/kprobes: Have uname use __get_str() in print_fmt
2020-01-27 10:56:02 -05:00
trace_probe.h
tracing/uprobe: Fix to make trace_uprobe_filter alignment safe
2020-01-22 07:09:20 -05:00
trace_sched_switch.c
tracing: Fix sched switch start/stop refcount racy updates
2020-01-30 09:46:10 -05:00
trace_sched_wakeup.c
tracing: Make struct ring_buffer less ambiguous
2020-01-13 13:19:38 -05:00
trace_selftest_dynamic.c
…
trace_selftest.c
tracing: Rename trace_buffer to array_buffer
2020-01-13 13:19:38 -05:00
trace_seq.c
tracing: Remove unused TRACE_SEQ_BUF_USED
2020-01-21 18:39:54 -05:00
trace_stack.c
tracing: Have stack tracer compile when MCOUNT_INSN_SIZE is not defined
2020-01-02 22:04:07 -05:00
trace_stat.c
tracing: Fix tracing_stat return values in error handling paths
2020-01-24 18:06:48 -05:00
trace_stat.h
tracing: Use generic type for comparator function
2019-11-14 13:15:11 -05:00
trace_syscalls.c
Merge tag 'trace-v5.6-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
2020-02-06 07:12:11 +00:00
trace_uprobe.c
bpf: disable preemption for bpf progs attached to uprobe
2020-02-24 16:17:14 -08:00
trace.c
tracing: Do not allocate buffer in trace_find_next_entry() in atomic
2020-04-03 11:30:50 -04:00
trace.h
tracing: Create set_event_notrace_pid to not trace tasks
2020-03-27 16:39:02 -04:00
tracing_map.c
tracing: Have the histogram compare functions convert to u64 first
2019-12-19 18:26:00 -05:00
tracing_map.h
tracing: Fix SPDX format headers to use C++ style comments
2018-08-16 19:08:06 -04:00