Vasily Averin a23f89a999
netfilter: conntrack: nf_ct_gre_keymap_flush() removal ...
nf_ct_gre_keymap_flush() is useless.
It is called from nf_conntrack_cleanup_net_list() only and tries to remove
nf_ct_gre_keymap entries from pernet gre keymap list. Though:
a) at this point the list should already be empty, all its entries were
deleted during the conntracks cleanup, because
nf_conntrack_cleanup_net_list() executes nf_ct_iterate_cleanup(kill_all)
before nf_conntrack_proto_pernet_fini():
nf_conntrack_cleanup_net_list
+- nf_ct_iterate_cleanup
| nf_ct_put
| nf_conntrack_put
| nf_conntrack_destroy
| destroy_conntrack
| destroy_gre_conntrack
| nf_ct_gre_keymap_destroy
`- nf_conntrack_proto_pernet_fini
nf_ct_gre_keymap_flush
b) Let's say we find that the keymap list is not empty. This means netns
still has a conntrack associated with gre, in which case we should not free
its memory, because this will lead to a double free and related crashes.
However I doubt it could have gone unnoticed for years, obviously
this does not happen in real life. So I think we can remove
both nf_ct_gre_keymap_flush() and nf_conntrack_proto_pernet_fini().
Signed-off-by: Vasily Averin <vvs@virtuozzo.com >
Acked-by: Florian Westphal <fw@strlen.de >
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org >
2021-07-02 02:07:01 +02:00
2020-11-19 17:21:34 +01:00
2021-06-26 07:12:44 +02:00
2021-07-01 13:19:48 -07:00
2021-01-28 20:36:21 -08:00
2021-07-02 02:07:01 +02:00
2021-06-28 13:17:16 -07:00
2021-05-17 13:56:29 -07:00
2019-06-05 17:37:07 +02:00
2021-07-01 11:47:13 -07:00
2021-06-01 16:54:42 -07:00
2020-02-28 14:51:30 +01:00
2021-04-08 13:47:33 -07:00
2021-04-27 14:02:06 -07:00
2019-05-30 11:26:41 -07:00
2021-04-23 10:17:26 +01:00
2020-02-28 12:12:53 -08:00
2021-06-11 13:32:46 -07:00
2019-11-06 16:14:48 -08:00
2019-06-19 17:09:55 +02:00
2020-07-21 18:30:47 -07:00
2019-05-24 17:37:53 +02:00
2020-05-01 12:15:37 -07:00
2019-07-04 12:30:48 -07:00
2021-06-15 11:26:15 -07:00
2021-03-26 17:43:55 +01:00
2021-07-01 11:23:50 -07:00
2019-05-21 11:28:45 +02:00
2019-06-19 17:09:55 +02:00
2021-06-28 13:06:12 -07:00
2020-02-29 14:39:08 +01:00
2020-08-20 15:45:15 -04:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2020-11-23 13:31:54 -08:00
2019-05-30 11:29:52 -07:00
2019-05-30 11:29:52 -07:00
2021-06-14 13:04:25 -07:00
2020-02-29 21:52:20 -08:00
2019-05-21 11:52:39 +02:00
2019-05-21 11:52:39 +02:00
2021-06-29 10:46:23 -07:00
2019-12-16 16:09:44 -08:00
2020-05-08 21:33:33 -07:00
2021-03-10 12:24:18 -08:00
2020-05-05 13:23:29 -07:00
2020-02-19 13:52:32 +01:00
2020-04-20 07:34:16 +02:00
2019-06-19 17:09:55 +02:00
2019-12-24 22:37:30 -08:00
2020-07-28 17:42:31 -07:00
2021-03-14 14:46:32 -07:00
2021-06-28 14:24:06 -07:00
2021-04-19 12:25:11 +02:00
2021-01-21 13:33:45 +01:00
2021-01-21 13:33:45 +01:00
2019-12-09 10:36:44 -08:00
2019-11-05 18:20:55 -08:00
2021-02-12 16:31:46 -08:00
2019-03-22 12:09:31 -07:00
2021-01-29 20:39:14 -08:00
2021-03-18 19:51:12 -07:00
2020-06-22 21:12:44 -07:00
2019-10-25 16:24:32 -07:00
2021-06-28 14:29:45 -07:00
2020-11-06 11:01:01 +01:00
2019-05-30 11:26:41 -07:00
2021-03-26 15:14:56 -07:00
2019-04-22 21:50:53 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-03-30 13:45:04 -07:00
2021-01-27 18:18:15 -08:00
2021-06-29 11:54:36 -07:00
2020-12-14 18:38:58 -08:00
2020-12-12 15:08:54 -08:00
2020-11-23 16:32:33 -08:00
2020-08-26 07:33:19 -07:00
2019-09-27 12:05:02 +02:00
2020-06-20 17:47:53 -07:00
2021-02-08 16:47:03 -08:00
2021-06-28 12:42:14 -07:00
2019-06-18 20:48:45 -04:00
2021-05-18 13:27:32 -07:00
2020-11-19 19:08:46 -08:00
2021-02-04 18:37:57 -08:00
2021-06-28 12:42:14 -07:00
2020-11-19 10:49:50 -08:00
2021-03-30 13:29:39 -07:00
2021-05-18 13:27:32 -07:00
2020-02-05 14:28:09 +01:00
2019-06-19 17:09:55 +02:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2019-10-08 13:23:05 -07:00
2020-03-29 22:30:57 -07:00
2021-06-23 18:12:00 +02:00
2019-05-30 11:26:41 -07:00
2021-06-24 12:41:12 -07:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2020-02-28 12:08:37 -08:00
2020-05-29 21:20:20 -07:00
2021-06-22 14:36:01 -07:00
2019-12-09 10:36:44 -08:00
2020-08-24 06:40:07 -07:00
2020-11-13 14:24:39 -08:00
2021-06-18 19:47:02 -07:00
2019-05-21 11:28:45 +02:00
2020-11-16 08:08:54 -08:00
2019-11-12 08:18:03 -08:00
2019-04-11 13:59:49 -07:00
2021-03-28 17:53:39 -07:00
2021-06-07 14:11:47 -07:00
2020-03-04 13:25:55 -08:00
2019-05-30 11:26:32 -07:00
2021-05-25 15:36:42 -07:00
2021-05-14 15:05:46 -07:00
2021-05-17 15:29:35 -07:00
2021-03-14 15:00:43 -07:00
2019-05-30 11:26:32 -07:00
2021-03-25 17:40:43 -07:00
2020-07-31 09:24:23 +02:00
2020-08-24 14:35:00 -07:00
2020-11-23 18:36:21 -05:00
2020-06-23 20:27:09 -07:00
2021-06-12 13:16:45 -07:00
2019-04-22 21:47:25 -07:00
2021-06-29 15:45:27 -07:00
2020-07-13 11:03:44 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2020-06-04 15:39:32 -07:00
2021-04-28 14:06:45 -07:00
2020-09-28 15:19:03 -07:00
2019-10-05 16:29:00 -07:00
2021-06-15 18:01:05 +02:00
2021-07-01 13:08:18 -07:00
2019-06-19 17:09:55 +02:00
2021-06-28 14:09:03 -07:00
2019-05-30 11:26:32 -07:00
2021-07-01 13:22:40 -07:00
2019-05-30 11:26:32 -07:00
2019-10-04 14:07:07 -07:00
2021-06-29 11:28:21 -07:00
2020-06-23 20:10:15 -07:00
2020-06-18 20:46:23 -07:00
2021-02-04 18:37:14 -08:00
2021-04-12 17:34:27 +02:00
2019-11-14 18:12:17 -08:00
2020-09-14 16:49:39 -07:00
2019-12-09 10:28:43 -08:00
2019-11-16 12:39:10 -08:00
2020-11-17 22:07:40 +01:00
2021-06-24 19:41:15 +02:00
2021-05-26 09:46:16 +02:00
2021-06-29 15:45:27 -07:00
2021-06-18 16:57:19 +02:00
a23f89a999