mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
ab198a7aab65d6fcdbde082ff59a790dbf7e08f4
linux/drivers/gpu/drm/msm
History
Sean Paul ab198a7aab drm/msm: Sanitize the modeset_is_locked checks in dpu 
As Daniel mentions in his email [1], non-blocking commits don't hold the
modeset locks, so we can safely access state as long as these functions
are in the commit path. So remove the WARN_ON in dpu_kms_encoder_enable.

In dpu_crtc_get_intf_mode, things are a bit more complicated. So keep
the WARN_ON, but add a comment explaining the situation and hope someone
comes along and fixes the issue.

[1]- https://lists.freedesktop.org/archives/dri-devel/2019-October/239441.html

Link to v1: https://patchwork.freedesktop.org/patch/msgid/20191010151351.126735-1-sean@poorly.run

Changes in v2:
- Restored the WARN_ON in get_intf_mode and added a clarifying comment (Daniel)

Fixes: 1dfdb0e107 ("drm/msm: dpu: Add modeset lock checks where applicable")
Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
Cc: Rob Clark <robdclark@chromium.org>
Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20191010181801.186069-1-sean@poorly.run
2019-10-10 14:33:12 -04:00
..
adreno
drm/msm/gpu: add ocmem init/cleanup functions
2019-10-07 08:17:39 -07:00
disp
drm/msm: Sanitize the modeset_is_locked checks in dpu
2019-10-10 14:33:12 -04:00
dsi
drm/msm/dsi: Move static keyword to the front of declarations
2019-10-07 08:41:57 -07:00
edp
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 284
2019-06-05 17:36:37 +02:00
hdmi
drm/msm/hdmi: Convert to use GPIO descriptors
2019-09-03 16:16:58 -07:00
Kconfig
drm/msm/gpu: add ocmem init/cleanup functions
2019-10-07 08:17:39 -07:00
Makefile
drm/msm: add atomic traces
2019-09-03 16:17:02 -07:00
msm_atomic_trace.h
drm/msm: add atomic traces
2019-09-03 16:17:02 -07:00
msm_atomic_tracepoints.c
drm/msm: add atomic traces
2019-09-03 16:17:02 -07:00
msm_atomic.c
drm/msm: add atomic traces
2019-09-03 16:17:02 -07:00
msm_debugfs.c
drm/msm: drop use of drmP.h
2019-09-03 16:16:57 -07:00
msm_debugfs.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_drv.c
drm/msm: async commit support
2019-09-03 16:17:01 -07:00
msm_drv.h
drm/msm: async commit support
2019-09-03 16:17:01 -07:00
msm_fb.c
drm/msm: drop use of drmP.h
2019-09-03 16:16:57 -07:00
msm_fbdev.c
drm/msm: Transition console to msm framebuffer
2019-09-03 16:16:58 -07:00
msm_fence.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_fence.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_gem_prime.c
drm/msm: drop use of drmP.h
2019-09-03 16:16:57 -07:00
msm_gem_shrinker.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_gem_submit.c
drm/msm: Use struct_size() helper
2019-09-03 16:16:58 -07:00
msm_gem_vma.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_gem.c
drm/msm: Use the correct dma_sync calls harder
2019-09-04 10:05:05 -07:00
msm_gem.h
dma-buf: rename reservation_object to dma_resv
2019-08-13 09:09:30 +02:00
msm_gpu_trace.h
drm/msm: add atomic traces
2019-09-03 16:17:02 -07:00
msm_gpu_tracepoints.c
…
msm_gpu.c
drm/msm: include linux/sched/task.h
2019-10-07 09:29:10 -07:00
msm_gpu.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_gpummu.c
drm/msm: Remove unused function arguments
2019-10-07 08:25:30 -07:00
msm_iommu.c
drm/msm: Remove unused function arguments
2019-10-07 08:25:30 -07:00
msm_kms.h
drm/msm/dpu: async commit support
2019-09-03 16:17:01 -07:00
msm_mmu.h
drm/msm: Remove unused function arguments
2019-10-07 08:25:30 -07:00
msm_perf.c
drm/msm: drop use of drmP.h
2019-09-03 16:16:57 -07:00
msm_rd.c
drm/msm: drop use of drmP.h
2019-09-03 16:16:57 -07:00
msm_ringbuffer.c
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_ringbuffer.h
treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 234
2019-06-19 17:09:07 +02:00
msm_submitqueue.c
drm/msm: drop use of drmP.h
2019-09-03 16:16:57 -07:00
NOTES
…