Christoph Böhmwalder 4b9c2edaf7 drbd: swap bvec_set_page len and offset ...

bvec_set_page has the following signature:

static inline void bvec_set_page(struct bio_vec *bv, struct page *page,
		unsigned int len, unsigned int offset)

However, the usage in DRBD swaps the len and offset parameters. This
leads to a bvec with length=0 instead of the intended length=4096, which
causes sock_sendmsg to return -EIO.

This leaves DRBD unable to transmit any pages and thus completely
broken.

Swapping the parameters fixes the regression.

Fixes: eeac7405c7 ("drbd: Use sendmsg(MSG_SPLICE_PAGES) rather than sendpage()")
Reported-by: Serguei Ivantsov <manowar@gsc-game.com>
Link: https://lore.kernel.org/regressions/CAKH+VT3YLmAn0Y8=q37UTDShqxDLsqPcQ4hBMzY7HPn7zNx+RQ@mail.gmail.com/
Cc: stable@vger.kernel.org
Signed-off-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Link: https://lore.kernel.org/r/20230906133034.948817-1-christoph.boehmwalder@linbit.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

2023-09-06 07:33:03 -06:00

..

drbd_actlog.c

drbd: Pass a peer device to the resync and online verify functions

2023-04-01 20:27:55 -06:00

drbd_bitmap.c

drbd: use __bio_add_page to add page to bio

2023-05-31 09:50:02 -06:00

drbd_buildtag.c

drbd: split off drbd_config into separate file

2023-01-29 15:18:33 -07:00

drbd_debugfs.c

drbd: drop API_VERSION define

2023-01-29 15:18:33 -07:00

drbd_debugfs.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_int.h

drbd: Pass a peer device to the resync and online verify functions

2023-04-01 20:27:55 -06:00

drbd_interval.c

drbd: drbd_insert_interval(): Clarify comment

2023-01-29 15:18:33 -07:00

drbd_interval.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_main.c

drbd: swap bvec_set_page len and offset

2023-09-06 07:33:03 -06:00

drbd_nl.c

genetlink: remove userhdr from struct genl_info

2023-08-15 14:54:44 -07:00

drbd_nla.c

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_nla.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_polymorph_printk.h

drbd: add context parameter to expect() macro

2022-12-01 11:33:49 -07:00

drbd_proc.c

drbd: drop API_VERSION define

2023-01-29 15:18:33 -07:00

drbd_protocol.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_receiver.c

drbd: stop defining __KERNEL_SYSCALLS__

2023-06-05 10:45:25 -06:00

drbd_req.c

drbd: Pass a peer device to the resync and online verify functions

2023-04-01 20:27:55 -06:00

drbd_req.h

drbd: pass drbd_peer_device to __req_mod

2023-04-01 20:27:55 -06:00

drbd_state_change.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_state.c

Merge tag 'for-6.4/block-2023-04-21' of git://git.kernel.dk/linux

2023-04-26 12:52:58 -07:00

drbd_state.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_strings.c

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_strings.h

drbd: use consistent license

2022-11-22 19:38:39 -07:00

drbd_vli.h

drbd: remove unnecessary assignment in vli_encode_bits

2023-01-29 15:18:33 -07:00

drbd_worker.c

drbd: Pass a peer device to the resync and online verify functions

2023-04-01 20:27:55 -06:00

Kconfig

drbd: use consistent license

2022-11-22 19:38:39 -07:00

Makefile

drbd: split off drbd_buildtag into separate file

2023-01-29 15:18:33 -07:00