Vladimir Davydov 8135be5a80
memcg: fix possible use-after-free in memcg_kmem_get_cache() ...
Suppose task @t that belongs to a memory cgroup @memcg is going to
allocate an object from a kmem cache @c. The copy of @c corresponding to
@memcg, @mc, is empty. Then if kmem_cache_alloc races with the memory
cgroup destruction we can access the memory cgroup's copy of the cache
after it was destroyed:
CPU0 CPU1
---- ----
[ current=@t
@mc->memcg_params->nr_pages=0 ]
kmem_cache_alloc(@c):
call memcg_kmem_get_cache(@c);
proceed to allocation from @mc:
alloc a page for @mc:
...
move @t from @memcg
destroy @memcg:
mem_cgroup_css_offline(@memcg):
memcg_unregister_all_caches(@memcg):
kmem_cache_destroy(@mc)
add page to @mc
We could fix this issue by taking a reference to a per-memcg cache, but
that would require adding a per-cpu reference counter to per-memcg caches,
which would look cumbersome.
Instead, let's take a reference to a memory cgroup, which already has a
per-cpu reference counter, in the beginning of kmem_cache_alloc to be
dropped in the end, and move per memcg caches destruction from css offline
to css free. As a side effect, per-memcg caches will be destroyed not one
by one, but all at once when the last page accounted to the memory cgroup
is freed. This doesn't sound as a high price for code readability though.
Note, this patch does add some overhead to the kmem_cache_alloc hot path,
but it is pretty negligible - it's just a function call plus a per cpu
counter decrement, which is comparable to what we already have in
memcg_kmem_get_cache. Besides, it's only relevant if there are memory
cgroups with kmem accounting enabled. I don't think we can find a way to
handle this race w/o it, because alloc_page called from kmem_cache_alloc
may sleep so we can't flush all pending kmallocs w/o reference counting.
Signed-off-by: Vladimir Davydov <vdavydov@parallels.com >
Acked-by: Christoph Lameter <cl@linux.com >
Cc: Johannes Weiner <hannes@cmpxchg.org >
Cc: Michal Hocko <mhocko@suse.cz >
Cc: Pekka Enberg <penberg@kernel.org >
Cc: David Rientjes <rientjes@google.com >
Cc: Joonsoo Kim <iamjoonsoo.kim@lge.com >
Signed-off-by: Andrew Morton <akpm@linux-foundation.org >
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org >
2014-12-13 12:42:49 -08:00
2014-09-24 10:25:52 +01:00
2014-11-11 16:31:11 -05:00
2014-08-06 18:01:23 -07:00
2014-12-07 21:22:09 +01:00
2014-10-14 12:57:02 -07:00
2014-11-13 09:26:33 -07:00
2014-08-08 15:57:26 -07:00
2014-10-15 20:31:05 +05:30
2014-09-22 16:48:47 +09:00
2014-11-04 21:58:23 +01:00
2014-11-30 20:13:13 -08:00
2014-11-15 16:04:56 +00:00
2014-08-07 23:37:07 -07:00
2014-11-24 07:45:15 +01:00
2014-11-24 17:24:08 -05:00
2014-12-11 13:20:50 -08:00
2014-12-11 14:47:36 -05:00
2014-12-08 20:45:54 -05:00
2014-12-08 09:11:04 +01:00
2014-10-21 13:46:03 -07:00
2014-09-15 22:20:21 +02:00
2014-09-04 19:21:45 +02:00
2014-12-11 14:27:06 -08:00
2014-10-28 03:30:21 +01:00
2014-12-05 11:14:43 +00:00
2014-09-24 11:53:39 -07:00
2014-11-24 18:53:42 +00:00
2014-11-27 13:14:52 -05:00
2014-12-04 00:51:54 +01:00
2014-08-07 14:40:09 -04:00
2014-12-08 20:00:44 +01:00
2014-09-16 16:28:34 -06:00
2014-08-16 08:35:34 -04:00
2014-08-23 13:05:08 -04:00
2014-10-27 14:16:19 -04:00
2014-09-08 10:54:03 +02:00
2014-11-10 12:40:48 +01:00
2014-08-13 10:31:57 +02:00
2014-11-19 13:01:26 -05:00
2014-09-08 10:00:43 -06:00
2014-10-09 22:26:01 -04:00
2014-10-03 15:28:18 -06:00
2014-12-13 12:42:46 -08:00
2014-11-16 09:55:39 +01:00
2014-10-14 09:00:44 -06:00
2014-11-12 11:16:09 +01:00
2014-12-10 21:17:00 -08:00
2014-11-13 16:17:06 -08:00
2014-12-05 21:47:32 -08:00
2014-10-01 22:12:48 -04:00
2014-09-04 22:04:42 -04:00
2014-07-24 21:53:47 +10:00
2014-09-24 14:23:34 +08:00
2014-12-11 18:57:19 -08:00
2014-09-27 12:52:33 -07:00
2014-11-17 11:13:52 -08:00
2014-10-15 07:05:03 +02:00
2014-10-22 16:14:03 -06:00
2014-10-27 13:00:55 +01:00
2014-09-29 14:36:26 -04:00
2014-12-10 17:41:06 -08:00
2014-10-28 11:03:40 +01:00
2014-10-28 11:03:40 +01:00
2014-09-18 16:22:27 -07:00
2014-10-21 00:51:01 +02:00
2014-11-29 23:38:38 +01:00
2014-11-12 21:17:27 +01:00
2014-08-28 08:58:57 -04:00
2014-10-27 11:15:27 -04:00
2014-10-22 16:14:04 -06:00
2014-09-27 09:14:59 -06:00
2014-08-01 22:35:55 +08:00
2014-11-19 13:01:20 -05:00
2014-11-05 14:13:38 -05:00
2014-09-23 22:53:15 -07:00
2014-11-19 11:24:59 -05:00
2014-12-04 12:41:59 +00:00
2014-08-06 18:01:16 -07:00
2014-08-26 07:39:13 +02:00
2014-10-18 18:11:04 -07:00
2014-10-02 12:12:25 +02:00
2014-10-03 14:55:48 -07:00
2014-09-29 00:04:55 -04:00
2014-10-20 14:22:22 +02:00
2014-11-25 15:42:53 +01:00
2014-11-05 09:03:16 +01:00
2014-11-24 07:45:02 +01:00
2014-12-08 20:47:41 -05:00
2014-12-08 21:07:10 -05:00
2014-11-04 17:34:15 -08:00
2014-12-10 17:41:10 -08:00
2014-12-05 21:47:32 -08:00
2014-09-08 09:51:30 +09:00
2014-10-09 11:35:48 +03:00
2014-11-04 07:17:46 +01:00
2014-10-08 16:01:41 -04:00
2014-08-07 14:40:08 -04:00
2014-12-13 12:42:45 -08:00
2014-09-03 18:02:55 -05:00
2014-10-15 21:31:27 +05:30
2014-08-06 18:01:12 -07:00
2014-11-19 15:25:39 -05:00
2014-11-21 14:42:10 -05:00
2014-10-09 22:25:52 -04:00
2014-10-14 17:03:53 -04:00
2014-12-13 12:42:48 -08:00
2014-08-06 18:01:24 -07:00
2014-11-04 21:58:23 +01:00
2014-12-10 15:17:46 -05:00
2014-12-12 11:15:33 +01:00
2014-08-06 18:01:22 -07:00
2014-08-04 10:07:36 +02:00
2014-10-09 22:25:57 -04:00
2014-12-10 17:41:04 -08:00
2014-12-11 17:48:14 -08:00
2014-12-08 20:24:11 -05:00
2014-09-25 16:07:15 +02:00
2014-11-19 18:45:16 +01:00
2014-11-17 09:49:17 +01:00
2014-12-02 20:01:23 -08:00
2014-09-29 15:37:01 -04:00
2014-11-21 14:20:17 -05:00
2014-09-04 22:26:14 -07:00
2014-09-09 10:28:43 -04:00
2014-11-14 17:08:58 -05:00
2014-12-09 21:21:34 -08:00
2014-09-01 13:48:59 +02:00
2014-11-04 14:53:36 +01:00
2014-09-04 14:41:43 -06:00
2014-09-23 23:13:13 -07:00
2014-11-05 16:59:04 -05:00
2014-09-13 18:38:15 +02:00
2014-12-10 09:01:01 -08:00
2014-10-09 16:07:43 -04:00
2014-11-23 13:01:46 +01:00
2014-11-23 13:01:46 +01:00
2014-08-02 15:03:58 -07:00
2014-09-18 00:58:12 -04:00
2014-09-12 13:59:03 -07:00
2014-08-10 09:00:16 +02:00
2014-12-10 17:41:11 -08:00
2014-11-16 10:04:18 +01:00
2014-12-10 17:41:10 -08:00
2014-10-14 15:05:34 -04:00
2014-10-14 02:18:21 +02:00
2014-09-16 17:36:08 +01:00
2014-09-09 10:34:56 +02:00
2014-10-22 16:14:04 -06:00
2014-10-29 16:33:14 -07:00
2014-08-06 18:01:24 -07:00
2014-12-13 12:42:47 -08:00
2014-10-27 13:27:27 +01:00
2014-07-28 14:16:30 -04:00
2014-11-26 14:40:45 +01:00
2014-08-29 16:35:53 +02:00
2014-11-04 21:58:25 +01:00
2014-12-11 18:52:37 -08:00
2014-11-20 14:45:15 +01:00
2014-10-13 15:51:40 +02:00
2014-11-27 12:50:59 +05:30
2014-10-08 10:39:41 +05:30
2014-10-24 15:49:20 -04:00
2014-11-30 16:40:11 +00:00
2014-09-29 11:56:02 -04:00
2014-08-06 18:01:15 -07:00
2014-12-13 12:42:49 -08:00
2014-10-09 22:25:52 -04:00
2014-10-22 16:14:04 -06:00
2014-10-09 22:25:56 -04:00
2014-11-21 14:08:56 -05:00
2014-10-09 22:26:01 -04:00
2014-12-13 12:42:48 -08:00
2014-12-13 12:42:48 -08:00
2014-10-09 22:25:58 -04:00
2014-12-13 12:42:45 -08:00
2014-12-13 12:42:48 -08:00
2014-10-29 14:31:17 +01:00
2014-07-27 20:52:44 +09:30
2014-07-27 20:52:42 +09:30
2014-10-14 02:18:28 +02:00
2014-10-24 00:14:36 +02:00
2014-11-23 17:14:43 +01:00
2014-08-13 10:32:03 +02:00
2014-11-05 23:52:33 -08:00
2014-12-09 16:10:06 -05:00
2014-09-26 18:42:31 +02:00
2014-08-25 10:45:28 +02:00
2014-11-25 16:38:32 -05:00
2014-11-25 16:38:32 -05:00
2014-11-24 17:00:42 -05:00
2014-08-22 18:04:43 -04:00
2014-11-25 16:38:32 -05:00
2014-10-25 08:07:30 +02:00
2014-10-14 02:18:27 +02:00
2014-08-06 18:01:21 -07:00
2014-07-29 18:08:50 -07:00
2014-11-04 16:43:08 +00:00
2014-07-26 00:21:41 +05:30
2014-07-29 21:26:45 -06:00
2014-11-12 07:49:38 -07:00
2014-11-04 13:29:38 +00:00
2014-11-24 22:25:06 +00:00
2014-10-29 16:33:14 -07:00
2014-12-11 13:06:58 -08:00
2014-09-18 09:53:25 -07:00
2014-11-20 12:11:25 -08:00
2014-07-29 12:38:07 +02:00
2014-11-27 12:51:04 +05:30
2014-12-13 12:42:49 -08:00
2014-12-10 17:41:05 -08:00
2014-12-13 12:42:48 -08:00
2014-12-13 12:42:48 -08:00
2014-08-06 18:01:17 -07:00
2014-11-13 16:17:05 -08:00
2014-10-09 22:26:01 -04:00
2014-11-13 10:35:25 -07:00
2014-10-20 14:08:40 +02:00
2014-11-05 13:06:16 -07:00
2014-12-11 18:15:33 -08:00
2014-09-08 09:51:29 +09:00
2014-08-26 13:45:56 -04:00
2014-12-11 18:36:26 -08:00
2014-11-21 11:19:15 -05:00
2014-11-16 11:42:04 +01:00
2014-10-07 13:06:45 -04:00
2014-11-21 14:08:55 -05:00
2014-08-04 10:07:11 -07:00
2014-10-08 10:39:33 +05:30
2014-11-20 14:45:15 +01:00
2014-11-07 01:46:51 +01:00
2014-12-08 20:00:44 +01:00
2014-11-29 23:53:20 +01:00
2014-12-04 00:46:58 +01:00
2014-12-04 00:46:58 +01:00
2014-12-08 20:00:44 +01:00
2014-10-19 20:22:32 +03:00
2014-10-28 03:30:19 +01:00
2014-12-10 20:35:41 -08:00
2014-09-17 16:33:11 -04:00
2014-11-04 21:58:23 +01:00
2014-09-08 09:51:30 +09:00
2014-12-11 13:38:31 -08:00
2014-12-10 17:41:10 -08:00
2014-11-26 18:07:45 +00:00
2014-10-28 16:48:02 -04:00
2014-11-10 10:06:08 +01:00
2014-11-10 10:06:07 +01:00
2014-08-24 18:36:01 -07:00
2014-10-14 02:18:21 +02:00
2014-12-12 10:08:06 -08:00
2014-11-20 08:57:58 +01:00
2014-11-03 19:20:34 -08:00
2014-11-03 19:20:43 -08:00
2014-09-26 00:00:06 -07:00
2014-11-19 10:28:14 +00:00
2014-10-20 10:11:29 +02:00
2014-10-20 10:11:29 +02:00
2014-11-13 15:18:40 -05:00
2014-11-10 16:45:43 -05:00
2014-08-08 15:57:24 -07:00
2014-10-09 22:25:57 -04:00
2014-11-21 12:00:00 -08:00
2014-12-09 13:36:57 -05:00
2014-08-13 10:32:03 +02:00
2014-08-08 15:57:26 -07:00
2014-12-13 12:42:47 -08:00
2014-10-09 22:26:04 -04:00
2014-09-03 14:58:17 -07:00
2014-10-12 10:13:55 -04:00
2014-11-19 22:01:19 -05:00
2014-10-29 20:26:06 -04:00
2014-09-19 12:35:16 +02:00
2014-08-28 11:59:38 +05:30
2014-09-29 18:20:38 -07:00
2014-09-26 18:01:56 +02:00
2014-08-08 15:57:26 -07:00
2014-08-08 15:57:31 -07:00
2014-12-13 12:42:48 -08:00
2014-10-14 02:18:20 +02:00
2014-12-10 13:31:57 -05:00
2014-10-09 22:25:51 -04:00
2014-12-13 12:42:49 -08:00
2014-09-19 12:35:15 +02:00
2014-12-10 22:41:55 -05:00
2014-08-13 10:32:38 +02:00
2014-12-13 12:42:48 -08:00
2014-07-31 14:13:29 -07:00
2014-10-14 02:18:26 +02:00
2014-10-24 12:33:32 -07:00
2014-09-30 21:06:07 +02:00
2014-12-10 17:41:09 -08:00
2014-12-13 12:42:47 -08:00
2014-11-19 16:22:59 -05:00
2014-08-08 15:57:24 -07:00
2014-11-17 10:28:04 -08:00
2014-09-27 09:14:59 -06:00
2014-12-10 13:17:23 -05:00
2014-10-10 14:02:25 +08:00
2014-09-26 08:15:29 +01:00
2014-10-14 03:47:00 +02:00
2014-11-21 11:59:58 -08:00
2014-10-29 15:15:40 +01:00
2014-12-10 10:13:28 -08:00
2014-10-09 22:25:51 -04:00
2014-09-16 13:41:06 -07:00
2014-07-29 23:10:56 +02:00
2014-11-19 22:01:15 -05:00
2014-08-06 13:03:43 +02:00
2014-09-10 10:48:46 -04:00
2014-09-23 21:19:35 -07:00
2014-09-25 12:17:25 +02:00
2014-09-01 21:36:28 -07:00
2014-10-02 21:35:54 -07:00
2014-12-09 16:29:11 -05:00
2014-10-22 16:14:04 -06:00
2014-09-23 21:40:48 -07:00
2014-12-04 00:51:54 +01:00
2014-08-08 15:57:22 -07:00
2014-11-28 16:08:16 +01:00
2014-08-08 10:39:16 -06:00
2014-09-18 19:21:20 -04:00
2014-09-16 15:02:55 -06:00
2014-12-09 12:05:24 +02:00
2014-12-09 16:32:32 +02:00
2014-12-09 21:42:00 +02:00
2014-12-13 12:42:48 -08:00
2014-08-06 18:01:19 -07:00
2014-12-09 16:28:23 -05:00
2014-11-04 07:17:45 +01:00
2014-10-20 20:46:25 +02:00
2014-09-13 05:13:08 +09:00
2014-08-06 18:01:23 -07:00
2014-08-08 15:57:26 -07:00
2014-08-06 18:01:23 -07:00
2014-10-09 22:26:02 -04:00
8135be5a80