Tejas Upadhyay
b8d8436840
drm/i915/gt: Hold RPM wakelock during PXP suspend
selftest --r live shows failure in suspend tests when
RPM wakelock is not acquired during suspend.
This changes addresses below error :
<4> [154.177535] RPM wakelock ref not held during HW access
<4> [154.177575] WARNING: CPU: 4 PID: 5772 at
drivers/gpu/drm/i915/intel_runtime_pm.h:113
fwtable_write32+0x240/0x320 [i915]
<4> [154.177974] Modules linked in: i915(+) vgem drm_shmem_helper
fuse snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic
ledtrig_audio mei_hdcp mei_pxp x86_pkg_temp_thermal coretemp
crct10dif_pclmul crc32_pclmul ghash_clmulni_intel snd_intel_dspcfg
snd_hda_codec snd_hwdep igc snd_hda_core ttm mei_me ptp
snd_pcm prime_numbers mei i2c_i801 pps_core i2c_smbus intel_lpss_pci
btusb btrtl btbcm btintel bluetooth ecdh_generic ecc [last unloaded: i915]
<4> [154.178143] CPU: 4 PID: 5772 Comm: i915_selftest Tainted: G
U 5.15.0-rc6-CI-Patchwork_21432+ #1
<4> [154.178154] Hardware name: ASUS System Product Name/TUF GAMING
Z590-PLUS WIFI, BIOS 0811 04/06/2021
<4> [154.178160] RIP: 0010:fwtable_write32+0x240/0x320 [i915]
<4> [154.178604] Code: 15 7b e1 0f 0b e9 34 fe ff ff 80 3d a9 89 31
00 00 0f 85 31 fe ff ff 48 c7 c7 88 9e 4f a0 c6 05 95 89 31 00 01 e8
c0 15 7b e1 <0f> 0b e9 17 fe ff ff 8b 05 0f 83 58 e2 85 c0 0f 85 8d
00 00 00 48
<4> [154.178614] RSP: 0018:ffffc900016279f0 EFLAGS: 00010286
<4> [154.178626] RAX: 0000000000000000 RBX: ffff888204fe0ee0
RCX: 0000000000000001
<4> [154.178634] RDX: 0000000080000001 RSI: ffffffff823142b5
RDI: 00000000ffffffff
<4> [154.178641] RBP: 00000000000320f0 R08: 0000000000000000
R09: c0000000ffffcd5a
<4> [154.178647] R10: 00000000000f8c90 R11: ffffc90001627808
R12: 0000000000000000
<4> [154.178654] R13: 0000000040000000 R14: ffffffffa04d12e0
R15: 0000000000000000
<4> [154.178660] FS: 00007f7390aa4c00(0000) GS:ffff88844f000000(0000)
knlGS:0000000000000000
<4> [154.178669] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
<4> [154.178675] CR2: 000055bc40595028 CR3: 0000000204474005
CR4: 0000000000770ee0
<4> [154.178682] PKRU: 55555554
<4> [154.178687] Call Trace:
<4> [154.178706] intel_pxp_fini_hw+0x23/0x30 [i915]
<4> [154.179284] intel_pxp_suspend+0x1f/0x30 [i915]
<4> [154.179807] live_gt_resume+0x5b/0x90 [i915]
Changes since V2 :
- Remove boolean in intel_pxp_runtime_preapre for
non-pxp configs. Solves build error
Changes since V2 :
- Open-code intel_pxp_runtime_suspend - Daniele
- Remove boolean in intel_pxp_runtime_preapre - Daniele
Changes since V1 :
- split the HW access parts in gt_suspend_late - Daniele
- Remove default PXP configs
Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Fixes: 0cfab4cb3c ("drm/i915/pxp: Enable PXP power management")
Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211117060321.3729343-1-tejaskumarx.surendrakumar.upadhyay@intel.com
(cherry picked from commit d22d446f7a)
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
2021-11-24 09:07:18 -05:00
..
2021-11-17 23:04:57 -05:00
2021-08-16 12:18:46 +02:00
2021-11-04 08:21:47 -07:00
2021-06-24 15:40:11 +02:00
2021-10-28 14:59:38 +10:00
2021-08-10 20:00:58 +02:00
2021-10-12 11:17:41 +02:00
2021-11-04 08:21:47 -07:00
2021-10-25 14:53:08 +02:00
2021-08-10 20:13:25 +02:00
2021-10-04 09:34:55 -04:00
2021-10-04 12:06:14 +02:00
2021-07-30 14:52:00 +10:00
2021-10-15 15:04:44 +10:00
2021-08-10 20:14:01 +02:00
2021-11-24 09:07:18 -05:00
2021-11-05 19:08:44 +01:00
2021-08-11 15:49:15 +02:00
2021-10-21 11:08:09 +02:00
2021-08-30 10:58:20 +02:00
2021-09-07 22:50:17 +02:00
2021-11-03 17:00:52 -07:00
2021-09-14 09:25:30 +02:00
2021-09-25 08:20:48 -07:00
2021-09-23 09:26:09 +02:00
2021-10-28 15:07:48 +10:00
2021-11-05 13:50:15 +10:00
2021-11-16 08:51:39 +01:00
2021-11-04 08:21:47 -07:00
2021-11-05 13:50:15 +10:00
2021-09-20 14:34:37 +01:00
2021-07-31 20:52:01 +02:00
2021-09-15 08:21:32 +02:00
2021-10-28 14:59:38 +10:00
2021-11-11 08:14:19 +10:00
2021-10-13 07:44:04 +10:00
2021-10-28 14:59:38 +10:00
2021-11-17 08:21:03 +01:00
2021-10-22 11:09:45 +02:00
2021-10-07 05:42:18 +03:00
2021-10-07 05:42:17 +03:00
2021-09-09 14:58:27 +02:00
2021-11-16 08:51:39 +01:00
2021-11-04 08:21:47 -07:00
2021-08-10 20:13:49 +02:00
2021-10-15 16:48:51 -07:00
2021-09-15 08:21:32 +02:00
2021-11-12 13:06:41 +10:00
2021-06-24 15:40:11 +02:00
2021-11-05 11:15:14 +01:00
2021-10-11 21:21:14 +01:00
2021-09-23 09:26:09 +02:00
2021-10-28 14:59:38 +10:00
2021-08-12 21:41:10 +02:00
2021-08-10 20:14:01 +02:00
2021-11-08 13:54:41 +01:00
2021-08-08 20:27:52 +02:00
2021-11-12 12:11:07 -08:00
2021-06-24 15:40:11 +02:00
2021-08-09 02:28:05 +03:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-05 12:08:15 +02:00
2021-09-24 19:25:23 +02:00
2021-08-02 10:19:43 +02:00
2021-10-04 11:47:24 +02:00
2021-10-04 09:34:57 -04:00
2021-10-11 21:46:58 +02:00
2021-10-04 09:34:57 -04:00
2021-08-20 12:35:59 +02:00
2021-08-02 10:19:43 +02:00
2021-06-10 19:14:47 +02:00
2021-07-20 20:14:42 +02:00
2021-08-11 08:47:08 +10:00
2021-09-20 18:45:35 +03:00
2021-11-09 10:11:53 -08:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-10-28 14:59:38 +10:00
2021-10-15 15:04:05 +10:00
2021-08-02 10:19:43 +02:00
2021-10-04 12:04:19 +02:00
2021-10-28 17:20:45 +10:00
2021-10-04 09:34:57 -04:00
2021-08-08 20:26:16 +02:00
2021-11-15 10:26:53 +01:00
2021-10-25 14:53:08 +02:00
2021-11-04 08:21:47 -07:00
2021-08-23 13:54:55 +02:00
2021-10-07 14:49:11 +02:00
2021-08-02 10:19:43 +02:00
2021-08-17 13:56:03 -04:00
2021-08-28 19:00:20 +02:00
2021-08-10 20:14:01 +02:00
2021-08-18 14:33:47 +02:00
2021-10-01 15:55:47 +02:00
2021-08-10 20:14:01 +02:00
2021-07-23 20:17:59 +02:00
2021-09-24 19:25:33 +02:00
2021-11-09 10:02:50 -08:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-11-11 08:14:19 +10:00
2021-09-14 10:39:01 +02:00
2021-11-12 09:23:16 +10:00
2021-07-13 06:38:37 -07:00
2021-10-07 12:24:44 +02:00
2021-08-02 10:19:43 +02:00
2021-11-12 12:11:07 -08:00
2021-08-19 09:02:55 +09:00
2021-09-28 12:29:13 +02:00
2021-10-07 05:42:13 +03:00
2021-08-02 10:19:43 +02:00
2021-08-08 20:14:08 +02:00
2021-08-02 10:19:43 +02:00
2021-08-20 12:35:59 +02:00
2021-08-10 20:14:01 +02:00
2021-08-02 10:19:43 +02:00
2021-11-05 18:52:47 +01:00
2021-08-26 11:19:08 +02:00