Russell King
bbfebeea76
[media] em28xx: fix em28xx-input removal
Removing the em28xx-rc module results in the following lockdep splat,
which is caused by trying to call cancel_delayed_work_sync() on an
uninitialised delayed work. Fix this by ensuring we always initialise
the work.
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 0 PID: 2183 Comm: rmmod Not tainted 3.18.0+ #1464
Hardware name: Freescale i.MX6 Quad/DualLite (Device Tree)
Backtrace:
[<c0012228>] (dump_backtrace) from [<c00123c0>] (show_stack+0x18/0x1c)
r6:c1419d2c r5:00000000 r4:00000000 r3:00000000
[<c00123a8>] (show_stack) from [<c06e2550>] (dump_stack+0x7c/0x98)
[<c06e24d4>] (dump_stack) from [<c0061c94>] (__lock_acquire+0x16d4/0x1bb0)
r4:edf19f74 r3:df049380
[<c00605c0>] (__lock_acquire) from [<c00626d4>] (lock_acquire+0xb0/0x124)
r10:00000000 r9:c003ba90 r8:00000000 r7:00000000 r6:00000000 r5:edf19f74
r4:00000000
[<c0062624>] (lock_acquire) from [<c003bad4>] (flush_work+0x44/0x264)
r10:00000000 r9:eaa86000 r8:edf190b0 r7:edf19f74 r6:00000001 r5:edf19f64
r4:00000000
[<c003ba90>] (flush_work) from [<c003d8f0>] (__cancel_work_timer+0x8c/0x124)
r7:00000000 r6:00000001 r5:00000000 r4:edf19f64
[<c003d864>] (__cancel_work_timer) from [<c003d99c>] (cancel_delayed_work_sync+0x14/0x18)
r7:00000000 r6:eccc3600 r5:00000000 r4:edf19000
[<c003d988>] (cancel_delayed_work_sync) from [<bf0b5c10>] (em28xx_ir_fini+0x48/0xd8 [em28xx_rc])
[<bf0b5bc8>] (em28xx_ir_fini [em28xx_rc]) from [<bf08a0a8>] (em28xx_unregister_extension+0x40/0x94 [em28xx])
r8:c000edc4 r7:00000081 r6:bf092bf4 r5:bf0b6a2c r4:edf19000 r3:bf0b5bc8
[<bf08a068>] (em28xx_unregister_extension [em28xx]) from [<bf0b64dc>] (em28xx_rc_unregister+0x14/0x1c [em28xx_rc])
r6:00000800 r5:00000000 r4:bf0b6a50 r3:bf0b64c8
[<bf0b64c8>] (em28xx_rc_unregister [em28xx_rc]) from [<c0096710>] (SyS_delete_module+0x11c/0x180)
[<c00965f4>] (SyS_delete_module) from [<c000ec00>] (ret_fast_syscall+0x0/0x48)
r6:00000001 r5:beb0f813 r4:b8b17d00
Fixes: f522260993 ("[media] em28xx: extend the support for device buttons")
Cc: <stable@vger.kernel.org>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Reviewed-by: Frank Schäfer <fschaefer.oss@googlemail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
2014-12-23 14:46:03 -02:00
..
2014-12-19 14:02:02 -08:00
2014-12-14 16:43:47 -08:00
2014-12-18 20:28:33 -08:00
2014-12-14 16:10:09 -08:00
2014-12-18 20:28:33 -08:00
2014-12-11 17:56:37 -08:00
2014-12-17 16:03:12 -08:00
2014-12-15 13:23:09 -05:00
2014-12-14 16:10:09 -08:00
2014-12-15 15:52:01 -08:00
2014-12-20 16:42:36 -08:00
2014-12-11 17:56:37 -08:00
2014-12-19 12:56:15 -08:00
2014-12-19 12:57:45 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:43:47 -08:00
2014-12-10 20:53:21 +01:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-15 18:06:13 -08:00
2014-12-12 10:26:47 -08:00
2014-12-15 17:33:47 -08:00
2014-12-14 16:43:47 -08:00
2014-12-17 10:16:27 -08:00
2014-12-20 13:52:52 -08:00
2014-12-14 16:10:09 -08:00
2014-12-15 18:06:13 -08:00
2014-12-20 13:42:57 -08:00
2014-12-17 10:06:02 -08:00
2014-12-19 14:02:02 -08:00
2014-12-15 17:30:09 -08:00
2014-12-12 10:08:06 -08:00
2014-12-18 20:28:33 -08:00
2014-12-09 16:32:32 +02:00
2014-12-19 19:32:47 +01:00
2014-12-14 16:10:09 -08:00
2014-12-14 12:13:05 -08:00
2014-12-23 14:46:03 -02:00
2014-12-17 09:59:26 -08:00
2014-12-14 16:10:09 -08:00
2014-12-19 12:57:45 -08:00
2014-12-18 20:28:33 -08:00
2014-12-17 09:59:26 -08:00
2014-12-18 20:10:44 -08:00
2014-12-18 20:28:33 -08:00
2014-12-16 14:53:01 -08:00
2014-12-14 16:43:47 -08:00
2014-12-19 14:02:02 -08:00
2014-12-14 16:43:47 -08:00
2014-12-18 20:28:33 -08:00
2014-12-14 16:10:09 -08:00
2014-12-18 20:24:55 -08:00
2014-12-18 20:28:33 -08:00
2014-12-17 10:10:51 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-14 16:10:09 -08:00
2014-12-20 13:42:57 -08:00
2014-12-05 03:08:24 +01:00
2014-12-15 15:52:01 -08:00
2014-12-19 15:25:31 +01:00
2014-12-11 17:56:37 -08:00
2014-12-23 14:46:02 -02:00
2014-12-20 13:42:57 -08:00
2014-12-19 13:29:20 -08:00
2014-12-19 15:27:58 +01:00
2014-12-14 16:43:47 -08:00
2014-12-20 13:42:57 -08:00
2014-12-17 10:44:22 -08:00
2014-12-18 20:50:30 -08:00
2014-12-18 20:28:33 -08:00
2014-12-18 20:50:30 -08:00
2014-12-14 16:43:47 -08:00
2014-12-18 16:01:20 +01:00
2014-12-18 05:56:29 -08:00
2014-12-15 18:06:13 -08:00
2014-12-15 18:06:13 -08:00