mirror
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/gpu/drm/amd/amdkfd
History
Philip Yang 74097f9fd2 drm/amdkfd: Process notifier release callback don't take mutex 
Move process queues cleanup to deferred work kfd_process_wq_release, to
avoid potential deadlock circular locking warning:

 WARNING: possible circular locking dependency detected
               the existing dependency chain (in reverse order) is:
      -> #2
        ((work_completion)(&svms->deferred_list_work)){+.+.}-{0:0}:
        __flush_work+0x343/0x4a0
        svm_range_list_lock_and_flush_work+0x39/0xc0
        svm_range_set_attr+0xe8/0x1080 [amdgpu]
        kfd_ioctl+0x19b/0x600 [amdgpu]
        __x64_sys_ioctl+0x81/0xb0
        do_syscall_64+0x34/0x80
        entry_SYSCALL_64_after_hwframe+0x44/0xae

      -> #1 (&info->lock#2){+.+.}-{3:3}:
        __mutex_lock+0xa4/0x940
        amdgpu_amdkfd_gpuvm_acquire_process_vm+0x2e3/0x590
        kfd_process_device_init_vm+0x61/0x200 [amdgpu]
        kfd_ioctl_acquire_vm+0x83/0xb0 [amdgpu]
        kfd_ioctl+0x19b/0x600 [amdgpu]
        __x64_sys_ioctl+0x81/0xb0
        do_syscall_64+0x34/0x80
       entry_SYSCALL_64_after_hwframe+0x44/0xae

      -> #0 (&process->mutex){+.+.}-{3:3}:
        __lock_acquire+0x1365/0x23d0
        lock_acquire+0xc9/0x2e0
        __mutex_lock+0xa4/0x940
        kfd_process_notifier_release+0x96/0xe0 [amdgpu]
        __mmu_notifier_release+0x94/0x210
        exit_mmap+0x35/0x1f0
        mmput+0x63/0x120
        svm_range_deferred_list_work+0x177/0x2c0 [amdgpu]
        process_one_work+0x2a4/0x600
        worker_thread+0x39/0x3e0
        kthread+0x16d/0x1a0

  Possible unsafe locking scenario:

      CPU0                    CPU1
        ----                    ----
   lock((work_completion)(&svms->deferred_list_work));
                                lock(&info->lock#2);
             lock((work_completion)(&svms->deferred_list_work));
   lock(&process->mutex);

Signed-off-by: Philip Yang <Philip.Yang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
 		2022-07-25 09:31:05 -04:00
..
Kconfig drm/amdkfd: Define config HSA_AMD_P2P to support peer-to-peer 2022-06-08 11:40:12 -04:00
Makefile drm/amdkfd: Add KFD support for soc21 v3 2022-05-04 10:43:54 -04:00
cik_event_interrupt.c drm/amdkfd: rename kfd_process_vm_fault to kfd_dqm_evict_pasid 2022-02-09 14:14:53 -05:00
cik_int.h
…
cik_regs.h
…
cwsr_trap_handler.h drm/amdkfd: Add gfx11 trap handler 2022-05-26 14:56:33 -04:00
cwsr_trap_handler_gfx8.asm
…
cwsr_trap_handler_gfx9.asm drm/amdkfd: port cwsr trap handler from dkms branch 2022-05-26 14:56:32 -04:00
cwsr_trap_handler_gfx10.asm drm/amdkfd: Add gfx11 trap handler 2022-05-26 14:56:33 -04:00
kfd_chardev.c drm/amdkfd: Add user queue eviction restore SMI event 2022-06-30 15:31:14 -04:00
kfd_crat.c drm/amdkfd: Remove field io_link_count from struct kfd_topology_device 2022-06-10 15:24:26 -04:00
kfd_crat.h drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_debugfs.c drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_device.c drm/amdkfd: correct the MEC atomic support firmware checking for GC 10.3.7 2022-07-13 11:25:16 -04:00
kfd_device_queue_manager.c drm/amdgpu: Fix one list corruption when create queue fails 2022-07-07 15:55:56 -04:00
kfd_device_queue_manager.h drm/amdkfd: Add KFD support for soc21 v3 2022-05-04 10:43:54 -04:00
kfd_device_queue_manager_cik.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_device_queue_manager_v9.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_device_queue_manager_v10.c drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_device_queue_manager_v11.c drm/amdkfd: Add KFD support for soc21 v3 2022-05-04 10:43:54 -04:00
kfd_device_queue_manager_vi.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_doorbell.c drm/amdkfd: Add KFD support for soc21 v3 2022-05-04 10:43:54 -04:00
kfd_events.c drm/amdkfd: Document and fix GTT BO kmap API 2022-06-08 11:40:59 -04:00
kfd_events.h drm/amdkfd: Asynchronously free events 2022-04-12 14:20:13 -04:00
kfd_flat_memory.c drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_int_process_v9.c drm/amdkfd: Add KFD support for soc21 v3 2022-05-04 10:43:54 -04:00
kfd_int_process_v11.c drm/amdkfd: Update event_interrupt_isr_v11 return 2022-05-10 17:53:11 -04:00
kfd_interrupt.c drm/amdkfd: Improve concurrency of event handling 2022-04-07 16:34:24 -04:00
kfd_iommu.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_iommu.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_kernel_queue.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_kernel_queue.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_migrate.c drm/amdkfd: Add migration SMI event 2022-06-30 15:31:04 -04:00
kfd_migrate.h drm/amdkfd: Add migration SMI event 2022-06-30 15:31:04 -04:00
kfd_module.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_mqd_manager.c drm/amdkfd: fix cu mask for asics with wgps 2022-06-30 15:28:03 -04:00
kfd_mqd_manager.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_mqd_manager_cik.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_mqd_manager_v9.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_mqd_manager_v10.c drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_mqd_manager_v11.c drm/amdkfd: Enable GFX11 usermode queue oversubscription 2022-06-23 17:22:12 -04:00
kfd_mqd_manager_vi.c drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_packet_manager.c drm/amdkfd: remove unneeded unmap single queue option 2022-02-14 15:08:41 -05:00
kfd_packet_manager_v9.c drm/amdkfd: Use proper enum in pm_unmap_queues_v9() 2022-02-17 15:59:06 -05:00
kfd_packet_manager_vi.c drm/amdkfd: remove unneeded unmap single queue option 2022-02-14 15:08:41 -05:00
kfd_pasid.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_pm4_headers.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_pm4_headers_ai.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_pm4_headers_aldebaran.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_pm4_headers_diq.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_pm4_headers_vi.h drm/amdkfd: Fix leftover errors and warnings 2022-02-14 15:08:40 -05:00
kfd_pm4_opcodes.h drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_priv.h drm/amdkfd: Add user queue eviction restore SMI event 2022-06-30 15:31:14 -04:00
kfd_process.c drm/amdkfd: Process notifier release callback don't take mutex 2022-07-25 09:31:05 -04:00
kfd_process_queue_manager.c drm/amdkfd: fix cu mask for asics with wgps 2022-06-30 15:28:03 -04:00
kfd_queue.c drm/amdkfd: update SPDX license header 2022-02-14 15:08:40 -05:00
kfd_smi_events.c drm/amdkfd: Asynchronously free smi_client 2022-06-30 15:31:30 -04:00
kfd_smi_events.h drm/amdkfd: Add unmap from GPU SMI event 2022-06-30 15:31:21 -04:00
kfd_svm.c drm/amdkfd: optimize svm range evict 2022-07-07 15:55:10 -04:00
kfd_svm.h drm/amdkfd: Add GPU recoverable fault SMI event 2022-06-30 15:30:54 -04:00
kfd_topology.c drm/amdkfd: fix warning when CONFIG_HSA_AMD_P2P is not set 2022-06-14 21:38:41 -04:00
kfd_topology.h drm/amdkfd: Remove field io_link_count from struct kfd_topology_device 2022-06-10 15:24:26 -04:00
soc15_int.h drm/amdkfd: Add KFD support for soc21 v3 2022-05-04 10:43:54 -04:00