Dmitry Baryshkov
c491a0c7bb
drm/msm/mdp5: fix cursor-related warnings
Since f35a2a9910 ("drm/encoder: make encoder control functions
optional") drm_mode_config_validate would print warnings if both cursor
plane and cursor functions are provided. Restore separate set of
drm_crtc_funcs to be used if separate cursor plane is provided.
[ 6.556046] ------------[ cut here ]------------
[ 6.556071] [CRTC:93:crtc-0] must not have both a cursor plane and a cursor_set func
[ 6.556091] WARNING: CPU: 1 PID: 76 at drivers/gpu/drm/drm_mode_config.c:648 drm_mode_config_validate+0x238/0x4d0
[ 6.567453] Modules linked in:
[ 6.577604] CPU: 1 PID: 76 Comm: kworker/u8:2 Not tainted 5.15.0-rc1-dirty #43
[ 6.580557] Hardware name: Qualcomm Technologies, Inc. DB820c (DT)
[ 6.587763] Workqueue: events_unbound deferred_probe_work_func
[ 6.593926] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 6.599740] pc : drm_mode_config_validate+0x238/0x4d0
[ 6.606596] lr : drm_mode_config_validate+0x238/0x4d0
[ 6.611804] sp : ffff8000121b3980
[ 6.616838] x29: ffff8000121b3990 x28: 0000000000000000 x27: 0000000000000001
[ 6.620140] x26: ffff8000114cde50 x25: ffff8000114cdd40 x24: ffff0000987282d8
[ 6.627258] x23: 0000000000000000 x22: 0000000000000000 x21: 0000000000000001
[ 6.634376] x20: ffff000098728000 x19: ffff000080a39000 x18: ffffffffffffffff
[ 6.641494] x17: 3136564e3631564e x16: 0000000000000324 x15: ffff800011c78709
[ 6.648613] x14: 0000000000000000 x13: ffff800011a22850 x12: 00000000000009ab
[ 6.655730] x11: 0000000000000339 x10: ffff800011a22850 x9 : ffff800011a22850
[ 6.662848] x8 : 00000000ffffefff x7 : ffff800011a7a850 x6 : ffff800011a7a850
[ 6.669966] x5 : 000000000000bff4 x4 : 40000000fffff339 x3 : 0000000000000000
[ 6.677084] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00008093b800
[ 6.684205] Call trace:
[ 6.691319] drm_mode_config_validate+0x238/0x4d0
[ 6.693577] drm_dev_register+0x17c/0x210
[ 6.698435] msm_drm_bind+0x4b4/0x694
[ 6.702429] try_to_bring_up_master+0x164/0x1d0
[ 6.706075] __component_add+0xa0/0x170
[ 6.710415] component_add+0x14/0x20
[ 6.714234] msm_hdmi_dev_probe+0x1c/0x2c
[ 6.718053] platform_probe+0x68/0xe0
[ 6.721959] really_probe.part.0+0x9c/0x30c
[ 6.725606] __driver_probe_device+0x98/0x144
[ 6.729600] driver_probe_device+0xc8/0x15c
[ 6.734114] __device_attach_driver+0xb4/0x120
[ 6.738106] bus_for_each_drv+0x78/0xd0
[ 6.742619] __device_attach+0xdc/0x184
[ 6.746351] device_initial_probe+0x14/0x20
[ 6.750172] bus_probe_device+0x9c/0xa4
[ 6.754337] deferred_probe_work_func+0x88/0xc0
[ 6.758158] process_one_work+0x1d0/0x370
[ 6.762671] worker_thread+0x2c8/0x470
[ 6.766839] kthread+0x15c/0x170
[ 6.770483] ret_from_fork+0x10/0x20
[ 6.773870] ---[ end trace 5884eb76cd26d274 ]---
[ 6.777500] ------------[ cut here ]------------
[ 6.782043] [CRTC:93:crtc-0] must not have both a cursor plane and a cursor_move func
[ 6.782063] WARNING: CPU: 1 PID: 76 at drivers/gpu/drm/drm_mode_config.c:654 drm_mode_config_validate+0x290/0x4d0
[ 6.794362] Modules linked in:
[ 6.804600] CPU: 1 PID: 76 Comm: kworker/u8:2 Tainted: G W 5.15.0-rc1-dirty #43
[ 6.807555] Hardware name: Qualcomm Technologies, Inc. DB820c (DT)
[ 6.816148] Workqueue: events_unbound deferred_probe_work_func
[ 6.822311] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYPE=--)
[ 6.828126] pc : drm_mode_config_validate+0x290/0x4d0
[ 6.834981] lr : drm_mode_config_validate+0x290/0x4d0
[ 6.840189] sp : ffff8000121b3980
[ 6.845223] x29: ffff8000121b3990 x28: 0000000000000000 x27: 0000000000000001
[ 6.848525] x26: ffff8000114cde50 x25: ffff8000114cdd40 x24: ffff0000987282d8
[ 6.855643] x23: 0000000000000000 x22: 0000000000000000 x21: 0000000000000001
[ 6.862763] x20: ffff000098728000 x19: ffff000080a39000 x18: ffffffffffffffff
[ 6.869879] x17: 3136564e3631564e x16: 0000000000000324 x15: ffff800011c790c2
[ 6.876998] x14: 0000000000000000 x13: ffff800011a22850 x12: 0000000000000a2f
[ 6.884116] x11: 0000000000000365 x10: ffff800011a22850 x9 : ffff800011a22850
[ 6.891234] x8 : 00000000ffffefff x7 : ffff800011a7a850 x6 : ffff800011a7a850
[ 6.898351] x5 : 000000000000bff4 x4 : 40000000fffff365 x3 : 0000000000000000
[ 6.905470] x2 : 0000000000000000 x1 : 0000000000000000 x0 : ffff00008093b800
[ 6.912590] Call trace:
[ 6.919702] drm_mode_config_validate+0x290/0x4d0
[ 6.921960] drm_dev_register+0x17c/0x210
[ 6.926821] msm_drm_bind+0x4b4/0x694
[ 6.930813] try_to_bring_up_master+0x164/0x1d0
[ 6.934459] __component_add+0xa0/0x170
[ 6.938799] component_add+0x14/0x20
[ 6.942619] msm_hdmi_dev_probe+0x1c/0x2c
[ 6.946438] platform_probe+0x68/0xe0
[ 6.950345] really_probe.part.0+0x9c/0x30c
[ 6.953991] __driver_probe_device+0x98/0x144
[ 6.957984] driver_probe_device+0xc8/0x15c
[ 6.962498] __device_attach_driver+0xb4/0x120
[ 6.966492] bus_for_each_drv+0x78/0xd0
[ 6.971004] __device_attach+0xdc/0x184
[ 6.974737] device_initial_probe+0x14/0x20
[ 6.978556] bus_probe_device+0x9c/0xa4
[ 6.982722] deferred_probe_work_func+0x88/0xc0
[ 6.986543] process_one_work+0x1d0/0x370
[ 6.991057] worker_thread+0x2c8/0x470
[ 6.995223] kthread+0x15c/0x170
[ 6.998869] ret_from_fork+0x10/0x20
[ 7.002255] ---[ end trace 5884eb76cd26d275 ]---
Fixes: aa649e875d ("drm/msm/mdp5: mdp5_crtc: Restore cursor state only if LM cursors are enabled")
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20210925192824.3416259-1-dmitry.baryshkov@linaro.org
Signed-off-by: Rob Clark <robdclark@chromium.org>
2021-10-11 17:30:53 -07:00
..
2021-09-23 17:06:11 -04:00
2021-08-10 20:00:51 +02:00
2021-07-01 11:11:55 +02:00
2021-06-24 15:40:11 +02:00
2021-08-08 20:27:06 +02:00
2021-08-10 20:00:58 +02:00
2021-08-12 09:56:09 -07:00
2021-09-16 10:35:37 +02:00
2021-08-22 01:56:39 +09:00
2021-08-10 20:13:25 +02:00
2021-08-10 20:13:32 +02:00
2021-08-08 20:27:24 +02:00
2021-07-30 14:52:00 +10:00
2021-08-08 20:27:27 +02:00
2021-08-10 20:14:01 +02:00
2021-09-21 13:36:34 +03:00
2021-09-01 11:26:46 -07:00
2021-08-11 15:49:15 +02:00
2021-09-01 11:26:46 -07:00
2021-07-21 11:58:28 +10:00
2021-07-30 14:52:00 +10:00
2021-09-01 11:26:46 -07:00
2021-09-01 11:26:46 -07:00
2021-08-10 20:14:01 +02:00
2021-08-18 20:47:59 +02:00
2021-10-11 17:30:53 -07:00
2021-08-10 20:13:45 +02:00
2021-09-20 11:05:49 -07:00
2021-07-28 16:33:12 +03:00
2021-09-01 11:26:46 -07:00
2021-08-25 15:40:19 +01:00
2021-07-31 20:52:01 +02:00
2021-07-21 11:58:28 +10:00
2021-08-10 20:14:01 +02:00
2021-09-16 09:56:24 -04:00
2021-07-28 16:33:32 +03:00
2021-09-16 12:02:33 -07:00
2021-07-01 08:53:25 +02:00
2021-08-02 11:15:11 +02:00
2021-07-25 11:01:12 +02:00
2021-07-28 16:33:12 +03:00
2021-07-19 15:35:55 +02:00
2021-07-28 16:33:12 +03:00
2021-08-26 13:05:19 +10:00
2021-08-10 20:13:49 +02:00
2021-08-10 20:13:53 +02:00
2021-08-08 20:27:40 +02:00
2021-09-14 13:36:02 -07:00
2021-06-24 15:40:11 +02:00
2021-08-08 20:27:44 +02:00
2021-07-21 00:19:59 +01:00
2021-08-08 20:27:49 +02:00
2021-09-19 10:11:53 -07:00
2021-07-13 13:15:52 +02:00
2021-08-10 20:14:01 +02:00
2021-08-12 14:58:31 +02:00
2021-08-08 20:27:52 +02:00
2021-09-02 14:47:21 -07:00
2021-06-24 15:40:11 +02:00
2021-08-09 02:28:05 +03:00
2021-06-29 15:40:53 +02:00
2021-05-11 14:13:33 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-05 12:08:15 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-07-20 20:13:56 +02:00
2021-05-16 22:01:14 +02:00
2021-07-27 12:48:17 +02:00
2021-08-02 10:19:43 +02:00
2021-06-10 19:14:47 +02:00
2021-07-20 20:14:42 +02:00
2021-08-11 08:47:08 +10:00
2021-08-02 10:19:43 +02:00
2021-07-27 18:58:28 -04:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-05-25 11:42:09 +01:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-06-04 06:13:57 +10:00
2021-08-02 10:19:43 +02:00
2021-08-08 20:26:16 +02:00
2021-06-01 17:27:20 +01:00
2021-08-08 20:26:16 +02:00
2021-08-02 10:19:43 +02:00
2021-06-02 11:07:25 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-05-17 21:19:48 +02:00
2021-08-17 13:56:03 -04:00
2021-08-02 10:19:43 +02:00
2021-08-10 20:14:01 +02:00
2021-07-30 11:55:41 +02:00
2021-08-10 20:14:01 +02:00
2021-05-17 21:19:48 +02:00
2021-05-10 15:46:58 +02:00
2021-07-23 20:17:59 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-07-15 10:54:04 +01:00
2021-07-13 06:38:37 -07:00
2021-05-17 21:19:48 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-09-02 14:47:21 -07:00
2021-08-19 09:02:55 +09:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-02 10:19:43 +02:00
2021-08-08 20:14:08 +02:00
2021-08-02 10:19:43 +02:00
2021-08-10 20:14:01 +02:00
2021-05-10 15:46:58 +02:00
2021-08-02 10:19:43 +02:00
2021-08-18 18:26:10 -04:00
2021-07-05 08:54:44 +02:00