Files
linux/drivers/scsi
Vasu Dev c826a31457 [SCSI] fcoe: Out of order tx frames was causing several check condition SCSI status
frames followed by these errors in log.

	[sdp] Result: hostbyte=DID_OK driverbyte=DRIVER_SENSE,SUGGEST_OK
	[sdp] Sense Key : Aborted Command [current]
	[sdp] Add. Sense: Data phase error

This was causing some test apps to exit due to write failure under heavy
load.

This was due to a race around adding and removing tx frame skb in
fcoe_pending_queue, Chris Leech helped me to find that brief unlocking
period when pulling skb from fcoe_pending_queue in various contexts
(fcoe_watchdog and fcoe_xmit) and then adding skb back into fcoe_pending_queue
up on a failed fcoe_start_io could change skb/tx frame order in
fcoe_pending_queue. Thanks Chris.

This patch allows only single context to pull skb from fcoe_pending_queue
at any time to prevent above described ordering issue/race by use of
fcoe_pending_queue_active flag.

This patch simplified fcoe_watchdog with modified fcoe_check_wait_queue by
use of FCOE_LOW_QUEUE_DEPTH instead previously used several conditionals
to clear and set lp->qfull.

I think FCOE_MAX_QUEUE_DEPTH with FCOE_LOW_QUEUE_DEPTH  will work better
in re/setting lp->qfull and these could be fine tuned for performance.

Signed-off-by: Vasu Dev <vasu.dev@intel.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
2009-03-10 09:09:21 -05:00
..
2009-02-10 11:15:19 -05:00
2008-01-11 18:22:30 -06:00
2006-09-12 17:12:31 -05:00
2006-09-12 17:12:31 -05:00
2008-10-16 16:52:06 +02:00
2008-12-29 11:24:14 -06:00
2008-08-29 02:13:10 -07:00
2008-11-30 10:03:36 -08:00
2008-10-09 08:56:13 +02:00
2006-09-12 17:12:31 -05:00
2009-02-21 20:29:36 -06:00
2008-10-09 08:56:13 +02:00
2008-01-30 13:14:02 -06:00
2008-12-28 20:00:03 +01:00
2009-01-02 16:12:51 +01:00
2006-09-12 17:12:31 -05:00
2008-01-30 13:14:02 -06:00
2008-01-30 13:14:02 -06:00
2008-10-23 11:42:17 -05:00
2007-07-18 11:16:32 -05:00
2008-07-02 15:06:25 -06:00
2008-02-07 18:02:44 -06:00
2009-01-02 12:02:25 -06:00
2008-10-23 11:42:19 -05:00
2006-11-15 16:43:50 -06:00
2007-10-19 23:22:55 +02:00