mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
cfceccca0157307318905907fd7a4d4231494de7
linux/net/batman-adv
History
Remi Pommarel 421d467dc2 batman-adv: Fix batadv_v_ogm_aggr_send memory leak 
When batadv_v_ogm_aggr_send is called for an inactive interface, the skb
is silently dropped by batadv_v_ogm_send_to_if() but never freed causing
the following memory leak:

  unreferenced object 0xffff00000c164800 (size 512):
    comm "kworker/u8:1", pid 2648, jiffies 4295122303 (age 97.656s)
    hex dump (first 32 bytes):
      00 80 af 09 00 00 ff ff e1 09 00 00 75 01 60 83  ............u.`.
      1f 00 00 00 b8 00 00 00 15 00 05 00 da e3 d3 64  ...............d
    backtrace:
      [<0000000007ad20f6>] __kmalloc_track_caller+0x1a8/0x310
      [<00000000d1029e55>] kmalloc_reserve.constprop.0+0x70/0x13c
      [<000000008b9d4183>] __alloc_skb+0xec/0x1fc
      [<00000000c7af5051>] __netdev_alloc_skb+0x48/0x23c
      [<00000000642ee5f5>] batadv_v_ogm_aggr_send+0x50/0x36c
      [<0000000088660bd7>] batadv_v_ogm_aggr_work+0x24/0x40
      [<0000000042fc2606>] process_one_work+0x3b0/0x610
      [<000000002f2a0b1c>] worker_thread+0xa0/0x690
      [<0000000059fae5d4>] kthread+0x1fc/0x210
      [<000000000c587d3a>] ret_from_fork+0x10/0x20

Free the skb in that case to fix this leak.

Cc: stable@vger.kernel.org
Fixes: 0da0035942 ("batman-adv: OGMv2 - add basic infrastructure")
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
2023-08-09 17:33:03 +02:00
..
bat_algo.c
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bat_algo.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bat_iv_ogm.c
batman-adv: Drop prandom.h includes
2023-01-06 08:43:02 +01:00
bat_iv_ogm.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bat_v_elp.c
batman-adv: Do not get eth header before batadv_check_management_packet
2023-07-28 15:39:38 +02:00
bat_v_elp.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bat_v_ogm.c
batman-adv: Fix batadv_v_ogm_aggr_send memory leak
2023-08-09 17:33:03 +02:00
bat_v_ogm.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bat_v.c
batman-adv: Drop NULL check before dropping references
2021-08-08 20:21:40 +02:00
bat_v.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bitarray.c
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bitarray.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
bridge_loop_avoidance.c
batman-adv: remove unnecessary type castings
2022-04-22 11:23:46 +02:00
bridge_loop_avoidance.h
batman-adv: Remove the repeated declaration
2021-05-30 13:38:27 +02:00
distributed-arp-table.c
batman-adv: Broken sync while rescheduling delayed work
2023-05-26 23:14:49 +02:00
distributed-arp-table.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
fragmentation.c
batman-adv: Don't skb_split skbuffs with frag_list
2022-04-17 23:41:44 +02:00
fragmentation.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
gateway_client.c
batman-adv: Migrate to linux/container_of.h
2022-03-02 09:00:13 +01:00
gateway_client.h
batman-adv: Check ptr for NULL before reducing its refcnt
2021-08-08 20:21:40 +02:00
gateway_common.c
batman-adv: tvlv: prepare for tvlv enabled multicast packet type
2023-01-21 19:01:59 +01:00
gateway_common.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
hard-interface.c
batman-adv: Don't increase MTU when set by user
2023-07-20 08:56:33 +02:00
hard-interface.h
batman-adv: Check ptr for NULL before reducing its refcnt
2021-08-08 20:21:40 +02:00
hash.c
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
hash.h
batman-adv: Fix spelling mistakes
2021-06-02 08:46:03 +02:00
Kconfig
Merge tag 'batadv-next-pullrequest-20210208' of git://git.open-mesh.org/linux-merge
2021-02-08 11:32:40 -08:00
log.c
isystem: ship and use stdarg.h
2021-08-19 09:02:55 +09:00
log.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
main.c
batman-adv: Migrate to linux/container_of.h
2022-03-02 09:00:13 +01:00
main.h
batman-adv: Start new development cycle
2023-01-06 08:42:59 +01:00
Makefile
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
multicast.c
batman-adv: tvlv: prepare for tvlv enabled multicast packet type
2023-01-21 19:01:59 +01:00
multicast.h
batman-adv: mcast: remove now redundant single ucast forwarding
2023-01-21 19:01:59 +01:00
netlink.c
genetlink: introduce split op representation
2022-11-07 12:30:16 +00:00
netlink.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
network-coding.c
batman-adv: tvlv: prepare for tvlv enabled multicast packet type
2023-01-21 19:01:59 +01:00
network-coding.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
originator.c
batman-adv: Migrate to linux/container_of.h
2022-03-02 09:00:13 +01:00
originator.h
batman-adv: Check ptr for NULL before reducing its refcnt
2021-08-08 20:21:40 +02:00
routing.c
batman-adv: tvlv: prepare for tvlv enabled multicast packet type
2023-01-21 19:01:59 +01:00
routing.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
send.c
batman-adv: Migrate to linux/container_of.h
2022-03-02 09:00:13 +01:00
send.h
batman-adv: bcast: queue per interface, if needed
2021-05-17 12:00:44 +02:00
soft-interface.c
batman-adv: Don't increase MTU when set by user
2023-07-20 08:56:33 +02:00
soft-interface.h
batman-adv: Check ptr for NULL before reducing its refcnt
2021-08-08 20:21:40 +02:00
tp_meter.c
batman-adv: Migrate to linux/container_of.h
2022-03-02 09:00:13 +01:00
tp_meter.h
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
trace.c
batman-adv: Drop publication years from copyright info
2021-02-06 09:22:10 +01:00
trace.h
batman-adv: Drop unused headers in trace.h
2022-08-17 12:10:43 +02:00
translation-table.c
batman-adv: Fix TT global entry leak when client roamed back
2023-08-05 08:02:01 +02:00
translation-table.h
batman-adv: Check ptr for NULL before reducing its refcnt
2021-08-08 20:21:40 +02:00
tvlv.c
batman-adv: tvlv: prepare for tvlv enabled multicast packet type
2023-01-21 19:01:59 +01:00
tvlv.h
batman-adv: tvlv: prepare for tvlv enabled multicast packet type
2023-01-21 19:01:59 +01:00
types.h
batman-adv: Don't increase MTU when set by user
2023-07-20 08:56:33 +02:00