mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
d0aa72604fbd80c8aabb46eda00535ed35570f1f
linux/fs
History
Wang Jianjian d0aa72604f quota: Fix potential NULL pointer dereference 
Below race may cause NULL pointer dereference

P1					P2
dquot_free_inode			quota_off
					  drop_dquot_ref
					   remove_dquot_ref
					   dquots = i_dquot(inode)
  dquots = i_dquot(inode)
  srcu_read_lock
  dquots[cnt]) != NULL (1)
					     dquots[type] = NULL (2)
  spin_lock(&dquots[cnt]->dq_dqb_lock) (3)
   ....

If dquot_free_inode(or other routines) checks inode's quota pointers (1)
before quota_off sets it to NULL(2) and use it (3) after that, NULL pointer
dereference will be triggered.

So let's fix it by using a temporary pointer to avoid this issue.

Signed-off-by: Wang Jianjian <wangjianjian3@huawei.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Message-Id: <20240202081852.2514092-1-wangjianjian3@huawei.com>
2024-02-05 15:57:34 +01:00
..
9p
9p: Use length of data written to the server in preference to error
2024-01-04 13:15:31 +00:00
adfs
adfs: remove writepage implementation
2023-12-29 11:58:33 -08:00
affs
affs: d_obtain_alias(ERR_PTR(...)) will do the right thing
2023-12-21 12:51:02 -05:00
afs
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
autofs
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
bcachefs
Merge tag 'bcachefs-2024-01-21' of https://evilpiepirate.org/git/bcachefs
2024-01-21 14:01:12 -08:00
befs
befs: d_obtain_alias(ERR_PTR(...)) will do the right thing
2023-12-21 12:51:02 -05:00
bfs
Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:23:50 -08:00
btrfs
Merge tag 'for-6.8/block-2024-01-08' of git://git.kernel.dk/linux
2024-01-11 13:58:04 -08:00
cachefiles
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
ceph
Merge tag 'ceph-for-6.8-rc1' of https://github.com/ceph/ceph-client
2024-01-19 09:58:55 -08:00
coda
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
configfs
…
cramfs
Merge tag 'vfs-6.7.ctime' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2023-10-30 09:47:13 -10:00
crypto
fscrypt: document that CephFS supports fscrypt now
2023-12-26 22:55:42 -06:00
debugfs
Merge branches 'acpi-pm', 'acpi-video', 'acpi-apei' and 'acpi-extlog'
2024-01-04 13:19:40 +01:00
devpts
fs: Remove the now superfluous sentinel elements from ctl_table array
2023-12-28 04:57:57 -08:00
dlm
dlm: update format header reflect current format
2023-12-20 15:36:48 -06:00
ecryptfs
Merge tag 'pull-rename' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:00:22 -08:00
efivarfs
efivarfs: automatically update super block flag
2023-12-11 11:19:18 +01:00
efs
Merge tag 'vfs-6.7.fsid' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-11-07 12:11:26 -08:00
erofs
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
exfat
exfat: do not zero the extended part
2024-01-08 21:57:22 +09:00
exportfs
fs: fix build error with CONFIG_EXPORTFS=m or not defined
2023-10-28 16:16:19 +02:00
ext2
ext2: Remove GFP_NOFS use in ext2_xattr_cache_insert()
2024-01-23 19:21:11 +01:00
ext4
Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:23:50 -08:00
f2fs
f2fs: fix double free of f2fs_sb_info
2024-01-12 18:55:09 -08:00
fat
Merge tag 'vfs-6.7.fsid' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-11-07 12:11:26 -08:00
freevxfs
freevxfs: lookup: fix function params kernel-doc
2023-12-20 15:02:58 -08:00
fuse
Merge tag 'vfs-6.8.rw' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2024-01-08 11:11:51 -08:00
gfs2
Merge tag 'dlm-6.8' of git://git.kernel.org/pub/scm/linux/kernel/git/teigland/linux-dlm
2024-01-10 10:17:23 -08:00
hfs
hfs: really remove hfs_writepage
2023-12-29 11:58:34 -08:00
hfsplus
Merge tag 'mm-stable-2024-01-08-15-31' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2024-01-09 11:18:47 -08:00
hostfs
hostfs: use d_splice_alias() calling conventions to simplify failure exits
2023-12-21 12:51:00 -05:00
hpfs
…
hugetlbfs
Merge tag 'mm-stable-2024-01-08-15-31' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2024-01-09 11:18:47 -08:00
iomap
mm: add folio_fill_tail() and use it in iomap
2023-12-10 16:51:36 -08:00
isofs
…
jbd2
jbd2: abort journal when detecting metadata writeback error of fs dev
2024-01-04 23:42:21 -05:00
jffs2
jffs2: mark __jffs2_dbg_superblock_counts() static
2023-12-10 17:21:43 -08:00
jfs
jfs: Add missing set_freezable() for freezable kthread
2024-01-02 11:06:52 -06:00
kernfs
Revert "kernfs: convert kernfs_idr_lock to an irq safe raw spinlock"
2024-01-11 11:51:27 +01:00
lockd
Merge tag 'sysctl-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux
2024-01-10 17:44:36 -08:00
minix
Merge tag 'pull-minix' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 19:54:18 -08:00
netfs
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
nfs
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
nfs_common
…
nfsd
Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:23:50 -08:00
nilfs2
Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:23:50 -08:00
nls
…
notify
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
ntfs
Merge tag 'sysctl-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux
2024-01-10 17:44:36 -08:00
ntfs3
Merge tag 'vfs-6.7.fsid' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2023-11-07 12:11:26 -08:00
ocfs2
quota: Set nofs allocation context when acquiring dqio_sem
2024-01-23 19:21:11 +01:00
omfs
…
openpromfs
…
orangefs
orangefs: saner arguments passing in readdir guts
2023-12-21 12:53:36 -05:00
overlayfs
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
proc
Merge tag 'mm-hotfixes-stable-2024-01-12-16-52' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2024-01-17 09:31:36 -08:00
pstore
pstore: inode: Use cleanup.h for struct pstore_private
2023-12-08 14:15:44 -08:00
qnx4
qnx4: Use get_directory_fname() in qnx4_match()
2023-12-13 11:19:18 -08:00
qnx6
…
quota
quota: Fix potential NULL pointer dereference
2024-02-05 15:57:34 +01:00
ramfs
mm, treewide: rename MAX_ORDER to MAX_PAGE_ORDER
2024-01-08 15:27:15 -08:00
reiserfs
Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:23:50 -08:00
romfs
Merge tag 'vfs-6.7.ctime' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2023-10-30 09:47:13 -10:00
smb
Merge tag 'v6.8-rc-part2-smb-client' of git://git.samba.org/sfrench/cifs-2.6
2024-01-20 16:48:07 -08:00
squashfs
Squashfs: fix variable overflow triggered by sysbot
2023-12-10 17:21:26 -08:00
sysfs
fs/sysfs/dir.c : Fix typo in comment
2023-12-07 11:35:23 +09:00
sysv
sysv: remove writepage implementation
2023-12-29 11:58:35 -08:00
tracefs
eventfs: Use kcalloc() instead of kzalloc()
2024-01-16 17:52:33 -05:00
ubifs
ubifs: fix kernel-doc warnings
2024-01-06 23:49:50 +01:00
udf
udf: Remove GFP_NOFS allocation in udf_expand_file_adinicb()
2024-01-23 19:21:10 +01:00
ufs
Merge tag 'mm-stable-2024-01-08-15-31' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2024-01-09 11:18:47 -08:00
unicode
…
vboxsf
fs: vboxsf: fix a kernel-doc warning
2023-12-08 15:32:31 -07:00
verity
Merge tag 'net-next-6.8' of git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next
2024-01-11 10:07:29 -08:00
xfs
Merge tag 'xfs-6.8-merge-4' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
2024-01-19 09:57:08 -08:00
zonefs
Merge tag 'pull-misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:23:50 -08:00
aio.c
Merge tag 'sysctl-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux
2024-01-10 17:44:36 -08:00
anon_inodes.c
Merge branch 'kvm-guestmemfd' into HEAD
2023-11-14 08:31:31 -05:00
attr.c
fs: fix doc comment typo fs tree wide
2023-12-21 13:17:54 +01:00
backing-file.c
fs: factor out backing_file_mmap() helper
2023-12-23 16:35:09 +02:00
bad_inode.c
…
binfmt_elf_fdpic.c
Merge tag 'execve-v6.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2023-10-30 19:28:19 -10:00
binfmt_elf_test.c
…
binfmt_elf.c
…
binfmt_flat.c
…
binfmt_misc.c
Merge tag 'execve-v6.7-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux
2023-10-30 19:28:19 -10:00
binfmt_script.c
…
buffer.c
Merge tag 'mm-stable-2024-01-08-15-31' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2024-01-09 11:18:47 -08:00
char_dev.c
Merge tag 'mm-nonmm-stable-2023-11-02-14-08' of git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm
2023-11-02 20:53:31 -10:00
compat_binfmt_elf.c
…
coredump.c
fs: Remove the now superfluous sentinel elements from ctl_table array
2023-12-28 04:57:57 -08:00
d_path.c
…
dax.c
fs : Fix warning using plain integer as NULL
2023-11-18 15:00:01 +01:00
dcache.c
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
direct-io.c
fs : Fix warning using plain integer as NULL
2023-11-18 15:00:01 +01:00
drop_caches.c
…
eventfd.c
eventfd: Remove usage of the deprecated ida_simple_xx() API
2023-12-12 14:24:55 +01:00
eventpoll.c
fs: Remove the now superfluous sentinel elements from ctl_table array
2023-12-28 04:57:57 -08:00
exec.c
execve: open the executable file before doing anything else
2024-01-20 12:15:43 -08:00
fcntl.c
…
fhandle.c
exportfs: add helpers to check if filesystem can encode/decode file handles
2023-10-24 17:57:45 +02:00
file_table.c
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
file.c
file: remove __receive_fd()
2023-12-12 14:24:14 +01:00
filesystems.c
…
fs_context.c
…
fs_parser.c
…
fs_pin.c
…
fs_struct.c
…
fs_types.c
…
fs-writeback.c
netfs: Move pinning-for-writeback from fscache to netfs
2023-12-24 15:08:49 +00:00
fsopen.c
…
init.c
…
inode.c
Merge tag 'pull-rename' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:00:22 -08:00
internal.h
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
ioctl.c
lsm: new security_file_ioctl_compat() hook
2023-12-24 15:48:03 -05:00
Kconfig
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
Kconfig.binfmt
…
kernel_read_file.c
…
libfs.c
Merge tag 'pull-dcache' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-11 20:11:35 -08:00
locks.c
fs: Remove the now superfluous sentinel elements from ctl_table array
2023-12-28 04:57:57 -08:00
Makefile
Merge tag 'vfs-6.8.netfs' of gitolite.kernel.org:pub/scm/linux/kernel/git/vfs/vfs
2024-01-19 09:10:23 -08:00
mbcache.c
…
mnt_idmapping.c
mnt_idmapping: decouple from namespaces
2023-11-28 14:08:47 +01:00
mount.h
mounts: keep list of mounts in an rbtree
2023-11-18 14:56:16 +01:00
mpage.c
fs: convert block_write_full_page to block_write_full_folio
2023-12-29 11:58:35 -08:00
namei.c
Merge tag 'pull-bcachefs-fix' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2024-01-12 18:04:01 -08:00
namespace.c
fs: rework listmount() implementation
2024-01-13 13:06:25 +01:00
nsfs.c
nsfs: use d_make_root()
2023-11-25 02:49:43 -05:00
open.c
Merge tag 'vfs-6.8.rw' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2024-01-08 11:11:51 -08:00
pipe.c
Merge tag 'sysctl-6.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux
2024-01-10 17:44:36 -08:00
pnode.c
mounts: keep list of mounts in an rbtree
2023-11-18 14:56:16 +01:00
pnode.h
…
posix_acl.c
fs: fix doc comment typo fs tree wide
2023-12-21 13:17:54 +01:00
proc_namespace.c
namespace: extract show_path() helper
2023-11-18 14:56:16 +01:00
read_write.c
fsnotify: optionally pass access range in file permission hooks
2023-12-12 16:20:02 +01:00
readdir.c
fsnotify: optionally pass access range in file permission hooks
2023-12-12 16:20:02 +01:00
remap_range.c
fsnotify: optionally pass access range in file permission hooks
2023-12-12 16:20:02 +01:00
select.c
…
seq_file.c
…
signalfd.c
…
splice.c
fs: use splice_copy_file_range() inline helper
2023-12-12 16:20:02 +01:00
stack.c
…
stat.c
Merge tag 'vfs-6.8.mount' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
2024-01-08 10:57:34 -08:00
statfs.c
…
super.c
Merge tag 'fscrypt-for-linus' of git://git.kernel.org/pub/scm/fs/fscrypt/linux
2024-01-10 10:24:49 -08:00
sync.c
…
sysctls.c
fs: Remove the now superfluous sentinel elements from ctl_table array
2023-12-28 04:57:57 -08:00
timerfd.c
…
userfaultfd.c
Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm
2024-01-17 13:03:37 -08:00
utimes.c
…
xattr.c
…