Gaosheng Cui
387659939c
drm/ttm: fix undefined behavior in bit shift for TTM_TT_FLAG_PRIV_POPULATED
Shifting signed 32-bit value by 31 bits is undefined, so changing
significant bit to unsigned. The UBSAN warning calltrace like below:
UBSAN: shift-out-of-bounds in ./include/drm/ttm/ttm_tt.h:122:26
left shift of 1 by 31 places cannot be represented in type 'int'
Call Trace:
<TASK>
dump_stack_lvl+0x7d/0xa5
dump_stack+0x15/0x1b
ubsan_epilogue+0xe/0x4e
__ubsan_handle_shift_out_of_bounds+0x1e7/0x20c
ttm_bo_move_memcpy+0x3b4/0x460 [ttm]
bo_driver_move+0x32/0x40 [drm_vram_helper]
ttm_bo_handle_move_mem+0x118/0x200 [ttm]
ttm_bo_validate+0xfa/0x220 [ttm]
drm_gem_vram_pin_locked+0x70/0x1b0 [drm_vram_helper]
drm_gem_vram_pin+0x48/0xb0 [drm_vram_helper]
drm_gem_vram_plane_helper_prepare_fb+0x53/0xe0 [drm_vram_helper]
drm_gem_vram_simple_display_pipe_prepare_fb+0x26/0x30 [drm_vram_helper]
drm_simple_kms_plane_prepare_fb+0x4d/0xe0 [drm_kms_helper]
drm_atomic_helper_prepare_planes+0xda/0x210 [drm_kms_helper]
drm_atomic_helper_commit+0xc3/0x1e0 [drm_kms_helper]
drm_atomic_commit+0x9c/0x160 [drm]
drm_client_modeset_commit_atomic+0x33a/0x380 [drm]
drm_client_modeset_commit_locked+0x77/0x220 [drm]
drm_client_modeset_commit+0x31/0x60 [drm]
__drm_fb_helper_restore_fbdev_mode_unlocked+0xa7/0x170 [drm_kms_helper]
drm_fb_helper_set_par+0x51/0x90 [drm_kms_helper]
fbcon_init+0x316/0x790
visual_init+0x113/0x1d0
do_bind_con_driver+0x2a3/0x5c0
do_take_over_console+0xa9/0x270
do_fbcon_takeover+0xa1/0x170
do_fb_registered+0x2a8/0x340
fbcon_fb_registered+0x47/0xe0
register_framebuffer+0x294/0x4a0
__drm_fb_helper_initial_config_and_unlock+0x43c/0x880 [drm_kms_helper]
drm_fb_helper_initial_config+0x52/0x80 [drm_kms_helper]
drm_fbdev_client_hotplug+0x156/0x1b0 [drm_kms_helper]
drm_fbdev_generic_setup+0xfc/0x290 [drm_kms_helper]
bochs_pci_probe+0x6ca/0x772 [bochs]
local_pci_probe+0x4d/0xb0
pci_device_probe+0x119/0x320
really_probe+0x181/0x550
__driver_probe_device+0xc6/0x220
driver_probe_device+0x32/0x100
__driver_attach+0x195/0x200
bus_for_each_dev+0xbb/0x120
driver_attach+0x27/0x30
bus_add_driver+0x22e/0x2f0
driver_register+0xa9/0x190
__pci_register_driver+0x90/0xa0
bochs_pci_driver_init+0x52/0x1000 [bochs]
do_one_initcall+0x76/0x430
do_init_module+0x61/0x28a
load_module+0x1f82/0x2e50
__do_sys_finit_module+0xf8/0x190
__x64_sys_finit_module+0x23/0x30
do_syscall_64+0x58/0x80
entry_SYSCALL_64_after_hwframe+0x63/0xcd
</TASK>
Fixes: 3312be8f6f ("drm/ttm: move populated state into page flags")
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221031113350.4180975-1-cuigaosheng1@huawei.com
Signed-off-by: Christian König <christian.koenig@amd.com>
2022-11-02 10:23:07 +01:00
..
2022-04-19 18:23:48 +02:00
2022-09-12 19:17:41 +10:00
2022-11-02 10:23:07 +01:00
2021-10-04 15:23:01 -04:00
2021-07-01 11:11:55 +02:00
2022-10-08 15:26:55 +02:00
2022-10-10 13:55:47 +02:00
2022-05-02 09:01:51 +02:00
2022-06-09 16:09:46 +02:00
2020-10-09 16:46:04 +02:00
2021-07-29 09:12:01 +02:00
2022-07-21 12:15:56 +02:00
2022-02-23 10:44:43 +01:00
2022-06-03 20:09:27 +08:00
2022-02-07 16:35:35 -08:00
2022-10-26 09:53:24 +03:00
2022-10-13 09:17:05 +02:00
2022-07-13 10:46:05 +02:00
2021-07-27 12:21:22 +02:00
2021-11-30 09:41:28 +01:00
2022-05-13 18:55:13 +03:00
2021-12-02 11:12:39 +01:00
2022-10-26 09:53:56 +03:00
2022-07-05 21:15:23 +03:00
2022-07-13 10:46:05 +02:00
2022-08-03 18:31:49 +02:00
2022-07-05 21:14:02 +03:00
2022-08-04 11:39:27 -04:00
2022-09-12 09:15:49 +02:00
2022-07-09 15:00:08 +02:00
2022-07-09 15:58:52 +02:00
2022-02-07 16:35:35 -08:00
2022-08-03 18:32:27 +02:00
2022-05-19 19:25:02 +02:00
2022-07-21 12:16:10 +02:00
2022-02-07 16:35:35 -08:00
2022-02-07 16:35:35 -08:00
2022-10-18 15:00:03 +02:00
2021-08-13 17:50:48 +02:00
2021-11-30 09:41:28 +01:00
2022-05-05 09:04:10 +02:00
2022-09-12 09:14:26 +02:00
2022-09-28 11:35:25 +10:00
2021-12-09 13:46:13 +01:00
2022-10-19 21:46:16 -04:00
2022-02-25 17:55:42 +01:00
2022-09-12 09:14:59 +02:00
2022-04-06 15:23:08 +02:00
2022-01-20 14:41:25 +02:00
2022-01-19 18:40:18 +01:00
2022-06-12 16:07:05 +02:00
2022-09-18 09:38:06 -07:00
2022-09-20 09:42:31 +02:00
2022-09-20 09:41:06 +02:00
2022-02-07 16:35:35 -08:00
2022-09-24 15:02:02 +02:00
2021-10-14 13:12:25 +02:00
2022-01-10 12:17:37 +01:00
2021-10-14 13:12:24 +02:00
2022-09-12 09:14:26 +02:00
2021-07-26 10:08:22 +02:00
2022-06-27 13:45:48 +02:00
2021-08-08 20:14:08 +02:00
2021-11-02 14:27:06 +01:00
2021-02-10 12:38:55 +01:00
2021-06-11 10:53:18 +02:00
2022-05-02 02:12:59 +03:00
2022-09-30 09:12:08 -04:00
2021-10-04 12:06:14 +02:00
2021-10-04 13:09:53 -04:00
2022-03-17 20:06:04 +02:00
2022-04-25 11:19:36 +02:00
2022-08-26 05:46:23 -07:00
2021-10-04 13:09:53 -04:00
2022-06-22 15:52:55 -07:00