mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
d36a9ea5e7766961e753ee38d4c331bbe6ef659b
linux/block
History
Ming Lei d36a9ea5e7 block: fix use-after-free of q->q_usage_counter 
For blk-mq, queue release handler is usually called after
blk_mq_freeze_queue_wait() returns. However, the
q_usage_counter->release() handler may not be run yet at that time, so
this can cause a use-after-free.

Fix the issue by moving percpu_ref_exit() into blk_free_queue_rcu().
Since ->release() is called with rcu read lock held, it is agreed that
the race should be covered in caller per discussion from the two links.

Reported-by: Zhang Wensheng <zhangwensheng@huaweicloud.com>
Reported-by: Zhong Jinghua <zhongjinghua@huawei.com>
Link: https://lore.kernel.org/linux-block/Y5prfOjyyjQKUrtH@T590/T/#u
Link: https://lore.kernel.org/lkml/Y4%2FmzMd4evRg9yDi@fedora/
Cc: Hillf Danton <hdanton@sina.com>
Cc: Yu Kuai <yukuai3@huawei.com>
Cc: Dennis Zhou <dennis@kernel.org>
Fixes: 2b0d3d3e4f ("percpu_ref: reduce memory footprint of percpu_ref in fast path")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20221215021629.74870-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2022-12-15 05:23:11 -07:00
..
partitions
block: don't add partitions if GD_SUPPRESS_PART_SCAN is set
2022-09-03 11:29:03 -06:00
badblocks.c
block/badblocks: Remove redundant assignments
2022-04-23 07:15:26 -06:00
bdev.c
block: bdev & blktrace: use consistent function doc. notation
2022-12-01 09:16:46 -07:00
bfq-cgroup.c
block, bfq: replace 0/1 with false/true in bic apis
2022-12-14 09:51:11 -07:00
bfq-iosched.c
block, bfq: only do counting of pending-request for BFQ_GROUP_IOSCHED
2022-12-15 05:11:59 -07:00
bfq-iosched.h
block, bfq: only do counting of pending-request for BFQ_GROUP_IOSCHED
2022-12-15 05:11:59 -07:00
bfq-wf2q.c
block, bfq: only do counting of pending-request for BFQ_GROUP_IOSCHED
2022-12-15 05:11:59 -07:00
bio-integrity.c
block: pass struct queue_limits to the bio splitting helpers
2022-08-02 21:08:53 -06:00
bio.c
block: bio_copy_data_iter
2022-12-06 10:18:27 -07:00
blk-cgroup-fc-appid.c
cgroup: Homogenize cgroup_get_from_id() return value
2022-08-26 10:57:41 -10:00
blk-cgroup-rwstat.c
…
blk-cgroup-rwstat.h
block: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
blk-cgroup.c
blk-iolatency: Fix memory leak on add_disk() failures
2022-12-14 12:42:55 -07:00
blk-cgroup.h
blk-cgroup: Optimize blkcg_rstat_flush()
2022-11-16 16:58:44 -07:00
blk-core.c
block: fix use-after-free of q->q_usage_counter
2022-12-15 05:23:11 -07:00
blk-crypto-fallback.c
treewide: use get_random_bytes() when possible
2022-10-11 17:42:58 -06:00
blk-crypto-internal.h
blk-crypto: pass a gendisk to blk_crypto_sysfs_{,un}register
2022-11-30 11:09:00 -07:00
blk-crypto-profile.c
blk-crypto: Add a missing include directive
2022-11-23 10:38:54 -07:00
blk-crypto-sysfs.c
block: untangle request_queue refcounting from sysfs
2022-11-30 11:09:00 -07:00
blk-crypto.c
Merge tag 'for-6.2/block-2022-12-08' of git://git.kernel.dk/linux
2022-12-13 10:43:59 -08:00
blk-flush.c
block: change request end_io handler to pass back a return value
2022-09-30 07:49:09 -06:00
blk-ia-ranges.c
block: untangle request_queue refcounting from sysfs
2022-11-30 11:09:00 -07:00
blk-integrity.c
blk-crypto: remove blk_crypto_unregister()
2021-11-29 06:38:51 -07:00
blk-ioc.c
block: fix default IO priority handling again
2022-06-27 06:29:12 -06:00
blk-iocost.c
block/blk-iocost (gcc13): keep large values in a new enum
2022-12-14 09:56:10 -07:00
blk-iolatency.c
block: Replace struct rq_depth with unsigned int in struct iolatency_grp
2022-11-01 09:12:24 -06:00
blk-ioprio.c
blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit
2022-09-26 19:09:31 -06:00
blk-ioprio.h
blk-ioprio: pass a gendisk to blk_ioprio_init and blk_ioprio_exit
2022-09-26 19:09:31 -06:00
blk-lib.c
blk-lib: fix blkdev_issue_secure_erase
2022-09-15 00:25:17 -06:00
blk-map.c
block: set FOLL_PCI_P2PDMA in bio_map_user_iov()
2022-11-09 11:29:21 -07:00
blk-merge.c
block: Micro-optimize get_max_segment_size()
2022-10-25 13:41:20 -06:00
blk-mq-cpumap.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-debugfs-zoned.c
block: move zone related fields to struct gendisk
2022-07-06 06:46:26 -06:00
blk-mq-debugfs.c
Merge tag 'for-6.1/block-2022-10-03' of git://git.kernel.dk/linux
2022-10-07 09:19:14 -07:00
blk-mq-debugfs.h
block: remove per-disk debugfs files in blk_unregister_queue
2022-06-17 07:31:05 -06:00
blk-mq-pci.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-rdma.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq-sched.c
block: split elevator_switch
2022-11-01 09:12:24 -06:00
blk-mq-sched.h
block: move blk_mq_sched_assign_ioc to blk-ioc.c
2021-11-29 06:41:29 -07:00
blk-mq-sysfs.c
blk-mq: fix possible memleak when register 'hctx' failed
2022-11-25 06:34:03 -07:00
blk-mq-tag.c
sbitmap: fix batched wait_cnt accounting
2022-09-12 00:10:34 -06:00
blk-mq-tag.h
blk-mq: blk_mq_tag_busy is no need to return a value
2022-06-27 06:29:12 -06:00
blk-mq-virtio.c
block: Change the return type of blk_mq_map_queues() into void
2022-08-22 10:07:53 -06:00
blk-mq.c
Merge tag 'for-6.2/block-2022-12-08' of git://git.kernel.dk/linux
2022-12-13 10:43:59 -08:00
blk-mq.h
blk-mq: move the srcu_struct used for quiescing to the tagset
2022-11-02 08:35:34 -06:00
blk-pm.c
scsi: block: pm: Always set request queue runtime active in blk_post_runtime_resume()
2021-12-22 23:38:29 -05:00
blk-pm.h
…
blk-rq-qos.c
block/rq_qos: Use atomic_try_cmpxchg in atomic_inc_below
2022-07-12 14:38:52 -06:00
blk-rq-qos.h
block/blk-rq-qos: delete useless enmu RQ_QOS_IOPRIO
2022-09-21 19:50:53 -06:00
blk-settings.c
Merge tag 'for-6.2/block-2022-12-08' of git://git.kernel.dk/linux
2022-12-13 10:43:59 -08:00
blk-stat.c
block: make queue stat accounting a reference
2021-12-14 17:23:05 -07:00
blk-stat.h
block: make queue stat accounting a reference
2021-12-14 17:23:05 -07:00
blk-sysfs.c
block: untangle request_queue refcounting from sysfs
2022-11-30 11:09:00 -07:00
blk-throttle.c
blk-throttle: Use more suitable time_after check for update of slice_start
2022-12-05 13:45:31 -07:00
blk-throttle.h
blk-throttle: pass a gendisk to blk_throtl_cancel_bios
2022-09-26 19:17:28 -06:00
blk-timeout.c
…
blk-wbt.c
blk-wbt: don't enable throttling if default elevator is bfq
2022-10-23 18:59:17 -06:00
blk-wbt.h
blk-wbt: don't show valid wbt_lat_usec in sysfs while wbt is disabled
2022-10-23 18:59:17 -06:00
blk-zoned.c
block: adapt blk_mq_plug() to not plug for writes that require a zone lock
2022-09-29 07:45:47 -06:00
blk.h
Merge tag 'for-6.2/block-2022-12-08' of git://git.kernel.dk/linux
2022-12-13 10:43:59 -08:00
bounce.c
block: change the blk_queue_bounce calling convention
2022-08-02 17:22:54 -06:00
bsg-lib.c
blk-mq: move the call to blk_put_queue out of blk_mq_destroy_queue
2022-10-25 08:25:10 -06:00
bsg.c
block: untangle request_queue refcounting from sysfs
2022-11-30 11:09:00 -07:00
disk-events.c
block: remove genhd.h
2022-02-02 07:49:59 -07:00
elevator.c
block: untangle request_queue refcounting from sysfs
2022-11-30 11:09:00 -07:00
elevator.h
block: add proper helpers for elevator_type module refcount management
2022-10-23 18:59:17 -06:00
fops.c
block: remove blkdev_writepages
2022-11-16 11:32:53 -07:00
genhd.c
Merge tag 'for-6.2/block-2022-12-08' of git://git.kernel.dk/linux
2022-12-13 10:43:59 -08:00
holder.c
block: don't allow a disk link holder to itself
2022-11-16 15:19:56 -07:00
ioctl.c
block: Do not reread partition table on exclusively open device
2022-12-01 07:44:03 -07:00
ioprio.c
block: Fix handling of tasks without ioprio in ioprio_get(2)
2022-06-27 06:29:12 -06:00
Kconfig
block: remove "select BLK_RQ_IO_DATA_LEN" from BLK_CGROUP_IOCOST dependency
2022-06-29 08:35:57 -06:00
Kconfig.iosched
block: only build the icq tracking code when needed
2021-12-16 10:59:02 -07:00
kyber-iosched.c
block/kyber: Use the new blk_opf_t type
2022-07-14 12:14:30 -06:00
Makefile
blk-cgroup: move blkcg_{get,set}_fc_appid out of line
2022-05-02 14:06:20 -06:00
mq-deadline.c
block: mq-deadline: Rename deadline_is_seq_writes()
2022-11-28 19:27:45 -07:00
opal_proto.h
block: sed-opal: Add ioctl to return device status
2022-08-22 07:52:51 -06:00
sed-opal.c
Merge tag 'for-6.2/block-2022-12-08' of git://git.kernel.dk/linux
2022-12-13 10:43:59 -08:00
t10-pi.c
block: add pi for extended integrity
2022-03-07 12:48:35 -07:00