Files
linux/drivers
Xuan Zhuo d5c0ed17fe virtio: packed: fix unmap leak for indirect desc table
When use_dma_api and premapped are true, then the do_unmap is false.

Because the do_unmap is false, vring_unmap_extra_packed is not called by
detach_buf_packed.

  if (unlikely(vq->do_unmap)) {
                curr = id;
                for (i = 0; i < state->num; i++) {
                        vring_unmap_extra_packed(vq,
                                                 &vq->packed.desc_extra[curr]);
                        curr = vq->packed.desc_extra[curr].next;
                }
  }

So the indirect desc table is not unmapped. This causes the unmap leak.

So here, we check vq->use_dma_api instead. Synchronously, dma info is
updated based on use_dma_api judgment

This bug does not occur, because no driver use the premapped with
indirect.

Fixes: b319940f83 ("virtio_ring: skip unmap for premapped")
Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com>
Message-Id: <20240223071833.26095-1-xuanzhuo@linux.alibaba.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2024-03-19 03:19:22 -04:00
..
2024-02-06 14:10:47 +08:00
2024-02-16 18:51:00 -05:00
2024-03-08 13:40:56 +10:00
2024-03-03 02:32:35 +00:00
2023-12-15 17:07:05 +01:00
2024-02-05 16:16:24 +01:00
2024-01-05 15:55:41 +05:30
2023-12-15 17:27:04 +01:00
2024-01-04 17:03:47 +01:00
2024-01-12 12:38:37 +01:00