Vladimir Oltean a721c3e54b
net/sched: taprio: allow per-TC user input of FP adminStatus ...
This is a duplication of the FP adminStatus logic introduced for
tc-mqprio. Offloading is done through the tc_mqprio_qopt_offload
structure embedded within tc_taprio_qopt_offload. So practically, if a
device driver is written to treat the mqprio portion of taprio just like
standalone mqprio, it gets unified handling of frame preemption.
I would have reused more code with taprio, but this is mostly netlink
attribute parsing, which is hard to transform into generic code without
having something that stinks as a result. We have the same variables
with the same semantics, just different nlattr type values
(TCA_MQPRIO_TC_ENTRY=5 vs TCA_TAPRIO_ATTR_TC_ENTRY=12;
TCA_MQPRIO_TC_ENTRY_FP=2 vs TCA_TAPRIO_TC_ENTRY_FP=3, etc) and
consequently, different policies for the nest.
Every time nla_parse_nested() is called, an on-stack table "tb" of
nlattr pointers is allocated statically, up to the maximum understood
nlattr type. That array size is hardcoded as a constant, but when
transforming this into a common parsing function, it would become either
a VLA (which the Linux kernel rightfully doesn't like) or a call to the
allocator.
Having FP adminStatus in tc-taprio can be seen as addressing the 802.1Q
Annex S.3 "Scheduling and preemption used in combination, no HOLD/RELEASE"
and S.4 "Scheduling and preemption used in combination with HOLD/RELEASE"
use cases. HOLD and RELEASE events are emitted towards the underlying
MAC Merge layer when the schedule hits a Set-And-Hold-MAC or a
Set-And-Release-MAC gate operation. So within the tc-taprio UAPI space,
one can distinguish between the 2 use cases by choosing whether to use
the TC_TAPRIO_CMD_SET_AND_HOLD and TC_TAPRIO_CMD_SET_AND_RELEASE gate
operations within the schedule, or just TC_TAPRIO_CMD_SET_GATES.
A small part of the change is dedicated to refactoring the max_sdu
nlattr parsing to put all logic under the "if" that tests for presence
of that nlattr.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com >
Reviewed-by: Ferenc Fejes <fejes@inf.elte.hu >
Reviewed-by: Simon Horman <simon.horman@corigine.com >
Signed-off-by: Jakub Kicinski <kuba@kernel.org >
2023-04-13 22:22:10 -07:00
2023-01-19 17:14:18 +01:00
2021-12-21 15:09:46 -08:00
2022-09-15 09:08:09 +02:00
2021-09-13 14:51:10 -05:00
2022-12-07 17:58:47 +01:00
2022-11-17 22:49:39 +01:00
2022-09-21 18:42:55 +01:00
2022-06-28 21:26:05 +02:00
2023-03-30 22:20:09 +02:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2022-08-09 19:51:05 +02:00
2021-10-02 15:50:45 -04:00
2022-06-28 21:26:05 +02:00
2022-04-19 13:13:47 +01:00
2023-03-30 23:24:24 -07:00
2023-02-06 13:46:42 +01:00
2022-04-29 14:38:03 -07:00
2022-11-23 19:55:22 +01:00
2022-05-13 10:56:10 +02:00
2021-11-01 13:36:08 +00:00
2022-11-04 16:56:41 +01:00
2022-08-11 10:31:19 -07:00
2022-12-22 18:18:37 -08:00
2022-10-31 07:29:47 -04:00
2022-12-27 12:52:10 +01:00
2023-01-21 19:01:59 +01:00
2022-06-28 21:26:05 +02:00
2023-04-11 18:05:43 +02:00
2022-06-07 10:20:42 -07:00
2022-12-05 18:00:58 +01:00
2023-03-06 19:28:19 +01:00
2022-05-18 00:11:18 +08:00
2022-09-15 09:08:09 +02:00
2022-11-05 01:25:57 -04:00
2022-05-15 18:31:28 -06:00
2022-09-24 08:50:04 +02:00
2022-09-24 08:50:04 +02:00
2021-11-26 16:48:59 +01:00
2022-06-28 21:26:05 +02:00
2022-09-30 14:32:35 +02:00
2023-02-10 17:54:45 -08:00
2022-01-26 14:49:46 +01:00
2022-06-28 21:26:05 +02:00
2023-01-20 09:33:22 +00:00
2022-12-07 20:09:18 -08:00
2021-10-18 12:28:53 -07:00
2022-08-23 14:54:54 -05:00
2022-08-02 19:50:47 -07:00
2022-06-28 21:26:05 +02:00
2022-06-20 18:21:25 +02:00
2022-08-29 15:32:13 +02:00
2022-06-03 20:09:27 +08:00
2023-03-01 09:27:00 -08:00
2023-03-27 19:49:58 -07:00
2023-01-23 12:44:18 +00:00
2022-11-21 07:45:29 -07:00
2022-11-28 12:46:23 -08:00
2023-02-07 12:53:53 +01:00
2022-04-04 08:55:23 +02:00
2023-01-18 17:12:37 -08:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2023-03-16 21:20:32 -07:00
2022-06-28 21:26:05 +02:00
2022-12-01 19:58:50 -08:00
2022-02-21 19:38:17 +10:30
2022-02-17 09:09:37 +01:00
2023-01-26 17:10:38 +01:00
2021-10-07 13:51:11 +02:00
2022-08-10 13:49:50 +01:00
2022-05-04 11:06:13 +02:00
2023-02-16 13:50:50 +01:00
2022-03-11 08:28:05 -08:00
2022-09-20 11:53:32 +01:00
2022-02-18 13:08:18 +00:00
2021-11-15 07:53:10 -08:00
2021-11-15 07:53:10 -08:00
2022-11-14 03:56:37 +05:30
2022-02-18 21:20:06 -08:00
2022-10-28 12:36:34 +08:00
2022-06-28 21:26:05 +02:00
2021-07-29 15:06:50 +01:00
2023-03-17 08:05:49 +00:00
2022-09-15 09:08:09 +02:00
2023-03-29 09:03:32 +01:00
2022-08-18 20:37:35 -07:00
2023-02-01 20:54:27 -08:00
2022-06-28 21:26:05 +02:00
2022-12-12 09:29:56 +00:00
2022-03-11 08:28:27 -08:00
2022-06-28 21:26:05 +02:00
2021-07-21 08:14:33 -07:00
2023-01-25 22:45:00 -08:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2022-11-22 17:50:36 -08:00
2022-07-17 07:52:46 -07:00
2023-02-21 11:07:23 -08:00
2021-07-21 08:14:33 -07:00
2022-02-04 20:24:45 -08:00
2023-01-06 19:22:53 -08:00
2022-02-28 13:25:48 +01:00
2022-11-30 20:16:49 -04:00
2021-08-18 07:23:15 -06:00
2022-06-28 21:26:05 +02:00
2023-02-06 09:01:00 +00:00
2022-10-17 09:51:26 -05:00
2021-10-05 06:54:16 -05:00
2023-02-06 09:01:00 +00:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2022-06-28 21:26:05 +02:00
2023-01-19 16:28:57 +01:00
2022-06-03 20:09:27 +08:00
2022-07-12 16:50:44 -04:00
2022-01-11 15:44:27 -05:00
2021-06-17 14:25:39 -04:00
2023-02-15 12:35:26 -05:00
2022-09-20 09:13:38 +02:00
2022-10-19 09:01:44 +02:00
2022-05-25 09:51:36 -07:00
2022-07-08 10:46:53 -07:00
2022-05-10 06:30:05 -06:00
2022-08-29 10:44:08 +02:00
2022-08-02 12:34:03 -04:00
2021-10-21 23:36:28 +02:00
2022-02-09 12:00:11 +00:00
2023-02-13 11:12:31 +00:00
2023-01-04 14:59:25 +01:00
2022-04-24 08:27:37 +01:00
2023-01-07 11:29:29 +01:00
2023-01-18 17:12:37 -08:00
2021-09-03 09:58:17 -07:00
2022-06-28 21:26:05 +02:00
2022-01-11 18:45:02 -08:00
2021-07-26 14:45:18 +02:00
2022-12-01 20:06:06 -08:00
2022-02-19 16:05:54 +00:00
2021-06-30 15:34:04 -06:00
2022-06-28 21:26:05 +02:00
2022-11-03 20:46:32 -07:00
2022-06-28 21:26:05 +02:00
2022-12-08 19:49:21 -08:00
2021-06-18 13:02:45 -07:00
2023-03-16 21:20:32 -07:00
2022-09-07 16:46:03 +02:00
2022-11-18 18:36:54 -08:00
2021-12-27 14:58:37 +00:00
2022-02-25 18:50:12 -05:00
2022-03-13 12:59:35 -04:00
2021-09-14 11:11:20 +02:00
2021-10-21 17:25:17 +02:00
2023-03-30 12:02:59 +02:00
2022-05-20 06:17:33 -06:00
2022-02-27 10:58:04 -08:00
2022-12-09 10:43:46 +00:00
2023-02-14 14:12:54 -08:00
2021-07-06 10:37:46 -05:00
2023-02-07 11:52:00 +00:00
2021-12-23 09:32:51 +01:00
2021-12-27 17:12:58 +01:00
2022-09-20 09:13:38 +02:00
2023-04-13 22:22:10 -07:00
2023-01-04 14:44:13 -07:00
2022-12-01 03:22:20 +00:00
2023-02-02 22:33:24 -08:00
2023-01-06 17:12:39 +00:00
2022-03-18 09:44:19 -05:00
2022-06-28 21:26:05 +02:00
2022-02-17 09:09:38 +01:00
2021-12-10 17:10:55 -08:00
2022-05-09 14:00:07 +02:00
2022-09-24 08:31:54 +02:00
2022-06-28 21:26:05 +02:00
2023-01-06 19:28:01 -08:00
2022-03-13 11:49:53 -05:00
2022-12-27 12:52:12 +01:00
2022-03-23 19:58:40 +01:00
2023-03-16 21:25:45 -07:00
2023-03-09 11:31:44 +01:00
2022-05-03 14:11:58 -07:00
2023-02-17 06:15:53 -07:00
2022-08-03 16:29:08 -07:00
2022-09-20 12:33:22 +02:00
2022-06-28 21:26:05 +02:00
2023-02-08 13:10:15 +01:00
2023-01-19 15:01:20 +01:00
2022-11-03 03:43:05 +01:00
2022-04-07 16:47:12 +02:00
2022-02-02 07:42:41 -08:00
2022-07-18 11:19:17 +01:00
2023-01-26 10:52:18 +01:00
2022-06-01 16:48:05 -07:00
2022-01-08 17:41:00 +09:00
2022-09-11 19:47:04 -05:00
2022-03-31 13:04:44 -07:00
2022-06-28 21:26:05 +02:00
2022-11-09 14:06:51 +01:00
2022-06-30 13:14:35 +02:00
2022-06-28 21:26:05 +02:00
2022-06-01 15:55:25 -07:00
2022-10-28 10:47:42 +01:00
2022-11-17 11:04:23 -08:00
2022-04-26 10:17:03 +02:00
2022-02-03 19:50:49 +01:00
2022-04-06 13:48:02 +01:00
2022-09-27 17:29:09 -07:00
2022-06-27 16:25:41 +02:00
2022-05-25 10:08:59 -07:00
2023-01-29 15:18:34 -07:00
2022-06-28 21:26:05 +02:00
2022-08-31 09:07:53 +02:00
2022-09-11 20:25:48 -07:00
2023-01-31 15:57:19 +01:00
2023-01-15 23:45:15 +02:00
2022-12-07 17:58:46 +01:00
2023-01-22 09:54:31 +01:00
2022-12-07 17:58:46 +01:00
2022-12-07 17:58:46 +01:00
2023-01-22 09:38:20 +01:00
2022-12-28 05:09:46 -05:00
2022-08-11 04:26:08 -04:00
2022-07-11 09:54:37 +02:00
2023-02-09 11:39:14 -07:00
2023-02-20 19:26:56 -05:00
2023-02-20 19:26:56 -05:00
2023-01-20 17:46:00 +02:00
2022-06-28 21:26:05 +02:00
2023-04-04 11:01:57 -04:00
2022-12-12 14:19:23 -08:00
2022-08-11 04:06:40 -04:00
2022-03-28 16:52:58 -04:00
2021-11-04 16:36:54 +01:00
2021-09-29 09:22:29 +02:00
2021-11-01 05:26:48 -04:00
2022-05-10 07:22:28 -04:00
2021-12-06 15:03:05 +01:00
2021-11-10 15:32:38 +01:00
2023-03-13 16:32:16 -07:00
2022-08-11 04:06:40 -04:00
2021-08-26 22:28:03 +02:00
2022-08-16 01:40:24 -04:00
2021-08-05 10:24:08 +01:00
2021-09-05 16:23:09 -04:00
2021-10-08 16:21:53 +01:00
2022-12-05 10:30:47 +01:00
a721c3e54b