Files
linux/include/asm-mips
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
2007-10-11 23:46:07 +01:00
2007-10-11 23:46:07 +01:00
2007-10-11 23:46:07 +01:00
2008-01-29 10:14:58 +00:00
2007-10-11 23:46:07 +01:00
2007-10-11 23:46:07 +01:00
2007-10-11 23:46:07 +01:00
2007-10-11 23:46:07 +01:00
2007-10-11 23:46:07 +01:00
2008-02-03 16:57:20 +02:00
2008-02-03 16:57:20 +02:00
2008-07-15 18:44:36 +01:00
2007-02-18 21:31:35 +00:00
2005-09-07 16:57:21 -07:00
2005-10-29 19:30:34 +01:00
2007-04-20 14:58:37 +01:00
2008-01-29 10:14:54 +00:00
2008-01-15 01:04:42 +00:00
2008-02-03 16:32:51 +02:00
2008-07-15 18:44:28 +01:00
2008-05-01 08:03:58 -07:00
2008-01-29 10:14:58 +00:00
2008-04-28 17:14:32 +01:00
2007-08-27 02:16:59 +01:00
2005-11-07 18:05:40 +00:00
2007-07-17 10:23:11 -07:00
2007-10-01 14:17:50 +01:00
2007-10-17 08:42:55 -07:00
2007-07-10 17:32:55 +01:00
2008-03-12 14:14:42 +00:00
2007-10-11 23:46:04 +01:00
2007-11-26 17:26:13 +00:00
2007-10-11 23:46:04 +01:00
2006-07-13 21:26:08 +01:00
2008-07-15 18:44:29 +01:00
2007-10-11 23:46:04 +01:00
2007-10-11 23:46:00 +01:00
2007-10-11 23:46:00 +01:00
2008-01-29 10:14:59 +00:00
2007-07-31 21:35:32 +01:00
2007-05-11 08:29:34 -07:00
2007-10-16 18:23:47 +01:00
2008-01-29 10:14:57 +00:00
2008-06-05 18:13:16 +01:00
2007-07-31 21:35:21 +01:00
2008-04-17 10:42:34 -04:00
2008-01-22 00:35:23 +00:00
2008-02-19 17:01:34 +00:00
2006-06-06 00:15:20 +01:00
2007-11-29 09:24:53 -08:00
2007-07-12 17:41:11 +01:00
2007-10-19 11:53:34 -07:00
2008-07-15 18:44:29 +01:00
2008-04-28 17:14:31 +01:00
2008-05-04 14:45:55 -07:00
2008-02-07 08:42:30 -08:00
2008-01-29 10:14:54 +00:00