mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
ebe8dee7aea6be7a775de718ee8fa93f77e3e4af
linux/drivers/ata
History
Anders Roxell d95d140e83 ata: libahci_platform: ahci_platform_find_clk: oops, NULL pointer 
When booting a arm 32-bit kernel with config CONFIG_AHCI_DWC enabled on
a am57xx-evm board. This happens when the clock references are unnamed
in DT, the strcmp() produces a NULL pointer dereference, see the
following oops, NULL pointer dereference:

[    4.673950] Unable to handle kernel NULL pointer dereference at virtual address 00000000
[    4.682098] [00000000] *pgd=00000000
[    4.685699] Internal error: Oops: 5 [#1] SMP ARM
[    4.690338] Modules linked in:
[    4.693420] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.1.0-rc7 #1
[    4.699615] Hardware name: Generic DRA74X (Flattened Device Tree)
[    4.705749] PC is at strcmp+0x0/0x34
[    4.709350] LR is at ahci_platform_find_clk+0x3c/0x5c
[    4.714416] pc : [<c130c494>]    lr : [<c0c230e0>]    psr: 20000013
[    4.720703] sp : f000dda8  ip : 00000001  fp : c29b1840
[    4.725952] r10: 00000020  r9 : c1b23380  r8 : c1b23368
[    4.731201] r7 : c1ab4cc4  r6 : 00000001  r5 : c3c66040  r4 : 00000000
[    4.737762] r3 : 00000080  r2 : 00000080  r1 : c1ab4cc4  r0 : 00000000
[...]
[    4.998870]  strcmp from ahci_platform_find_clk+0x3c/0x5c
[    5.004302]  ahci_platform_find_clk from ahci_dwc_probe+0x1f0/0x54c
[    5.010589]  ahci_dwc_probe from platform_probe+0x64/0xc0
[    5.016021]  platform_probe from really_probe+0xe8/0x41c
[    5.021362]  really_probe from __driver_probe_device+0xa4/0x204
[    5.027313]  __driver_probe_device from driver_probe_device+0x38/0xc8
[    5.033782]  driver_probe_device from __driver_attach+0xb4/0x1ec
[    5.039825]  __driver_attach from bus_for_each_dev+0x78/0xb8
[    5.045532]  bus_for_each_dev from bus_add_driver+0x17c/0x220
[    5.051300]  bus_add_driver from driver_register+0x90/0x124
[    5.056915]  driver_register from do_one_initcall+0x48/0x1e8
[    5.062591]  do_one_initcall from kernel_init_freeable+0x1cc/0x234
[    5.068817]  kernel_init_freeable from kernel_init+0x20/0x13c
[    5.074584]  kernel_init from ret_from_fork+0x14/0x2c
[    5.079681] Exception stack(0xf000dfb0 to 0xf000dff8)
[    5.084747] dfa0:                                     00000000 00000000 00000000 00000000
[    5.092956] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000
[    5.101165] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000
[    5.107818] Code: e5e32001 e3520000 1afffffb e12fff1e (e4d03001)
[    5.114013] ---[ end trace 0000000000000000 ]---

Add an extra check in the if-statement if hpriv-clks[i].id.

Fixes: 6ce73f3a6f ("ata: libahci_platform: Add function returning a clock-handle by id")
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
2022-12-07 08:36:37 +09:00
..
acard-ahci.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
ahci_brcm.c
ata: ahci_brcm: Fix compilation warning
2022-10-18 08:01:57 +09:00
ahci_ceva.c
ata: Drop commas after OF match table sentinels
2022-03-07 11:49:10 +09:00
ahci_da850.c
ata: libahci_platform: Convert to using devm bulk clocks API
2022-09-17 01:39:22 +09:00
ahci_dm816.c
ata: libahci_platform: Convert to using devm bulk clocks API
2022-09-17 01:39:22 +09:00
ahci_dwc.c
ata: ahci-dwc: Add Baikal-T1 AHCI SATA interface support
2022-09-17 01:40:31 +09:00
ahci_imx.c
ata: ahci_imx: Fix compilation warning
2022-10-18 08:02:14 +09:00
ahci_mtk.c
ata: libahci_platform: Parse ports-implemented property in resources getter
2022-09-17 01:39:30 +09:00
ahci_mvebu.c
Merge tag 'char-misc-5.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2022-03-28 12:27:35 -07:00
ahci_octeon.c
ata: Drop commas after OF match table sentinels
2022-03-07 11:49:10 +09:00
ahci_platform.c
ata: ahci: Add DWC AHCI SATA controller support
2022-09-17 01:40:15 +09:00
ahci_qoriq.c
ata: ahci_qoriq: Fix compilation warning
2022-10-18 08:02:14 +09:00
ahci_seattle.c
…
ahci_st.c
ata: ahci_st: Fix compilation warning
2022-10-17 22:01:57 +09:00
ahci_sunxi.c
ata: Drop commas after OF match table sentinels
2022-03-07 11:49:10 +09:00
ahci_tegra.c
…
ahci_xgene.c
ata: ahci_xgene: Fix compilation warning
2022-10-18 08:02:14 +09:00
ahci.c
ata: ahci: Convert __ahci_port_base to accepting hpriv as arguments
2022-09-17 01:39:54 +09:00
ahci.h
ata: ahci: Match EM_MAX_SLOTS with SATA_PMP_MAX_PORTS
2022-10-17 12:02:59 +09:00
ata_generic.c
…
ata_piix.c
ata: libata: make ata_host_suspend() *void*
2022-02-19 11:18:35 +09:00
Kconfig
ata: ahci_st: Enable compile test
2022-09-20 08:52:02 +09:00
libahci_platform.c
ata: libahci_platform: ahci_platform_find_clk: oops, NULL pointer
2022-12-07 08:36:37 +09:00
libahci.c
ata: ahci: Introduce firmware-specific caps initialization
2022-09-17 01:40:02 +09:00
libata-acpi.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
libata-core.c
Merge tag 'ata-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
2022-10-07 10:48:49 -07:00
libata-eh.c
Merge tag 'ata-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
2022-10-07 10:48:49 -07:00
libata-pata-timings.c
…
libata-pmp.c
ata: libata: add tracepoints for ATA error handling
2022-01-05 19:33:01 +09:00
libata-sata.c
Merge tag 'ata-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
2022-10-07 10:48:49 -07:00
libata-scsi.c
ata: libata-core: do not issue non-internal commands once EH is pending
2022-11-12 07:51:06 +09:00
libata-sff.c
ata: libata-sff: Fix double word in comments
2022-09-16 23:24:06 +09:00
libata-trace.c
ata: libata-sff: tracepoints for HSM state machine
2022-01-05 19:33:01 +09:00
libata-transport.c
ata: libata-transport: fix error handling in ata_tdev_add()
2022-11-11 17:26:05 +09:00
libata-transport.h
…
libata-zpodd.c
…
libata.h
ata: libata-core: Simplify ata_build_rw_tf()
2022-08-26 07:46:08 +09:00
Makefile
ata: ahci: Add DWC AHCI SATA controller support
2022-09-17 01:40:15 +09:00
pata_acpi.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_ali.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_amd.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_arasan_cf.c
ata: libata: make ata_host_suspend() *void*
2022-02-19 11:18:35 +09:00
pata_artop.c
ata: pata_artop: use *switch* in atp8xx_fixup()
2022-02-19 11:18:42 +09:00
pata_atiixp.c
ata: pata_atiixp: make static read-only arrays const
2022-01-31 09:58:32 +09:00
pata_atp867x.c
ata: pata_atp867x: convert printk() calls
2022-01-05 19:33:02 +09:00
pata_bk3710.c
…
pata_buddha.c
…
pata_cmd64x.c
ata: pata_cmd64x: convert printk() calls
2022-01-05 19:33:03 +09:00
pata_cmd640.c
ata: pata_cmd640: convert printk() calls
2022-01-05 19:33:02 +09:00
pata_cs5520.c
ata: libata: make ata_host_suspend() *void*
2022-02-19 11:18:35 +09:00
pata_cs5530.c
ata: pata_cs5530: Avoid overwriting initialised field in 'cs5530_sht'
2021-06-16 06:50:25 -06:00
pata_cs5535.c
ata: pata_cs5535: Fix W=1 warnings
2022-06-30 08:21:43 +09:00
pata_cs5536.c
ata: pata_cs5536: convert printk() calls
2022-01-05 19:33:03 +09:00
pata_cypress.c
ata: pata_cypress: convert printk() calls
2022-01-05 19:33:03 +09:00
pata_efar.c
…
pata_ep93xx.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
pata_falcon.c
pata_falcon: Avoid type warnings from sparse
2021-11-29 20:28:13 +09:00
pata_ftide010.c
ata: pata_ftide010: Remove unneeded ERROR check before clk_disable_unprepare
2022-05-16 20:22:37 +09:00
pata_gayle.c
…
pata_hpt3x2n.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_hpt3x3.c
…
pata_hpt37x.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_hpt366.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_icside.c
…
pata_imx.c
ata: libata: make ata_host_suspend() *void*
2022-02-19 11:18:35 +09:00
pata_isapnp.c
…
pata_it821x.c
ata: fix read_id() ata port operation interface
2022-01-14 15:17:16 +09:00
pata_it8213.c
…
pata_ixp4xx_cf.c
ata: Drop commas after OF match table sentinels
2022-03-07 11:49:10 +09:00
pata_jmicron.c
…
pata_legacy.c
ata: pata_legacy: fix pdc20230_set_piomode()
2022-10-31 20:27:27 +09:00
pata_macio.c
ata: pata_macio: Remove unneeded word in comments
2022-09-16 23:24:06 +09:00
pata_marvell.c
ata: pata_marvell: Check the 'bmdma_addr' beforing reading
2022-04-22 08:45:06 +09:00
pata_mpc52xx.c
powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode
2022-06-22 12:51:49 +10:00
pata_mpiix.c
…
pata_netcell.c
ata: fix read_id() ata port operation interface
2022-01-14 15:17:16 +09:00
pata_ninja32.c
…
pata_ns87410.c
…
pata_ns87415.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
pata_octeon_cf.c
ata: pata_octeon_cf: Fix refcount leak in octeon_cf_probe
2022-06-06 09:52:17 +09:00
pata_of_platform.c
ata: Drop commas after OF match table sentinels
2022-03-07 11:49:10 +09:00
pata_oldpiix.c
…
pata_opti.c
…
pata_optidma.c
pata_optidma: fix checking of DMA state
2021-10-12 17:46:59 +09:00
pata_palmld.c
ata: palmld: fix return value check in palmld_pata_probe()
2022-10-31 20:28:05 +09:00
pata_pcmcia.c
…
pata_pdc202xx_old.c
ata: pata_pdc202xx_old: make static read-only array pio_timing const
2022-01-31 09:58:32 +09:00
pata_pdc2027x.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_piccolo.c
…
pata_platform.c
ata: pata_platform: Make use of platform_get_mem_or_io()
2022-01-31 09:58:31 +09:00
pata_pxa.c
ata: pata_pxa: Use platform_get_irq() to get the interrupt
2022-03-10 11:17:59 +09:00
pata_radisys.c
pata_radisys: fix checking of DMA state
2021-10-12 17:47:02 +09:00
pata_rb532_cf.c
ata: rb532_cf: remove redundant codes
2021-06-24 18:49:01 -06:00
pata_rdc.c
…
pata_rz1000.c
ata: pata_rz1000: convert printk() calls
2022-01-05 19:33:03 +09:00
pata_samsung_cf.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
pata_sc1200.c
ata: pata_sc1200: sc1200_sht'Avoid overwriting initialised field in '
2021-06-16 06:50:25 -06:00
pata_sch.c
…
pata_serverworks.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_sil680.c
ata: pata_sil680: fix result type of sil680_sel{dev|reg}()
2022-04-13 12:42:51 +09:00
pata_sis.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pata_sl82c105.c
…
pata_triflex.c
ata: libata: make ata_host_suspend() *void*
2022-02-19 11:18:35 +09:00
pata_via.c
ata: make transfer mode masks *unsigned int*
2022-06-17 16:35:02 +09:00
pdc_adma.c
ata: pdc_adma: Drop pointless VPRINTK() calls and remove disabled NCQ debugging
2022-01-05 19:33:01 +09:00
sata_dwc_460ex.c
ata: sata_dwc_460ex: Fix crash due to OOB write
2022-04-04 09:56:34 +09:00
sata_fsl.c
Merge tag 'ata-5.18-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
2022-03-23 14:35:59 -07:00
sata_gemini.c
ata: Make use of the helper function devm_platform_ioremap_resource()
2022-04-22 08:38:18 +09:00
sata_gemini.h
…
sata_highbank.c
ata: Drop commas after OF match table sentinels
2022-03-07 11:49:10 +09:00
sata_inic162x.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
sata_mv.c
ata: sata_mv: Fixes expected number of resources now IRQs are gone
2022-08-03 07:59:12 +09:00
sata_nv.c
ata: sata_nv: drop pointless VPRINTK() calls and convert remaining ones
2022-01-05 19:33:02 +09:00
sata_promise.c
ata: sata_promise: Drop pointless VPRINTK() calls and convert the remaining ones
2022-01-05 19:33:01 +09:00
sata_promise.h
…
sata_qstor.c
ata: sata_qstor: Drop pointless VPRINTK() calls
2022-01-05 19:33:02 +09:00
sata_rcar.c
ata: sata_rcar: Fix compilation warning
2022-10-18 08:01:45 +09:00
sata_sil24.c
ata: libata: add reset tracepoints
2022-01-04 20:00:57 +09:00
sata_sil.c
ata: sata_sil: Drop pointless VPRINTK() calls
2022-01-05 19:33:02 +09:00
sata_sis.c
…
sata_svw.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
sata_sx4.c
ata: sata_sx4: convert printk() calls
2022-01-05 19:33:03 +09:00
sata_uli.c
…
sata_via.c
…
sata_vsc.c
ata: add/use ata_taskfile::{error|status} fields
2022-02-20 09:06:05 +09:00
sis.h
…