Files
linux/drivers/rtc
Geert Uytterhoeven f65e727464 rtc: rtc-rs5c313: Fix late hardware init
rs5c313_rtc_init() calls platform_driver_register(), and initializes the
hardware.  This is wrong because of two reasons:
  1. As soon as the driver has been registered, the device may be
     probed.  If devm_rtc_device_register() is called before hardware
     initialization, reading the current time will fail:

	rs5c313 rs5c313: rs5c313_rtc_read_time: timeout error
	rs5c313 rs5c313: registered as rtc0
	rs5c313 rs5c313: rs5c313_rtc_read_time: timeout error
	rs5c313 rs5c313: hctosys: unable to read the hardware clock

  2. If the platform device does not exist, the driver will still write
     to a hardware device that may not be present.

Fix this by moving the hardware initialization sequence to the driver's
.probe() method.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20200814110731.29029-3-geert+renesas@glider.be
2020-08-21 00:13:44 +02:00
..
2020-07-01 12:10:59 +03:00
2020-07-02 22:32:00 +02:00
2020-07-21 09:56:46 +02:00
2019-11-08 16:14:09 +01:00
2020-07-02 22:32:01 +02:00
2019-11-08 16:14:09 +01:00
2020-08-12 11:48:29 +02:00
2019-12-23 11:23:53 +01:00
2019-04-04 10:07:10 +02:00
2019-10-19 22:33:05 +02:00
2019-11-08 16:14:09 +01:00
2019-05-23 17:44:52 +02:00
2020-03-16 11:12:08 +01:00
2019-05-08 22:14:36 +02:00