Files
linux/drivers/net
Ingo Molnar e8ebe3b893 e1000e: fix e1000_netpoll(), remove extraneous e1000_clean_tx_irq() call
Evgeniy Polyakov noticed that drivers/net/e1000e/netdev.c:e1000_netpoll()
was calling e1000_clean_tx_irq() without taking the TX lock.

David Miller suggested to remove the call altogether: since in this
callpah there's periodic calls to ->poll() anyway which will do
e1000_clean_tx_irq() and will garbage-collect any finished TX ring
descriptors.

This fix solved the e1000e+netconsole crashes i've been seeing:

=============================================================================
BUG skbuff_head_cache: Poison overwritten
-----------------------------------------------------------------------------

INFO: 0xf658ae9c-0xf658ae9c. First byte 0x6a instead of 0x6b
INFO: Allocated in __alloc_skb+0x2c/0x110 age=0 cpu=0 pid=5098
INFO: Freed in __kfree_skb+0x31/0x80 age=0 cpu=1 pid=4440
INFO: Slab 0xc16cc140 objects=16 used=1 fp=0xf658ae00 flags=0x400000c3
INFO: Object 0xf658ae00 @offset=3584 fp=0xf658af00

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-07-23 15:30:52 -07:00
..
2008-07-22 19:39:14 -04:00
2008-05-22 14:12:39 -04:00
2008-07-22 16:09:13 -04:00
2008-03-26 00:18:44 -04:00
2008-07-21 21:55:03 -07:00
2008-03-17 08:11:03 -04:00
2008-01-28 15:04:05 -08:00
2008-06-10 18:20:17 -04:00
2008-03-26 00:18:43 -04:00
2007-10-10 16:51:43 -07:00
2008-04-29 01:56:14 -04:00
2008-07-18 17:54:17 -07:00
2008-05-16 22:20:27 -07:00
2008-07-18 17:58:57 -07:00
2008-07-18 17:55:11 -07:00
2008-06-23 20:33:36 -07:00
2008-06-23 20:27:26 -07:00
2008-06-23 20:36:51 -07:00
2008-06-23 20:33:01 -07:00
2008-06-23 20:34:36 -07:00
2008-01-04 00:47:04 -08:00
2008-03-26 00:18:43 -04:00
2008-02-01 20:54:03 +11:00
2008-07-22 17:54:07 -04:00
2007-10-10 16:51:13 -07:00
2007-10-10 16:51:13 -07:00
2008-01-28 15:07:59 -08:00
2008-04-29 01:56:01 -04:00
2008-06-17 23:07:29 -04:00
2007-10-19 11:53:42 -07:00
2008-05-01 08:08:36 -07:00
2008-07-22 17:12:37 +10:00
2008-07-22 17:12:37 +10:00
2008-05-22 14:12:40 -04:00
2008-01-28 15:07:12 -08:00
2008-07-22 17:50:44 -04:00
2008-07-22 17:50:44 -04:00
2008-02-03 04:26:12 -08:00
2007-10-10 16:50:46 -07:00
2008-07-17 19:21:30 -07:00
2008-03-17 08:11:41 -04:00
2008-04-25 02:08:51 -04:00
2008-06-11 22:06:31 -04:00
2008-01-28 15:04:05 -08:00
2008-01-28 15:07:12 -08:00
2008-07-22 19:34:21 -04:00
2007-10-19 11:53:42 -07:00
2008-02-03 04:28:10 -08:00
2008-07-22 19:56:37 -04:00
2008-07-22 17:50:44 -04:00
2008-03-17 07:56:33 -04:00
2008-07-22 17:50:44 -04:00
2008-03-26 00:18:04 -04:00
2008-03-26 00:18:00 -04:00
2007-10-23 21:28:40 -04:00
2008-07-17 19:21:17 -07:00
2008-05-30 22:19:22 -04:00
2008-03-05 16:34:41 -06:00
2008-07-20 17:12:34 -07:00
2008-01-28 15:11:27 -08:00
2008-07-20 17:12:34 -07:00
2008-06-20 21:58:02 -07:00
2008-01-28 15:08:00 -08:00
2008-07-22 20:00:01 -04:00
2008-01-28 15:03:59 -08:00
2008-07-17 19:21:07 -07:00
2008-07-11 01:11:40 -04:00
2008-04-16 20:41:44 -04:00
2008-05-30 22:07:17 -04:00
2008-06-28 10:23:33 -04:00
2007-10-16 21:10:29 -04:00
2008-07-22 21:53:40 -07:00
2008-06-17 23:59:39 -04:00
2008-01-28 15:11:27 -08:00
2008-07-20 17:12:34 -07:00
2008-01-28 15:03:59 -08:00
2008-04-16 20:06:50 -04:00
2007-10-10 16:51:13 -07:00
2008-02-03 04:26:15 -08:00
2008-01-28 15:03:46 -08:00
2008-03-23 03:35:12 -07:00
2008-01-28 15:07:10 -08:00
2008-01-28 15:07:09 -08:00
2008-02-03 04:26:14 -08:00
2007-10-10 16:51:34 -07:00
2008-05-29 01:38:46 -07:00
2008-05-30 22:18:02 -04:00
2008-05-30 22:18:02 -04:00
2008-07-22 17:54:17 -04:00