Files
linux/arch
Pavel Machek fa5b8a30cf aperture_64.c: duplicated code, buggy?
Hi!

void __init early_gart_iommu_check(void)

contains

	for (num = 24; num < 32; num++) {
		if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00)))
			continue;

loop, with very similar loop duplicated in

void __init gart_iommu_hole_init(void)

. First copy of a loop seems to be buggy, too. It uses 0 as a "nothing
set" value, which may actually bite us in last_aper_enabled case
(because it may be often zero).

(Beware, it is hard to test this patch, because this code has about
2^8 different code paths, depending on hardware and cmdline settings).

Plus, the second loop does not check for consistency of
aper_enabled. Should it?

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
2008-06-05 13:58:42 +02:00
..
2008-05-09 08:03:03 -07:00
2008-05-09 08:04:56 -07:00
2008-05-05 12:38:50 -07:00
2008-05-12 22:57:51 +10:00
2008-05-14 19:11:14 -07:00
2008-05-12 22:45:15 -07:00
2008-05-13 08:02:22 -07:00
2008-04-29 08:06:11 -07:00