Files
linux/net
Masayuki Nakagawa fb7e2399ec [TCP]: skb is unexpectedly freed.
I encountered a kernel panic with my test program, which is a very
simple IPv6 client-server program.

The server side sets IPV6_RECVPKTINFO on a listening socket, and the
client side just sends a message to the server.  Then the kernel panic
occurs on the server.  (If you need the test program, please let me
know. I can provide it.)

This problem happens because a skb is forcibly freed in
tcp_rcv_state_process().

When a socket in listening state(TCP_LISTEN) receives a syn packet,
then tcp_v6_conn_request() will be called from
tcp_rcv_state_process().  If the tcp_v6_conn_request() successfully
returns, the skb would be discarded by __kfree_skb().

However, in case of a listening socket which was already set
IPV6_RECVPKTINFO, an address of the skb will be stored in
treq->pktopts and a ref count of the skb will be incremented in
tcp_v6_conn_request().  But, even if the skb is still in use, the skb
will be freed.  Then someone still using the freed skb will cause the
kernel panic.

I suggest to use kfree_skb() instead of __kfree_skb().

Signed-off-by: Masayuki Nakagawa <nakagawa.msy@ncos.nec.co.jp>
Signed-off-by: David S. Miller <davem@davemloft.net>
2007-01-23 20:25:52 -08:00
..
2006-12-08 08:28:44 -08:00
2007-01-23 20:25:52 -08:00
2006-11-05 14:11:25 -08:00
2006-12-06 20:14:22 -08:00
2006-08-05 21:15:58 -07:00
2006-12-02 21:21:23 -08:00
2007-01-03 18:38:15 -08:00
2006-12-07 00:11:33 -08:00
2006-12-08 08:28:50 -08:00
2007-01-23 20:25:51 -08:00
2006-09-22 14:53:34 -07:00
2006-12-08 08:28:48 -08:00
2005-04-16 15:20:36 -07:00