mirror
/
linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
linux/drivers/gpu/drm
History
Thomas Hellström 9a9a8fe267 drm/ttm: Fix a NULL pointer dereference 
The LRU mechanism may look up a resource in the process of being removed
from an object. The locking rules here are a bit unclear but it looks
currently like res->bo assignment is protected by the LRU lock, whereas
bo->resource is protected by the object lock, while *clearing* of
bo->resource is also protected by the LRU lock. This means that if
we check that bo->resource points to the LRU resource under the LRU
lock we should be safe.
So perform that check before deciding to swap out a bo. That avoids
dereferencing a NULL bo->resource in ttm_bo_swapout().

Fixes: 6a9b028994 ("drm/ttm: move the LRU into resource handling v4")
Cc: Christian König <christian.koenig@amd.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Christian Koenig <christian.koenig@amd.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Felix Kuehling <Felix.Kuehling@amd.com>
Cc: Philip Yang <Philip.Yang@amd.com>
Cc: Qiang Yu <qiang.yu@amd.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Nirmoy Das <nirmoy.das@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
Cc: Anshuman Gupta <anshuman.gupta@intel.com>
Cc: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@amd.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <stable@vger.kernel.org> # v5.19+
Signed-off-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230307144621.10748-2-thomas.hellstrom@linux.intel.com
 		2023-03-07 18:26:38 +01:00
..
amd drm/amdgpu: fix memory leak in amdgpu_cs_sync_rings 2023-02-03 14:21:31 -05:00
arm drm/arm/malidp: remove calls to drm_mode_config_cleanup() 2022-11-16 10:33:45 +00:00
armada drm/fb-helper: Perform all fbdev I/O with the same implementation 2022-11-05 17:05:54 +01:00
aspeed drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
ast drm/ast: Fix start address computation 2023-02-10 14:32:57 +01:00
atmel-hlcdc drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
bridge pwm: Changes for v6.2-rc1 2022-12-21 09:41:28 -08:00
display Linux 6.1-rc6 2022-11-24 11:05:43 +10:00
etnaviv MM patches for 6.2-rc1. 2022-12-13 19:29:45 -08:00
exynos MM patches for 6.2-rc1. 2022-12-13 19:29:45 -08:00
fsl-dcu hardening updates for v6.2-rc1 2022-12-14 12:20:00 -08:00
gma500 drm/fb-helper: Perform all fbdev I/O with the same implementation 2022-11-05 17:05:54 +01:00
gud drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
hisilicon drm/hisilicon: Use drm_mode_init() for on-stack modes 2022-11-12 01:36:43 +02:00
hyperv drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
i2c drm: tda99x: Don't advertise non-existent capture support 2022-12-02 14:07:19 +00:00
i810
…
i915 drm/i915: Fix a memory leak with reused mmap_offset 2023-01-19 14:17:05 +01:00
imx Merge drm/drm-fixes into drm-misc-fixes 2023-01-03 08:32:12 +01:00
ingenic drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
kmb drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
lib
…
lima Linux 6.1-rc6 2022-11-24 11:05:43 +10:00
logicvc drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
mcde drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
mediatek Mediatek DRM Next for Linux 6.2 2022-11-24 12:49:36 +10:00
meson drm/meson: fix 1px pink line on GXM when scaling video overlay 2023-03-06 09:42:01 +01:00
mga
…
mgag200 drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
msm drm/msm/gem: Prevent blocking within shrinker loop 2023-02-27 07:06:56 +03:00
mxsfb drm: lcdif: Set and enable FIFO Panic threshold 2022-11-09 01:31:45 +01:00
nouveau drm/nouveau/fb/gp102-: cache scrubber binary on first load 2023-02-21 02:07:24 +01:00
omapdrm drm: Assert held reservation lock for dma-buf mmapping 2022-11-11 23:49:47 +03:00
panel drm/panel: boe-tv101wum-nl6: Ensure DSI writes succeed during disable 2023-02-01 11:41:15 +01:00
panfrost drm/panfrost: Don't sync rpm suspension after mmu flushing 2023-02-27 07:07:25 +03:00
pl111 drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
qxl drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
r128
…
radeon drm/radeon: Fix PCI device refcount leak in radeon_atrm_get_bios() 2022-11-29 11:03:38 -05:00
rcar-du Kconfig fix for RZ/G2L DSI 2022-11-24 12:38:36 +10:00
rockchip Linux 6.1-rc6 2022-11-24 11:05:43 +10:00
savage
…
scheduler drm/scheduler: Fix lockup in drm_sched_entity_kill() 2023-01-03 14:49:59 +03:00
shmobile drm/plane: Remove drm_plane_init() 2022-09-20 09:37:12 +02:00
sis drm/sis: use idr_init_base() to initialize dev_priv->object_idr 2022-07-28 15:35:56 +01:00
solomon drm/ssd130x: Init display before the SSD130X_DISPLAY_ON command 2023-01-26 19:55:23 +01:00
sprd drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
sti hardening updates for v6.2-rc1 2022-12-14 12:20:00 -08:00
stm drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
sun4i drm/sun4i: fix missing component unbind on bind errors 2023-03-07 16:11:02 +01:00
tdfx
…
tegra drm/tegra: Changes for v6.2-rc1 2022-11-30 13:08:58 +10:00
tests The drm-misc-next-fixes leftovers. It addresses a bug in drm/scheduler 2023-01-03 21:02:57 +01:00
tidss drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
tilcdc drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
tiny drm/cirrus: NULL-check pipe->plane.state->fb in cirrus_pipe_update() 2023-02-17 11:32:10 +01:00
ttm drm/ttm: Fix a NULL pointer dereference 2023-03-07 18:26:38 +01:00
tve200 drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
udl drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
v3d drm/v3d: add missing mutex_destroy 2022-11-10 11:49:40 -01:00
vboxvideo drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
vc4 drm/vc4: crtc: Increase setup cost in core clock calculation to handle extreme reduced blanking 2023-02-09 09:59:10 +01:00
vgem
…
via drm/via: Add new condition to via_dma_cleanup() 2022-09-07 07:01:16 +02:00
virtio drm/virtio: Pass correct device to dma_sync_sgtable_for_device() 2023-02-27 02:39:24 +03:00
vkms drm/fb-helper: Move generic fbdev emulation into separate source file 2022-11-05 17:12:04 +01:00
vmwgfx drm/vmwgfx: Do not drop the reference to the handle too soon 2023-02-14 23:00:09 -05:00
xen drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
xlnx drm-misc-next for 6.2: 2022-11-16 07:17:32 +10:00
Kconfig drm: Disable dynamic debug as broken 2023-02-13 18:23:04 +02:00
Makefile drivers/accel: define kconfig and register a new major 2022-11-22 13:13:51 +02:00
drm_agpsupport.c
…
drm_aperture.c drm/aperture: Fix some kerneldoc comments 2022-09-12 09:34:07 +02:00
drm_atomic.c
…
drm_atomic_helper.c drm/atomic-helper: Add {begin,end}_fb_access to plane helpers 2022-11-08 17:10:27 +01:00
drm_atomic_state_helper.c drm/atomic-helper: Rename drm_atomic_helper_connector_tv_reset to avoid ambiguity 2022-10-10 13:55:47 +02:00
drm_atomic_uapi.c drm/atomic: Add TV subconnector property to get/set_property 2022-10-10 13:56:42 +02:00
drm_auth.c drm: use idr_init_base() to initialize master->lessee_idr 2022-07-28 15:35:55 +01:00
drm_blend.c drm/doc: Fix comment typo 2022-06-28 07:56:32 +02:00
drm_bridge.c drm/bridge: Avoid uninitialized variable warning 2022-07-08 13:41:28 +02:00
drm_bridge_connector.c
…
drm_buddy.c drm: Optimize drm buddy top-down allocation method 2023-01-12 13:50:28 +01:00
drm_bufs.c
…
drm_cache.c
…
drm_client.c drm/client: fix circular reference counting issue 2023-02-07 09:42:56 +01:00
drm_client_modeset.c drm/client: Add some tests for drm_connector_pick_cmdline_mode() 2022-11-15 10:08:37 +01:00
drm_color_mgmt.c drm: fix whitespace in drm_plane_create_color_properties() 2022-08-04 15:24:46 +02:00
drm_connector.c drm-misc-next for 6.2: 2022-10-28 13:16:36 +10:00
drm_context.c
…
drm_crtc.c drm/crtc: Introduce drmm_crtc_init_with_planes 2022-07-13 10:46:05 +02:00
drm_crtc_helper.c drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
drm_crtc_helper_internal.h
…
drm_crtc_internal.h drm/edid: move edid load declarations to internal header 2022-10-26 09:53:56 +03:00
drm_damage_helper.c drm: Use original src rect while initializing damage iterator 2022-09-13 14:38:33 +03:00
drm_debugfs.c drm/edid: abstract debugfs override EDID show better 2022-10-26 09:53:08 +03:00
drm_debugfs_crc.c
…
drm_displayid.c
…
drm_dma.c
…
drm_drv.c This tag contains the patches that add the new compute acceleration 2022-11-30 12:01:27 +10:00
drm_dumb_buffers.c
…
drm_edid.c drm/edid: fix info leak when failing to get panel id 2023-03-02 10:27:17 -08:00
drm_edid_load.c drm/edid/firmware: stop using a throwaway platform device 2022-11-16 14:54:44 +02:00
drm_encoder.c drm/encoder: Introduce drmm_encoder_init 2022-07-13 10:46:05 +02:00
drm_encoder_slave.c
…
drm_fb_dma_helper.c drm/gem: rename struct drm_gem_dma_object.{paddr => dma_addr} 2022-08-03 18:32:27 +02:00
drm_fb_helper.c drm/fb-helper: Set framebuffer for vga-switcheroo clients 2023-01-18 17:12:23 +01:00
drm_fbdev_generic.c drm/fb-helper: Use a per-driver FB deferred I/O handler 2023-01-24 11:13:08 +01:00
drm_file.c accel: add dedicated minor for accelerator devices 2022-11-22 13:14:44 +02:00
drm_flip_work.c
…
drm_format_helper.c Linux 6.1-rc6 2022-11-24 11:05:43 +10:00
drm_fourcc.c drm/fourcc: Fix vsub/hsub for Q410 and Q401 2022-11-16 11:29:09 +00:00
drm_framebuffer.c drm/framebuffer: convert to drm_dbg_kms() 2022-09-28 10:43:30 +02:00
drm_gem.c drm/msm/gem: Prevent blocking within shrinker loop 2023-02-27 07:06:56 +03:00
drm_gem_atomic_helper.c drm/gem: Implement shadow-plane {begin, end}_fb_access with vmap 2022-11-08 17:10:41 +01:00
drm_gem_dma_helper.c drm/gem: Take reservation lock for vmap/vunmap operations 2022-10-18 01:21:38 +03:00
drm_gem_framebuffer_helper.c drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
drm_gem_shmem_helper.c drm/shmem-helper: Remove another errant put in error path 2023-02-27 02:39:52 +03:00
drm_gem_ttm_helper.c drm/gem: Take reservation lock for vmap/vunmap operations 2022-10-18 01:21:38 +03:00
drm_gem_vram_helper.c drm/gem-vram: Fix deadlock in drm_gem_vram_vmap() 2022-11-14 15:55:21 +03:00
drm_hashtab.c
…
drm_internal.h drm: Fix potential null-ptr-deref in drm_vblank_destroy_worker() 2022-11-10 18:49:02 -05:00
drm_ioc32.c
…
drm_ioctl.c drm: Prevent drm_copy_field() to attempt copying a NULL pointer 2022-07-15 10:25:36 +02:00
drm_irq.c
…
drm_kms_helper_common.c
…
drm_lease.c
…
drm_legacy.h
…
drm_legacy_misc.c
…
drm_lock.c
…
drm_managed.c
…
drm_memory.c
…
drm_mipi_dbi.c drm/probe-helper: Add drm_crtc_helper_mode_valid_fixed() 2022-09-12 09:14:26 +02:00
drm_mipi_dsi.c gpu/drm: fix repeated words in comments 2022-10-24 09:26:56 +02:00
drm_mm.c
…
drm_mode_config.c Revert "drm: hide unregistered connectors from GETCONNECTOR IOCTL" 2022-11-15 19:18:41 +01:00
drm_mode_object.c
…
drm_modes.c drm/connector: Add pixel clock to cmdline mode 2022-11-15 10:10:24 +01:00
drm_modeset_helper.c drm/plane-helper: Provide DRM_PLANE_NON_ATOMIC_FUNCS initializer macro 2022-09-20 09:42:31 +02:00
drm_modeset_lock.c
…
drm_of.c drm: Remove linux/media-bus-format.h from drm_crtc.h 2022-07-05 21:15:13 +03:00
drm_panel.c
…
drm_panel_orientation_quirks.c drm: Add orientation quirk for Lenovo ideapad D330-10IGL 2023-01-06 09:56:26 +01:00
drm_pci.c
…
drm_plane.c drm/plane: Allocate planes with drm_universal_plane_alloc() 2022-09-20 09:41:06 +02:00
drm_plane_helper.c drm/crtc-helper: Add a drm_crtc_helper_atomic_check() helper 2022-10-13 09:17:05 +02:00
drm_prime.c drm: Assert held reservation lock for dma-buf mmapping 2022-11-11 23:49:47 +03:00
drm_print.c drm_print: add _ddebug descriptor to drm_*dbg prototypes 2022-09-24 15:02:02 +02:00
drm_privacy_screen.c
…
drm_privacy_screen_x86.c
…
drm_probe_helper.c drm/fb-helper: Remove unnecessary include statements 2022-11-05 17:12:04 +01:00
drm_property.c
…
drm_rect.c gpu/drm: fix repeated words in comments 2022-10-24 09:27:04 +02:00
drm_scatter.c
…
drm_self_refresh_helper.c
…
drm_simple_kms_helper.c drm/atomic-helper: Add {begin,end}_fb_access to plane helpers 2022-11-08 17:10:27 +01:00
drm_syncobj.c
…
drm_sysfs.c Driver Core changes for 6.2-rc1 2022-12-16 03:54:54 -08:00
drm_trace.h
…
drm_trace_points.c
…
drm_vblank.c
…
drm_vblank_work.c
…
drm_vm.c
…
drm_vma_manager.c drm/drm_vma_manager: Add drm_vma_node_allow_once() 2023-01-19 14:16:55 +01:00
drm_writeback.c
…