mirror/linux
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
Files
ffeafdd2bf0b280d67ec1a47ea6287910d271f3f
linux/drivers
History
John Garry ffeafdd2bf scsi: libsas: Fix rphy phy_identifier for PHYs with end devices attached 
The sysfs phy_identifier attribute for a sas_end_device comes from the rphy
phy_identifier value.

Currently this is not being set for rphys with an end device attached, so
we see incorrect symlinks from systemd disk/by-path:

root@localhost:~# ls -l /dev/disk/by-path/
total 0
lrwxrwxrwx 1 root root  9 Feb 13 12:26 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0 -> ../../sdb
lrwxrwxrwx 1 root root 10 Feb 13 12:26 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0-part1 -> ../../sdb1
lrwxrwxrwx 1 root root 10 Feb 13 12:26 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0-part2 -> ../../sdb2
lrwxrwxrwx 1 root root 10 Feb 13 12:26 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy0-lun-0-part3 -> ../../sdc3

Indeed, each sas_end_device phy_identifier value is 0:

root@localhost:/# more sys/class/sas_device/end_device-0\:0\:2/phy_identifier
0
root@localhost:/# more sys/class/sas_device/end_device-0\:0\:10/phy_identifier
0

This patch fixes the discovery code to set the phy_identifier.  With this,
we now get proper symlinks:

root@localhost:~# ls -l /dev/disk/by-path/
total 0
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy10-lun-0 -> ../../sdg
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy11-lun-0 -> ../../sdh
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy2-lun-0 -> ../../sda
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy2-lun-0-part1 -> ../../sda1
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy3-lun-0 -> ../../sdb
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy3-lun-0-part1 -> ../../sdb1
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy3-lun-0-part2 -> ../../sdb2
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy4-lun-0 -> ../../sdc
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy4-lun-0-part1 -> ../../sdc1
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy4-lun-0-part2 -> ../../sdc2
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy4-lun-0-part3 -> ../../sdc3
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy5-lun-0 -> ../../sdd
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy7-lun-0 -> ../../sde
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy7-lun-0-part1 -> ../../sde1
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy7-lun-0-part2 -> ../../sde2
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy7-lun-0-part3 -> ../../sde3
lrwxrwxrwx 1 root root  9 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy8-lun-0 -> ../../sdf
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy8-lun-0-part1 -> ../../sdf1
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy8-lun-0-part2 -> ../../sdf2
lrwxrwxrwx 1 root root 10 Feb 13 11:53 platform-HISI0162:01-sas-exp0x500e004aaaaaaa1f-phy8-lun-0-part3 -> ../../sdf3

Fixes: 2908d778ab ("[SCSI] aic94xx: new driver")
Reported-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Jason Yan <yanaijie@huawei.com>
Tested-by: dann frazier <dann.frazier@canonical.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2019-02-15 22:16:07 -05:00
..
accessibility
…
acpi
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
amba
…
android
binder: implement binderfs
2018-12-19 09:40:13 +01:00
ata
scsi: communicate max segment size to the DMA mapping code
2019-01-22 20:40:59 -05:00
atm
…
auxdisplay
auxdisplay: charlcd: fix x/y command parsing
2018-12-21 21:27:21 +01:00
base
Merge branch 'mount.part1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs
2019-01-05 13:25:58 -08:00
bcma
…
block
block: sunvdc: don't run hw queue synchronously from irq context
2019-01-03 08:21:47 -07:00
bluetooth
Bluetooth: hci_bcm: Handle specific unknown packets after firmware loading
2018-12-19 13:43:42 +01:00
bus
Merge tag 'armsoc-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
2018-12-31 17:32:35 -08:00
cdrom
gdrom: fix a memory leak bug
2018-12-29 08:20:44 -07:00
char
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
clk
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2019-01-02 18:56:59 -08:00
clocksource
Merge tag 'csky-for-linus-4.21' of git://github.com/c-sky/csky-linux
2019-01-05 09:50:07 -08:00
connector
…
cpufreq
Merge tag 'powerpc-4.21-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2018-12-27 10:43:24 -08:00
cpuidle
Merge tag 'powerpc-4.21-1' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
2018-12-27 10:43:24 -08:00
crypto
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
dax
mm, devm_memremap_pages: fix shutdown handling
2018-12-28 12:11:47 -08:00
dca
…
devfreq
…
dio
…
dma
Merge branch 'next/drivers' into next/late
2019-01-04 14:31:38 -08:00
dma-buf
drivers/dma-buf/udmabuf.c: convert to use vm_fault_t
2019-01-04 13:13:46 -08:00
edac
EDAC, fsl_ddr: Add LS1021A to the list of supported hardware
2018-12-19 11:57:45 +01:00
eisa
…
extcon
…
firewire
scsi: communicate max segment size to the DMA mapping code
2019-01-22 20:40:59 -05:00
firmware
Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux
2019-01-05 11:28:39 -08:00
fmc
…
fpga
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
fsi
…
gnss
…
gpio
Merge tag 'gpio-v4.21-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio
2018-12-28 20:00:21 -08:00
gpu
Merge tag 'drm-next-2019-01-05' of git://anongit.freedesktop.org/drm/drm
2019-01-05 18:25:19 -08:00
hid
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid
2019-01-05 17:53:40 -08:00
hsi
…
hv
Merge tag 'char-misc-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2018-12-28 20:54:57 -08:00
hwmon
Merge tag 'kconfig-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2018-12-29 13:03:29 -08:00
hwspinlock
hwspinlock: fix return value check in stm32_hwspinlock_probe()
2019-01-03 11:42:10 -08:00
hwtracing
intel_th: msu: Fix an off-by-one in attribute store
2018-12-19 20:21:06 +01:00
i2c
Merge branch 'i2c/for-5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2019-01-05 18:13:35 -08:00
i3c
…
ide
Merge tag 'for-4.21/block-20181221' of git://git.kernel.dk/linux-block
2018-12-28 13:19:59 -08:00
idle
…
iio
Merge tag 'staging-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging
2018-12-28 20:39:58 -08:00
infiniband
Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
2019-01-05 18:20:51 -08:00
input
Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input
2019-01-02 18:56:59 -08:00
iommu
Merge tag 'iommu-updates-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
2019-01-01 15:55:29 -08:00
ipack
…
irqchip
Merge tag 'xtensa-20181228' of git://github.com/jcmvbkbc/linux-xtensa
2018-12-29 09:40:40 -08:00
isdn
isdn: fix kernel-infoleak in capi_unlocked_ioctl
2019-01-02 10:31:39 -08:00
leds
Merge tag 'leds-for-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds
2018-12-25 14:52:50 -08:00
lightnvm
lightnvm: pblk: fix use-after-free bug
2018-12-22 14:45:35 -07:00
macintosh
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
mailbox
mailbox: tegra-hsp: Use device-managed registration API
2018-12-21 22:31:26 -06:00
mcb
…
md
Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/shli/md into for-linus
2019-01-03 08:21:02 -07:00
media
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
memory
Merge tag 'armsoc-late' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
2019-01-05 11:30:37 -08:00
memstick
Merge tag 'mmc-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
2018-12-28 16:52:18 -08:00
message
scsi: flip the default on use_clustering
2018-12-18 23:13:12 -05:00
mfd
…
misc
Merge branch 'i2c/for-5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux
2019-01-05 18:13:35 -08:00
mmc
Merge tag 'mmc-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
2018-12-28 16:52:18 -08:00
mtd
Merge tag 'kbuild-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2018-12-29 12:03:17 -08:00
mux
…
net
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net
2019-01-03 12:53:47 -08:00
nfc
…
ntb
…
nubus
…
nvdimm
Merge branch 'akpm' (patches from Andrew)
2018-12-28 16:55:46 -08:00
nvme
nvme-pci: trace SQ status on completions
2018-12-19 08:35:36 +01:00
nvmem
…
of
Merge tag 'devicetree-for-4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux
2018-12-28 20:08:34 -08:00
opp
…
oprofile
…
parisc
Merge tag 'kconfig-v4.21-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2018-12-29 13:40:29 -08:00
parport
…
pci
Merge tag 'pci-v4.21-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
2019-01-05 17:57:34 -08:00
pcmcia
Merge tag 'for-4.21' of git://git.armlinux.org.uk/~rmk/linux-arm
2019-01-05 11:23:17 -08:00
perf
drivers/perf: hisi: Fixup one DDRC PMU register offset
2019-01-04 10:13:27 +00:00
phy
…
pinctrl
Merge tag 'pinctrl-v4.21-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl
2019-01-01 13:19:16 -08:00
platform
Merge tag 'tag-chrome-platform-for-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/bleung/chrome-platform
2019-01-06 11:40:06 -08:00
pnp
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
power
Merge tag 'for-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply
2018-12-28 20:22:45 -08:00
powercap
…
pps
Merge tag 'kconfig-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2018-12-29 13:03:29 -08:00
ps3
…
ptp
Merge tag 'char-misc-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2018-12-28 20:54:57 -08:00
pwm
pwm: imx: Add ipg clock operation
2018-12-24 12:06:56 +01:00
rapidio
…
ras
treewide: surround Kconfig file paths with double quotes
2018-12-22 00:25:54 +09:00
regulator
Merge remote-tracking branch 'regulator/topic/coupled' into regulator-next
2018-12-21 13:43:35 +00:00
remoteproc
…
reset
…
rpmsg
…
rtc
Merge tag 'rtc-4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux
2019-01-01 13:24:31 -08:00
s390
scsi: zfcp: fix sysfs block queue limit output for max_segment_size
2019-01-29 01:14:59 -05:00
sbus
Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/sparc-next
2018-12-26 10:32:18 -08:00
scsi
scsi: libsas: Fix rphy phy_identifier for PHYs with end devices attached
2019-02-15 22:16:07 -05:00
sfi
…
sh
…
siox
…
slimbus
…
sn
…
soc
Merge tag 'armsoc-drivers' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
2018-12-31 17:32:35 -08:00
soundwire
…
spi
Merge tag 'spi-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi
2018-12-25 14:43:54 -08:00
spmi
…
ssb
…
staging
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
target
scsi: target: make the pi_prot_format ConfigFS path readable
2019-02-04 21:40:32 -05:00
tc
…
tee
Merge tag 'tee-subsys-optee-for-4.21' of https://git.linaro.org/people/jens.wiklander/linux-tee into next/late
2018-12-31 13:06:30 -08:00
thermal
Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux
2019-01-05 16:07:28 -08:00
thunderbolt
…
tty
Merge tag 'armsoc-late' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc
2019-01-05 11:30:37 -08:00
uio
Merge tag 'char-misc-4.21-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc
2018-12-28 20:54:57 -08:00
usb
Merge tag 'pci-v4.21-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
2019-01-05 17:57:34 -08:00
uwb
…
vfio
Merge tag 'iommu-updates-v4.21' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
2019-01-01 15:55:29 -08:00
vhost
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
video
Merge tag 'fbdev-v4.21' of git://github.com/bzolnier/linux
2019-01-05 18:15:37 -08:00
virt
…
virtio
Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost
2019-01-02 18:54:45 -08:00
visorbus
…
vlynq
…
vme
…
w1
treewide: surround Kconfig file paths with double quotes
2018-12-22 00:25:54 +09:00
watchdog
Merge tag 'linux-watchdog-4.21-rc1' of git://www.linux-watchdog.org/linux-watchdog
2019-01-01 13:16:45 -08:00
xen
Remove 'type' argument from access_ok() function
2019-01-03 18:57:57 -08:00
zorro
…
Kconfig
Merge tag 'kconfig-v4.21-2' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
2018-12-29 13:40:29 -08:00
Makefile
…