Fix some of the memory allocation in framebuffers (#182)

* Fix some of the memory allocation in framebuffers

Also includes a the questionable change of undoing a previously
 made match for func_80027A20. The changes made here remove an
 AVOID_UB usage and (I would argue) is therefore more "correct",
 but undoing a byte-for-byte match is admittedly bad.

Also adds in some header files and updates some not-quite-right
 decomps to be slighly more accurate.

Signed-off-by: Taggerung <tyler.taggerung@gmail.com>
This commit is contained in:
Tyler McGavran
2022-08-15 01:47:11 -04:00
committed by GitHub
parent 2fe6c6a2f9
commit 7d23fcc063
13 changed files with 546 additions and 448 deletions
-8
View File
@@ -513,14 +513,6 @@ typedef struct
/* 0x7F */ u8 checksum;
} struct_8018EE10_entry; // size = 0x80
typedef struct {
char unk_00[0x920];
} struct_D_802DFB80; // size = 0x920
typedef struct {
char unk_00[0x1000];
} struct_D_802BFB80;
typedef struct {
/* 0x00 */ u16 red;
/* 0x02 */ u16 green;
-4
View File
@@ -12,10 +12,6 @@ void func_802B6540(f32* arg0, f32 arg1, f32 arg2, f32 arg3, s16 arg4);
void func_80295BF8(s32 arg0);
void func_8005D6C0(Player* player);
void func_8006B7E4(Player* player, s32 arg1);
void func_8002D268(Player* player, s32 arg1, s8 arg2, s8 arg3);
void func_8002934C(Player* player, s32 arg1, s8 arg2, s8 arg3);
void func_80027A20(Player* player, s8 arg1, s8 arg2, s32 arg3);
void func_80027040(Player* player, s8 arg1, s8 arg2, s8 arg3, s32 arg4);
void func_800267AC(Player* player, s8 arg1, s8 arg2);
void func_8005D290(void);
// TODO: should rot, arg4, and arg5 be rotx, roty, and rotz?
-2
View File
@@ -91,8 +91,6 @@ extern Mtx D_80183D60[];
extern struct_D_8018CE10 D_8018CE10[];
extern struct_D_802874D8 D_802874D8;
//extern struct_D_802DFB80 D_802DFB80[][8];
//extern struct_D_802BFB80 D_802BFB80[][8];
//extern struct GfxPool *gGfxPool; // D_8014EF40