diff --git a/actors_8c.html b/actors_8c.html index 65b7b2ff6..b9f497989 100644 --- a/actors_8c.html +++ b/actors_8c.html @@ -2618,7 +2618,7 @@ Here is the caller graph for this function:
-
Todo
Is this making the shell spin?
+
Todo
Is this making the shell spin?
Here is the call graph for this function:
diff --git a/actors_8h.html b/actors_8h.html index a79629aa6..d6c8b536f 100644 --- a/actors_8h.html +++ b/actors_8h.html @@ -2684,7 +2684,7 @@ Here is the caller graph for this function:
-
Todo
Is this making the shell spin?
+
Todo
Is this making the shell spin?
Here is the call graph for this function:
diff --git a/audio_2effects_8h_source.html b/audio_2effects_8h_source.html index 79b73a993..43e78ac0f 100644 --- a/audio_2effects_8h_source.html +++ b/audio_2effects_8h_source.html @@ -146,12 +146,12 @@ $(function(){initNavTree('audio_2effects_8h_source.html',''); initResizable(); }
36
37void sequence_channel_process_sound(struct SequenceChannel *seqChannel, s32 recalculateVolume);
38void sequence_player_process_sound(struct SequencePlayer *seqPlayer);
-
39f32 get_portamento_freq_scale(struct Portamento *p);
-
40s16 get_vibrato_pitch_change(struct VibratoState *vib);
-
41f32 get_vibrato_freq_scale(struct VibratoState *vib);
+
39f32 get_portamento_freq_scale(struct Portamento *p);
+
40s16 get_vibrato_pitch_change(struct VibratoState *vib);
+
41f32 get_vibrato_freq_scale(struct VibratoState *vib);
42void note_vibrato_update(struct Note *note);
43void note_vibrato_init(struct Note *note);
-
44void adsr_init(struct AdsrState *adsr, struct AdsrEnvelope *envelope, s16 *volOut);
+
44void adsr_init(struct AdsrState *adsr, struct AdsrEnvelope *envelope, s16 *volOut);
45f32 adsr_update(struct AdsrState *adsr);
46
47#endif /* AUDIO_EFFECTS_H */
@@ -164,7 +164,6 @@ $(function(){initNavTree('audio_2effects_8h_source.html',''); initResizable(); }
note_vibrato_update
void note_vibrato_update(struct Note *note)
Definition effects.c:160
sequence_player_process_sound
void sequence_player_process_sound(struct SequencePlayer *seqPlayer)
Definition effects.c:50
sequence_channel_process_sound
void sequence_channel_process_sound(struct SequenceChannel *seqChannel, s32 recalculateVolume)
Definition effects.c:10
-
D_8015F6E8
s16 D_8015F6E8
Definition code_800029B0.c:86
AdsrEnvelope
Definition internal.h:115
AdsrState
Definition internal.h:239
diff --git a/bug.html b/bug.html index 189575b96..59cb433d0 100644 --- a/bug.html +++ b/bug.html @@ -111,9 +111,9 @@ $(function(){initNavTree('bug.html',''); initResizable(); });
Global func_8001969C (s32, f32, s32, s16)
Adding an (f32) cast changes asm, why?
Global func_800B9BE4 (f32, f32, u16 *)
-
they probably meant to store the value to tmp[i] and tmp[8 + i]
+
they probably meant to store the value to tmp[i] and tmp[8 + i]
Global func_800BB388 (s32 bankId, s32 instId, s32 arg2)
-
missing return
+
missing return
Global func_802AF314 (void)
possibly bug. Allocate memory but not increment the pointer. This is bad, dumb code, and more importantly it's bad dumb code that doesn't make any sense here. It is incremented after this function completes using a different variable. Not good.
Global init_sequence_players (void)
@@ -121,15 +121,15 @@ $(function(){initNavTree('bug.html',''); initResizable(); });
Global load_ceremony_cutscene (void)
these segmented addresses need to be symbols for mobility
Global load_sequence_internal (u32, u32, s32)
-
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
+
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
Global new_actor (ActorInitParams *)

No null check.

Global note_set_vel_pan_reverb (struct Note *note, f32 velocity, u8 pan, u8 reverbVol)
-
for the change to UQ0.7, the if statement should also have been changed accordingly
+
for the change to UQ0.7, the if statement should also have been changed accordingly
Global preload_sequence (u32, u8)
-
should be IS_SEQ_LOAD_COMPLETE
+
should be IS_SEQ_LOAD_COMPLETE
Global update_gamestate (void)
Reloading this segment makes random_u16() deterministic for player spawn order. In laymens terms, random_u16() outputs the same value every time.
diff --git a/ceremony__and__credits_8c.html b/ceremony__and__credits_8c.html index ba1a2faa8..727ae9ef3 100644 --- a/ceremony__and__credits_8c.html +++ b/ceremony__and__credits_8c.html @@ -1008,7 +1008,7 @@ Here is the caller graph for this function:
-
Todo
Cast to normal Camera? Or from CinematicCamera?
+
Todo
Cast to normal Camera? Or from CinematicCamera?
Here is the call graph for this function:
@@ -1295,7 +1295,7 @@ Here is the caller graph for this function:
-
Todo
Does this match as a return of s8?
+
Todo
Does this match as a return of s8?
Here is the call graph for this function:
@@ -2367,7 +2367,7 @@ Here is the call graph for this function:
-
Todo
What does this even do?
+
Todo
What does this even do?
Here is the call graph for this function:
diff --git a/ceremony__and__credits_8h.html b/ceremony__and__credits_8h.html index dba923f0f..feb487175 100644 --- a/ceremony__and__credits_8h.html +++ b/ceremony__and__credits_8h.html @@ -955,7 +955,7 @@ Here is the caller graph for this function:
-
Todo
Cast to normal Camera? Or from CinematicCamera?
+
Todo
Cast to normal Camera? Or from CinematicCamera?
Here is the call graph for this function:
@@ -2197,7 +2197,7 @@ Here is the call graph for this function:
-
Todo
What does this even do?
+
Todo
What does this even do?
Here is the call graph for this function:
diff --git a/ceremony__data_8c.html b/ceremony__data_8c.html index e02892b04..994a3e562 100644 --- a/ceremony__data_8c.html +++ b/ceremony__data_8c.html @@ -1241,7 +1241,7 @@ Variables
{{{ 7, 0, -7}, 0, {-1279, 1024}, {0xe3, 0xf6, 0xff, 0xff}}},
}
-
Todo
rename this to left_ or right_ instead of model2.
+
Todo
rename this to left_ or right_ instead of model2.
diff --git a/ceremony__data_8h.html b/ceremony__data_8h.html index 83dde26ca..757228f2d 100644 --- a/ceremony__data_8h.html +++ b/ceremony__data_8h.html @@ -1031,7 +1031,7 @@ Variables
-
Todo
rename this to left_ or right_ instead of model2.
+
Todo
rename this to left_ or right_ instead of model2.
diff --git a/choco__mountain_2course__offsets_8c.html b/choco__mountain_2course__offsets_8c.html index fcf2ca7ff..76545271d 100644 --- a/choco__mountain_2course__offsets_8c.html +++ b/choco__mountain_2course__offsets_8c.html @@ -195,7 +195,7 @@ Variables
{gTexture653DB0, 0x06AE, 0x0800, 0x0},
{gTexture652B54, 0x0606, 0x0800, 0x0},
{gTexture65315C, 0x04A9, 0x0800, 0x0},
-
{gTexture6684F8, 0x010D, 0x0800, 0x0},
+
{gTexture6684F8, 0x010D, 0x0800, 0x0},
{gTextureSignLuigis0, 0x0287, 0x1000, 0x0},
{gTextureSignLuigis1, 0x02AF, 0x1000, 0x0},
{gTextureSignNintendoRed0, 0x02A6, 0x1000, 0x0},
@@ -219,7 +219,6 @@ Variables
gTexture64647C
u8 gTexture64647C[]
gTextureSignLuigis0
u8 gTextureSignLuigis0[]
gTexture652B54
u8 gTexture652B54[]
-
gTexture6684F8
u8 gTexture6684F8[]
gTextureSignYoshi
u8 gTextureSignYoshi[]
gTextureSignNintendoRed1
u8 gTextureSignNintendoRed1[]
gTextureSignLuigis1
u8 gTextureSignLuigis1[]
@@ -230,6 +229,7 @@ Variables
gTextureSignFallingRocks
u8 gTextureSignFallingRocks[]
gTexture647F4C
u8 gTexture647F4C[]
gTexture67DC20
u8 gTexture67DC20[]
+
gTexture6684F8
u8 gTexture6684F8[]
diff --git a/code__80005FD0_8c.html b/code__80005FD0_8c.html index e83b3ff2e..15efa4a39 100644 --- a/code__80005FD0_8c.html +++ b/code__80005FD0_8c.html @@ -2946,7 +2946,7 @@ Here is the caller graph for this function:
-
Todo
Confirm this comment
+
Todo
Confirm this comment
Here is the call graph for this function:
diff --git a/code__80005FD0_8h.html b/code__80005FD0_8h.html index ca4456395..986ecca59 100644 --- a/code__80005FD0_8h.html +++ b/code__80005FD0_8h.html @@ -2651,7 +2651,7 @@ Here is the caller graph for this function:
-
Todo
Confirm this comment
+
Todo
Confirm this comment
Here is the call graph for this function:
diff --git a/code__80091750_8c.html b/code__80091750_8c.html index 4fbe22c02..1cfe38d5e 100644 --- a/code__80091750_8c.html +++ b/code__80091750_8c.html @@ -325,8 +325,10 @@ Functions   void func_8009A344 (void)   -s32 func_8009A478 (MkAnimation *arg0, s32 arg1) -  +s32 func_8009A374 (MkAnimation *anim) +  +s32 func_8009A478 (MkAnimation *anim, s32 arg1) +  void func_8009A594 (s32 arg0, s32 arg1, MkAnimation *arg2)   void func_8009A640 (s32 arg0, s32 arg1, s32 arg2, MkAnimation *arg3) @@ -1872,7 +1874,7 @@ Here is the caller graph for this function:
-
Todo
These sizes need to be sizeof() for shiftability if possible
+
Todo
These sizes need to be sizeof() for shiftability if possible
Here is the call graph for this function:
@@ -3429,6 +3431,11 @@ Here is the call graph for this function:
+
+Here is the caller graph for this function:
+
+
+
@@ -3649,8 +3656,30 @@ Here is the caller graph for this function: - -

◆ func_8009A478()

+ +

◆ func_8009A374()

+ +
+
+ + + + + + + +
s32 func_8009A374 (MkAnimation * anim)
+
+
+Here is the call graph for this function:
+
+
+
+ +
+
+ +

◆ func_8009A478()

@@ -3658,7 +3687,7 @@ Here is the caller graph for this function:
s32 func_8009A478 ( - MkAnimation * arg0, + MkAnimation * anim, @@ -3670,7 +3699,7 @@ Here is the caller graph for this function:
Here is the call graph for this function:
-
+
@@ -12272,7 +12301,7 @@ Here is the caller graph for this function:
-
Todo
Move gGfxPool out of main.h
+
Todo
Move gGfxPool out of main.h
diff --git a/code__80091750_8c.js b/code__80091750_8c.js index bb07ead75..c0d636ac9 100644 --- a/code__80091750_8c.js +++ b/code__80091750_8c.js @@ -78,7 +78,8 @@ var code__80091750_8c = [ "func_8009A238", "code__80091750_8c.html#a9a2ab5fb6d9628518e4ee5adaabe4b95", null ], [ "func_8009A2F0", "code__80091750_8c.html#af8a43216551bc7fec0b6c1bbca329391", null ], [ "func_8009A344", "code__80091750_8c.html#ae938fb8c5b56456f2f0caf7dd552a51e", null ], - [ "func_8009A478", "code__80091750_8c.html#a4cf624bfea8bf40b25d30b373baa5d88", null ], + [ "func_8009A374", "code__80091750_8c.html#a615de300ffce980b06a7858a32b0c092", null ], + [ "func_8009A478", "code__80091750_8c.html#a062afe249e0193e30bdd29c511a36d90", null ], [ "func_8009A594", "code__80091750_8c.html#ab0b57eabb503b4ecd8eabd136da96826", null ], [ "func_8009A640", "code__80091750_8c.html#a5357c731c8075fc00c3b89630d2397e0", null ], [ "func_8009A6D4", "code__80091750_8c.html#a542612c8fd0d6566ae6133119b5fe9a2", null ], diff --git a/code__80091750_8c_a00867deac5db7d915e90f79b51b56d71_cgraph.svg b/code__80091750_8c_a00867deac5db7d915e90f79b51b56d71_cgraph.svg index 85ca0b351..f4d17b52d 100644 --- a/code__80091750_8c_a00867deac5db7d915e90f79b51b56d71_cgraph.svg +++ b/code__80091750_8c_a00867deac5db7d915e90f79b51b56d71_cgraph.svg @@ -48,7 +48,7 @@ + diff --git a/code__80091750_8c_a169ae6d995bc35511450e62bd89b4a9b_icgraph_org.svg b/code__80091750_8c_a169ae6d995bc35511450e62bd89b4a9b_icgraph_org.svg new file mode 100644 index 000000000..3b7d96de0 --- /dev/null +++ b/code__80091750_8c_a169ae6d995bc35511450e62bd89b4a9b_icgraph_org.svg @@ -0,0 +1,39 @@ + + + + + + +func_8009969C + + +Node1 + + +func_8009969C + + + + + +Node2 + + +func_8009A374 + + + + + +Node1->Node2 + + + + + + + + diff --git a/code__80091750_8c_a16a3481084a789f7c86482a195f63fee_cgraph.svg b/code__80091750_8c_a16a3481084a789f7c86482a195f63fee_cgraph.svg index f57f4bff7..4b66e7a37 100644 --- a/code__80091750_8c_a16a3481084a789f7c86482a195f63fee_cgraph.svg +++ b/code__80091750_8c_a16a3481084a789f7c86482a195f63fee_cgraph.svg @@ -48,7 +48,7 @@ + diff --git a/code__80091750_8c_a615de300ffce980b06a7858a32b0c092_cgraph_org.svg b/code__80091750_8c_a615de300ffce980b06a7858a32b0c092_cgraph_org.svg new file mode 100644 index 000000000..785597b70 --- /dev/null +++ b/code__80091750_8c_a615de300ffce980b06a7858a32b0c092_cgraph_org.svg @@ -0,0 +1,76 @@ + + + + + + +func_8009A374 + + +Node1 + + +func_8009A374 + + + + + +Node2 + + +func_8009969C + + + + + +Node1->Node2 + + + + + + + + +Node4 + + +segmented_to_virtual +_dupe_2 + + + + + +Node1->Node4 + + + + + + + + +Node3 + + +func_800996BC + + + + + +Node2->Node3 + + + + + + + + diff --git a/code__80091750_8c_a61edfa2085424561dc3a54bcaf4820dd_cgraph.svg b/code__80091750_8c_a61edfa2085424561dc3a54bcaf4820dd_cgraph.svg index 7482f213e..ca1b5d1b6 100644 --- a/code__80091750_8c_a61edfa2085424561dc3a54bcaf4820dd_cgraph.svg +++ b/code__80091750_8c_a61edfa2085424561dc3a54bcaf4820dd_cgraph.svg @@ -48,7 +48,7 @@ + diff --git a/code__80091750_8h_a0fcae22175ef1df772d337fb246c6120_icgraph_org.svg b/code__80091750_8h_a0fcae22175ef1df772d337fb246c6120_icgraph_org.svg new file mode 100644 index 000000000..3b7d96de0 --- /dev/null +++ b/code__80091750_8h_a0fcae22175ef1df772d337fb246c6120_icgraph_org.svg @@ -0,0 +1,39 @@ + + + + + + +func_8009969C + + +Node1 + + +func_8009969C + + + + + +Node2 + + +func_8009A374 + + + + + +Node1->Node2 + + + + + + + + diff --git a/code__80091750_8h_a10393ac14c047963cc7f3ef70aa25570_cgraph.svg b/code__80091750_8h_a10393ac14c047963cc7f3ef70aa25570_cgraph.svg index e50fa3a7b..b2c9d9e13 100644 --- a/code__80091750_8h_a10393ac14c047963cc7f3ef70aa25570_cgraph.svg +++ b/code__80091750_8h_a10393ac14c047963cc7f3ef70aa25570_cgraph.svg @@ -48,7 +48,7 @@ + diff --git a/code__80091750_8h_adff066f7147e37589be52c54176baed9_cgraph_org.svg b/code__80091750_8h_adff066f7147e37589be52c54176baed9_cgraph_org.svg new file mode 100644 index 000000000..785597b70 --- /dev/null +++ b/code__80091750_8h_adff066f7147e37589be52c54176baed9_cgraph_org.svg @@ -0,0 +1,76 @@ + + + + + + +func_8009A374 + + +Node1 + + +func_8009A374 + + + + + +Node2 + + +func_8009969C + + + + + +Node1->Node2 + + + + + + + + +Node4 + + +segmented_to_virtual +_dupe_2 + + + + + +Node1->Node4 + + + + + + + + +Node3 + + +func_800996BC + + + + + +Node2->Node3 + + + + + + + + diff --git a/code__80091750_8h_ae1d23ff319339fe77abc9af763b091f6_icgraph.svg b/code__80091750_8h_ae1d23ff319339fe77abc9af763b091f6_icgraph.svg index 4744730fa..5771a8aab 100644 --- a/code__80091750_8h_ae1d23ff319339fe77abc9af763b091f6_icgraph.svg +++ b/code__80091750_8h_ae1d23ff319339fe77abc9af763b091f6_icgraph.svg @@ -48,7 +48,7 @@