diff --git a/actors_8c.html b/actors_8c.html index c7bccaa36..b4001284e 100644 --- a/actors_8c.html +++ b/actors_8c.html @@ -1570,7 +1570,7 @@ Here is the caller graph for this function:
-
Todo
Is this making the shell spin?
+
Todo
Is this making the shell spin?
Here is the call graph for this function:
diff --git a/banshee__boardwalk_2course__data_8c.html b/banshee__boardwalk_2course__data_8c.html index a888c97de..a17edbca8 100644 --- a/banshee__boardwalk_2course__data_8c.html +++ b/banshee__boardwalk_2course__data_8c.html @@ -670,7 +670,7 @@ Variables
{
gsSPEndDisplayList(),
}
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/banshee__boardwalk_2course__data_8h.html b/banshee__boardwalk_2course__data_8h.html index 82e53fb3e..11ab48f2d 100644 --- a/banshee__boardwalk_2course__data_8h.html +++ b/banshee__boardwalk_2course__data_8h.html @@ -721,7 +721,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/bowsers__castle_2course__data_8c.html b/bowsers__castle_2course__data_8c.html index b583d0852..775a9e4a1 100644 --- a/bowsers__castle_2course__data_8c.html +++ b/bowsers__castle_2course__data_8c.html @@ -415,7 +415,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/bowsers__castle_2course__data_8h.html b/bowsers__castle_2course__data_8h.html index a60ae5481..8e84b53b8 100644 --- a/bowsers__castle_2course__data_8h.html +++ b/bowsers__castle_2course__data_8h.html @@ -427,7 +427,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/bug.html b/bug.html index 397ed0096..818f0cd57 100644 --- a/bug.html +++ b/bug.html @@ -120,21 +120,21 @@ $(function(){initNavTree('bug.html',''); initResizable(true); });
Global func_800B9BE4 (f32, f32, u16 *)
they probably meant to store the value to tmp[i] and tmp[8 + i]
Global func_800BB388 (s32 bankId, s32 instId, s32 arg2)
-
missing return
+
missing return
Global init_sequence_players (void)
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
Global load_ceremony_cutscene (void)
these segmented addresses need to be symbols for mobility
Global load_sequence_internal (u32, u32, s32)
-
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
+
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
Global new_actor (ActorInitParams *)

No null check.

Global note_set_vel_pan_reverb (struct Note *note, f32 velocity, u8 pan, u8 reverbVol)
-
for the change to UQ0.7, the if statement should also have been changed accordingly
+
for the change to UQ0.7, the if statement should also have been changed accordingly
Global preload_sequence (u32, u8)
-
should be IS_SEQ_LOAD_COMPLETE
+
should be IS_SEQ_LOAD_COMPLETE
Global update_gamestate (void)
Reloading this segment makes random_u16() deterministic for player spawn order. In laymens terms, random_u16() outputs the same value every time.
diff --git a/doxygen_crawl.html b/doxygen_crawl.html index 3cc1b09a7..695e9a4eb 100644 --- a/doxygen_crawl.html +++ b/doxygen_crawl.html @@ -10,10 +10,10 @@ - + - + @@ -58,10 +58,10 @@ - - + + @@ -242,8 +242,8 @@ - + @@ -379,8 +379,8 @@ - + @@ -409,7 +409,6 @@ - @@ -419,6 +418,8 @@ + + @@ -428,15 +429,14 @@ + - - - + @@ -506,29 +506,29 @@ + - - + - + - + @@ -546,8 +546,8 @@ - + @@ -556,10 +556,10 @@ + - @@ -629,8 +629,8 @@ - + @@ -669,8 +669,8 @@ - + @@ -683,8 +683,8 @@ - + @@ -699,9 +699,9 @@ - + @@ -712,8 +712,8 @@ - + @@ -733,12 +733,12 @@ - - + + @@ -770,9 +770,9 @@ - + @@ -800,6 +800,7 @@ + @@ -814,7 +815,6 @@ - @@ -836,17 +836,17 @@ - + + - @@ -856,8 +856,8 @@ - + @@ -866,27 +866,27 @@ - + + - - + - - + + @@ -901,20 +901,20 @@ - + - + - + @@ -922,21 +922,21 @@ - + - + @@ -952,14 +952,14 @@ - + - + @@ -972,22 +972,22 @@ + - - - + + @@ -996,28 +996,28 @@ - - + + - + - + @@ -1030,11 +1030,11 @@ + - @@ -1045,13 +1045,13 @@ - + - + diff --git a/load_8c.html b/load_8c.html index 5136deb35..79770be4a 100644 --- a/load_8c.html +++ b/load_8c.html @@ -841,7 +841,7 @@ Here is the caller graph for this function:
-
Bug
missing return
+
Bug
missing return
Here is the call graph for this function:
@@ -1029,7 +1029,7 @@ Here is the caller graph for this function:
-
Bug
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
+
Bug
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
Here is the call graph for this function:
@@ -1140,7 +1140,7 @@ Here is the caller graph for this function:
-
Bug
should be IS_SEQ_LOAD_COMPLETE
+
Bug
should be IS_SEQ_LOAD_COMPLETE
Here is the call graph for this function:
diff --git a/load_8h.html b/load_8h.html index e9ac0edd8..dba03b1da 100644 --- a/load_8h.html +++ b/load_8h.html @@ -650,7 +650,7 @@ Here is the caller graph for this function:
-
Bug
missing return
+
Bug
missing return
Here is the call graph for this function:
@@ -838,7 +838,7 @@ Here is the caller graph for this function:
-
Bug
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
+
Bug
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
Here is the call graph for this function:
@@ -949,7 +949,7 @@ Here is the caller graph for this function:
-
Bug
should be IS_SEQ_LOAD_COMPLETE
+
Bug
should be IS_SEQ_LOAD_COMPLETE
Here is the call graph for this function:
diff --git a/objects_8h.html b/objects_8h.html index 4e24a42bb..2d5c7f296 100644 --- a/objects_8h.html +++ b/objects_8h.html @@ -1969,7 +1969,7 @@ Variables
-
Todo
fix this extern
+
Todo
fix this extern
diff --git a/osPiRawStartDma_8c.html b/osPiRawStartDma_8c.html index d9692b656..f6ae1c3dc 100644 --- a/osPiRawStartDma_8c.html +++ b/osPiRawStartDma_8c.html @@ -191,7 +191,7 @@ Here is the caller graph for this function:
-
Todo
figure out why this is like this
+
Todo
figure out why this is like this
diff --git a/osPiStartDma_8c.html b/osPiStartDma_8c.html index 9f3d336d3..c67cabd1e 100644 --- a/osPiStartDma_8c.html +++ b/osPiStartDma_8c.html @@ -172,7 +172,7 @@ Variables
-
Todo
name magic constants
+
Todo
name magic constants
Here is the call graph for this function:
diff --git a/osViSwapBuffer_8c.html b/osViSwapBuffer_8c.html index c06aac184..d29fb6e09 100644 --- a/osViSwapBuffer_8c.html +++ b/osViSwapBuffer_8c.html @@ -143,7 +143,7 @@ Variables
-
Todo
figure out what this flag means
+
Todo
figure out what this flag means
Here is the call graph for this function:
diff --git a/os__pi_8h.html b/os__pi_8h.html index 4823c0e2a..7aeb528dd 100644 --- a/os__pi_8h.html +++ b/os__pi_8h.html @@ -446,7 +446,7 @@ Here is the caller graph for this function:
-
Todo
name magic constants
+
Todo
name magic constants
Here is the call graph for this function:
diff --git a/os__vi_8h.html b/os__vi_8h.html index 50010b8eb..c266e6b09 100644 --- a/os__vi_8h.html +++ b/os__vi_8h.html @@ -995,7 +995,7 @@ Here is the caller graph for this function:
-
Todo
figure out what this flag means
+
Todo
figure out what this flag means
Here is the call graph for this function:
diff --git a/piint_8h.html b/piint_8h.html index fc3419c0e..613e3407e 100644 --- a/piint_8h.html +++ b/piint_8h.html @@ -790,7 +790,7 @@ Variables
-
Todo
name
+
Todo
name
@@ -805,7 +805,7 @@ Variables
-
Todo
name
+
Todo
name
@@ -820,7 +820,7 @@ Variables
-
Todo
name
+
Todo
name
diff --git a/playback_8c.html b/playback_8c.html index 49714ca83..b852f9725 100644 --- a/playback_8c.html +++ b/playback_8c.html @@ -859,7 +859,7 @@ Here is the caller graph for this function:
-
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
+
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
Here is the caller graph for this function:
diff --git a/playback_8h.html b/playback_8h.html index 0b818a53e..6fbc35dd2 100644 --- a/playback_8h.html +++ b/playback_8h.html @@ -921,7 +921,7 @@ Here is the caller graph for this function:
-
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
+
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
Here is the caller graph for this function:
diff --git a/player__controller_8c.html b/player__controller_8c.html index 785a52fda..3ce8ba8ea 100644 --- a/player__controller_8c.html +++ b/player__controller_8c.html @@ -799,7 +799,7 @@ Here is the caller graph for this function:
-
Todo
make a proper match
+
Todo
make a proper match
Here is the call graph for this function:
diff --git a/player__controller_8h.html b/player__controller_8h.html index 6e735f407..d3dff464f 100644 --- a/player__controller_8h.html +++ b/player__controller_8h.html @@ -765,7 +765,7 @@ Here is the caller graph for this function:
-
Todo
make a proper match
+
Todo
make a proper match
Here is the call graph for this function:
diff --git a/some__data_8c.html b/some__data_8c.html index fe7a2d25e..d5dfcb6e2 100644 --- a/some__data_8c.html +++ b/some__data_8c.html @@ -2375,7 +2375,7 @@ Variables
0xff25, 0xffed, 0x0320,
0xffca, 0xfff8, 0x0270,
}
-
Todo
fix this extern
+
Todo
fix this extern
diff --git a/toads__turnpike_2course__data_8c.html b/toads__turnpike_2course__data_8c.html index 1a2c9e41a..413d8d60f 100644 --- a/toads__turnpike_2course__data_8c.html +++ b/toads__turnpike_2course__data_8c.html @@ -3033,7 +3033,7 @@ Variables
G_IM_FMT_RGBA
#define G_IM_FMT_RGBA
Definition gbi.h:396
G_IM_SIZ_16b
#define G_IM_SIZ_16b
Definition gbi.h:407
G_CC_DECALRGBA
#define G_CC_DECALRGBA
Definition gbi.h:512
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/toads__turnpike_2course__data_8h.html b/toads__turnpike_2course__data_8h.html index 785b6c262..2bd50a883 100644 --- a/toads__turnpike_2course__data_8h.html +++ b/toads__turnpike_2course__data_8h.html @@ -2817,7 +2817,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/todo.html b/todo.html index db3dfad75..c887fbcb3 100644 --- a/todo.html +++ b/todo.html @@ -126,21 +126,21 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global _course_mario_raceway_dl_mio0SegmentRomStart []
These should probably be ptr's instead of array's?
Global add_unused_obj_index (s32 *listIdx, s32 *nextFree, s32 size)
-
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
+
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
Global BAD_RETURN (cmd)
put this define in types.h or similar. Certain functions are marked as having return values, but do not actually return a value. This causes undefined behavior, which we'd rather avoid on modern GCC. This only impacts -O2 and can matter for both the function itself and functions that call it.
Global clear_framebuffer (s32)
Why did void* work for matching
Global D_800E43B0 []
-
unused?
+
unused?
Global D_8018D9B0
Move gGfxPool out of main.h
Global d_course_banshee_boardwalk_dl_0 []
-
Replace addresses with variables
+
Replace addresses with variables
Global d_course_big_donut_dl []
Replace addresses with variables
Global d_course_bowsers_castle_dl_0 []
-
Replace addresses with variables
+
Replace addresses with variables
Global d_course_dks_jungle_parkway_dl_0 []
Replace addresses with variables
Global d_course_frappe_snowland_dl_0 []
@@ -162,9 +162,9 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global d_course_sherbet_land_dl_0 []
Replace addresses with variables
Global d_course_toads_turnpike_dl_0 []
-
Replace addresses with variables
-
Global d_course_wario_stadium_dl_0 []
Replace addresses with variables
+
Global d_course_wario_stadium_dl_0 []
+
Replace addresses with variables
Global d_course_yoshi_valley_dl_0 []
Replace addresses with variables
Global debug_switch_character_ceremony_cutscene (void)
@@ -180,7 +180,7 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global func_800100F0 (s32)
Confirm this comment
Global func_80028864 (Player *, Camera *, s8, s8)
-
make a proper match
+
make a proper match
Global func_80046030 (u8 *tlut, u8 *texture, Vtx *arg2, s32 width, s32 arg4, s32 height)
tlut/texture unconfirmed. This could be texture1 and texture2
Global func_8004B7DC (s32 x, s32 y, s32 width, s32 height, s32 arg4, s32 arg5, s32 arg6)
@@ -188,7 +188,7 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global func_8004C268 (u32 arg0, u32 arg1, u8 *texture, u32 width, u32 arg4, u32 height, s32 arg6)
fakematch?
Global func_800745C8 (s32 objectIndex, uintptr_t arg1)
-
arg1 should likely be a u8 *
+
arg1 should likely be a u8 *
Global func_80091FA4 (void)
These sizes need to be sizeof() for shiftability if possible
Global func_800CBC24 (void)
@@ -206,15 +206,15 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global gPlayerWinningIndex
gPlayerWinningIndex (D_800DC5E8) accessed as word, D_800DC5EB as u8
Global gTorchSpawns []
-
fix this extern
+
fix this extern
Global IO_WRITE (addr, data)
These defines are from PR/rcp.h, but including that causes problems...
Global LEO_CMD_TYPE_0
-
name
+
name
Global LEO_CMD_TYPE_1
-
name
+
name
Global LEO_CMD_TYPE_2
-
name
+
name
Global M_TASK_FLAG0
These defines shouldn't exist - PR/rcp.h has them properly defined (ultralib)
Global MTX_KART_POOL_SIZE
@@ -230,17 +230,17 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global osPfsDeleteFile (OSPfs *pfs, u16 company_code, u32 game_code, u8 *game_name, u8 *ext_name)
magic constant
Global osPiStartDma (OSIoMesg *mb, s32 priority, s32 direction, uintptr_t devAddr, void *vAddr, size_t nbytes, OSMesgQueue *mq)
-
name magic constants
+
name magic constants
Global osRomBase
-
figure out why this is like this
+
figure out why this is like this
Global osViBlack (u8 active)
name magic constants
Global osViSwapBuffer (void *vaddr)
-
figure out what this flag means
+
figure out what this flag means
Global PI_DOMAIN1
This define is from os.h, but including that causes problems...
Global render_actor_shell (Camera *camera, Mat4 matrix, struct ShellActor *shell)
-
Is this making the shell spin?
+
Is this making the shell spin?
Global render_course_segments (uintptr_t, struct UnkStruct_800DC5EC *)
Should be Gfx*
Global SOUND_ARG_LOAD (sound_bank, byte2, byte3, sound_id)
diff --git a/update__objects_8c.html b/update__objects_8c.html index 3dc5d4215..48c108799 100644 --- a/update__objects_8c.html +++ b/update__objects_8c.html @@ -956,7 +956,7 @@ Variables
-
Todo
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
+
Todo
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
Here is the call graph for this function:
@@ -3944,7 +3944,7 @@ Here is the caller graph for this function:
-
Todo
arg1 should likely be a u8 *
+
Todo
arg1 should likely be a u8 *
Here is the call graph for this function:
@@ -12225,7 +12225,7 @@ Here is the caller graph for this function:
0.0, 0.0, 0.0, 0.0,
0.0, 0.0, 0.0, 0.0
}
-
Todo
unused?
+
Todo
unused?
diff --git a/wario__stadium_2course__data_8c.html b/wario__stadium_2course__data_8c.html index e4e15470c..fe60a77a3 100644 --- a/wario__stadium_2course__data_8c.html +++ b/wario__stadium_2course__data_8c.html @@ -455,7 +455,7 @@ Variables
d_course_wario_stadium_packed_dl_4218
Gfx d_course_wario_stadium_packed_dl_4218[]
Definition course_displaylists.inc.c:2649
d_course_wario_stadium_packed_dl_5888
Gfx d_course_wario_stadium_packed_dl_5888[]
Definition course_displaylists.inc.c:3475
d_course_wario_stadium_packed_dl_4BA8
Gfx d_course_wario_stadium_packed_dl_4BA8[]
Definition course_displaylists.inc.c:3007
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/wario__stadium_2course__data_8h.html b/wario__stadium_2course__data_8h.html index 84899ccee..befe1f103 100644 --- a/wario__stadium_2course__data_8h.html +++ b/wario__stadium_2course__data_8h.html @@ -423,7 +423,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables