diff --git a/bug.html b/bug.html index 62cba2b74..9f6eb6fee 100644 --- a/bug.html +++ b/bug.html @@ -124,12 +124,12 @@ $(function(){initNavTree('bug.html',''); initResizable(true); });
Global init_sequence_players (void)
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
Global load_ceremony_cutscene (void)
-
these segmented addresses need to be symbols for mobility
+
these segmented addresses need to be symbols for mobility
Global load_sequence_internal (u32, u32, s32)
This should set the last bank (i.e. the first in the JSON) as default, not the missing one. This code path never gets taken, though – all sequence loading is synchronous.
Global new_actor (ActorInitParams *)
-

No null check.

-

+

No null check.

+

Global note_set_vel_pan_reverb (struct Note *note, f32 velocity, u8 pan, u8 reverbVol)
for the change to UQ0.7, the if statement should also have been changed accordingly
diff --git a/choco__mountain_2course__offsets_8c.html b/choco__mountain_2course__offsets_8c.html index d12e752be..1c0db2ef1 100644 --- a/choco__mountain_2course__offsets_8c.html +++ b/choco__mountain_2course__offsets_8c.html @@ -197,10 +197,10 @@ Variables
{ gTexture64647C, 0x0829, 0x1000, 0x0 },
{ gTexture647F4C, 0x05BC, 0x1000, 0x0 },
{ gTexture64FBF4, 0x0274, 0x0800, 0x0 },
-
{ gTexture653DB0, 0x06AE, 0x0800, 0x0 },
+
{ gTexture653DB0, 0x06AE, 0x0800, 0x0 },
{ gTexture652B54, 0x0606, 0x0800, 0x0 },
{ gTexture65315C, 0x04A9, 0x0800, 0x0 },
-
{ gTexture6684F8, 0x010D, 0x0800, 0x0 },
+
{ gTexture6684F8, 0x010D, 0x0800, 0x0 },
{ gTextureSignLuigis0, 0x0287, 0x1000, 0x0 },
{ gTextureSignLuigis1, 0x02AF, 0x1000, 0x0 },
{ gTextureSignNintendoRed0, 0x02A6, 0x1000, 0x0 },
@@ -216,7 +216,6 @@ Variables
{ 0x00000000, 0x0000, 0x0000, 0x0 },
}
gTexture64FBF4
u8 gTexture64FBF4[]
-
gTexture653DB0
u8 gTexture653DB0[]
gTexture67B864
u8 gTexture67B864[]
gTexture65315C
u8 gTexture65315C[]
gTexture679C04
u8 gTexture679C04[]
@@ -225,16 +224,17 @@ Variables
gTexture64647C
u8 gTexture64647C[]
gTextureSignLuigis0
u8 gTextureSignLuigis0[]
gTexture652B54
u8 gTexture652B54[]
+
gTexture6684F8
u8 gTexture6684F8[]
gTextureSignYoshi
u8 gTextureSignYoshi[]
gTextureSignNintendoRed1
u8 gTextureSignNintendoRed1[]
gTextureSignLuigis1
u8 gTextureSignLuigis1[]
gTexture64619C
u8 gTexture64619C[]
gTextureSignBackside
u8 gTextureSignBackside[]
gTexture6774D8
u8 gTexture6774D8[]
+
gTexture653DB0
u8 gTexture653DB0[]
gTextureSignFallingRocks
u8 gTextureSignFallingRocks[]
gTexture647F4C
u8 gTexture647F4C[]
gTexture67DC20
u8 gTexture67DC20[]
-
gTexture6684F8
u8 gTexture6684F8[]
diff --git a/code__80281780_8c.html b/code__80281780_8c.html index d52f7c57d..0e4106bbe 100644 --- a/code__80281780_8c.html +++ b/code__80281780_8c.html @@ -247,7 +247,7 @@ Here is the caller graph for this function:
-
Bug
these segmented addresses need to be symbols for mobility
+
Bug
these segmented addresses need to be symbols for mobility
Here is the call graph for this function:
diff --git a/code__80281780_8h.html b/code__80281780_8h.html index 859c7bf3e..9ae89542e 100644 --- a/code__80281780_8h.html +++ b/code__80281780_8h.html @@ -247,7 +247,7 @@ Here is the caller graph for this function:
-
Bug
these segmented addresses need to be symbols for mobility
+
Bug
these segmented addresses need to be symbols for mobility
Here is the call graph for this function:
diff --git a/controller_8h.html b/controller_8h.html index 7311e85c3..1fb2c494d 100644 --- a/controller_8h.html +++ b/controller_8h.html @@ -1327,7 +1327,7 @@ Here is the caller graph for this function:
-
Todo
magic number
+
Todo
magic number
Here is the call graph for this function:
diff --git a/dks__jungle__parkway_2course__offsets_8c.html b/dks__jungle__parkway_2course__offsets_8c.html index 547daeef9..f6dfe0413 100644 --- a/dks__jungle__parkway_2course__offsets_8c.html +++ b/dks__jungle__parkway_2course__offsets_8c.html @@ -185,7 +185,7 @@ Variables
Initial value:
= {
{ gTexture648508, 0x01FE, 0x1000, 0x0 },
-
{ gTexture6684F8, 0x010D, 0x0800, 0x0 },
+
{ gTexture6684F8, 0x010D, 0x0800, 0x0 },
{ gTextureWoodBridgeSlats, 0x0DAB, 0x1000, 0x0 },
{ gTexture654460, 0x0B12, 0x1000, 0x0 },
{ gTexture654F74, 0x0A24, 0x1000, 0x0 },
@@ -210,6 +210,7 @@ Variables
{ gTexture683844, 0x0655, 0x0800, 0x0 },
{ 0x00000000, 0x0000, 0x0000, 0x0 },
}
+
u8 gTexture6684F8[]
u8 gTexture65E2EC[]
u8 gTexture655998[]
u8 gTexture65E59C[]
@@ -224,7 +225,6 @@ Variables
u8 gTexture65C8DC[]
u8 gTexture65BB3C[]
u8 gTexture65FB18[]
-
u8 gTexture6684F8[]
u8 gTexture654460[]
u8 gTexture65ADE0[]
u8 gTexture658370[]
diff --git a/doxygen_crawl.html b/doxygen_crawl.html index 3843d6cc7..5ef42047f 100644 --- a/doxygen_crawl.html +++ b/doxygen_crawl.html @@ -126,8 +126,8 @@ - + @@ -252,10 +252,10 @@ - - + + @@ -388,13 +388,13 @@ - + - + @@ -426,21 +426,21 @@ - + - + - - + + @@ -521,19 +521,19 @@ + + - - - + @@ -710,8 +710,8 @@ - + @@ -752,8 +752,8 @@ - + @@ -841,11 +841,11 @@ + - @@ -866,16 +866,16 @@ + - - + @@ -884,9 +884,9 @@ - + @@ -970,17 +970,17 @@ - + + - @@ -998,11 +998,11 @@ - + + - @@ -1010,15 +1010,15 @@ + - - + @@ -1030,8 +1030,8 @@ - + @@ -1041,13 +1041,13 @@ + - diff --git a/frappe__snowland_2course__offsets_8c.html b/frappe__snowland_2course__offsets_8c.html index 517fbbf35..095c26f35 100644 --- a/frappe__snowland_2course__offsets_8c.html +++ b/frappe__snowland_2course__offsets_8c.html @@ -152,7 +152,7 @@ Variables
Initial value:
= {
-
{ gTexture6684F8, 0x010D, 0x0800, 0x0 }, { gTexture66CA98, 0x02C9, 0x0800, 0x0 },
+
{ gTexture6684F8, 0x010D, 0x0800, 0x0 }, { gTexture66CA98, 0x02C9, 0x0800, 0x0 },
{ gTexture66EBF0, 0x0146, 0x0800, 0x0 }, { gTexture675434, 0x0245, 0x0800, 0x0 },
{ gTexture677F04, 0x0213, 0x0800, 0x0 }, { gTexture678118, 0x0314, 0x0800, 0x0 },
{ gTexture679258, 0x04E3, 0x1000, 0x0 }, { gTexture67973C, 0x04C6, 0x1000, 0x0 },
@@ -160,7 +160,7 @@ Variables
}
u8 gTexture66CA98[]
u8 gTexture66EBF0[]
-
u8 gTexture6684F8[]
+
u8 gTexture6684F8[]
u8 gTexture67973C[]
u8 gTexture675434[]
u8 gTexture678118[]
diff --git a/guMtxCatL_8c.html b/guMtxCatL_8c.html index 040701075..41d61aeb1 100644 --- a/guMtxCatL_8c.html +++ b/guMtxCatL_8c.html @@ -184,7 +184,7 @@ Here is the caller graph for this function:
-
Todo
Move gGfxPool out of main.h
+
Todo
Move gGfxPool out of main.h
Here is the call graph for this function:
diff --git a/kalimari__desert_2course__offsets_8c.html b/kalimari__desert_2course__offsets_8c.html index 711568024..5844bd999 100644 --- a/kalimari__desert_2course__offsets_8c.html +++ b/kalimari__desert_2course__offsets_8c.html @@ -862,7 +862,7 @@ Variables
Initial value:
= {
-
{ gTexture6684F8, 0x010D, 0x0800, 0x0 }, { gTextureSignLuigis0, 0x0287, 0x1000, 0x0 },
+
{ gTexture6684F8, 0x010D, 0x0800, 0x0 }, { gTextureSignLuigis0, 0x0287, 0x1000, 0x0 },
{ gTextureSignLuigis1, 0x02AF, 0x1000, 0x0 }, { gTextureSignMarioStar0, 0x02D2, 0x1000, 0x0 },
{ gTextureSignMarioStar1, 0x02B1, 0x1000, 0x0 }, { gTextureSignNintendoRed0, 0x02A6, 0x1000, 0x0 },
{ gTextureSignNintendoRed1, 0x02F7, 0x1000, 0x0 }, { gTexture67490C, 0x021C, 0x0800, 0x0 },
@@ -872,26 +872,24 @@ Variables
{ gTextureRailroadTrack, 0x0B5B, 0x1000, 0x0 }, { gTextureRailroadCrossingTrack, 0x0208, 0x1000, 0x0 },
{ gTexture67291C, 0x059C, 0x0800, 0x0 }, { gTextureFenceBarbedWire, 0x021E, 0x1000, 0x0 },
{ gTexture67D304, 0x091C, 0x1000, 0x0 }, { gTexture67E010, 0x0415, 0x0800, 0x0 },
-
{ gTexture67EEAC, 0x0140, 0x0800, 0x0 }, { gTextureSignShellShot0, 0x038C, 0x1000, 0x0 },
-
{ gTextureSignShellShot1, 0x0247, 0x1000, 0x0 }, { gTextureSignKoopaAir0, 0x0360, 0x1000, 0x0 },
+
{ gTexture67EEAC, 0x0140, 0x0800, 0x0 }, { gTextureSignShellShot0, 0x038C, 0x1000, 0x0 },
+
{ gTextureSignShellShot1, 0x0247, 0x1000, 0x0 }, { gTextureSignKoopaAir0, 0x0360, 0x1000, 0x0 },
{ gTextureSignKoopaAir1, 0x0304, 0x1000, 0x0 }, { 0x00000000, 0x0000, 0x0000, 0x0 },
}
u8 gTexture67490C[]
u8 gTextureCheckerboardBlueGray[]
u8 gTextureSignNintendoRed0[]
u8 gTextureSignLuigis0[]
+
u8 gTexture6684F8[]
u8 gTextureSignYoshi[]
u8 gTextureSignNintendoRed1[]
u8 gTextureSignLuigis1[]
-
u8 gTexture6684F8[]
u8 gTexture67E010[]
u8 gTextureRailroadTrack[]
u8 gTextureRailroadCrossingTrack[]
u8 gTextureSignKoopaAir0[]
u8 gTexture6473E4[]
-
u8 gTextureSignShellShot1[]
u8 gTexture67D304[]
-
u8 gTextureSignShellShot0[]
u8 gTextureSignMarioStar0[]
u8 gTexture668920[]
u8 gTexture67291C[]
@@ -901,6 +899,8 @@ Variables
u8 gTexture647994[]
u8 gTextureFenceBarbedWire[]
u8 gTextureSignMarioStar1[]
+
u8 gTextureSignShellShot1[]
+
u8 gTextureSignShellShot0[]
diff --git a/menu__items_8c.html b/menu__items_8c.html index 066419835..9821b7fd5 100644 --- a/menu__items_8c.html +++ b/menu__items_8c.html @@ -1984,7 +1984,7 @@ Here is the caller graph for this function:
-
Todo
These sizes need to be sizeof() for shiftability if possible
+
Todo
These sizes need to be sizeof() for shiftability if possible
Here is the call graph for this function:
@@ -8954,7 +8954,7 @@ Here is the caller graph for this function:
-
Todo
Move gGfxPool out of main.h
+
Todo
Move gGfxPool out of main.h
Here is the call graph for this function:
diff --git a/menu__items_8h.html b/menu__items_8h.html index 76c787785..debb46663 100644 --- a/menu__items_8h.html +++ b/menu__items_8h.html @@ -2602,7 +2602,7 @@ Here is the caller graph for this function:
-
Todo
These sizes need to be sizeof() for shiftability if possible
+
Todo
These sizes need to be sizeof() for shiftability if possible
Here is the call graph for this function:
diff --git a/osEPiRawStartDma_8c.html b/osEPiRawStartDma_8c.html index cfc511d28..228e343c2 100644 --- a/osEPiRawStartDma_8c.html +++ b/osEPiRawStartDma_8c.html @@ -154,7 +154,7 @@ Functions
-
Todo
These defines are from PR/rcp.h, but including that causes problems...
+
Todo
These defines are from PR/rcp.h, but including that causes problems...
@@ -169,7 +169,7 @@ Functions
-
Todo
This define is from os.h, but including that causes problems...
+
Todo
This define is from os.h, but including that causes problems...
@@ -193,7 +193,7 @@ Functions
Value:
if (cHandle->var != pihandle->var) \
IO_WRITE(reg, pihandle->var);
-
Todo
This define is from piint.h, but including that causes problems...
+
Todo
This define is from piint.h, but including that causes problems...
diff --git a/osPfsDeleteFile_8c.html b/osPfsDeleteFile_8c.html index d84cba50c..057e6db9e 100644 --- a/osPfsDeleteFile_8c.html +++ b/osPfsDeleteFile_8c.html @@ -212,7 +212,7 @@ Here is the caller graph for this function:
-
Todo
magic number
+
Todo
magic number
Here is the call graph for this function:
@@ -259,7 +259,7 @@ Here is the caller graph for this function:
-
Todo
magic constant
+
Todo
magic constant
Here is the call graph for this function:
diff --git a/osPiRawStartDma_8c.html b/osPiRawStartDma_8c.html index 71ec84cb3..2cc167b60 100644 --- a/osPiRawStartDma_8c.html +++ b/osPiRawStartDma_8c.html @@ -191,7 +191,7 @@ Here is the caller graph for this function:
-
Todo
figure out why this is like this
+
Todo
figure out why this is like this
diff --git a/osPiStartDma_8c.html b/osPiStartDma_8c.html index 161441ba4..94ac5d4fa 100644 --- a/osPiStartDma_8c.html +++ b/osPiStartDma_8c.html @@ -172,7 +172,7 @@ Variables
-
Todo
name magic constants
+
Todo
name magic constants
Here is the call graph for this function:
diff --git a/os__pi_8h.html b/os__pi_8h.html index 7aeb528dd..1badf506c 100644 --- a/os__pi_8h.html +++ b/os__pi_8h.html @@ -446,7 +446,7 @@ Here is the caller graph for this function:
-
Todo
name magic constants
+
Todo
name magic constants
Here is the call graph for this function:
diff --git a/podium__ceremony__actors_8c.html b/podium__ceremony__actors_8c.html index 085410149..618e680ef 100644 --- a/podium__ceremony__actors_8c.html +++ b/podium__ceremony__actors_8c.html @@ -598,8 +598,8 @@ Here is the caller graph for this function:
-
Bug
No null check.
-
Bug
+
Bug
No null check.
+
Bug
Todo
More indepth error checking/return value
Here is the call graph for this function:
diff --git a/podium__ceremony__actors_8h.html b/podium__ceremony__actors_8h.html index 4cf9a2839..5a7319d1e 100644 --- a/podium__ceremony__actors_8h.html +++ b/podium__ceremony__actors_8h.html @@ -558,8 +558,8 @@ Here is the caller graph for this function:
-
Bug
No null check.
-
Bug
+
Bug
No null check.
+
Bug
Todo
More indepth error checking/return value
Here is the call graph for this function:
diff --git a/race__logic_8c.html b/race__logic_8c.html index 4c399decc..360147dc4 100644 --- a/race__logic_8c.html +++ b/race__logic_8c.html @@ -736,7 +736,7 @@ Here is the caller graph for this function:
-
Todo
increasing players past four would require increase this loop iterator.
+
Todo
increasing players past four would require increase this loop iterator.
Here is the call graph for this function:
diff --git a/race__logic_8h.html b/race__logic_8h.html index da3e4236f..18b1223b7 100644 --- a/race__logic_8h.html +++ b/race__logic_8h.html @@ -675,7 +675,7 @@ Here is the caller graph for this function:
-
Todo
increasing players past four would require increase this loop iterator.
+
Todo
increasing players past four would require increase this loop iterator.
Here is the call graph for this function:
diff --git a/render__courses_8c.html b/render__courses_8c.html index bbc858030..1b5c6a43f 100644 --- a/render__courses_8c.html +++ b/render__courses_8c.html @@ -741,7 +741,7 @@ Here is the caller graph for this function:
-
Todo
Should be Gfx*
+
Todo
Should be Gfx*
Here is the call graph for this function:
diff --git a/render__courses_8h.html b/render__courses_8h.html index f4f3a7440..2fa8953ee 100644 --- a/render__courses_8h.html +++ b/render__courses_8h.html @@ -709,7 +709,7 @@ Here is the caller graph for this function:
-
Todo
Should be Gfx*
+
Todo
Should be Gfx*
Here is the call graph for this function:
diff --git a/toads__turnpike_2course__data_8c.html b/toads__turnpike_2course__data_8c.html index b3c360463..02ae07f38 100644 --- a/toads__turnpike_2course__data_8c.html +++ b/toads__turnpike_2course__data_8c.html @@ -3036,7 +3036,7 @@ Variables
#define G_IM_SIZ_16b
Definition gbi.h:403
#define G_CC_DECALRGBA
Definition gbi.h:508
u8 gTTTexture64FE68[]
Definition course_textures.linkonly.c:9
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/toads__turnpike_2course__data_8h.html b/toads__turnpike_2course__data_8h.html index f8ee6fc48..ae6d7b68c 100644 --- a/toads__turnpike_2course__data_8h.html +++ b/toads__turnpike_2course__data_8h.html @@ -2817,7 +2817,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/todo.html b/todo.html index 96826a7f1..4da22ca2f 100644 --- a/todo.html +++ b/todo.html @@ -114,7 +114,7 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });

loads of magic constants..

Global __osPfsReleasePages (OSPfs *pfs, __OSInode *inode, u8 start_page, u16 *sum, u8 bank, __OSInodeUnit *last_page, int flag)
-
magic number
+
magic number
Global __osPfsRWInode (OSPfs *pfs, __OSInode *inode, u8 flag, u8 bank)
don't like this =/ //maybe &inode->inode_table[j*PFS_ONE_PAGE].ipage or something
Global __osPiDevMgr
@@ -160,9 +160,9 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global d_course_sherbet_land_dl_0 []
Replace addresses with variables
Global d_course_toads_turnpike_dl_0 []
-
Replace addresses with variables
-
Global d_course_wario_stadium_dl_0 []
Replace addresses with variables
+
Global d_course_wario_stadium_dl_0 []
+
Replace addresses with variables
Global d_course_yoshi_valley_dl_0 []
Replace addresses with variables
Global debug_switch_character_ceremony_cutscene (void)
@@ -184,7 +184,7 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global func_800745C8 (s32 objectIndex, uintptr_t arg1)
arg1 should likely be a u8 *
Global func_80091FA4 (void)
-
These sizes need to be sizeof() for shiftability if possible
+
These sizes need to be sizeof() for shiftability if possible
Global func_800CBC24 (void)
clenanup, something's weird with the variables. D_800EA4A4 is probably EuAudioCmd bc of the + 0x100
Global func_8028336C (UNUSED CinematicCamera *arg0, UNUSED Camera *camera)
@@ -192,7 +192,7 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global func_802846E4 (CinematicCamera *)
What does this even do?
Global func_8028F970 (void)
-
increasing players past four would require increase this loop iterator.
+
increasing players past four would require increase this loop iterator.
Global gen_random_item (s16 rank, s16 isCpu)
Cleanup this function to use array access and struct if possible.
Global gPlayerWinningIndex
@@ -200,9 +200,9 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global gTorchSpawns []
fix this extern
Global guMtxCatL (Mtx *m, Mtx *n, Mtx *res)
-
Move gGfxPool out of main.h
+
Move gGfxPool out of main.h
Global IO_WRITE (addr, data)
-
These defines are from PR/rcp.h, but including that causes problems...
+
These defines are from PR/rcp.h, but including that causes problems...
Global LEO_CMD_TYPE_0
name
Global LEO_CMD_TYPE_1
@@ -224,25 +224,25 @@ $(function(){initNavTree('todo.html',''); initResizable(true); });
Global osContInit (OSMesgQueue *mq, u8 *bitpattern, OSContStatus *status)
figure out what it means
Global osPfsDeleteFile (OSPfs *pfs, u16 company_code, u32 game_code, u8 *game_name, u8 *ext_name)
-
magic constant
+
magic constant
Global osPiStartDma (OSIoMesg *mb, s32 priority, s32 direction, uintptr_t devAddr, void *vAddr, size_t nbytes, OSMesgQueue *mq)
-
name magic constants
+
name magic constants
Global osRomBase
-
figure out why this is like this
+
figure out why this is like this
Global osViBlack (u8 active)
name magic constants
Global osViSwapBuffer (void *vaddr)
figure out what this flag means
Global PI_DOMAIN1
-
This define is from os.h, but including that causes problems...
+
This define is from os.h, but including that causes problems...
Global render_actor_shell (Camera *camera, Mat4 matrix, struct ShellActor *shell)
Is this making the shell spin?
Global render_course_segments (uintptr_t, struct UnkStruct_800DC5EC *)
-
Should be Gfx*
+
Should be Gfx*
Global SOUND_ARG_LOAD (sound_bank, byte2, byte3, sound_id)
format like sm64 sounds.h
Global UPDATE_REG (reg, var)
-
This define is from piint.h, but including that causes problems...
+
This define is from piint.h, but including that causes problems...
Global US_FLOAT (x)
US_FLOAT should probably be renamed to JP_DOUBLE since eu seems to use floats too
diff --git a/wario__stadium_2course__data_8c.html b/wario__stadium_2course__data_8c.html index 4a8dc91b6..4522f2814 100644 --- a/wario__stadium_2course__data_8c.html +++ b/wario__stadium_2course__data_8c.html @@ -454,7 +454,7 @@ Variables
d_course_wario_stadium_packed_dl_4218
Gfx d_course_wario_stadium_packed_dl_4218[]
Definition course_displaylists.inc.c:2737
d_course_wario_stadium_packed_dl_5888
Gfx d_course_wario_stadium_packed_dl_5888[]
Definition course_displaylists.inc.c:3603
d_course_wario_stadium_packed_dl_4BA8
Gfx d_course_wario_stadium_packed_dl_4BA8[]
Definition course_displaylists.inc.c:3112
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/wario__stadium_2course__data_8h.html b/wario__stadium_2course__data_8h.html index 6b58a8349..3ce1e96b4 100644 --- a/wario__stadium_2course__data_8h.html +++ b/wario__stadium_2course__data_8h.html @@ -423,7 +423,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables