diff --git a/actors_8c.html b/actors_8c.html index 1f69431ad..a7631b973 100644 --- a/actors_8c.html +++ b/actors_8c.html @@ -1565,7 +1565,7 @@ Here is the caller graph for this function:
-
Todo
Is this making the shell spin?
+
Todo
Is this making the shell spin?
Here is the call graph for this function:
diff --git a/blue__and__red__shells_2update_8inc_8c_source.html b/blue__and__red__shells_2update_8inc_8c_source.html index 9e5415d53..6b593cd1a 100644 --- a/blue__and__red__shells_2update_8inc_8c_source.html +++ b/blue__and__red__shells_2update_8inc_8c_source.html @@ -158,59 +158,59 @@ $(function(){initNavTree('blue__and__red__shells_2update_8inc_8c_source.html',''
47 temp_f16_3 = D_80164490[nextWaypoint].posY;
48 temp_f26 = D_80164490[nextWaypoint].posZ;
49
-
50 temp_f12_0 = temp_f18_3 - shell->pos[0];
-
51 temp_f12_1 = temp_f16_3 - shell->pos[1];
-
52 temp_f12_2 = temp_f26 - shell->pos[2];
+
50 temp_f12_0 = temp_f18_3 - shell->pos[0];
+
51 temp_f12_1 = temp_f16_3 - shell->pos[1];
+
52 temp_f12_2 = temp_f26 - shell->pos[2];
53
-
54 temp_f0_3 = (temp_f12_0 * temp_f12_0) + (temp_f12_1 * temp_f12_1) + (temp_f12_2 * temp_f12_2);
-
55 if (temp_f0_3 < temp_f0) {
-
56 shell->pathIndex = nextWaypoint;
+ +
55 if (temp_f0_3 < temp_f0) {
+
56 shell->pathIndex = nextWaypoint;
57 } else {
-
58 temp_f0_2 = sqrtf(temp_f0) * 4.0f;
-
59 temp_f20 /= temp_f0_2;
-
60 temp_f22 /= temp_f0_2;
-
61 temp_f24 /= temp_f0_2;
+
58 temp_f0_2 = sqrtf(temp_f0) * 4.0f;
+ + +
62
-
63 temp_f12_3 = shell->velocity[0];
-
64 temp_f14_2 = shell->velocity[1];
-
65 temp_f16_2 = shell->velocity[2];
+
63 temp_f12_3 = shell->velocity[0];
+
64 temp_f14_2 = shell->velocity[1];
+
65 temp_f16_2 = shell->velocity[2];
66
-
67 temp_f12_3 += temp_f20;
-
68 temp_f14_2 += temp_f22;
-
69 temp_f16_2 += temp_f24;
-
70 temp_f0 = sqrtf((temp_f12_3 * temp_f12_3) + (temp_f14_2 * temp_f14_2) + (temp_f16_2 * temp_f16_2));
-
71 if (temp_f0 > 6.0f) {
-
72 temp_f0 /= 6.0f;
-
73 temp_f12_3 /= temp_f0;
-
74 temp_f14_2 /= temp_f0;
-
75 temp_f16_2 /= temp_f0;
+ + + + +
71 if (temp_f0 > 6.0f) {
+
72 temp_f0 /= 6.0f;
+ + +
76 }
-
77 shell->velocity[0] = temp_f12_3;
-
78 shell->velocity[1] = temp_f14_2;
-
79 shell->velocity[2] = temp_f16_2;
+
77 shell->velocity[0] = temp_f12_3;
+
78 shell->velocity[1] = temp_f14_2;
+
79 shell->velocity[2] = temp_f16_2;
80
-
81 origPos[0] = shell->pos[0];
-
82 origPos[1] = shell->pos[1];
-
83 origPos[2] = shell->pos[2];
+
81 origPos[0] = shell->pos[0];
+
82 origPos[1] = shell->pos[1];
+
83 origPos[2] = shell->pos[2];
84
-
85 shell->pos[0] += temp_f12_3;
-
86 shell->pos[1] += temp_f14_2;
-
87 shell->pos[2] += temp_f16_2;
-
88 func_802AD950(&shell->unk30, 4.0f, shell->pos[0], shell->pos[1], shell->pos[2], origPos[0], origPos[1], origPos[2]);
-
89 func_802B4E30((struct Actor *) shell);
+
85 shell->pos[0] += temp_f12_3;
+
86 shell->pos[1] += temp_f14_2;
+
87 shell->pos[2] += temp_f16_2;
+
88 func_802AD950(&shell->unk30, 4.0f, shell->pos[0], shell->pos[1], shell->pos[2], origPos[0], origPos[1], origPos[2]);
+
89 func_802B4E30((struct Actor *) shell);
90 }
91 } else {
-
92 if (temp_f0 > 5.0f) {
-
93 shell->pos[0] = temp_f2;
-
94 shell->pos[1] = shell->boundingBoxSize + temp_f12;
-
95 shell->pos[2] = temp_f28;
-
96 shell->pathIndex = nextWaypoint;
+
92 if (temp_f0 > 5.0f) {
+
93 shell->pos[0] = temp_f2;
+
94 shell->pos[1] = shell->boundingBoxSize + temp_f12;
+
95 shell->pos[2] = temp_f28;
+
96 shell->pathIndex = nextWaypoint;
97 } else {
-
98 temp_f18_3 = D_80164490[nextWaypoint].posX;
-
99 temp_f16_3 = D_80164490[nextWaypoint].posY;
-
100 temp_f26 = D_80164490[nextWaypoint].posZ;
+ + +
101
-
102 shell->pos[0] = (temp_f2 + temp_f18_3) * 0.5f;
+
102 shell->pos[0] = (temp_f2 + temp_f18_3) * 0.5f;
103 shell->pos[1] = ((temp_f12 + temp_f16_3) * 0.5f) + shell->boundingBoxSize;
104 shell->pos[2] = (temp_f28 + temp_f26) * 0.5f;
105
@@ -660,10 +660,7 @@ $(function(){initNavTree('blue__and__red__shells_2update_8inc_8c_source.html',''
s16 currentRank
Definition common_structs.h:251
Vec3f pos
Definition common_structs.h:258
Definition actor_types.h:302
-
f32 boundingBoxSize
Definition actor_types.h:315
-
Vec3f velocity
Definition actor_types.h:324
Vec3f pos
Definition actor_types.h:323
-
Collision unk30
Definition actor_types.h:325
u16 pathIndex
Definition actor_types.h:319
s16 posZ
Definition waypoints.h:9
s16 posY
Definition waypoints.h:8
diff --git a/bug.html b/bug.html index cb0bbc309..b0b20d6ca 100644 --- a/bug.html +++ b/bug.html @@ -117,7 +117,7 @@ $(function(){initNavTree('bug.html',''); initResizable(); });
Global func_802AF314 (void)
possibly bug. Allocate memory but not increment the pointer. This is bad, dumb code, and more importantly it's bad dumb code that doesn't make any sense here. It is incremented after this function completes using a different variable. Not good.
Global init_sequence_players (void)
-
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
+
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
Global load_ceremony_cutscene (void)
these segmented addresses need to be symbols for mobility
Global load_sequence_internal (u32, u32, s32)
@@ -127,7 +127,7 @@ $(function(){initNavTree('bug.html',''); initResizable(); });

Global note_set_vel_pan_reverb (struct Note *note, f32 velocity, u8 pan, u8 reverbVol)
-
for the change to UQ0.7, the if statement should also have been changed accordingly
+
for the change to UQ0.7, the if statement should also have been changed accordingly
Global preload_sequence (u32, u8)
should be IS_SEQ_LOAD_COMPLETE
Global update_gamestate (void)
diff --git a/ceremony__and__credits_8c.html b/ceremony__and__credits_8c.html index 118e7321c..537a90de9 100644 --- a/ceremony__and__credits_8c.html +++ b/ceremony__and__credits_8c.html @@ -1008,7 +1008,7 @@ Here is the caller graph for this function:
-
Todo
Cast to normal Camera? Or from CinematicCamera?
+
Todo
Cast to normal Camera? Or from CinematicCamera?
Here is the call graph for this function:
@@ -1295,7 +1295,7 @@ Here is the caller graph for this function:
-
Todo
Does this match as a return of s8?
+
Todo
Does this match as a return of s8?
Here is the call graph for this function:
@@ -2367,7 +2367,7 @@ Here is the call graph for this function:
-
Todo
What does this even do?
+
Todo
What does this even do?
Here is the call graph for this function:
diff --git a/ceremony__and__credits_8h.html b/ceremony__and__credits_8h.html index 4c4413038..d6d4c8fbd 100644 --- a/ceremony__and__credits_8h.html +++ b/ceremony__and__credits_8h.html @@ -960,7 +960,7 @@ Here is the caller graph for this function:
-
Todo
Cast to normal Camera? Or from CinematicCamera?
+
Todo
Cast to normal Camera? Or from CinematicCamera?
Here is the call graph for this function:
@@ -2202,7 +2202,7 @@ Here is the call graph for this function:
-
Todo
What does this even do?
+
Todo
What does this even do?
Here is the call graph for this function:
diff --git a/choco__mountain_2course__offsets_8c.html b/choco__mountain_2course__offsets_8c.html index 627cb3a2f..01c9eead1 100644 --- a/choco__mountain_2course__offsets_8c.html +++ b/choco__mountain_2course__offsets_8c.html @@ -192,7 +192,7 @@ Variables
{gTexture64647C, 0x0829, 0x1000, 0x0},
{gTexture647F4C, 0x05BC, 0x1000, 0x0},
{gTexture64FBF4, 0x0274, 0x0800, 0x0},
-
{gTexture653DB0, 0x06AE, 0x0800, 0x0},
+
{gTexture653DB0, 0x06AE, 0x0800, 0x0},
{gTexture652B54, 0x0606, 0x0800, 0x0},
{gTexture65315C, 0x04A9, 0x0800, 0x0},
{gTexture6684F8, 0x010D, 0x0800, 0x0},
@@ -211,6 +211,7 @@ Variables
{0x00000000, 0x0000, 0x0000, 0x0},
}
u8 gTexture64FBF4[]
+
u8 gTexture653DB0[]
u8 gTexture67B864[]
u8 gTexture65315C[]
u8 gTexture679C04[]
@@ -226,7 +227,6 @@ Variables
u8 gTexture64619C[]
u8 gTextureSignBackside[]
u8 gTexture6774D8[]
-
u8 gTexture653DB0[]
u8 gTextureSignFallingRocks[]
u8 gTexture647F4C[]
u8 gTexture67DC20[]
diff --git a/code__80091750_8c.html b/code__80091750_8c.html index 26461aaa9..2082a710a 100644 --- a/code__80091750_8c.html +++ b/code__80091750_8c.html @@ -1880,7 +1880,7 @@ Here is the caller graph for this function:
-
Todo
These sizes need to be sizeof() for shiftability if possible
+
Todo
These sizes need to be sizeof() for shiftability if possible
Here is the call graph for this function:
@@ -12161,7 +12161,7 @@ Here is the caller graph for this function:
-
Todo
Move gGfxPool out of main.h
+
Todo
Move gGfxPool out of main.h
diff --git a/code__80091750_8h.html b/code__80091750_8h.html index f8b32875b..34d710eaf 100644 --- a/code__80091750_8h.html +++ b/code__80091750_8h.html @@ -2057,7 +2057,7 @@ Here is the caller graph for this function:
-
Todo
These sizes need to be sizeof() for shiftability if possible
+
Todo
These sizes need to be sizeof() for shiftability if possible
Here is the call graph for this function:
@@ -13095,7 +13095,7 @@ Here is the caller graph for this function:
-
Todo
Move gGfxPool out of main.h
+
Todo
Move gGfxPool out of main.h
diff --git a/code__80281780_8c.html b/code__80281780_8c.html index de7285953..2aa52b199 100644 --- a/code__80281780_8c.html +++ b/code__80281780_8c.html @@ -165,7 +165,7 @@ Variables
-
Todo
confirm this.
+
Todo
confirm this.
Here is the call graph for this function:
diff --git a/code__80281780_8h.html b/code__80281780_8h.html index 3b18f8e1b..72e5eb8c6 100644 --- a/code__80281780_8h.html +++ b/code__80281780_8h.html @@ -165,7 +165,7 @@ Variables
-
Todo
confirm this.
+
Todo
confirm this.
Here is the call graph for this function:
-
Todo
Why did void* work for matching
+
Todo
Why did void* work for matching
Here is the caller graph for this function:
diff --git a/main_8h.html b/main_8h.html index aed101a92..7c156017d 100644 --- a/main_8h.html +++ b/main_8h.html @@ -611,7 +611,7 @@ Variables
-
Todo
Verify with proper documentation
+
Todo
Verify with proper documentation
@@ -640,7 +640,7 @@ Variables
-
Todo
Verify with proper documentation
+
Todo
Verify with proper documentation
@@ -659,7 +659,7 @@ Variables
-
Todo
Why did void* work for matching
+
Todo
Why did void* work for matching
Here is the caller graph for this function:
diff --git a/navtreeindex40.js b/navtreeindex40.js index e2d3524c0..766bd9839 100644 --- a/navtreeindex40.js +++ b/navtreeindex40.js @@ -40,8 +40,8 @@ var NAVTREEINDEX40 = "frappe__snowland_2course__textures_8linkonly_8h_source.html":[8,0,0,7,6], "frappe__snowland_2course__vertices_8inc_8c.html":[8,0,0,7,7], "frappe__snowland_2course__vertices_8inc_8c.html#a1ec683eb9d6c6022a1131cd35cf8d7e8":[8,0,0,7,7,0], -"functions.html":[7,2,0], "functions.html":[7,2,0,0], +"functions.html":[7,2,0], "functions_b.html":[7,2,0,1], "functions_c.html":[7,2,0,2], "functions_d.html":[7,2,0,3], @@ -62,8 +62,8 @@ var NAVTREEINDEX40 = "functions_t.html":[7,2,0,18], "functions_u.html":[7,2,0,19], "functions_v.html":[7,2,0,20], -"functions_vars.html":[7,2,1], "functions_vars.html":[7,2,1,0], +"functions_vars.html":[7,2,1], "functions_vars_b.html":[7,2,1,1], "functions_vars_c.html":[7,2,1,2], "functions_vars_d.html":[7,2,1,3], diff --git a/navtreeindex42.js b/navtreeindex42.js index a572fa532..6f97b820a 100644 --- a/navtreeindex42.js +++ b/navtreeindex42.js @@ -83,8 +83,8 @@ var NAVTREEINDEX42 = "globals_b.html":[8,1,0,2], "globals_c.html":[8,1,0,3], "globals_d.html":[8,1,0,4], -"globals_defs.html":[8,1,6,0], "globals_defs.html":[8,1,6], +"globals_defs.html":[8,1,6,0], "globals_defs_a.html":[8,1,6,1], "globals_defs_b.html":[8,1,6,2], "globals_defs_c.html":[8,1,6,3], diff --git a/navtreeindex69.js b/navtreeindex69.js index ec404128f..b099413c0 100644 --- a/navtreeindex69.js +++ b/navtreeindex69.js @@ -8,8 +8,8 @@ var NAVTREEINDEX69 = "load_8c.html#ae413774208e1213a9146b077715c7787":[8,0,3,1,10,45], "load_8c.html#ae4a9b501905301177af6c476cff02f7f":[8,0,3,1,10,40], "load_8c.html#ae61d39b44029939585c581369dc5a050":[8,0,3,1,10,2], -"load_8c.html#ae6f2c925e86efb824ed050683f9b5113":[8,0,3,1,10,5], "load_8c.html#ae6f2c925e86efb824ed050683f9b5113":[8,0,3,1,10,6], +"load_8c.html#ae6f2c925e86efb824ed050683f9b5113":[8,0,3,1,10,5], "load_8c.html#aea5e1113ed6186106c99f9d146e80e75":[8,0,3,1,10,33], "load_8c.html#aeead683cd086cc979e2e7e94d8b4e7b9":[8,0,3,1,10,66], "load_8c.html#aef4659733b428e6fcae0c19331e720cf":[8,0,3,1,10,35], diff --git a/objects_8h.html b/objects_8h.html index c252417ed..b1d25ca81 100644 --- a/objects_8h.html +++ b/objects_8h.html @@ -1964,7 +1964,7 @@ Variables
-
Todo
fix this extern
+
Todo
fix this extern
diff --git a/osPiRawStartDma_8c.html b/osPiRawStartDma_8c.html index 59e8acd63..b4feeebe7 100644 --- a/osPiRawStartDma_8c.html +++ b/osPiRawStartDma_8c.html @@ -186,7 +186,7 @@ Here is the caller graph for this function:
-
Todo
figure out why this is like this
+
Todo
figure out why this is like this
diff --git a/osPiStartDma_8c.html b/osPiStartDma_8c.html index 9de6d0159..661858b66 100644 --- a/osPiStartDma_8c.html +++ b/osPiStartDma_8c.html @@ -167,7 +167,7 @@ Variables
-
Todo
name magic constants
+
Todo
name magic constants
Here is the call graph for this function:
diff --git a/osViSwapBuffer_8c.html b/osViSwapBuffer_8c.html index baec66b79..71496921e 100644 --- a/osViSwapBuffer_8c.html +++ b/osViSwapBuffer_8c.html @@ -138,7 +138,7 @@ Variables
-
Todo
figure out what this flag means
+
Todo
figure out what this flag means
Here is the call graph for this function:
diff --git a/os__pi_8h.html b/os__pi_8h.html index 6e2c0bcb1..b6b02c130 100644 --- a/os__pi_8h.html +++ b/os__pi_8h.html @@ -441,7 +441,7 @@ Here is the caller graph for this function:
-
Todo
name magic constants
+
Todo
name magic constants
Here is the call graph for this function:
diff --git a/os__vi_8h.html b/os__vi_8h.html index 849a08b12..6e0309a0c 100644 --- a/os__vi_8h.html +++ b/os__vi_8h.html @@ -990,7 +990,7 @@ Here is the caller graph for this function:
-
Todo
figure out what this flag means
+
Todo
figure out what this flag means
Here is the call graph for this function:
diff --git a/piint_8h.html b/piint_8h.html index 4105e2c66..863e77753 100644 --- a/piint_8h.html +++ b/piint_8h.html @@ -786,7 +786,7 @@ Variables
-
Todo
name
+
Todo
name
@@ -801,7 +801,7 @@ Variables
-
Todo
name
+
Todo
name
@@ -816,7 +816,7 @@ Variables
-
Todo
name
+
Todo
name
diff --git a/playback_8c.html b/playback_8c.html index 3eefc2511..bbde74e2e 100644 --- a/playback_8c.html +++ b/playback_8c.html @@ -854,7 +854,7 @@ Here is the caller graph for this function:
-
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
+
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
Here is the caller graph for this function:
diff --git a/playback_8h.html b/playback_8h.html index 699793e8b..730f9100d 100644 --- a/playback_8h.html +++ b/playback_8h.html @@ -916,7 +916,7 @@ Here is the caller graph for this function:
-
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
+
Bug
for the change to UQ0.7, the if statement should also have been changed accordingly
Here is the caller graph for this function:
diff --git a/player__controller_8c.html b/player__controller_8c.html index 1dc364437..f282cfbab 100644 --- a/player__controller_8c.html +++ b/player__controller_8c.html @@ -763,7 +763,7 @@ Here is the caller graph for this function:
-
Todo
make a proper match
+
Todo
make a proper match
Here is the call graph for this function:
diff --git a/player__controller_8h.html b/player__controller_8h.html index b84a49437..8c1437f27 100644 --- a/player__controller_8h.html +++ b/player__controller_8h.html @@ -729,7 +729,7 @@ Here is the caller graph for this function:
-
Todo
make a proper match
+
Todo
make a proper match
Here is the call graph for this function:
diff --git a/podium__ceremony__actors_8c.html b/podium__ceremony__actors_8c.html index b07e35f7a..2b86f2dec 100644 --- a/podium__ceremony__actors_8c.html +++ b/podium__ceremony__actors_8c.html @@ -596,7 +596,7 @@ Here is the caller graph for this function:
Bug
No null check.
Bug
-
Todo
More indepth error checking/return value
+
Todo
More indepth error checking/return value
Here is the call graph for this function:
diff --git a/podium__ceremony__actors_8h.html b/podium__ceremony__actors_8h.html index 68ed10cc8..0a24820db 100644 --- a/podium__ceremony__actors_8h.html +++ b/podium__ceremony__actors_8h.html @@ -555,7 +555,7 @@ Here is the caller graph for this function:
Bug
No null check.
Bug
-
Todo
More indepth error checking/return value
+
Todo
More indepth error checking/return value
Here is the call graph for this function:
diff --git a/race__logic_8c.html b/race__logic_8c.html index dc5399f72..9c5cb61de 100644 --- a/race__logic_8c.html +++ b/race__logic_8c.html @@ -704,7 +704,7 @@ Here is the caller graph for this function:
-
Todo
increasing players past four would require increase this loop iterator.
+
Todo
increasing players past four would require increase this loop iterator.
Here is the call graph for this function:
diff --git a/race__logic_8h.html b/race__logic_8h.html index 44e87ce0a..a98eacff5 100644 --- a/race__logic_8h.html +++ b/race__logic_8h.html @@ -643,7 +643,7 @@ Here is the caller graph for this function:
-
Todo
increasing players past four would require increase this loop iterator.
+
Todo
increasing players past four would require increase this loop iterator.
Here is the call graph for this function:
diff --git a/render__courses_8c.html b/render__courses_8c.html index 09a0cf0a6..4d0d8a66f 100644 --- a/render__courses_8c.html +++ b/render__courses_8c.html @@ -541,7 +541,7 @@ Here is the caller graph for this function:
-
Todo
Should be Gfx*
+
Todo
Should be Gfx*
Here is the call graph for this function:
diff --git a/render__courses_8h.html b/render__courses_8h.html index 0e4bbb686..d49a2bd54 100644 --- a/render__courses_8h.html +++ b/render__courses_8h.html @@ -513,7 +513,7 @@ Here is the caller graph for this function:
-
Todo
Should be Gfx*
+
Todo
Should be Gfx*
Here is the call graph for this function:
diff --git a/render__objects_8c.html b/render__objects_8c.html index f5ded02e7..7f00dfd7a 100644 --- a/render__objects_8c.html +++ b/render__objects_8c.html @@ -2818,7 +2818,7 @@ Here is the caller graph for this function:
-
Todo
tlut/texture unconfirmed. This could be texture1 and texture2
+
Todo
tlut/texture unconfirmed. This could be texture1 and texture2
Here is the call graph for this function:
@@ -10962,7 +10962,7 @@ Here is the caller graph for this function:
-
Todo
Update to F3DEX. Uses OLD definition for gspTextureRectangle.
+
Todo
Update to F3DEX. Uses OLD definition for gspTextureRectangle.
Here is the caller graph for this function:
@@ -11429,7 +11429,7 @@ Here is the caller graph for this function:
-
Todo
fakematch?
+
Todo
fakematch?
Here is the call graph for this function:
diff --git a/seqplayer_8c.html b/seqplayer_8c.html index 42e09fb6f..619e4ac87 100644 --- a/seqplayer_8c.html +++ b/seqplayer_8c.html @@ -431,7 +431,7 @@ Here is the caller graph for this function:
-
Bug
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
+
Bug
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
Here is the call graph for this function:
diff --git a/seqplayer_8h.html b/seqplayer_8h.html index cb0d697f2..0bfd1f449 100644 --- a/seqplayer_8h.html +++ b/seqplayer_8h.html @@ -495,7 +495,7 @@ Here is the caller graph for this function:
-
Bug
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
+
Bug
Size of wrong array. Zeroes out second half of gSequenceChannels[0], all of gSequenceChannels[1..31], and part of gSequenceLayers[0]. However, this is only called at startup, so it's harmless.
Here is the call graph for this function:
diff --git a/some__data_8c.html b/some__data_8c.html index fdbe0375a..127be255e 100644 --- a/some__data_8c.html +++ b/some__data_8c.html @@ -2371,7 +2371,7 @@ Variables
0xff25, 0xffed, 0x0320,
0xffca, 0xfff8, 0x0270,
}
-
Todo
fix this extern
+
Todo
fix this extern
diff --git a/sounds_8h.html b/sounds_8h.html index d0d331ec9..5e9768b58 100644 --- a/sounds_8h.html +++ b/sounds_8h.html @@ -419,7 +419,7 @@ Macros
-
Todo
format like sm64 sounds.h
+
Todo
format like sm64 sounds.h
diff --git a/sptask_8h.html b/sptask_8h.html index 53b6368e2..823caa627 100644 --- a/sptask_8h.html +++ b/sptask_8h.html @@ -236,7 +236,7 @@ Macros
-
Todo
These defines shouldn't exist - PR/rcp.h has them properly defined (ultralib)
+
Todo
These defines shouldn't exist - PR/rcp.h has them properly defined (ultralib)
diff --git a/toads__turnpike_2course__data_8c.html b/toads__turnpike_2course__data_8c.html index 0c0810c53..1b978096a 100644 --- a/toads__turnpike_2course__data_8c.html +++ b/toads__turnpike_2course__data_8c.html @@ -3026,7 +3026,7 @@ Variables
G_IM_FMT_RGBA
#define G_IM_FMT_RGBA
Definition gbi.h:396
G_IM_SIZ_16b
#define G_IM_SIZ_16b
Definition gbi.h:407
G_CC_DECALRGBA
#define G_CC_DECALRGBA
Definition gbi.h:512
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/toads__turnpike_2course__data_8h.html b/toads__turnpike_2course__data_8h.html index 8649ed263..840c1177b 100644 --- a/toads__turnpike_2course__data_8h.html +++ b/toads__turnpike_2course__data_8h.html @@ -2812,7 +2812,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/todo.html b/todo.html index efba5389d..68992dfca 100644 --- a/todo.html +++ b/todo.html @@ -105,8 +105,8 @@ $(function(){initNavTree('todo.html',''); initResizable(); });
Global __osGetId (OSPfs *pfs)
-

loads of magic constants..

-

remove magic constant

+

remove magic constant

+

loads of magic constants..

Global __osPfsReleasePages (OSPfs *pfs, __OSInode *inode, u8 start_page, u16 *sum, u8 bank, __OSInodeUnit *last_page, int flag)
magic number
@@ -115,21 +115,21 @@ $(function(){initNavTree('todo.html',''); initResizable(); });
Global __osPiDevMgr
In libreultra this is in an include
Global __osRepairPackId (OSPfs *pfs, __OSPackId *badid, __OSPackId *newid)
-

remove magic constant

-

fix magic number

+

fix magic number

+

remove magic constant

Global _course_mario_raceway_dl_mio0SegmentRomStart []
These should probably be ptr's instead of array's?
Global add_unused_obj_index (s32 *listIdx, s32 *nextFree, s32 size)
-
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
+
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
Global BAD_RETURN (cmd)
put this define in types.h or similar. Certain functions are marked as having return values, but do not actually return a value. This causes undefined behavior, which we'd rather avoid on modern GCC. This only impacts -O2 and can matter for both the function itself and functions that call it.
Global clear_framebuffer (s32)
-
Why did void* work for matching
+
Why did void* work for matching
Global D_800E43B0 []
-
unused?
+
unused?
Global D_8018D9B0
-
Move gGfxPool out of main.h
+
Move gGfxPool out of main.h
Global d_course_banshee_boardwalk_dl_0 []
Replace addresses with variables
Global d_course_big_donut_dl []
@@ -157,13 +157,13 @@ $(function(){initNavTree('todo.html',''); initResizable(); });
Global d_course_sherbet_land_dl_0 []
Replace addresses with variables
Global d_course_toads_turnpike_dl_0 []
-
Replace addresses with variables
-
Global d_course_wario_stadium_dl_0 []
Replace addresses with variables
+
Global d_course_wario_stadium_dl_0 []
+
Replace addresses with variables
Global d_course_yoshi_valley_dl_0 []
Replace addresses with variables
Global debug_switch_character_ceremony_cutscene (void)
-
confirm this.
+
confirm this.
Union du

is it possible to remove them somehow?

is it possible to remove them somehow?

@@ -175,51 +175,51 @@ $(function(){initNavTree('todo.html',''); initResizable(); });
Global func_800100F0 (s32)
Confirm this comment
Global func_80028864 (Player *, Camera *, s8, s8)
-
make a proper match
+
make a proper match
Global func_80046030 (u8 *tlut, u8 *texture, Vtx *arg2, s32 width, s32 arg4, s32 height)
-
tlut/texture unconfirmed. This could be texture1 and texture2
+
tlut/texture unconfirmed. This could be texture1 and texture2
Global func_8004B7DC (s32 x, s32 y, s32 width, s32 height, s32 arg4, s32 arg5, s32 arg6)
-
Update to F3DEX. Uses OLD definition for gspTextureRectangle.
+
Update to F3DEX. Uses OLD definition for gspTextureRectangle.
Global func_8004C268 (u32 arg0, u32 arg1, u8 *texture, u32 width, u32 arg4, u32 height, s32 arg6)
-
fakematch?
+
fakematch?
Global func_800745C8 (s32 objectIndex, s32 arg1)
-
arg1 should likely be a u8 *
+
arg1 should likely be a u8 *
Global func_80091FA4 (void)
-
These sizes need to be sizeof() for shiftability if possible
+
These sizes need to be sizeof() for shiftability if possible
Global func_800CBC24 (void)
clenanup, something's weird with the variables. D_800EA4A4 is probably EuAudioCmd bc of the + 0x100
Global func_80282D90 (struct CinematicCamera *, struct struct_80286A04 *, struct struct_80286A04 *, s32)
-
Cast to normal Camera? Or from CinematicCamera?
+
Cast to normal Camera? Or from CinematicCamera?
Global func_8028336C (UNUSED struct CinematicCamera *arg0, UNUSED Camera *camera)
-
Does this match as a return of s8?
+
Does this match as a return of s8?
Global func_802846E4 (struct CinematicCamera *)
-
What does this even do?
+
What does this even do?
Global func_8028F970 (void)
-
increasing players past four would require increase this loop iterator.
+
increasing players past four would require increase this loop iterator.
Global gen_random_item (s16 rank, s16 isCpu)
-
Cleanup this function to use array access and struct if possible.
+
Cleanup this function to use array access and struct if possible.
Global gPlayerWinningIndex
gPlayerWinningIndex (D_800DC5E8) accessed as word, D_800DC5EB as u8
Global gTorchSpawns []
-
fix this extern
+
fix this extern
Global IO_WRITE (addr, data)
These defines are from PR/rcp.h, but including that causes problems...
Global LEO_CMD_TYPE_0
-
name
-
Global LEO_CMD_TYPE_1
name
-
Global LEO_CMD_TYPE_2
+
Global LEO_CMD_TYPE_1
name
+
Global LEO_CMD_TYPE_2
+
name
Global load_surface_map (uintptr_t, struct UnkStruct_800DC5EC *)
-
Should be Gfx*
+
Should be Gfx*
Global M_TASK_FLAG0
-
These defines shouldn't exist - PR/rcp.h has them properly defined (ultralib)
+
These defines shouldn't exist - PR/rcp.h has them properly defined (ultralib)
Global MTX_KART_POOL_SIZE
-
Verify with proper documentation
+
Verify with proper documentation
Global MTX_SHADOW_POOL_SIZE
-
Verify with proper documentation
+
Verify with proper documentation
Global new_actor (ActorInitParams *)
-
More indepth error checking/return value
+
More indepth error checking/return value
Global Note::priority
use macros or something instead.
Global osContInit (OSMesgQueue *mq, u8 *bitpattern, OSContStatus *status)
@@ -227,19 +227,19 @@ $(function(){initNavTree('todo.html',''); initResizable(); });
Global osPfsDeleteFile (OSPfs *pfs, u16 company_code, u32 game_code, u8 *game_name, u8 *ext_name)
magic constant
Global osPiStartDma (OSIoMesg *mb, s32 priority, s32 direction, uintptr_t devAddr, void *vAddr, size_t nbytes, OSMesgQueue *mq)
-
name magic constants
+
name magic constants
Global osRomBase
-
figure out why this is like this
+
figure out why this is like this
Global osViBlack (u8 active)
name magic constants
Global osViSwapBuffer (void *vaddr)
-
figure out what this flag means
+
figure out what this flag means
Global PI_DOMAIN1
This define is from os.h, but including that causes problems...
Global render_actor_shell (Camera *camera, Mat4 matrix, struct ShellActor *shell)
-
Is this making the shell spin?
+
Is this making the shell spin?
Global SOUND_ARG_LOAD (sound_bank, byte2, byte3, sound_id)
-
format like sm64 sounds.h
+
format like sm64 sounds.h
Global UPDATE_REG (reg, var)
This define is from piint.h, but including that causes problems...
Global US_FLOAT (x)
diff --git a/train_2render_8inc_8c_source.html b/train_2render_8inc_8c_source.html index 9aceb0c9d..e55a82461 100644 --- a/train_2render_8inc_8c_source.html +++ b/train_2render_8inc_8c_source.html @@ -250,103 +250,103 @@ $(function(){initNavTree('train_2render_8inc_8c_source.html',''); initResizable(
145
146 f32 temp_f0 = is_within_render_distance(camera->pos, actor->pos, camera->rot[1], 625.0f, gCameraZoom[camera - camera1], 9000000.0f);
147
-
148 if (temp_f0 < 0.0f) { return; }
+
148 if (temp_f0 < 0.0f) { return; }
149
-
150 gSPClearGeometryMode(gDisplayListHead++, G_LIGHTING);
+
151
-
152 mtxf_pos_rotation_xyz(sp120, actor->pos, actor->rot);
-
153 if (render_set_position(sp120, 0) == 0) { return; }
+ +
153 if (render_set_position(sp120, 0) == 0) { return; }
154
-
155 if (temp_f0 < 250000.0f) {
+
155 if (temp_f0 < 250000.0f) {
156
- +
158
-
159 } else if (temp_f0 < 1000000.0f) {
- +
159 } else if (temp_f0 < 1000000.0f) {
+
161 } else {
- +
163 }
-
164 if (1440000.0f < temp_f0) { return; }
+
164 if (1440000.0f < temp_f0) { return; }
165
-
166 gSPClearGeometryMode(gDisplayListHead++, G_CULL_BACK);
- + +
168
-
169 mtxf_rotate_x(sp120, actor->wheelRot);
-
170 vec3f_set(sp160, 17.0f, 6.0f, 8.0f);
-
171 mtxf_translate(spE0, sp160);
-
172 mtxf_multiplication(spA0, sp120, spE0);
+
169 mtxf_rotate_x(sp120, actor->wheelRot);
+
170 vec3f_set(sp160, 17.0f, 6.0f, 8.0f);
+ +
173
-
174 if (render_set_position(spA0, 3) == 0) { return; }
+
174 if (render_set_position(spA0, 3) == 0) { return; }
175
- -
177 gSPPopMatrix(gDisplayListHead++, G_MTX_MODELVIEW);
+ +
178
-
179 mtxf_rotate_x(sp120, actor->wheelRot);
-
180 vec3f_set(sp160, -17.0, 6.0f, 8.0f);
-
181 mtxf_translate(spE0, sp160);
-
182 mtxf_multiplication(spA0, sp120, spE0);
+
179 mtxf_rotate_x(sp120, actor->wheelRot);
+
180 vec3f_set(sp160, -17.0, 6.0f, 8.0f);
+ +
183
-
184 if (render_set_position(spA0, 3) == 0) { return; }
+
184 if (render_set_position(spA0, 3) == 0) { return; }
185
- -
187 gSPPopMatrix(gDisplayListHead++, G_MTX_MODELVIEW);
+ +
188
-
189 mtxf_rotate_x(sp120, (s16) (actor->wheelRot + 0x444));
-
190 vec3f_set(sp160, 17.0f, 6.0f, -8.0f);
-
191 mtxf_translate(spE0, sp160);
-
192 mtxf_multiplication(spA0, sp120, spE0);
+
189 mtxf_rotate_x(sp120, (s16) (actor->wheelRot + 0x444));
+
190 vec3f_set(sp160, 17.0f, 6.0f, -8.0f);
+ +
193
-
194 if (render_set_position(spA0, 3) == 0) { return; }
+
194 if (render_set_position(spA0, 3) == 0) { return; }
195
- -
197 gSPPopMatrix(gDisplayListHead++, G_MTX_MODELVIEW);
+ +
198
-
199 mtxf_rotate_x(sp120, (s16) (actor->wheelRot + 0x444));
-
200 vec3f_set(sp160, -17.0f, 6.0f, -8.0f);
-
201 mtxf_translate(spE0, sp160);
-
202 mtxf_multiplication(spA0, sp120, spE0);
+
199 mtxf_rotate_x(sp120, (s16) (actor->wheelRot + 0x444));
+
200 vec3f_set(sp160, -17.0f, 6.0f, -8.0f);
+ +
203
-
204 if (render_set_position(spA0, 3) == 0) { return; }
- -
206 gSPPopMatrix(gDisplayListHead++, G_MTX_MODELVIEW);
-
207 gSPSetGeometryMode(gDisplayListHead++, G_CULL_BACK);
+
204 if (render_set_position(spA0, 3) == 0) { return; }
+ + +
208}
209
- -
211 Mat4 sp120;
-
212 Vec3f sp160;
-
213 Mat4 spE0;
-
214 Mat4 spA0;
+ +
211 Mat4 sp120;
+
212 Vec3f sp160;
+
213 Mat4 spE0;
+
214 Mat4 spA0;
215
-
216 f32 temp_f0 = is_within_render_distance(camera->pos, actor->pos, camera->rot[1], 2025.0f, gCameraZoom[camera - camera1], 9000000.0f);
+
216 f32 temp_f0 = is_within_render_distance(camera->pos, actor->pos, camera->rot[1], 2025.0f, gCameraZoom[camera - camera1], 9000000.0f);
217
-
218 if (temp_f0 < 0.0f) { return; }
+
218 if (temp_f0 < 0.0f) { return; }
219
-
220 gSPClearGeometryMode(gDisplayListHead++, G_LIGHTING);
+
221
-
222 mtxf_pos_rotation_xyz(sp120, actor->pos, actor->rot);
+
223
-
224 if (render_set_position(sp120, 0) == 0) { return; }
+
224 if (render_set_position(sp120, 0) == 0) { return; }
225
-
226 if (temp_f0 < 250000.0f) {
+
226 if (temp_f0 < 250000.0f) {
227
- - + +
230
-
231 } else if (temp_f0 < 1000000.0f) {
+
231 } else if (temp_f0 < 1000000.0f) {
232
- - + +
235 } else {
- - + +
238 }
-
239 if (1440000.0f < temp_f0) { return; }
+
239 if (1440000.0f < temp_f0) { return; }
240
-
241 gSPClearGeometryMode(gDisplayListHead++, G_CULL_BACK);
- + +
243
244 mtxf_rotate_x(sp120, actor->wheelRot);
245 vec3f_set(sp160, 17.0f, 6.0f, 28.0f);
diff --git a/trees_2render_8inc_8c_source.html b/trees_2render_8inc_8c_source.html index 1b11a2531..aa51fefde 100644 --- a/trees_2render_8inc_8c_source.html +++ b/trees_2render_8inc_8c_source.html @@ -258,86 +258,86 @@ $(function(){initNavTree('trees_2render_8inc_8c_source.html',''); initResizable(
172 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 250000.0f)) {
173 func_8029794C(arg2->pos, arg2->rot, 2.79999995f);
174 }
-
175 arg1[3][0] = arg2->pos[0];
-
176 arg1[3][1] = arg2->pos[1];
-
177 arg1[3][2] = arg2->pos[2];
+
175 arg1[3][0] = arg2->pos[0];
+
176 arg1[3][1] = arg2->pos[1];
+
177 arg1[3][2] = arg2->pos[2];
178
-
179 if (render_set_position(arg1, 0) != 0) {
- - +
179 if (render_set_position(arg1, 0) != 0) {
+
180 gDPLoadTLUT_pal256(gDisplayListHead++, common_tlut_trees_import);
+
182 }
183}
184
- -
193 f32 temp_f0;
-
194 s16 temp_v0 = arg2->flags;
+
192void render_actor_bush_bowser_castle(Camera *camera, Mat4 arg1, struct Actor *arg2) {
+
193 f32 temp_f0;
+
194 s16 temp_v0 = arg2->flags;
195
-
196 if ((temp_v0 & 0x800) != 0) { return; }
+
196 if ((temp_v0 & 0x800) != 0) { return; }
197
-
198 temp_f0 = is_within_render_distance(camera->pos, arg2->pos, camera->rot[1], 0, gCameraZoom[camera - camera1], 640000.0f);
+
198 temp_f0 = is_within_render_distance(camera->pos, arg2->pos, camera->rot[1], 0, gCameraZoom[camera - camera1], 640000.0f);
199
-
200 if (temp_f0 < 0.0f) { return; }
+
200 if (temp_f0 < 0.0f) { return; }
201
-
202 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 250000.0f)) {
+
202 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 250000.0f)) {
203 func_8029794C(arg2->pos, arg2->rot, 2.79999995f);
204 }
-
205 arg1[3][0] = arg2->pos[0];
-
206 arg1[3][1] = arg2->pos[1];
-
207 arg1[3][2] = arg2->pos[2];
+
205 arg1[3][0] = arg2->pos[0];
+
206 arg1[3][1] = arg2->pos[1];
+
207 arg1[3][2] = arg2->pos[2];
208
-
209 if (render_set_position(arg1, 0) != 0) {
- - +
209 if (render_set_position(arg1, 0) != 0) {
+
210 gDPLoadTLUT_pal256(gDisplayListHead++, common_tlut_trees_import);
+
212 }
213}
214
- -
223 f32 temp_f0;
-
224 s16 temp_v0 = arg2->flags;
+
222void render_actor_tree_frappe_snowland(Camera *camera, Mat4 arg1, struct Actor *arg2) {
+
223 f32 temp_f0;
+
224 s16 temp_v0 = arg2->flags;
225
-
226 if ((temp_v0 & 0x800) != 0) { return; }
+
226 if ((temp_v0 & 0x800) != 0) { return; }
227
-
228 temp_f0 = is_within_render_distance(camera->pos, arg2->pos, camera->rot[1], 0, gCameraZoom[camera - camera1], 4000000.0f);
+
228 temp_f0 = is_within_render_distance(camera->pos, arg2->pos, camera->rot[1], 0, gCameraZoom[camera - camera1], 4000000.0f);
229
-
230 if (temp_f0 < 0.0f) { return; }
+
230 if (temp_f0 < 0.0f) { return; }
231
-
232 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 250000.0f)) {
+
232 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 250000.0f)) {
233 func_8029794C(arg2->pos, arg2->rot, 2.79999995f);
234 }
-
235 arg1[3][0] = arg2->pos[0];
-
236 arg1[3][1] = arg2->pos[1];
-
237 arg1[3][2] = arg2->pos[2];
+
235 arg1[3][0] = arg2->pos[0];
+
236 arg1[3][1] = arg2->pos[1];
+
237 arg1[3][2] = arg2->pos[2];
238
-
239 if (render_set_position(arg1, 0) != 0) {
- +
239 if (render_set_position(arg1, 0) != 0) {
+
241 }
242}
243
- -
252 f32 temp_f0;
-
253 s16 temp_v0 = arg2->flags;
+ +
252 f32 temp_f0;
+
253 s16 temp_v0 = arg2->flags;
254
-
255 if ((temp_v0 & 0x800) != 0) { return; }
+
255 if ((temp_v0 & 0x800) != 0) { return; }
256
-
257 temp_f0 = is_within_render_distance(camera->pos, arg2->pos, camera->rot[1], 0, gCameraZoom[camera - camera1], 4000000.0f);
+
257 temp_f0 = is_within_render_distance(camera->pos, arg2->pos, camera->rot[1], 0, gCameraZoom[camera - camera1], 4000000.0f);
258
-
259 if (temp_f0 < 0.0f) { return; }
+
259 if (temp_f0 < 0.0f) { return; }
260
-
261 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 40000.0f)) {
+
261 if (((temp_v0 & 0x400) == 0) && (temp_f0 < 40000.0f)) {
262 func_8029794C(arg2->pos, arg2->rot, 1.0f);
263 }
-
264 arg1[3][0] = arg2->pos[0];
-
265 arg1[3][1] = arg2->pos[1];
-
266 arg1[3][2] = arg2->pos[2];
+
264 arg1[3][0] = arg2->pos[0];
+
265 arg1[3][1] = arg2->pos[1];
+
266 arg1[3][2] = arg2->pos[2];
267
-
268 if (render_set_position(arg1, 0) != 0) {
- +
268 if (render_set_position(arg1, 0) != 0) {
+
270 }
271}
diff --git a/update__objects_8c.html b/update__objects_8c.html index 79478dab3..6ac82a4ca 100644 --- a/update__objects_8c.html +++ b/update__objects_8c.html @@ -946,7 +946,7 @@ Variables
-
Todo
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
+
Todo
This HAS to be a for-loop of some variety, but I can't make a for-loop to match. If you replace this with for(var_v1 = 0; var_v1 < size; var_v1++) The diff gets massive.
Here is the call graph for this function:
@@ -3934,7 +3934,7 @@ Here is the caller graph for this function:
-
Todo
arg1 should likely be a u8 *
+
Todo
arg1 should likely be a u8 *
Here is the call graph for this function:
@@ -10463,7 +10463,7 @@ Here is the caller graph for this function:
-
Todo
Cleanup this function to use array access and struct if possible.
+
Todo
Cleanup this function to use array access and struct if possible.
Here is the call graph for this function:
@@ -12157,7 +12157,7 @@ Here is the caller graph for this function:
0.0, 0.0, 0.0, 0.0,
0.0, 0.0, 0.0, 0.0
}
-
Todo
unused?
+
Todo
unused?
diff --git a/wario__stadium_2course__data_8c.html b/wario__stadium_2course__data_8c.html index 258a5dd03..387a9844b 100644 --- a/wario__stadium_2course__data_8c.html +++ b/wario__stadium_2course__data_8c.html @@ -450,7 +450,7 @@ Variables
d_course_wario_stadium_packed_dl_4218
Gfx d_course_wario_stadium_packed_dl_4218[]
Definition course_displaylists.inc.c:2649
d_course_wario_stadium_packed_dl_5888
Gfx d_course_wario_stadium_packed_dl_5888[]
Definition course_displaylists.inc.c:3475
d_course_wario_stadium_packed_dl_4BA8
Gfx d_course_wario_stadium_packed_dl_4BA8[]
Definition course_displaylists.inc.c:3007
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables
diff --git a/wario__stadium_2course__data_8h.html b/wario__stadium_2course__data_8h.html index 5b98ef9fd..fa6f8f05b 100644 --- a/wario__stadium_2course__data_8h.html +++ b/wario__stadium_2course__data_8h.html @@ -418,7 +418,7 @@ Variables
-
Todo
Replace addresses with variables
+
Todo
Replace addresses with variables