Vanilla bug: pressing START on the splash screen in the last moments
before the demo timeout plays the enter chime but then drops into the
demo reel with no music. The attract timer fires while the press-start
fade is still in flight and overwrites the fade target, so the fade
completes as a demo entry instead of the main menu.
Adds a @bug comment documenting it, and guards the demo arm with
is_screen_being_faded() under AVOID_UB only, so the matching build is
byte-identical (the non-AVOID_UB path is unchanged).
* rename some texture
* ok document drifting effect and player particle
* continue rename
* push more rename
* more documentation
* minor rename test
* continue rename texture
* continue rename
* some rename
* more rename
* other fix
* fix comment
* fix a missing I
* fix a mistake
---------
Co-authored-by: MegaMech <MegaMech@users.noreply.github.com>
* small adjustement
* adjust some naming and other just two other in link with time trial
---------
Co-authored-by: MegaMech <MegaMech@users.noreply.github.com>
* Document time trial input replay system
Documents how the input replay system works in time trials. This is used for
* Course ghosts (on the raceways)
* Player ghosts
* Replays
* Rename ghosts/replays and minor cleanup
Refer to staff and player ghosts in time trials as replays.
Refer to the basic replay as a "post time trial replay"
Change variable / function names to reflect terminology change
* Define replay magic values
* Rename staff_ghosts files to replays
Renames staff_ghosts files to replays, since they also deal with player ghosts and post time trial replays.
Also, changes staff_ghosts_loop -> replays_loop
* REPLAY_NOT_FRAME_COUNTER -> REPLAY_CLEAR_FRAME_COUNTER
* Add replays header and format
* Update replays.c
* Name load replay functions
---------
Co-authored-by: MegaMech <MegaMech@users.noreply.github.com>
* Document various functions and variables
* Fix code changes
* Rename function based on discussion
* Identify global table of player speeds
* Improve names of functions
* Label further things related to playerIndex
* Label further balloon related things
* Document further balloon related things
* Use STAR_DURATION
* Update vars
* Fix missing arg
* Commit unpr'd matches
* fix compile
* Commit matching func_80086074
* More matches
* Fix missed labelling
* menus.c formatting
* More matches
* Match update_player_path_completion
* Formatting
* Match func_80050E34
* Match EU Audio init
* Match func_800C16E8
* Match synthesis_process_note
* Match func_80009B60
* Match
* Match cpu_use_item_strategy
* Match render_menus
* match last func
* couple of matches
* match func_800C4FE4
* match func_800C284C
* match func_800C2A2C
* match func_800C3724
* match func_800C4398
* format
* format2
* remove asms
* some rename
* type menu
* continue rename and place const
* Renames and doc
* more
* buffer vars
* clang format
* continue rename
* some rename and get it compile (but don't match for obscure reason)
* get it match again and fix some warning
* fix all warning
* Match 6 functions
* continue rename
* load img renames and first step or label menu items
* MenuItem struct names and some rename
* rename around
* rename code_80091750 to menu_item
* clean up a little
* Update menu_item.h
* document waypoint and more
* Revert "document waypoint and more"
This reverts commit 5e6eb4fbcc.
* apply review
* Update menu_item.c
* fix some review
* rename func_8009E620 to clear_menus
* do a rename
* apply review
* finish rename normally
* more small rename
* few fix of name
* few more fix
* minor fix
* Update menus.c
* last rename normally
* Update render_menus.s
* Update menu_items.c
* Renames seg2 textures.c
* MENU_ITEMtype --> MENU_ITEM_TYPE
* remove a useless parameter
* func_80099110 --> clear_menu_textures
---------
Co-authored-by: MegaMech <MegaMech@users.noreply.github.com>
Co-authored-by: AloXado320 <david.albujar.s.30@gmail.com>
MegaMech