From 255c6b850a31fc3d376f453e1127e1f019496d87 Mon Sep 17 00:00:00 2001 From: Garrett Cox Date: Fri, 2 Feb 2024 02:03:55 -0600 Subject: [PATCH] Document OoB in z_message_nes (#1537) --- src/code/z_message_nes.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/code/z_message_nes.c b/src/code/z_message_nes.c index 108146d3ae..d33de3ced6 100644 --- a/src/code/z_message_nes.c +++ b/src/code/z_message_nes.c @@ -1626,6 +1626,7 @@ void Message_DecodeNES(PlayState* play) { Message_LoadPluralRupeesNES(play, &decodedBufPos, &charTexIndex, &spA4); } else if (curChar == MESSAGE_BOMBER_CODE) { for (i = 0; i < 5; i++) { + //! @bug OoB read & write for i == 4, digits array is only 4 elements digits[i] = gSaveContext.save.saveInfo.bomberCode[i]; Font_LoadCharNES(play, digits[i] + '0', charTexIndex); charTexIndex += FONT_CHAR_TEX_SIZE;