Provide original sequence names for all BGM and rename some sequences (#1311)

* Provide original sequence names for all BGM and rename some sequences

* Include official soundtrack names, respond to reviews, rename some more sequences based on new evidence

* Forgot to rename the shooting gallery sequence, oops

* Rephrase the comment on NA_BGM_CLOCK_TOWN_MAIN_SEQUENCE
This commit is contained in:
Tom Overton
2023-07-10 15:30:21 -07:00
committed by GitHub
parent 08006cc0ea
commit 7cbd63c33d
2 changed files with 152 additions and 148 deletions
+20 -20
View File
@@ -286,7 +286,7 @@ u8 sSeqFlags[] = {
0, // NA_BGM_SHARPS_CURSE
SEQ_FLAG_ENEMY, // NA_BGM_GREAT_BAY_REGION
SEQ_FLAG_ENEMY, // NA_BGM_IKANA_REGION
0, // NA_BGM_DEKU_KING
0, // NA_BGM_DEKU_PALACE
SEQ_FLAG_ENEMY, // NA_BGM_MOUNTAIN_REGION
0, // NA_BGM_PIRATES_FORTRESS
0, // NA_BGM_CLOCK_TOWN_DAY_1
@@ -297,13 +297,13 @@ u8 sSeqFlags[] = {
0, // NA_BGM_ENEMY
SEQ_FLAG_RESTORE, // NA_BGM_BOSS
SEQ_FLAG_ENEMY, // NA_BGM_WOODFALL_TEMPLE
0, // NA_BGM_MARKET
0, // NA_BGM_CLOCK_TOWN_MAIN_SEQUENCE
0, // NA_BGM_OPENING
SEQ_FLAG_RESUME_PREV, // NA_BGM_INSIDE_A_HOUSE
SEQ_FLAG_FANFARE, // NA_BGM_GAME_OVER
0, // NA_BGM_CLEAR_BOSS
SEQ_FLAG_FANFARE, // NA_BGM_GET_ITEM
SEQ_FLAG_FANFARE, // NA_BGM_GATE_OPEN
SEQ_FLAG_FANFARE, // NA_BGM_CLOCK_TOWN_DAY_2_PTR
SEQ_FLAG_FANFARE, // NA_BGM_GET_HEART
SEQ_FLAG_RESTORE, // NA_BGM_TIMED_MINI_GAME
0, // NA_BGM_GORON_RACE
@@ -318,10 +318,10 @@ u8 sSeqFlags[] = {
0, // NA_BGM_ROMANI_RANCH
0, // NA_BGM_GORON_VILLAGE
0, // NA_BGM_MAYORS_OFFICE
SEQ_FLAG_FANFARE, // NA_BGM_OCA_EPONA
SEQ_FLAG_FANFARE, // NA_BGM_OCA_SUNS
SEQ_FLAG_FANFARE, // NA_BGM_OCA_TIME
SEQ_FLAG_FANFARE, // NA_BGM_OCA_STORM
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_EPONA
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_SUNS
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_TIME
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_STORM
SEQ_FLAG_RESUME, // NA_BGM_ZORA_HALL
SEQ_FLAG_FANFARE, // NA_BGM_GET_NEW_MASK
SEQ_FLAG_RESTORE, // NA_BGM_MINI_BOSS
@@ -338,9 +338,9 @@ u8 sSeqFlags[] = {
0, // NA_BGM_KOTAKE_POTION_SHOP
SEQ_FLAG_RESUME_PREV, // NA_BGM_SHOP
SEQ_FLAG_FANFARE, // NA_BGM_OWL
SEQ_FLAG_RESUME_PREV, // NA_BGM_MINI_GAME
SEQ_FLAG_FANFARE, // NA_BGM_OCA_SOARING
SEQ_FLAG_FANFARE, // NA_BGM_OCA_HEALING
SEQ_FLAG_RESUME_PREV, // NA_BGM_SHOOTING_GALLERY
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_SOARING
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_HEALING
SEQ_FLAG_FANFARE, // NA_BGM_INVERTED_SONG_OF_TIME
SEQ_FLAG_FANFARE, // NA_BGM_SONG_OF_DOUBLE_TIME
SEQ_FLAG_FANFARE, // NA_BGM_SONATA_OF_AWAKENING
@@ -349,8 +349,8 @@ u8 sSeqFlags[] = {
SEQ_FLAG_FANFARE, // NA_BGM_ELEGY_OF_EMPTINESS
SEQ_FLAG_FANFARE, // NA_BGM_OATH_TO_ORDER
0, // NA_BGM_SWORD_TRAINING_HALL
SEQ_FLAG_FANFARE, // NA_BGM_GORON_LULLABY_INTRO
SEQ_FLAG_FANFARE, // NA_BGM_OCA_FAIRY
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_LULLABY_INTRO
SEQ_FLAG_FANFARE, // NA_BGM_LEARNED_NEW_SONG
SEQ_FLAG_FANFARE, // NA_BGM_BREMEN_MARCH
SEQ_FLAG_FANFARE, // NA_BGM_BALLAD_OF_THE_WIND_FISH
SEQ_FLAG_RESTORE, // NA_BGM_SONG_OF_SOARING
@@ -359,14 +359,14 @@ u8 sSeqFlags[] = {
SEQ_FLAG_FANFARE, // NA_BGM_MIKAU_RIFF
SEQ_FLAG_FANFARE, // NA_BGM_MIKAU_FINALE
0, // NA_BGM_FROG_SONG
SEQ_FLAG_FANFARE, // NA_BGM_OCA_SONATA
SEQ_FLAG_FANFARE, // NA_BGM_OCA_LULLABY
SEQ_FLAG_FANFARE, // NA_BGM_OCA_NEW_WAVE
SEQ_FLAG_FANFARE, // NA_BGM_OCA_ELEGY
SEQ_FLAG_FANFARE, // NA_BGM_OCA_OATH
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_SONATA
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_LULLABY
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_NEW_WAVE
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_ELEGY
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_OATH
0, // NA_BGM_MAJORAS_LAIR
SEQ_FLAG_FANFARE, // NA_BGM_OCA_LULLABY_INTRO
SEQ_FLAG_FANFARE, // NA_BGM_OCA_GUITAR_BASS_SESSION
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_LULLABY_INTRO_PTR
SEQ_FLAG_FANFARE, // NA_BGM_OCARINA_GUITAR_BASS_SESSION
SEQ_FLAG_FANFARE, // NA_BGM_PIANO_SESSION
SEQ_FLAG_FANFARE, // NA_BGM_INDIGO_GO_SESSION
SEQ_FLAG_ENEMY, // NA_BGM_SNOWHEAD_TEMPLE
@@ -395,7 +395,7 @@ u8 sSeqFlags[] = {
0, // NA_BGM_GOODBYE_GIANT
0, // NA_BGM_TATL_AND_TAEL
0, // NA_BGM_MOONS_DESTRUCTION
0, // NA_BGM_END_CREDITS_2
0, // NA_BGM_END_CREDITS_SECOND_HALF
};
s8 sSpecReverbs[] = {