River_Sound OK and Documented + River_Sound Related z_actor/Audio Functions (#661)

* First pass of `func_800BCCDC`

* river_sound OK (copy progress from audio WIP)

* Copy progress from `code_8019AF00.c` (still waiting for data to be imported)

* More docs

* feedback

* Add in `code_8019AF00.c` functions

* format

* params

* Minor cleanup

* Small fix

* one more

* Better names

* Add comment, cleanup Idx

* Fix bss

* Fix BSS

tools/disasm/functions.txt

@@ -867,7 +867,7 @@
     0x800BCB70:("Actor_SetColorFilter",),
     0x800BCBF4:("func_800BCBF4",),
     0x800BCC68:("func_800BCC68",),
-    0x800BCCDC:("func_800BCCDC",),
+    0x800BCCDC:("Actor_GetClosestPosOnPath",),
     0x800BD2B4:("func_800BD2B4",),
     0x800BD384:("func_800BD384",),
     0x800BD6B8:("func_800BD6B8",),
@@ -3689,7 +3689,7 @@
     0x8019380C:("func_8019380C",),
     0x80193858:("func_80193858",),
     0x8019387C:("func_8019387C",),
-    0x801938A0:("func_801938A0",),
+    0x801938A0:("Audio_QueueCmdS8",),
     0x801938D0:("func_801938D0",),
     0x80193900:("func_80193900",),
     0x80193990:("func_80193990",),
@@ -3897,18 +3897,18 @@
     0x8019FE74:("func_8019FE74",),
     0x8019FEDC:("func_8019FEDC",),
     0x8019FF38:("func_8019FF38",),
-    0x8019FF9C:("func_8019FF9C",),
-    0x801A0048:("func_801A0048",),
-    0x801A00EC:("func_801A00EC",),
+    0x8019FF9C:("Audio_PlaySfxForRiver",),
+    0x801A0048:("Audio_PlaySfxForWaterfall",),
+    0x801A00EC:("Audio_StepFreqLerp",),
     0x801A0124:("func_801A0124",),
     0x801A0184:("func_801A0184",),
     0x801A01C4:("func_801A01C4",),
     0x801A0204:("func_801A0204",),
     0x801A0238:("func_801A0238",),
-    0x801A026C:("func_801A026C",),
-    0x801A0318:("func_801A0318",),
-    0x801A0450:("func_801A0450",),
-    0x801A046C:("func_801A046C",),
+    0x801A026C:("Audio_SetGanonsTowerBgmVolumeLevel",),
+    0x801A0318:("Audio_SetGanonsTowerBgmVolume",),
+    0x801A0450:("Audio_LowerMainBgmVolume",),
+    0x801A046C:("Audio_UpdateRiverSoundVolumes",),
     0x801A0554:("func_801A0554",),
     0x801A05E4:("func_801A05E4",),
     0x801A05F0:("func_801A05F0",),
@@ -3916,9 +3916,9 @@
     0x801A0810:("func_801A0810",),
     0x801A0868:("func_801A0868",),
     0x801A09D4:("func_801A09D4",),
-    0x801A0C70:("func_801A0C70",),
-    0x801A0C90:("func_801A0C90",),
-    0x801A0CB0:("func_801A0CB0",),
+    0x801A0C70:("Audio_ClearSariaBgm",),
+    0x801A0C90:("Audio_ClearSariaBgmAtPos",),
+    0x801A0CB0:("Audio_SplitBgmChannels",),
     0x801A0E44:("func_801A0E44",),
     0x801A1290:("func_801A1290",),
     0x801A1348:("func_801A1348",),
@@ -3935,8 +3935,8 @@
     0x801A1F88:("func_801A1F88",),
     0x801A1FB4:("func_801A1FB4",),
     0x801A2090:("func_801A2090",),
-    0x801A21FC:("func_801A21FC",),
-    0x801A2460:("func_801A2460",),
+    0x801A21FC:("Audio_PlaySariaBgm",),
+    0x801A2460:("Audio_ClearSariaBgm2",),
     0x801A246C:("func_801A246C",),
     0x801A2544:("func_801A2544",),
     0x801A257C:("func_801A257C",),
@@ -4050,7 +4050,7 @@
     0x801A7794:("func_801A7794",),
     0x801A7828:("func_801A7828",),
     0x801A787C:("func_801A787C",),
-    0x801A78E4:("func_801A78E4",),
+    0x801A78E4:("Audio_IsSfxPlaying",),
     0x801A794C:("func_801A794C",),
     0x801A7B10:("func_801A7B10",),
     0x801A7D04:("func_801A7D04",),
@@ -4061,7 +4061,7 @@
     0x801A8ABC:("func_801A8ABC",),
     0x801A8B14:("func_801A8B14",),
     0x801A8B2C:("func_801A8B2C",),
-    0x801A8BD0:("func_801A8BD0",),
+    0x801A8BD0:("Audio_SetVolumeScale",),
     0x801A8D5C:("func_801A8D5C",),
     0x801A9768:("func_801A9768",),
     0x801A982C:("func_801A982C",),

tools/sizes/code_functions.csv

@@ -381,7 +381,7 @@ asm/non_matchings/code/z_actor/Actor_SpawnShieldParticlesMetal.s,Actor_SpawnShie
 asm/non_matchings/code/z_actor/Actor_SetColorFilter.s,Actor_SetColorFilter,0x800BCB70,0x21
 asm/non_matchings/code/z_actor/func_800BCBF4.s,func_800BCBF4,0x800BCBF4,0x1D
 asm/non_matchings/code/z_actor/func_800BCC68.s,func_800BCC68,0x800BCC68,0x1D
-asm/non_matchings/code/z_actor/func_800BCCDC.s,func_800BCCDC,0x800BCCDC,0x176
+asm/non_matchings/code/z_actor/Actor_GetClosestPosOnPath.s,Actor_GetClosestPosOnPath,0x800BCCDC,0x176
 asm/non_matchings/code/z_actor/func_800BD2B4.s,func_800BD2B4,0x800BD2B4,0x34
 asm/non_matchings/code/z_actor/func_800BD384.s,func_800BD384,0x800BD384,0xCD
 asm/non_matchings/code/z_actor/func_800BD6B8.s,func_800BD6B8,0x800BD6B8,0xB
@@ -3205,7 +3205,7 @@ asm/non_matchings/code/code_80192BE0/func_80193774.s,func_80193774,0x80193774,0x
 asm/non_matchings/code/code_80192BE0/func_8019380C.s,func_8019380C,0x8019380C,0x13
 asm/non_matchings/code/code_80192BE0/func_80193858.s,func_80193858,0x80193858,0x9
 asm/non_matchings/code/code_80192BE0/func_8019387C.s,func_8019387C,0x8019387C,0x9
-asm/non_matchings/code/code_80192BE0/func_801938A0.s,func_801938A0,0x801938A0,0xC
+asm/non_matchings/code/code_80192BE0/Audio_QueueCmdS8.s,Audio_QueueCmdS8,0x801938A0,0xC
 asm/non_matchings/code/code_80192BE0/func_801938D0.s,func_801938D0,0x801938D0,0xC
 asm/non_matchings/code/code_80192BE0/func_80193900.s,func_80193900,0x80193900,0x24
 asm/non_matchings/code/code_80192BE0/func_80193990.s,func_80193990,0x80193990,0x6
@@ -3413,18 +3413,18 @@ asm/non_matchings/code/code_8019AF00/func_8019FE1C.s,func_8019FE1C,0x8019FE1C,0x
 asm/non_matchings/code/code_8019AF00/func_8019FE74.s,func_8019FE74,0x8019FE74,0x1A
 asm/non_matchings/code/code_8019AF00/func_8019FEDC.s,func_8019FEDC,0x8019FEDC,0x17
 asm/non_matchings/code/code_8019AF00/func_8019FF38.s,func_8019FF38,0x8019FF38,0x19
-asm/non_matchings/code/code_8019AF00/func_8019FF9C.s,func_8019FF9C,0x8019FF9C,0x2B
-asm/non_matchings/code/code_8019AF00/func_801A0048.s,func_801A0048,0x801A0048,0x29
-asm/non_matchings/code/code_8019AF00/func_801A00EC.s,func_801A00EC,0x801A00EC,0xE
+asm/non_matchings/code/code_8019AF00/Audio_PlaySfxForRiver.s,Audio_PlaySfxForRiver,0x8019FF9C,0x2B
+asm/non_matchings/code/code_8019AF00/Audio_PlaySfxForWaterfall.s,Audio_PlaySfxForWaterfall,0x801A0048,0x29
+asm/non_matchings/code/code_8019AF00/Audio_StepFreqLerp.s,Audio_StepFreqLerp,0x801A00EC,0xE
 asm/non_matchings/code/code_8019AF00/func_801A0124.s,func_801A0124,0x801A0124,0x18
 asm/non_matchings/code/code_8019AF00/func_801A0184.s,func_801A0184,0x801A0184,0x10
 asm/non_matchings/code/code_8019AF00/func_801A01C4.s,func_801A01C4,0x801A01C4,0x10
 asm/non_matchings/code/code_8019AF00/func_801A0204.s,func_801A0204,0x801A0204,0xD
 asm/non_matchings/code/code_8019AF00/func_801A0238.s,func_801A0238,0x801A0238,0xD
-asm/non_matchings/code/code_8019AF00/func_801A026C.s,func_801A026C,0x801A026C,0x2B
-asm/non_matchings/code/code_8019AF00/func_801A0318.s,func_801A0318,0x801A0318,0x4E
-asm/non_matchings/code/code_8019AF00/func_801A0450.s,func_801A0450,0x801A0450,0x7
-asm/non_matchings/code/code_8019AF00/func_801A046C.s,func_801A046C,0x801A046C,0x3A
+asm/non_matchings/code/code_8019AF00/Audio_SetGanonsTowerBgmVolumeLevel.s,Audio_SetGanonsTowerBgmVolumeLevel,0x801A026C,0x2B
+asm/non_matchings/code/code_8019AF00/Audio_SetGanonsTowerBgmVolume.s,Audio_SetGanonsTowerBgmVolume,0x801A0318,0x4E
+asm/non_matchings/code/code_8019AF00/Audio_LowerMainBgmVolume.s,Audio_LowerMainBgmVolume,0x801A0450,0x7
+asm/non_matchings/code/code_8019AF00/Audio_UpdateRiverSoundVolumes.s,Audio_UpdateRiverSoundVolumes,0x801A046C,0x3A
 asm/non_matchings/code/code_8019AF00/func_801A0554.s,func_801A0554,0x801A0554,0x24
 asm/non_matchings/code/code_8019AF00/func_801A05E4.s,func_801A05E4,0x801A05E4,0x3
 asm/non_matchings/code/code_8019AF00/func_801A05F0.s,func_801A05F0,0x801A05F0,0x19
@@ -3432,9 +3432,9 @@ asm/non_matchings/code/code_8019AF00/func_801A0654.s,func_801A0654,0x801A0654,0x
 asm/non_matchings/code/code_8019AF00/func_801A0810.s,func_801A0810,0x801A0810,0x16
 asm/non_matchings/code/code_8019AF00/func_801A0868.s,func_801A0868,0x801A0868,0x5B
 asm/non_matchings/code/code_8019AF00/func_801A09D4.s,func_801A09D4,0x801A09D4,0xA7
-asm/non_matchings/code/code_8019AF00/func_801A0C70.s,func_801A0C70,0x801A0C70,0x8
-asm/non_matchings/code/code_8019AF00/func_801A0C90.s,func_801A0C90,0x801A0C90,0x8
-asm/non_matchings/code/code_8019AF00/func_801A0CB0.s,func_801A0CB0,0x801A0CB0,0x65
+asm/non_matchings/code/code_8019AF00/Audio_ClearSariaBgm.s,Audio_ClearSariaBgm,0x801A0C70,0x8
+asm/non_matchings/code/code_8019AF00/Audio_ClearSariaBgmAtPos.s,Audio_ClearSariaBgmAtPos,0x801A0C90,0x8
+asm/non_matchings/code/code_8019AF00/Audio_SplitBgmChannels.s,Audio_SplitBgmChannels,0x801A0CB0,0x65
 asm/non_matchings/code/code_8019AF00/func_801A0E44.s,func_801A0E44,0x801A0E44,0x113
 asm/non_matchings/code/code_8019AF00/func_801A1290.s,func_801A1290,0x801A1290,0x2E
 asm/non_matchings/code/code_8019AF00/func_801A1348.s,func_801A1348,0x801A1348,0x1D
@@ -3451,8 +3451,8 @@ asm/non_matchings/code/code_8019AF00/func_801A1F00.s,func_801A1F00,0x801A1F00,0x
 asm/non_matchings/code/code_8019AF00/func_801A1F88.s,func_801A1F88,0x801A1F88,0xB
 asm/non_matchings/code/code_8019AF00/func_801A1FB4.s,func_801A1FB4,0x801A1FB4,0x37
 asm/non_matchings/code/code_8019AF00/func_801A2090.s,func_801A2090,0x801A2090,0x5B
-asm/non_matchings/code/code_8019AF00/func_801A21FC.s,func_801A21FC,0x801A21FC,0x99
-asm/non_matchings/code/code_8019AF00/func_801A2460.s,func_801A2460,0x801A2460,0x3
+asm/non_matchings/code/code_8019AF00/Audio_PlaySariaBgm.s,Audio_PlaySariaBgm,0x801A21FC,0x99
+asm/non_matchings/code/code_8019AF00/Audio_ClearSariaBgm2.s,Audio_ClearSariaBgm2,0x801A2460,0x3
 asm/non_matchings/code/code_8019AF00/func_801A246C.s,func_801A246C,0x801A246C,0x36
 asm/non_matchings/code/code_8019AF00/func_801A2544.s,func_801A2544,0x801A2544,0xE
 asm/non_matchings/code/code_8019AF00/func_801A257C.s,func_801A257C,0x801A257C,0x1A
@@ -3566,7 +3566,7 @@ asm/non_matchings/code/code_801A5BD0/func_801A7720.s,func_801A7720,0x801A7720,0x
 asm/non_matchings/code/code_801A5BD0/func_801A7794.s,func_801A7794,0x801A7794,0x25
 asm/non_matchings/code/code_801A5BD0/func_801A7828.s,func_801A7828,0x801A7828,0x15
 asm/non_matchings/code/code_801A5BD0/func_801A787C.s,func_801A787C,0x801A787C,0x1A
-asm/non_matchings/code/code_801A5BD0/func_801A78E4.s,func_801A78E4,0x801A78E4,0x1A
+asm/non_matchings/code/code_801A5BD0/Audio_IsSfxPlaying.s,Audio_IsSfxPlaying,0x801A78E4,0x1A
 asm/non_matchings/code/code_801A5BD0/func_801A794C.s,func_801A794C,0x801A794C,0x71
 asm/non_matchings/code/code_801A7B10/func_801A7B10.s,func_801A7B10,0x801A7B10,0x7D
 asm/non_matchings/code/code_801A7B10/func_801A7D04.s,func_801A7D04,0x801A7D04,0x20
@@ -3577,7 +3577,7 @@ asm/non_matchings/code/code_801A7B10/func_801A8A50.s,func_801A8A50,0x801A8A50,0x
 asm/non_matchings/code/code_801A7B10/func_801A8ABC.s,func_801A8ABC,0x801A8ABC,0x16
 asm/non_matchings/code/code_801A7B10/func_801A8B14.s,func_801A8B14,0x801A8B14,0x6
 asm/non_matchings/code/code_801A7B10/func_801A8B2C.s,func_801A8B2C,0x801A8B2C,0x29
-asm/non_matchings/code/code_801A7B10/func_801A8BD0.s,func_801A8BD0,0x801A8BD0,0x63
+asm/non_matchings/code/code_801A7B10/Audio_SetVolumeScale.s,Audio_SetVolumeScale,0x801A8BD0,0x63
 asm/non_matchings/code/code_801A7B10/func_801A8D5C.s,func_801A8D5C,0x801A8D5C,0x283
 asm/non_matchings/code/code_801A7B10/func_801A9768.s,func_801A9768,0x801A9768,0x31
 asm/non_matchings/code/code_801A7B10/func_801A982C.s,func_801A982C,0x801A982C,0x63