Color_RGBAu32 (#253)

* Renamed deprecated RGB5A1 to RGBA16

* Cleanup shopkeeper structs with Color_RGBAu32 and Vec3f

* Rename functions with RGB5A1 in them

* BSS fix

tools/calc_bss.sh

@@ -0,0 +1,42 @@
+#!/bin/bash
+# Given a list of header files, compute the bss index that results from
+# including them. (See prevent_bss_reordering.h for more information.)
+
+TEMPC=$(mktemp -t bss.XXXXXXX.c)
+TEMPO=$(mktemp -t bss.XXXXXXX.o)
+trap "rm -f $TEMPC $TEMPO" EXIT
+
+set -e
+
+if [[ $# = 0 ]]; then
+    echo "Usage: ./tools/calc_bss.sh file1.h file2.h ..." >&2
+    exit 1
+fi
+
+if [ -z "$CROSS" ]; then
+    CROSS=mips-linux-gnu-
+fi
+
+# bss indexing starts at 3
+for I in {3..255}; do
+    echo "char bss$I;" >> $TEMPC
+done
+for I in {0..2}; do
+    echo "char bss$I;" >> $TEMPC
+done
+
+while [[ $# -gt 0 ]]; do
+    echo "#include \"$1\"" >> $TEMPC
+    shift
+done
+
+echo "char measurement;" >> $TEMPC
+
+$(pwd)/tools/ido_recomp/linux/7.1/cc -G 0 -non_shared \
+    -Xfullwarn -Xcpluscomm -O2 -g3 -Xcpluscomm -mips2 \
+    -I $(pwd)/include/ -I $(pwd)/src/ -I $(pwd)/assets/ -I $(pwd)/build/ \
+    -Wab,-r4300_mul -woff 624,649,838,712 -c $TEMPC -o $TEMPO
+
+LINE=$(${CROSS}objdump -t $TEMPO | grep measurement | cut -d' ' -f1)
+NUM=$((0x$LINE - 1))
+echo "bss index: $NUM"

tools/disasm/functions.txt

@@ -3240,10 +3240,10 @@
     0x80178DAC:("func_80178DAC",),
     0x80178E3C:("func_80178E3C",),
     0x80178E7C:("func_80178E7C",),
-    0x80178F30:("Check_WriteRGB5A1Pixel",),
+    0x80178F30:("Check_WriteRGBA16Pixel",),
     0x80178F60:("Check_WriteI4Pixel",),
     0x80178FA0:("Check_DrawI4Texture",),
-    0x80179090:("Check_ClearRGB5A1",),
+    0x80179090:("Check_ClearRGBA16",),
     0x8017910C:("Check_DrawExpansionPakErrorMessage",),
     0x801791CC:("Check_DrawRegionLockErrorMessage",),
     0x80179260:("Check_ExpansionPak",),

tools/sizes/code_functions.csv

@@ -2754,10 +2754,10 @@ asm/non_matchings/code/sys_cmpdma/func_80178D7C.s,func_80178D7C,0x80178D7C,0xC
 asm/non_matchings/code/sys_cmpdma/func_80178DAC.s,func_80178DAC,0x80178DAC,0x24
 asm/non_matchings/code/sys_cmpdma/func_80178E3C.s,func_80178E3C,0x80178E3C,0x10
 asm/non_matchings/code/sys_cmpdma/func_80178E7C.s,func_80178E7C,0x80178E7C,0x2D
-asm/non_matchings/code/sys_initial_check/Check_WriteRGB5A1Pixel.s,Check_WriteRGB5A1Pixel,0x80178F30,0xC
+asm/non_matchings/code/sys_initial_check/Check_WriteRGBA16Pixel.s,Check_WriteRGBA16Pixel,0x80178F30,0xC
 asm/non_matchings/code/sys_initial_check/Check_WriteI4Pixel.s,Check_WriteI4Pixel,0x80178F60,0x10
 asm/non_matchings/code/sys_initial_check/Check_DrawI4Texture.s,Check_DrawI4Texture,0x80178FA0,0x3C
-asm/non_matchings/code/sys_initial_check/Check_ClearRGB5A1.s,Check_ClearRGB5A1,0x80179090,0x1F
+asm/non_matchings/code/sys_initial_check/Check_ClearRGBA16.s,Check_ClearRGBA16,0x80179090,0x1F
 asm/non_matchings/code/sys_initial_check/Check_DrawExpansionPakErrorMessage.s,Check_DrawExpansionPakErrorMessage,0x8017910C,0x30
 asm/non_matchings/code/sys_initial_check/Check_DrawRegionLockErrorMessage.s,Check_DrawRegionLockErrorMessage,0x801791CC,0x25
 asm/non_matchings/code/sys_initial_check/Check_ExpansionPak.s,Check_ExpansionPak,0x80179260,0x11