6fb180d0e1
En_Holl (Loading Halls/Holes) OK and mostly documented. ( #270 )
...
* EnHoll_Destroy() matching.
* EnHoll_Update() matching.
* EnHoll_Draw() matching and mostly documented.
* func_808999B0() matching and mostly documented.
* En_Holl OK (some asm remains)
* Renamed macros.
* func_80899B88 matching, but control flow could use some work.
* Got rid of GOTO in func_80899B88.
* Removed as many returns and magic numbers as currently possible.
* Renamed previous two functions to EnHoll_ChangeRooms and
EnHoll_VisibleIdle.
* EnHoll_SetAlwaysZero matching.
* EnHoll_TransparentIdle matching.
* func_8089A0C0 matching and mostly documented.
* func_8089A238 matching and mostly documented.
* Deleted last GLOBAL_ASM pragma.
* Final documentation for En_Holl PR.
* Switched spec to generated reloc.
* Clean up macros.
* Rename functions.
* Simplify name of ActionFunc array.
* Renamed globalCtx->unk_18878 to bgCoverAlpha.
* Ran format.sh.
* Added c file header.
* Update src/overlays/actors/ovl_En_Holl/z_en_holl.c
add trailing comma to sActionFuncs[]
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com >
* Update src/overlays/actors/ovl_En_Holl/z_en_holl.c
replace UNK_TYPE with s32.
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com >
* Run format.sh.
* s32 pad and declaration formatting
* Remove comma in EnHoll_TransparentIdle.
* Renamed sThis to sInstancePlayingSound.
* renamed gfxP to dl
* Improved affine transformation documentation.
* ran format.sh
* Updated documentation to be doxygen compatible.
* Extracted assets.
* fix bss
* Update src/overlays/actors/ovl_En_Holl/z_en_holl.c
replace bitmask == 0 with !
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com >
* Rename extracted asset variables.
* Renamed argument to macro functions to match .c
* renamed Vertices to Vtx.
* Renamed Vtx and DL.
* Update src/overlays/actors/ovl_En_Holl/z_en_holl.c
Shorten documentation.
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com >
* Apply suggestions from code review
Newline changes for readability.
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com >
* Update src/overlays/actors/ovl_En_Holl/z_en_holl.c
* Update src/overlays/actors/ovl_En_Holl/z_en_holl.c
Change oldCurrRoom to tempRoom.
* Apply suggestions from code review
engineer124's suggestions
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com >
Co-authored-by: Anghelo Carvajal <angheloalf95@gmail.com >
Co-authored-by: Derek Hensley <hensley.derek58@gmail.com >
Co-authored-by: EllipticEllipsis <73679967+EllipticEllipsis@users.noreply.github.com >
Co-authored-by: engineer124 <47598039+engineer124@users.noreply.github.com >
2021-09-01 19:39:01 -04:00
b292647ea2
ZAPD update: Gotta go fast! ( #226 )
...
* update extract_assets script
* git subrepo pull --force tools/ZAPD
subrepo:
subdir: "tools/ZAPD"
merged: "820678b4"
upstream:
origin: "https://github.com/zeldaret/ZAPD.git "
branch: "master"
commit: "820678b4"
git-subrepo:
version: "0.4.3"
origin: "???"
commit: "???"
* fixes and rgba16 format change
* git subrepo pull --force tools/ZAPD
subrepo:
subdir: "tools/ZAPD"
merged: "6be9af65d"
upstream:
origin: "https://github.com/zeldaret/ZAPD.git "
branch: "master"
commit: "6be9af65d"
git-subrepo:
version: "0.4.3"
origin: "???"
commit: "???"
* Update warning counts
2021-07-28 21:55:02 -04:00
9637e19303
EnClearTag OK and documented ( #214 )
...
* merge main
* Match Init
* Clear_Tag OK
* Full documentation
* More docs
* Fix function
* Fix MakeFile for assets and Fix texture swapped names
* Fix name
* Improve name and remove pad
* Can't stop the minor tweeks
* Adding potential Makefile fixes
* Minor name change
* Another name fix... and format
* PR Suggestion & Add Overlay File Description
* Re-documentation to match OoT WIP (more to come)
* Finish docs from OoT
* Fix merge and format
* Minor touch-ups
* Cleaner conditional
2021-07-20 11:07:05 -04:00
rylieb