Commit Graph

5 Commits

Author SHA1 Message Date
Dragorn421 a1c6253cd7 [CI] Fix apply_fix_bss_patches.py (#1892) 2026-08-16 09:21:52 -04:00
Dragorn421 e77acba9c4 [GHA] Fixup final jobs if conditions (#1889) 2026-08-13 18:26:32 -04:00
Anghelo Carvajal b9861edd77 Migrate CI to Github Actions (#1885)
* Migrate CI to Github Actions (#1884)

Changes the CI system from Jenkins to Github Actions (GHA) like we did for OoT

This is an adaptation of the Jenkinsfile we have and the solution made by @Dragorn421 for OoT

Relevant OoT PRs:
- https://github.com/zeldaret/oot/pull/2740
- https://github.com/zeldaret/oot/pull/2742
- https://github.com/zeldaret/oot/pull/2754

New features include:
- Not needing to selfhost a runner
  - Required private stuff for building is hosted on a private repo
- Building multiple versions in parallel
  - Our old jenkinsfile wasn't building `n64-jp-1.1`. Even if it doesn't match right now, I think it is important checking a PR doesn't completely break it.
- Run bss fixer in CI
- Upload mapfiles as build artifacts

This specific approach to handle GHA for decomp projects was adapted from the one used by the GC/Wii community. It is documented here https://github.com/encounter/dtk-template/blob/main/docs/github_actions.md There's a writeup about this adaptation for N64 projects [here](https://github.com/AngheloAlf/drmario64/pull/19).

* Remove duplicated step id

* Wire up compiler_archives machinery

* Remove extra quote

* Select bash as the default shell

* Fix asset extraction for WIP versions

* Properly fix the assets step this time

* fix assets building for jp

* Prevent running CI on forks

Incorporates the changes from https://github.com/zeldaret/oot/pull/2788

* Incorporate fix_bss tiebreaking algorithm from https://github.com/zeldaret/oot/pull/2779
2026-08-04 18:14:57 -04:00
EllipticEllipsis 0582c636b8 Contributing docs refresh (#793)
* Contributing docs refresh

* Apply suggestions from code review

Co-authored-by: LtPeriwinkle <62761190+LtPeriwinkle@users.noreply.github.com>

* Link MM tutorial

* Add link to XML spec

* Review

Co-authored-by: LtPeriwinkle <62761190+LtPeriwinkle@users.noreply.github.com>
2022-05-25 22:06:21 -04:00
Zach Banks 8c62c102cf CONTRIBUTING.md (#157)
* Draft CONTRIBUTING.md

* Expand PR process; mention KZ

* More TODO

* Add notes about documenting

* Address (most) PR comments

* Finish responding to PR comments; add PR template

* Fix grammar

* Add missing periods. More actor examples. Remove ref to booleans

* Add note about `NON_EQUIVALENT`; bold asset warning

* Condense PR template

* PR feedback from Kenix; Condense PR template

* Incorporate Thar0's feedback
2021-05-20 21:06:30 -04:00